Re: [8u-backport] JDK-8087516 : [JavaFX] Conditional support for GTK 3 on Linux

2018-10-10 Thread Johan Vos
I will test on Ubuntu 18.04 and 16.04 tomorrow. On Wed, Oct 10, 2018 at 10:05 PM Kevin Rushforth wrote: > Looks good. I have done full testing with both GTK 2 and GTK 3 on Ubuntu > 16.04 with a sanity check on Oracle Linux. > > +1 (note that you will need a second reviewer) > > As a reminder of

Re: [8u-backport] JDK-8087516 : [JavaFX] Conditional support for GTK 3 on Linux

2018-10-10 Thread Kevin Rushforth
Looks good. I have done full testing with both GTK 2 and GTK 3 on Ubuntu 16.04 with a sanity check on Oracle Linux. +1 (note that you will need a second reviewer) As a reminder of what we discussed off-line, please use "8206246" as the bug ID when pushing this change (rather than 8087516),

RE: [8u-backport] JDK-8087516 : [JavaFX] Conditional support for GTK 3 on Linux

2018-10-10 Thread Pankaj Bansal
Hi Kevin, Thanks for review and the information provided. I have updated the webrev for the proposed change from RTLD_GLOBAL to RTLD_LOCAL in launcher.c. Along with the this change, the new patch also includes the backport of two more fixes mentioned below. So now we have backported total of

Re: Compiling using javac

2018-10-10 Thread Graham Norris
** Reply to message from "Graham Norris" on Wed, 10 Oct 2018 10:29:06 +0100 Correction to previous test (omitted ".java":) D:\pbmdev>dir HelloFX.java PATH_TO_FX %PATH_TO_FX%javafx.* --module-path %PATH_TO_FX% --add-modules=javafx.controls HelloFX.java Volume in drive D is DataVolume Volume

Re: Compiling using javac

2018-10-10 Thread Abhinay Agarwal
Hi Graham, The error "module not found: javafx.controls" can be caused when env variable 'PATH_TO_FX' is targeting the 'JavaFX SDK' instead of 'JavaFX SDK/lib' directory The following works for me on a Windows machine: > set JAVA_HOME="C:\Program Files\Java\jdk-11" > set PATH_TO_FX="C:\Program

Re: Compiling using javac

2018-10-10 Thread Abhinay Agarwal
Hi Graham, The error "module not found: javafx.controls" can be caused when env variable 'PATH_TO_FX' is targeting the 'JavaFX SDK' instead of 'JavaFX SDK/lib' directory The following works for me on a Windows machine: > set JAVA_HOME="C:\Program Files\Java\jdk-11" > set PATH_TO_FX="C:\Program

Re: Compiling using javac

2018-10-10 Thread Graham Norris
** Reply to message from Abhinay Agarwal on Tue, 9 Oct 2018 16:30:18 + No stack trace from either type of failure, just error messages. I've tried compiling that example program, with the following result: D:\pbmdev>dir HelloFX.java PATH_TO_FX %PATH_TO_FX%javafx.* --module-path %PATH_TO_FX%

CSS Import Error with Java 11

2018-10-10 Thread marcel Austenfeld
For my application I apply a custom stylesheet for the JavafX components, e.g., to switch from a light to a dark theme to colorize, e.g., the SceneBuilder and other JavaFX components I use.   So at startup I load and apply a custom stylesheet with: