Re: [8u] RFR: JDK-8212139: FX 8u-dev fails to build on Oracle Linux 6 after fix for JDK-8206246

2018-10-12 Thread Phil Race
+1 -phil. On 10/12/2018 11:46 AM, Kevin Rushforth wrote: Phil, Please review the following: https://bugs.openjdk.java.net/browse/JDK-8212139 http://cr.openjdk.java.net/~kcr/8212139/webrev/ The recently-pushed GTK3 update for JDK-8206246 [1] has caused a fatal build failure on our

[8u] RFR: JDK-8212139: FX 8u-dev fails to build on Oracle Linux 6 after fix for JDK-8206246

2018-10-12 Thread Kevin Rushforth
Phil, Please review the following: https://bugs.openjdk.java.net/browse/JDK-8212139 http://cr.openjdk.java.net/~kcr/8212139/webrev/ The recently-pushed GTK3 update for JDK-8206246 [1] has caused a fatal build failure on our production Linux build machines. Please review the following webrev,

RFR: JDK-8212115 : Typo in javadoc for javafx.stage.Window

2018-10-12 Thread Martin Kröning
Please review the following fix for a typo in the javadocs: https://bugs.openjdk.java.net/browse/JDK-8212115 https://github.com/javafxports/openjdk-jfx/pull/227 Thanks, Martin

TableViewFocusModel.focusedCellProperty() using raw type TablePosition

2018-10-12 Thread LJY
Can I check is there any reason why this is designed so? This causes anyone who actually uses it to do casts/suppresses.

Re: [8u-backport] JDK-8087516 : [JavaFX] Conditional support for GTK 3 on Linux

2018-10-12 Thread Johan Vos
Hi Pankaj, Now the build succeeds, and my basic tests are working. +1 Thanks, - Johan On Fri, Oct 12, 2018 at 11:25 AM Pankaj Bansal wrote: > Hello Johan, > > We have backported https://bugs.openjdk.java.net/browse/JDK-8189689 in > 8u-dev under

RE: [8u-backport] JDK-8087516 : [JavaFX] Conditional support for GTK 3 on Linux

2018-10-12 Thread Pankaj Bansal
Hello Johan, We have backported https://bugs.openjdk.java.net/browse/JDK-8189689 in 8u-dev under https://bugs.openjdk.java.net/browse/JDK-8212106. Can you please try now to build on 18.04 LTS ? It should pass. Regards, Pankaj -Original Message- From: Kevin Rushforth Sent: Thursday,