I don't have a strong opinion. On the one hand, the platform libraries
(at least Mac and Windows) use some variation of BUTTON4 and BUTTON5
rather than a name. On the other hand, we already use symbolic names for
the PRIMARY, SECONDARY, and MIDDLE buttons, rather than using 1, 2, 3.
I'm OK
The "java" command expects a fully-qualified class name, not a file path as
its argument.
E.g.
cd /Users/me/Documents/java
java --module-path $PATH_TO_FX --add-modules=javafx.controls HelloFX
On Tue, Oct 30, 2018 at 2:06 PM Murray Eisenberg
wrote:
> This is under macOS Mojave (10.14).
>
>
This is under macOS Mojave (10.14).
Following instructions at https://openjfx.io/openjfx-docs/#install-javafx, I
compiled the sample HelloFX.java via:
javac --module-path $PATH_TO_FX --add-modules=javafx.controls
/Users/me/Documents/java/HelloFX.java
But now if I attempt to run that...
Great question. It seems to be pretty standard that mouse buttons 4 and 5
are called
back and forward. So either way would be fine with me. In my opinion the
descriptive
names may be better as then EventListeners responding to these new buttons
would
be more human-readable.
On Tue, Oct 30, 2018
Hi Kevin, Johan, Arun,
Please review the below enhancement for File Reader support in JavaFX WebView.
JIRA: https://bugs.openjdk.java.net/browse/JDK-8207772
Github PR: https://github.com/javafxports/openjdk-jfx/pull/250
Thanks,
Murali
Hi Michael,
I only started to look into this now, sorry for being late at the party.
Overall, this looks good to me. The risk is indeed minimal (developers
relying on switch-default cases to select e.g. middle button will be
punished).
I am not entirely sure about the naming though. Should it
Thank you,
Laurent
Le lun. 29 oct. 2018 à 19:35, Kevin Rushforth
a écrit :
> Looks good. Approved for pushing to 11-dev.
>
> -- Kevin
>
> On 10/29/2018 11:27 AM, Johan Vos wrote:
> > new webrev including test:
> > http://cr.openjdk.java.net/~jvos/8210386/webrev.01/
> >
