Re: JDK-8193445 Performance Test

2018-11-07 Thread Dean Wookey
Hi, I just wanted to clarify a few things about the fix. The test I showed hints at a potentially safer way to implement the fix for this problem. One would expect adding nodes 1 by 1 to the scene graph to be less efficient than adding them all at once, but it's far worse to add them all at once.

Re: JDK-8193445 Performance Test

2018-11-07 Thread Kevin Rushforth
My thoughts as well. I would love to see a safe robust fix for this issue, but there is a very real possibility of a regression: We thought we had a safe fix earlier and only later discovered the (multiple) regressions a few months after it was released. One possible way to improve

Re: JDK-8193445 Performance Test

2018-11-07 Thread Scott Palmer
> On Nov 7, 2018, at 8:37 AM, David Grieve wrote: > > ... > > Reapplying CSS to a Node but not its children could cause a problem if there > are styles in the parent or the parent's parents that affect the children. It > seems like bypassing children in reapplyCSS is bound to cause a

Re: Running JavaFX-11 applications from within Eclipse fails

2018-11-07 Thread Nir Lisker
I have a related problem when developing JavaFX in Eclipse and Win10 that started in 11. I created a modular project and in its build configuration (in Eclipse) I added the JavaFX base and graphics projects (that point to rt\modules\...) and OpenJDK11 to the module path. In the module-info file I

Re: JDK-8193445 Performance Test

2018-11-07 Thread David Grieve
One of the dangers of mucking around with the CSS code is whether or not the changes break things like popups, dialogs, menus. And whether or not the change breaks inline styles versus attributes set in code, versus stylesheets added to the scene/subscene/control, versus default stylesheets.

JDK-8193445 Performance Test

2018-11-07 Thread Dean Wookey
Hi, I was going to ask if it was possible to reopen JDK-8151756 ( https://bugs.openjdk.java.net/browse/JDK-8151756) since it was fixed but reverted in JDK-8183100 (https://bugs.openjdk.java.net/browse/JDK-8183100) after causing several regressions. I only noticed now that a followup bug was