Re: Previews for shared buffer PR

[Ty Young]

On 6/7/19 4:40 AM, Johan Vos wrote:

The PR discussed in https://github.com/javafxports/openjdk-jfx/pull/472,
addressing https://bugs.openjdk.java.net/browse/JDK-8167148 provides a 
very

much wanted feature. It is important that things are done in the right way
so that the code can be maintained in the long-term future.
Therefore, feedback on this PR is extremely important before we can
consider merging it. Once this PR is merged, there is no easy way back. It
is possible to add more functionality, hence my preference is to only
implement the functionality that is safe and stable, while allowing other
functionality to be added later or by third-party extensions. (e.g.
(avoiding) copying from/to GPU)

To make it easier to give feedback, we've build early access versions of
SDK's including this PR. Note that the PR is not merged, hence not
available in the regular EA downloads!

If you want to give it a try, download the SDK's from the URL's below.
There is a test in tests/manual/graphics/PixelBufferPerformanceTest (
https://github.com/arapte/openjdk-jfx/blob/JDK-8167148-NIO-ByteBuffer/tests/manual/graphics/PixelBufferPerformanceTest.java)
that should get you started.

https://download2.gluonhq.com/openjfx/forks/pixelbuffer/openjfx-13-pixelbuffer-ea+9_linux-x64_bin-jmods.zip
https://download2.gluonhq.com/openjfx/forks/pixelbuffer/openjfx-13-pixelbuffer-ea+9_linux-x64_bin-sdk.zip
https://download2.gluonhq.com/openjfx/forks/pixelbuffer/openjfx-13-pixelbuffer-ea+9_osx-x64_bin-jmods.zip
https://download2.gluonhq.com/openjfx/forks/pixelbuffer/openjfx-13-pixelbuffer-ea+9_osx-x64_bin-sdk.zip
https://download2.gluonhq.com/openjfx/forks/pixelbuffer/openjfx-13-pixelbuffer-ea+9_windows-x64_bin-jmods.zip
https://download2.gluonhq.com/openjfx/forks/pixelbuffer/openjfx-13-pixelbuffer-ea+9_windows-x64_bin-sdk.zip

- Johan



FYI this SDK causes a hard system crash when GTK is set to 2 and/or 
prism.forceUploadingPainter is set to true. I don't feel like 
purposefully crashing my system to see which of the various combinations 
is the issue so forgive me for not providing a more narrowed down cause.


GTK 2 is still necessary as there are still lingering GTK3 bugs that 
have yet to be fixed even in current JavaFX 13.


prism.forceUploadingPainter is a prism setting that fixes buffer resets 
and other various GUI glitching under Linux(an issue I tried reporting a 
long time ago) which affects ALL JavaFX applications under Linux but 
dramatically increases GPU utilization by 2x-2.5x when doing any kind of 
application interaction(resizing, scrolling, etc). Is there a reason 
this isn't enabled by default under Linux besides performance? Where is 
the documentation for this and other settings? I randomly ran into this 
from http://werner.yellowcouch.org/log/javafx-8-command-line-options/ 
and was surprised noone really knows about it nor is it documented 
anywhere that I can see.



Even with GTK 3 this results in a null pointer exception:


java.lang.NullPointerException
    at 
javafx.graphics/com.sun.prism.es2.ES2SwapChain.createGraphics(ES2SwapChain.java:223)
    at 
javafx.graphics/com.sun.prism.es2.ES2SwapChain.createGraphics(ES2SwapChain.java:40)
    at 
javafx.graphics/com.sun.javafx.tk.quantum.PresentingPainter.run(PresentingPainter.java:87)
    at 
java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
    at 
java.base/java.util.concurrent.FutureTask.runAndReset(FutureTask.java:305)

    at javafx.graphics/com.sun.javafx.tk.RenderJob.run(RenderJob.java:58)
    at 
java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
    at 
java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
    at 
javafx.graphics/com.sun.javafx.tk.quantum.QuantumRenderer$PipelineRunnable.run(QuantumRenderer.java:125



Please don't merge this into JDK13 or at least provide a switch to 
disable it. This is extremely busted on Linux.



Can the source code for this entire JavaFX build please be linked?

RFR: 8185937 - Spinner with Double/Integer value factory ignores up/down arrow keys

[Scott Palmer]

Please review the fix for   JDK-8185937 - Spinner with Double/Integer value 
factory ignores up/down arrow keys

https://bugs.openjdk.java.net/browse/JDK-8185937 

 
https://github.com/javafxports/openjdk-jfx/pull/517 

Re: Windows (32bit) build problems

[Michael Ennen]

I recommend using
https://github.com/javafxports/openjdk-jfx/blob/develop/tools/scripts/build.ps1
when trying to
build OpenJFX locally on Windows. I personally use it with the "-nocygwin"
argument so that it does not try and
auto-install cygwin.

On Fri, Jul 5, 2019 at 5:31 AM Robert Lichtenberger <
r.lichtenber...@gmail.com> wrote:

> I've started from scratch and one obvious problem in win.gradle is this
> line:
> >
> > defineProperty("WINDOWS_VS_VSINSTALLDIR", properties, "c:/Program
> > Files (x86)/Microsoft Visual Studio/2017/Professional");
>
> as it hardcodes the Professional version of VS.
>
> I've also found [1] which indicates that this kind of problem isn't
> uncommon or new :-).
>
> It also seems to me that the environment variable WINSDK_DIR has to be set
> (before launching any gradle task) on windows which should be added to the
> documentation.
>
> So after setting the environment varialbe and patching win.gradle to point
> to the Community Edition I've installed I now get a new error:
>
> > * What went wrong:
> > A problem occurred evaluating script.
> > > FAIL: cannot find RC: C:/Program Files/Microsoft
> > SDKs/Windows/v7.1/Bin/10.0.17134.0/x86/rc.exe
>
>
> I'll try and find out why that happens...
>
> [1]
> http://mail.openjdk.java.net/pipermail/openjfx-dev/2017-October/020861.html
>
> Am Do., 4. Juli 2019 um 17:29 Uhr schrieb Nir Lisker :
>
> > Hi Robert,
> >
> > My guess is that the build
> >> instructions refer to the current head version.
> >
> >
> > Correct.
> >
> > Gradle version was changed from 4.8 to 5.3 during the development of
> > OpenJFX 13 [1], so for 12 you will need 4.8.
> >
> > I don't have time right now to look at the WinSDK issue, but you can look
> > at the build instructions page at the time of OpenJFX 12 release [2].
> >
> > - Nir
> >
> > [1] https://bugs.openjdk.java.net/browse/JDK-8218172
> >
> > [2]
> >
> https://wiki.openjdk.java.net/pages/viewpreviousversions.action?pageId=8257548
> >
> > On Thu, Jul 4, 2019 at 6:02 PM Robert Lichtenberger <
> > r.lichtenber...@gmail.com> wrote:
> >
> >> Hello everyone,
> >>
> >> I try to build JavaFX-12 mods for Windows-32.
> >>
> >> For that I cloned http://hg.openjdk.java.net/openjfx/12-dev/rt/
> >> (correct?)
> >> and read the build instructions at
> >>
> >>
> https://wiki.openjdk.java.net/display/OpenJFX/Building+OpenJFX#BuildingOpenJFX-Windows
> >> .
> >>
> >> First question:
> >> * The build instructions tell me that gradle 5.3 is used but the
> >> gradle-wrapper actually downloads 4.8. My guess is that the build
> >> instructions refer to the current head version.
> >> * A simple ./gradlew tasks gives the following error:
> >>
> >> > * What went wrong:
> >> > A problem occurred evaluating script.
> >> > > FAIL: WINSDK_DIR not defined
> >> >
> >> There's no such environment variable in the build instructions. By
> looking
> >> around in win.gradle I guessed that this should point to the "Microsoft
> >> DirectShow header files", but it is not really well documented.
> >> I could only make the build continue by patching win.gradle, setting an
> >> environment variable did not help.
> >>
> >> If I add WINDOWS_SDK_DIR="C:\\Program Files\\Microsoft
> >> SDKs\\Windows\\v7.1"
> >> in win.gradle right above the checking code, I can execute gradlew
> tasks.
> >>
> >> However If I just start gradlew to really build JavaFX I get:
> >>
> >> FAILURE: Build failed with an exception.
> >> >
> >> > * What went wrong:
> >> > Execution failed for task ':graphics:compileDecoraNativeShadersWin'.
> >> > > java.util.concurrent.ExecutionException:
> >> > org.gradle.process.internal.ExecException: A problem occurred starting
> >> > process 'command '/VC/BIN/cl.exe''
> >> >
> >>
> >> Any help/hints welcome :-)
> >>
> >
>


-- 
Michael Ennen

Re: Windows (32bit) build problems

[Dan Howard]

You will need Windows 7 or later (Windows 10 is recommended) 64-bit OS


On 7/4/2019 11:01 AM, Robert Lichtenberger wrote:

Hello everyone,

I try to build JavaFX-12 mods for Windows-32.

For that I cloned http://hg.openjdk.java.net/openjfx/12-dev/rt/ (correct?)
and read the build instructions at
https://wiki.openjdk.java.net/display/OpenJFX/Building+OpenJFX#BuildingOpenJFX-Windows
.

First question:
* The build instructions tell me that gradle 5.3 is used but the
gradle-wrapper actually downloads 4.8. My guess is that the build
instructions refer to the current head version.
* A simple ./gradlew tasks gives the following error:


* What went wrong:
A problem occurred evaluating script.

FAIL: WINSDK_DIR not defined

There's no such environment variable in the build instructions. By looking
around in win.gradle I guessed that this should point to the "Microsoft
DirectShow header files", but it is not really well documented.
I could only make the build continue by patching win.gradle, setting an
environment variable did not help.

If I add WINDOWS_SDK_DIR="C:\\Program Files\\Microsoft SDKs\\Windows\\v7.1"
in win.gradle right above the checking code, I can execute gradlew tasks.

However If I just start gradlew to really build JavaFX I get:

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':graphics:compileDecoraNativeShadersWin'.

java.util.concurrent.ExecutionException:

org.gradle.process.internal.ExecException: A problem occurred starting
process 'command '/VC/BIN/cl.exe''


Any help/hints welcome :-)

Re: Windows (32bit) build problems

[Robert Lichtenberger]

I've started from scratch and one obvious problem in win.gradle is this
line:
>
> defineProperty("WINDOWS_VS_VSINSTALLDIR", properties, "c:/Program
> Files (x86)/Microsoft Visual Studio/2017/Professional");

as it hardcodes the Professional version of VS.

I've also found [1] which indicates that this kind of problem isn't
uncommon or new :-).

It also seems to me that the environment variable WINSDK_DIR has to be set
(before launching any gradle task) on windows which should be added to the
documentation.

So after setting the environment varialbe and patching win.gradle to point
to the Community Edition I've installed I now get a new error:

> * What went wrong:
> A problem occurred evaluating script.
> > FAIL: cannot find RC: C:/Program Files/Microsoft
> SDKs/Windows/v7.1/Bin/10.0.17134.0/x86/rc.exe


I'll try and find out why that happens...

[1]
http://mail.openjdk.java.net/pipermail/openjfx-dev/2017-October/020861.html

Am Do., 4. Juli 2019 um 17:29 Uhr schrieb Nir Lisker :

> Hi Robert,
>
> My guess is that the build
>> instructions refer to the current head version.
>
>
> Correct.
>
> Gradle version was changed from 4.8 to 5.3 during the development of
> OpenJFX 13 [1], so for 12 you will need 4.8.
>
> I don't have time right now to look at the WinSDK issue, but you can look
> at the build instructions page at the time of OpenJFX 12 release [2].
>
> - Nir
>
> [1] https://bugs.openjdk.java.net/browse/JDK-8218172
>
> [2]
> https://wiki.openjdk.java.net/pages/viewpreviousversions.action?pageId=8257548
>
> On Thu, Jul 4, 2019 at 6:02 PM Robert Lichtenberger <
> r.lichtenber...@gmail.com> wrote:
>
>> Hello everyone,
>>
>> I try to build JavaFX-12 mods for Windows-32.
>>
>> For that I cloned http://hg.openjdk.java.net/openjfx/12-dev/rt/
>> (correct?)
>> and read the build instructions at
>>
>> https://wiki.openjdk.java.net/display/OpenJFX/Building+OpenJFX#BuildingOpenJFX-Windows
>> .
>>
>> First question:
>> * The build instructions tell me that gradle 5.3 is used but the
>> gradle-wrapper actually downloads 4.8. My guess is that the build
>> instructions refer to the current head version.
>> * A simple ./gradlew tasks gives the following error:
>>
>> > * What went wrong:
>> > A problem occurred evaluating script.
>> > > FAIL: WINSDK_DIR not defined
>> >
>> There's no such environment variable in the build instructions. By looking
>> around in win.gradle I guessed that this should point to the "Microsoft
>> DirectShow header files", but it is not really well documented.
>> I could only make the build continue by patching win.gradle, setting an
>> environment variable did not help.
>>
>> If I add WINDOWS_SDK_DIR="C:\\Program Files\\Microsoft
>> SDKs\\Windows\\v7.1"
>> in win.gradle right above the checking code, I can execute gradlew tasks.
>>
>> However If I just start gradlew to really build JavaFX I get:
>>
>> FAILURE: Build failed with an exception.
>> >
>> > * What went wrong:
>> > Execution failed for task ':graphics:compileDecoraNativeShadersWin'.
>> > > java.util.concurrent.ExecutionException:
>> > org.gradle.process.internal.ExecException: A problem occurred starting
>> > process 'command '/VC/BIN/cl.exe''
>> >
>>
>> Any help/hints welcome :-)
>>
>