RFR: 8233747: JVM crash in com.sun.webkit.dom.DocumentImpl.createAttribute

2019-11-19 Thread Arun Joseph
Issue: Native part of WebView throws a DOMException and then, continues executing the rest of the function assuming that value is present. This causes the JVM to crash when retrieving the value. Fix: Return from the function if exception was raised (code is similar to exception handling in [We

Re: [Integrated] RFR: 8229472: Deprecate JavaBeanXxxPropertyBuilders public constructors

2019-11-19 Thread Nir Lisker
Changeset: 8bea7b71 Author:Nir Lisker Date: 2019-11-20 06:53:00 + URL: https://git.openjdk.java.net/jfx/commit/8bea7b71 8229472: Deprecate for removal JavaBeanXxxPropertyBuilders constructors Reviewed-by: kcr, arapte ! modules/javafx.base/src/main/java/javafx/beans/property/

Re: [Approved] RFR: 8229472: Deprecate for removal JavaBeanXxxPropertyBuilders constructors

2019-11-19 Thread Ambarish Rapte
On Tue, 19 Nov 2019 19:17:00 GMT, Nir Lisker wrote: > The pull request has been updated with additional changes. > > > > Added commits: > - ae9ee73e: Added @deprecated javadoc annotation and fixed ReadOnly variants > > Changes: > - all: https://git.openjdk.java.net/jfx/pull

Re: [Rev 01] RFR: 8087980: Add property to disable Monocle cursor

2019-11-19 Thread John Neffenger
On Mon, 18 Nov 2019 14:04:25 GMT, Dell Green wrote: > The pull request has been updated with additional changes. > > > > Added commits: > - 1f6e282d: changed from system propert debug logging to javafx platform > logger > > Changes: > - all: https://git.openjdk.java.net/j

Re: RFR: 8217472: Add attenuation for PointLight

2019-11-19 Thread Nir Lisker
On Mon, 18 Nov 2019 18:00:46 GMT, Nir Lisker wrote: > On Mon, 18 Nov 2019 18:00:45 GMT, Nir Lisker wrote: > >> CSR: https://bugs.openjdk.java.net/browse/JDK-8218264 >> >> >> >> Commits: >> - a388fb92: Fixed whitespaces >> - 415927e6: Correction for indexes >> - 3450ffe9: D

Re: [Approved] RFR: 8229472: Deprecate for removal JavaBeanXxxPropertyBuilders constructors

2019-11-19 Thread Kevin Rushforth
On Tue, 19 Nov 2019 19:17:00 GMT, Nir Lisker wrote: > The pull request has been updated with additional changes. > > > > Added commits: > - ae9ee73e: Added @deprecated javadoc annotation and fixed ReadOnly variants > > Changes: > - all: https://git.openjdk.java.net/jfx/pull

Re: [Rev 02] RFR: 8229472: Deprecate for removal JavaBeanXxxPropertyBuilders constructors

2019-11-19 Thread Nir Lisker
The pull request has been updated with additional changes. Added commits: - ae9ee73e: Added @deprecated javadoc annotation and fixed ReadOnly variants Changes: - all: https://git.openjdk.java.net/jfx/pull/30/files - new: https://git.openjdk.java.net/jfx/pull/30/files/a1cdb3

Re: RFR: 8229472: Deprecate for removal JavaBeanXxxPropertyBuilders constructors

2019-11-19 Thread Kevin Rushforth
On Tue, 19 Nov 2019 18:02:23 GMT, Nir Lisker wrote: > On Mon, 18 Nov 2019 18:12:13 GMT, Kevin Rushforth wrote: > >> On Wed, 13 Nov 2019 23:47:58 GMT, Kevin Rushforth wrote: >> >>> On Wed, 6 Nov 2019 12:54:40 GMT, Kevin Rushforth wrote: >>> On Wed, 6 Nov 2019 11:50:27 GMT, Nir Lisker w

Re: RFR: 8229472: Deprecate for removal JavaBeanXxxPropertyBuilders constructors

2019-11-19 Thread Nir Lisker
On Mon, 18 Nov 2019 18:12:13 GMT, Kevin Rushforth wrote: > On Wed, 13 Nov 2019 23:47:58 GMT, Kevin Rushforth wrote: > >> On Wed, 6 Nov 2019 12:54:40 GMT, Kevin Rushforth wrote: >> >>> On Wed, 6 Nov 2019 11:50:27 GMT, Nir Lisker wrote: >>> On Wed, 6 Nov 2019 07:12:26 GMT, Robin Westberg

Re: RFR: 8193445: JavaFX CSS is applied redundantly leading to significant performance degradation

2019-11-19 Thread David Grieve
On Tue, 19 Nov 2019 10:48:52 GMT, Ajit Ghaisas wrote: > On Fri, 15 Nov 2019 09:14:04 GMT, Ajit Ghaisas wrote: > >> On Thu, 14 Nov 2019 18:33:05 GMT, Kevin Rushforth wrote: >> >>> On Tue, 12 Nov 2019 16:45:04 GMT, Ajit Ghaisas wrote: >>> **Issue :** https://bugs.openjdk.java.net/br

Re: RFR: 8193445: JavaFX CSS is applied redundantly leading to significant performance degradation

2019-11-19 Thread Ajit Ghaisas
On Fri, 15 Nov 2019 09:14:04 GMT, Ajit Ghaisas wrote: > On Thu, 14 Nov 2019 18:33:05 GMT, Kevin Rushforth wrote: > >> On Tue, 12 Nov 2019 16:45:04 GMT, Ajit Ghaisas wrote: >> >>> **Issue :** >>> https://bugs.openjdk.java.net/browse/JDK-8193445 >>> >>> **Background :** >>> The CSS performance