Re: RFR: 8212034: Potential memory leaks in jpegLoader.c in error case

2019-11-27 Thread Johan Vos
On Wed, 27 Nov 2019 11:58:18 GMT, Ambarish Rapte wrote: > Memory allocated in initDecompressor() and decompressIndirect() is not freed > in error case. > In error case, > 1. Allocated memory should be freed. > 2. Appropriate de-initialization jpeg library calls should be added. > > Verified

Re: RFR: 8212034: Potential memory leaks in jpegLoader.c in error case

2019-11-27 Thread Johan Vos
On Wed, 27 Nov 2019 11:58:18 GMT, Ambarish Rapte wrote: > Memory allocated in initDecompressor() and decompressIndirect() is not freed > in error case. > In error case, > 1. Allocated memory should be freed. > 2. Appropriate de-initialization jpeg library calls should be added. > > Verified

Re: RFR: 8212034: Potential memory leaks in jpegLoader.c in error case

2019-11-27 Thread Kevin Rushforth
On Wed, 27 Nov 2019 11:58:18 GMT, Ambarish Rapte wrote: > Memory allocated in initDecompressor() and decompressIndirect() is not freed > in error case. > In error case, > 1. Allocated memory should be freed. > 2. Appropriate de-initialization jpeg library calls should be added. > > Verified

Re: RFR: 8234916: [macos 10.15] Garbled text running with native-image

2019-11-27 Thread Kevin Rushforth
On Wed, 27 Nov 2019 17:06:13 GMT, Jose Pereda wrote: > Running on MacOS Catalina, when doing static builds of `libjavafx_font.a` and > linking against this in a JavaFX app compiled with GraalVM native-image, if > default fonts are used, the rendered text is garbled, and a warning message > is

Re: [Approved] RFR: 8234916: [macos 10.15] Garbled text running with native-image

2019-11-27 Thread Phil Race
On Wed, 27 Nov 2019 17:06:13 GMT, Jose Pereda wrote: > Running on MacOS Catalina, when doing static builds of `libjavafx_font.a` and > linking against this in a JavaFX app compiled with GraalVM native-image, if > default fonts are used, the rendered text is garbled, and a warning message > is

RFR: 8234916: [macos 10.15] Garbled text running with native-image

2019-11-27 Thread Jose Pereda
Running on MacOS Catalina, when doing static builds of `libjavafx_font.a` and linking against this in a JavaFX app compiled with GraalVM native-image, if default fonts are used, the rendered text is garbled, and a warning message is printed: CoreText note: Client requested name

Re: [Integrated] RFR: 8200224: Multiple press event when JFXPanel gains focus

2019-11-27 Thread Kevin Rushforth
Changeset: 1d670f18 Author:Florian Kirmaier Committer: Kevin Rushforth Date: 2019-11-27 16:20:12 + URL: https://git.openjdk.java.net/jfx/commit/1d670f18 8200224: Multiple press event when JFXPanel gains focus Reviewed-by: kcr, psadhukhan !

Re: [Rev 05] RFR: 8200224: Multiple press event when JFXPanel gains focus

2019-11-27 Thread Florian Kirmaier
The pull request has been updated with additional changes. Added commits: - fa465c55: JDK-8200224 Changes: - all: https://git.openjdk.java.net/jfx/pull/25/files - new: https://git.openjdk.java.net/jfx/pull/25/files/24385eb8..fa465c55 Webrevs: - full:

Re: [Rev 04] RFR: 8200224: Multiple press event when JFXPanel gains focus

2019-11-27 Thread Florian Kirmaier
On Wed, 27 Nov 2019 15:13:33 GMT, Kevin Rushforth wrote: > On Wed, 27 Nov 2019 05:31:27 GMT, Prasanta Sadhukhan > wrote: > >> On Tue, 26 Nov 2019 13:06:36 GMT, Florian Kirmaier >> wrote: >> >>> The pull request has been updated with additional changes. >>> >>> >>> >>>

Re: [Rev 04] RFR: 8200224: Multiple press event when JFXPanel gains focus

2019-11-27 Thread Kevin Rushforth
On Wed, 27 Nov 2019 05:31:27 GMT, Prasanta Sadhukhan wrote: > On Tue, 26 Nov 2019 13:06:36 GMT, Florian Kirmaier > wrote: > >> The pull request has been updated with additional changes. >> >> >> >> Added commits: >> - 24385eb8: JDK-8200224 >> - e0829ad3: JDK-8200224 >>

Re: [Rev 03] RFR: 8130738: Add tabSize property to Text and TextFlow

2019-11-27 Thread Scott Palmer
The pull request has been updated with additional changes. Added commits: - af959665: 8130738: Add tabSize property to Text and TextFlow Changes: - all: https://git.openjdk.java.net/jfx/pull/32/files - new: https://git.openjdk.java.net/jfx/pull/32/files/254c40de..af959665

Re: RFR: 8211308: Support HTTP/2 in WebView

2019-11-27 Thread Kevin Rushforth
On Wed, 16 Oct 2019 21:43:15 GMT, Kevin Rushforth wrote: > On Wed, 16 Oct 2019 18:10:00 GMT, Kevin Rushforth wrote: > >> On Wed, 16 Oct 2019 17:58:32 GMT, Arunprasad Rajkumar >> wrote: >> >>> On Fri, 11 Oct 2019 11:21:08 GMT, Robin Westberg >>> wrote: >>> On Fri, 11 Oct 2019

RFR: 8212034: Potential memory leaks in jpegLoader.c in error case

2019-11-27 Thread Ambarish Rapte
Memory allocated in initDecompressor() and decompressIndirect() is not freed in error case. In error case, 1. Allocated memory should be freed. 2. Appropriate de-initialization jpeg library calls should be added. Verified that, 1. All unit and systems tests pass on three platforms, and 2. Memory

Re: RFR: 8196587: Remove use of deprecated finalize method from JPEGImageLoader

2019-11-27 Thread Ambarish Rapte
On Tue, 26 Nov 2019 15:16:41 GMT, Kevin Rushforth wrote: > On Tue, 26 Nov 2019 15:16:38 GMT, Ambarish Rapte wrote: > >> The finalize() method is deprecated in JDK9. See [Java 9 deprecated >> features](https://www.oracle.com/technetwork/java/javase/9-deprecated-features-3745636.html). >> And

Re: RFR: 8130738: Add tabSize property to Text and TextFlow

2019-11-27 Thread Thomas K
On Wed, 27 Nov 2019 01:30:22 GMT, Kevin Rushforth wrote: > On Wed, 27 Nov 2019 01:17:42 GMT, Scott Palmer wrote: > >> On Tue, 26 Nov 2019 18:48:38 GMT, Kevin Rushforth wrote: >> >>> On Tue, 26 Nov 2019 18:40:10 GMT, Scott Palmer wrote: >>> On Thu, 7 Nov 2019 14:56:58 GMT, Kevin

Re: [Rev 02] RFR: 8130738: TextFlow's tab width is static

2019-11-27 Thread Jeanette Winzenburg
On Wed, 27 Nov 2019 00:58:22 GMT, Kevin Rushforth wrote: > On Tue, 26 Nov 2019 17:26:33 GMT, Scott Palmer wrote: > >> The pull request has been updated with a complete new set of changes >> (possibly due to a rebase). >> >> >> >> Commits: >> - 254c40de: Merge