I have a testcase + fix ready for JDK-8237372 (A null pointer exception in
TabPaneSkin if only a mouse release event is sent to the skin).
To avoid the kind of confusion I created with my last pull request ;-)
* For what branch should I create the pull request? (From my point of view
jfx14 is
I'd create a scenegraph
R
.-+-.
A B
.+.
CD
Where C and D are Labels. Then I'd set a font style on A and a different font
style on B.
C and D should pick up the font style of A. Then move D to B and see if it
On Thu, 16 Jan 2020 17:00:47 GMT, Frederic Thevenet
wrote:
>> This PR aims to address the following issue: JDK-8088198 Exception thrown
>> from snapshot if dimensions are larger than max texture size
>>
>> In order to do that, it simply captures snapshots in multiple tiles of
>>
On Thu, 16 Jan 2020 14:26:24 GMT, Kevin Rushforth wrote:
>> I think it is not worth it.
>
> I agree. I do like the suggestion to rename the variables, though.
done in 501917284e0490d16b1831fcd854e31a779449b9
-
PR: https://git.openjdk.java.net/jfx/pull/68
Hi Ajit, David,
I came accross a potential issue introduced by JDK-8090462 (
https://bugs.openjdk.java.net/browse/JDK-8090462), (
https://github.com/openjdk/jfx/commit/834b0d05e7a2a8351403ec4a121eab312d80fd24#diff-9ec098280fa1aeed53c70243347e76ab).
The issue is in the canReuseStyleHelper method.
On Thu, 16 Jan 2020 10:47:26 GMT, Ambarish Rapte wrote:
>> The pull request has been updated with 1 additional commit.
>
> modules/javafx.graphics/src/main/java/javafx/scene/Scene.java line 1303:
>
>> 1302: if (height > maxTextureSize || width > maxTextureSize) {
>> 1303:
On Thu, 16 Jan 2020 10:58:12 GMT, Ambarish Rapte wrote:
>> The pull request has been updated with 1 additional commit.
>
> modules/javafx.graphics/src/main/java/javafx/scene/Scene.java line 1312:
>
>> 1311: int tileWidth = Math.min(maxTextureSize, width -
>> xOffset);
>>
On Thu, 16 Jan 2020 14:16:37 GMT, Michael Paus wrote:
>> Indeed, substituting the floating math for integer math requires an extra
>> test on the remainder to be correct.
>> Since this code isn't located in a tight loop, I'm not sure this
>> optimization is worth making the code less straight
On Thu, 16 Jan 2020 13:56:44 GMT, Frederic Thevenet
wrote:
>> I think the proposed code changes are wrong in case that `height /
>> maxTextureSize` is an exact integer. (Same for width). I normally add the 1
>> only if `height % maxTextureSize != 0`
>
> Indeed, substituting the floating
> This PR aims to address the following issue: JDK-8088198 Exception thrown
> from snapshot if dimensions are larger than max texture size
>
> In order to do that, it simply captures snapshots in multiple tiles of
> maxTextureSize^2 dimensions (or less, as needed), and then recomposes all the
On Thu, 16 Jan 2020 11:56:10 GMT, Michael Paus wrote:
>> Assuming `Nb` in `verticalTileNb` stands for number, I would recommend to
>> change the names as `numVerticalTiles` and `numHorizontalTiles`
>
> I think the proposed code changes are wrong in case that `height /
> maxTextureSize` is an
On Thu, 16 Jan 2020 11:28:21 GMT, Ambarish Rapte wrote:
>> The pull request has been updated with 1 additional commit.
>
> The fix itself looks good and seems safe for 14.
> I do have few minor changes in test file and suggestions in fix code, please
> take a look.
> Also verified that large
On Thu, 16 Jan 2020 10:55:38 GMT, Ambarish Rapte wrote:
>> modules/javafx.graphics/src/main/java/javafx/scene/Scene.java line 1306:
>>
>>> 1305: int verticalTileNb = (int) Math.ceil(height / (double)
>>> maxTextureSize);
>>> 1306: int horizontalTileNb = (int)
On Thu, 16 Jan 2020 11:28:46 GMT, Frederic Thevenet
wrote:
>> This PR aims to address the following issue: JDK-8088198 Exception thrown
>> from snapshot if dimensions are larger than max texture size
>>
>> In order to do that, it simply captures snapshots in multiple tiles of
>>
On Thu, 16 Jan 2020 10:55:11 GMT, Ambarish Rapte wrote:
>> The pull request has been updated with 1 additional commit.
>
> modules/javafx.graphics/src/main/java/javafx/scene/Scene.java line 1306:
>
>> 1305: int verticalTileNb = (int) Math.ceil(height / (double)
>> maxTextureSize);
I filed https://bugs.openjdk.java.net/browse/JDK-8237329
Tom
On 09.01.20 15:48, Tom Schindl wrote:
> I also tried with
> https://docs.oracle.com/javafx/2/drag_drop/jfxpub-drag_drop.htm and it
> does not work either.
--
Tom Schindl, CTO
BestSolution.at EDV Systemhaus GmbH
Salurnerstrasse 15.
16 matches
Mail list logo
