Re: RFR: 8236651: Simplify and update glass gtk backend

On Wed, 1 Apr 2020 03:21:31 GMT, Thiago Milczarek Sayao wrote: >> Ubuntu 20.04 Test Results >> >> Updated April 2nd. >> >>  > > Test on 16.04 (without Webkit - it does not build on

Re: [Rev 42] RFR: 8236651: Simplify and update glass gtk backend

> This proposed change does the following: > > - Ports DND target to use GTK reducing code size and adding extra text / > image formats (such as .gif); > - Use gtk signals instead of gdk events (also to reduce code size); > - Simplifies geometry (sizing/positioning) with a more straightforward

Re: [Rev 41] RFR: 8236651: Simplify and update glass gtk backend

> This proposed change does the following: > > - Ports DND target to use GTK reducing code size and adding extra text / > image formats (such as .gif); > - Use gtk signals instead of gdk events (also to reduce code size); > - Simplifies geometry (sizing/positioning) with a more straightforward

Re: RFR: 8129123: ComboBox popup list view does not scrollTo when ComboBox value/selection is set

On Thu, 2 Apr 2020 22:20:18 GMT, Kevin Rushforth wrote: > Can you please provide a unit test? One that fails before your fix and passes > after your fix. I can provide a manual test the next couple of days that demonstrates it before and after, but I'm not sure how to create an automated unit

Re: A WIP for JDK-8238080 for review/discussion (Re: "Internal review ID 9063426: "FXMLLoader: if script engines implement javax.script.Compilabel compile scripts"

Hi Rony, I see that you updated the PR and sent it for review. Before we formally review it in the PR, let's finish the discussion as to whether this is a useful feature, and if so, what form this feature should take. From my point of view, this does seem like a useful feature. Would other

RFR: 8238080: FXMLLoader: if script engines implement javax.script.Compilable compile scripts

TODO: ADD DESCRIPTION OF PROPOSED FIX HERE. - Commit messages: - Correct error constant. - appease the jcheck script, such that that important trailing Whitespace error can be resolved (why would jcheck not do it automagically as well as expanding tabs?) - Merge master, correct

Re: RFR: 8238080: FXMLLoader: if script engines implement javax.script.Compilable compile scripts

On Fri, 28 Feb 2020 17:46:58 GMT, Rony G. Flatscher wrote: > TODO: ADD DESCRIPTION OF PROPOSED FIX HERE. We will need to finish the discussion on this proposed new feature on the openjfx-dev mailing list. The PR can be used to illustrate what you want to do, but use [this email

Re: RFR: 8129123: ComboBox popup list view does not scrollTo when ComboBox value/selection is set

On Thu, 2 Apr 2020 22:20:18 GMT, Kevin Rushforth wrote: >> This pull request fixes JDK-8129123. This bug also effects Windows and >> Linux platforms. >> Also, I believe JDK-8196037 is a duplicate of this issue. >> >> I've tested this against OpenJDK 11.0.6 on Ubuntu 18.04, Arch Linux and >>

Re: RFR: 8129123: ComboBox popup list view does not scrollTo when ComboBox value/selection is set

On Wed, 4 Mar 2020 22:43:45 GMT, Craig Cavanaugh wrote: > This pull request fixes JDK-8129123. This bug also effects Windows and Linux > platforms. > Also, I believe JDK-8196037 is a duplicate of this issue. > > I've tested this against OpenJDK 11.0.6 on Ubuntu 18.04, Arch Linux and >

RFR: 8236971: [macos] Gestures handled incorrectly due to missing events

As noted in the JBS issue, this bug is a result of a deliberate change by Apple that affects applications (in this case the JDK) linked against MacOSX 10.11 SDK or later -- they no longer call two methods that we are relying on, `beginGestureWithEvent` and `endGestureWithEvent`. There is no

Re: RFR: 8236971: [macos] Gestures handled incorrectly due to missing events

On Thu, 2 Apr 2020 14:55:35 GMT, Kevin Rushforth wrote: > As noted in the JBS issue, this bug is a result of a deliberate change by > Apple that affects applications (in this case > the JDK) linked against MacOSX 10.11 SDK or later -- they no longer call two > methods that we are relying on, >

Re: [Rev 40] RFR: 8236651: Simplify and update glass gtk backend

> This proposed change does the following: > > - Ports DND target to use GTK reducing code size and adding extra text / > image formats (such as .gif); > - Use gtk signals instead of gdk events (also to reduce code size); > - Simplifies geometry (sizing/positioning) with a more straightforward

Re: [Rev 39] RFR: 8236651: Simplify and update glass gtk backend

> This proposed change does the following: > > - Ports DND target to use GTK reducing code size and adding extra text / > image formats (such as .gif); > - Use gtk signals instead of gdk events (also to reduce code size); > - Simplifies geometry (sizing/positioning) with a more straightforward

Re: [Rev 38] RFR: 8236651: Simplify and update glass gtk backend

> This proposed change does the following: > > - Ports DND target to use GTK reducing code size and adding extra text / > image formats (such as .gif); > - Use gtk signals instead of gdk events (also to reduce code size); > - Simplifies geometry (sizing/positioning) with a more straightforward

Re: Seeking help with latest master ...

I have no scientific evidence for this, but I remember issues related to SSL with some JDK's as well, which may or may not be related to the cacerts file that is bundled. - Johan On Thu, Apr 2, 2020 at 6:52 PM Rony G. Flatscher wrote: > Being stuck (tried the previous working gradle 5.6.4,

Re: A WIP for JDK-8238080 for review/discussion (Re: "Internal review ID 9063426: "FXMLLoader: if script engines implement javax.script.Compilabel compile scripts"

After merging master, applying some fixes and changing the title to reflect the change from WIP to a pull request I would kindly request a review of this pull request! Here the URL: , title changed to: "8238080: FXMLLoader: if script engines implement

RFR: 8129123: ComboBox popup list view does not scrollTo when ComboBox value/selection is set

This pull request fixes JDK-8129123. This bug also effects Windows and Linux platforms. Also, I believe JDK-8196037 is a duplicate of this issue. I've tested this against OpenJDK 11.0.6 on Ubuntu 18.04, Arch Linux and Windows 10. Thanks! - Commit messages: - Merge branch

Re: Seeking help with latest master ...

Being stuck (tried the previous working gradle 5.6.4, could get "gradle clean", but not further) in the end I just tried Java 14 and that allowed me to run "gradle" successfully (currently building webkit to get going again). Just wanted to let interested readers know. (Would be great though,

Re: [Rev 03] RFR: 8236840: Memory leak when switching ButtonSkin

On Thu, 2 Apr 2020 12:58:11 GMT, Ambarish Rapte wrote: >> ButtonSkin adds a `ChangeListener` to `Control.sceneProperty()` which >> results in leaking the `ButtonSkin` itself when >> the `Button`'s skin is changed to a new `ButtonSkin`. Using a >> `WeakChangeListener` instead of

Re: [Rev 01] RFR: 8236840: Memory leak when switching ButtonSkin

On Mon, 30 Mar 2020 10:36:13 GMT, Jeanette Winzenburg wrote: >> Thanks for the test case, I did minor changes to it and included in the next >> commit. >> The NPE can occur even without `button.setDefaultButton(true);`. >> Please take a look > > good catch! You are right, without explicit

Re: [Rev 03] RFR: 8236840: Memory leak when switching ButtonSkin

> ButtonSkin adds a `ChangeListener` to `Control.sceneProperty()` which results > in leaking the `ButtonSkin` itself when > the `Button`'s skin is changed to a new `ButtonSkin`. Using a > `WeakChangeListener` instead of `ChangeListener` solves > the issue. > Please take a look. Ambarish Rapte

Re: [Rev 03] RFR: 8217472: Add attenuation for PointLight

On Fri, 3 Jan 2020 09:26:43 GMT, Ambarish Rapte wrote: >> Nir Lisker has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Attenuation and range changed internally to floats from doubles > > I have added few comments, but have not run tests

Re: [Rev 01] RFR: 8241370: Crash in JPEGImageLoader after fix for JDK-8212034

On Thu, 2 Apr 2020 07:04:08 GMT, Ambarish Rapte wrote: >> This is a regression of >> [JDK-8212034](https://bugs.openjdk.java.net/browse/JDK-8212034). >> When image is loaded in WebView usinga url, WebView attempts to load a image >> frames with partial image data. This was >> implemented

Re: [Rev 01] RFR: 8241455: Memory leak on replacing selection/focusModel

On Thu, 2 Apr 2020 09:12:55 GMT, Jeanette Winzenburg wrote: >> modules/javafx.controls/src/test/java/test/javafx/scene/control/SelectionFocusModelMemoryTest.java >> line 285: >> >>> 284: } >>> 285: root.getChildren().add(node); >>> 286: if (!stage.isShowing()) { >> >>

Re: [Rev 02] RFR: 8241455: Memory leak on replacing selection/focusModel

On Thu, 2 Apr 2020 09:11:57 GMT, Jeanette Winzenburg wrote: >> Several controls with selection/focusModels leave memory leaks on replacing >> the model. >> >> Added tests for all such, those for the misbehaving models fail before and >> pass after the fix. >> >> for convenience, the bug

Re: [Rev 01] RFR: 8241455: Memory leak on replacing selection/focusModel

On Wed, 1 Apr 2020 19:34:09 GMT, Ambarish Rapte wrote: > > Will it be good to add a call to `root.getChildren().removeAll()` before > adding the `node` to `root` ? hmm .. don't think that it's necessary to clear out other children: the thing that actually matters is that the control goes

Re: [Rev 02] RFR: 8241455: Memory leak on replacing selection/focusModel

> Several controls with selection/focusModels leave memory leaks on replacing > the model. > > Added tests for all such, those for the misbehaving models fail before and > pass after the fix. > > for convenience, the bug reference > https://bugs.openjdk.java.net/browse/JDK-8241455 Jeanette

Re: [Rev 01] RFR: 8241370: Crash in JPEGImageLoader after fix for JDK-8212034

> This is a regression of > [JDK-8212034](https://bugs.openjdk.java.net/browse/JDK-8212034). > When image is loaded in WebView usinga url, WebView attempts to load a image > frames with partial image data. This was > implemented under, JDK-8153148 -> WCImageDecoderImpl.addImageData() -> calls >