Re: Proposed IntegerSpinner buggy behavior correction - JDK-8242553

Hi Jeanette, The doc never assumes amountPerStep = 1. I am quoting it here - “The wrapAround property is used to specify whether the value factory should be circular. For example, should an integer-based value model increment from the maximum value back to the minimum value (and vice versa).” T

Re: RFR: 8238650: Allow to override buildDate with SOURCE_DATE_EPOCH

On Tue, 14 Apr 2020 11:48:55 GMT, Kevin Rushforth wrote: >> Finally getting to this (sorry for the delay). This seems OK to me, as it is >> not an intrusive change. I do not think >> that actually setting this property for production builds is a good idea, so >> I recommend against that (ultima

Re: RFR: Request to sync April 2020 CPU changes into jfx

Approved. On Tue, Apr 14, 2020 at 5:58 PM Kevin Rushforth wrote: > Johan and Phil, > > I request approval to sync changes from to the just-released April 2020 > CPU release into the 'master' branch of the 'jfx' repo. Here is the > aggregate set of changes for the fixes: > > https://github.com/ke

Re: [11][14] RFR: Request to backport April 2020 CPU changes

Approved, looks good. - Johan On Tue, Apr 14, 2020 at 6:10 PM Kevin Rushforth wrote: > Hi Johan, > > I request approval to backport the changes from the just-released April > 2020 CPU to 11-dev (for 11.0.7) and the jfx14 branch of jfx (for 14.0.1). > > https://cr.openjdk.java.net/~kcr/cpu-2004-

Re: A WIP for JDK-8238080 for review/discussion (Re: "Internal review ID 9063426: "FXMLLoader: if script engines implement javax.script.Compilabel compile scripts"

Yes, I agree that enough time has gone by. Go ahead with your proposal. I would wait a bit to create the CSR until the review is far enough along to know which direction we intend to go. Unless there is a real concern about possible regressions if scripts are compiled by default, I think "enab

Re: [Rev 03] RFR: 8241476: Linux build warnings issued on gcc 9

On Fri, 10 Apr 2020 19:00:25 GMT, Thiago Milczarek Sayao wrote: >> Simple fix to remove annoying warnings. > > Thiago Milczarek Sayao has updated the pull request incrementally with one > additional commit since the last revision: > > Gstreamer build Marked as reviewed by arapte (Reviewer).

Re: [Rev 03] RFR: 8241476: Linux build warnings issued on gcc 9

On Mon, 13 Apr 2020 14:47:35 GMT, Kevin Rushforth wrote: >> Looks good. > > @johanvos or @arapte Can one of you be the second reviewer on this? After this change below c files would be compiled without `-Werror=implicit-function-declaration` option. modules/javafx.media/src/main/native/jfxmedi

Re: A WIP for JDK-8238080 for review/discussion (Re: "Internal review ID 9063426: "FXMLLoader: if script engines implement javax.script.Compilabel compile scripts"

Hi there, as there was probably enough time that has passed by I would intend to create a CSR in the next days with the PR as per Kevin's suggestion. (For the case that this feature should not be active by default, the CSR will suggest to define a new "compile" PI in the form (default, if no P

[11][14] RFR: Request to backport April 2020 CPU changes

Hi Johan, I request approval to backport the changes from the just-released April 2020 CPU to 11-dev (for 11.0.7) and the jfx14 branch of jfx (for 14.0.1). https://cr.openjdk.java.net/~kcr/cpu-2004-sync/11-dev/webrev/ https://github.com/kevinrushforth/jfx/compare/f8c235b...14-cpu-2004-sync Ea

RFR: Request to sync April 2020 CPU changes into jfx

Johan and Phil, I request approval to sync changes from to the just-released April 2020 CPU release into the 'master' branch of the 'jfx' repo. Here is the aggregate set of changes for the fixes: https://github.com/kevinrushforth/jfx/compare/4d69a0d...cpu-2004-sync NOTE: Since this is an int

Re: [jfx14] RFR: 8242637: Change JavaFX release version in jfx14 branch to 14.0.1

On Tue, 14 Apr 2020 14:33:53 GMT, Johan Vos wrote: > Fix for JDK-8242637 Marked as reviewed by kcr (Lead). - PR: https://git.openjdk.java.net/jfx/pull/183

[jfx14] RFR: 8242637: Change JavaFX release version in jfx14 branch to 14.0.1

Fix for JDK-8242637 - Commit messages: - Increase release version for JavaFX 14.0.1 Changes: https://git.openjdk.java.net/jfx/pull/183/files Webrev: https://webrevs.openjdk.java.net/jfx/183/webrev.00 Issue: https://bugs.openjdk.java.net/browse/JDK-8242637 Stats: 1 line in 1 fil

Re: Proposed IntegerSpinner buggy behavior correction - JDK-8242553

Hi Ajit, thought the doc was simply bad (in specifying the behavior for amountPerStep = 1 and not thinking of larger amounts) - my expection is a calculated wrap, that is the target as you suggest via modulo the difference from current value. Don't know if anybody took the doc literally

Proposed IntegerSpinner buggy behavior correction - JDK-8242553

Hi, Once I fix JDK-8193286, I would like to take up JDK-8242553 (IntegerSpinner does not wrap around values correctly if amountToStepBy is larger than total numbers between Max and Min) The current implementation is not as per what is documented. Refer : https://openjfx.io/javadoc/14/

Re: RFR: backport fixes for JavaFX 14.0.1

+1 Looks good. -- Kevin On 4/14/2020 5:53 AM, Johan Vos wrote: Hi Kevin, I request permission to backport the following fixes into JavaFX 14.0.1 (in the jfx14 branch). https://bugs.openjdk.java.net/browse/JDK-8233942 JDK-8233942 -- Update

Re: RFR: 8241737: TabPaneSkin memory leak on replacing selectionModel

On Tue, 14 Apr 2020 13:01:18 GMT, Jeanette Winzenburg wrote: >> This is needed to future safe the code from an NPE from scenarios as in >> below test case, >> >> class TabPaneSkin1 extends TabPaneSkin { >> TabPaneSkin1(TabPane tabPane) { >> super(tabPane); >> }

Re: [Rev 01] RFR: 8240969: WebView does not allow to load style sheet in modularized applications

> Currently, loading a style sheet file using > `WebView.getEngine().setUserStyleSheetLocation(url)` fails if the url > start's with `jrt`, i.e. if the file is packaged in an application image > using jlink. This is fixed with this PR. Tobias Diez has updated the pull request incrementally with

Re: RFR: 8240969: WebView does not allow to load style sheet in modularized applications

On Tue, 14 Apr 2020 11:49:50 GMT, Kevin Rushforth wrote: >> Yes, we had this exception in our application which was (temporarily) fixed >> with >> https://github.com/JabRef/jabref/pull/5497. But JabRef is 100k lines of >> code, so I doubt this counts as a unit test. > > @tobiasdiez are you plan

Re: RFR: 8241737: TabPaneSkin memory leak on replacing selectionModel

On Tue, 14 Apr 2020 12:20:16 GMT, Ambarish Rapte wrote: >> modules/javafx.controls/src/main/java/javafx/scene/control/skin/TabPaneSkin.java >> line 270: >> >>> 269: } >>> 270: >>> 271: super.dispose(); >> >> wondering if the removal is really needed? The memory leak seems to be

RFR: backport fixes for JavaFX 14.0.1

Hi Kevin, I request permission to backport the following fixes into JavaFX 14.0.1 (in the jfx14 branch). https://bugs.openjdk.java.net/browse/JDK-8233942 JDK-8233942 -- Update to 609.1 version of WebKit https://bugs.openjdk.java.net/browse/JDK-

Re: RFR: 8185886: Improve scrolling performance of TableView and TreeTableView

On Tue, 10 Mar 2020 06:08:25 GMT, yosbits wrote: >>> technically true - but the implementation was linear with a fixed sequence >>> since-the-beginning-of-java-desktop-time >>> (and sometimes, for good ol' beans properties, even exposed as api to >>> access the array of listeners). So technica

Re: RFR: 8241737: TabPaneSkin memory leak on replacing selectionModel

On Mon, 13 Apr 2020 15:47:00 GMT, Jeanette Winzenburg wrote: >> `TabPaneSkin` adds a listener to `SelectionModel.selectedItemProperty()` >> which holds the `SelectionModel` from being >> GCed. Fix is to add and remove the listener when a `SelectionModel` is >> changed. >> If the fix looks good

Re: RFR: 8240969: WebView does not allow to load style sheet in modularized applications

On Fri, 13 Mar 2020 13:05:29 GMT, Tobias Diez wrote: >> You must have some use case that fails without this proposed fix (else why >> are you proposing it), right? > > Yes, we had this exception in our application which was (temporarily) fixed > with > https://github.com/JabRef/jabref/pull/549

Re: RFR: 8238650: Allow to override buildDate with SOURCE_DATE_EPOCH

On Thu, 27 Feb 2020 00:01:28 GMT, Kevin Rushforth wrote: >> Allow to override buildDate with `SOURCE_DATE_EPOCH` >> in order to make builds reproducible. >> See https://reproducible-builds.org/ for why this is good >> and https://reproducible-builds.org/specs/source-date-epoch/ >> for the definit

Re: RFR: 8176270: Adding ChangeListener to TextField.selectedTextProperty causes StringOutOfBoundsException

On Sun, 9 Feb 2020 14:40:25 GMT, Jeanette Winzenburg wrote: >> I left comments inline. This will need changes. Also, you will need to >> provide a test that fails without the fix and >> passes with the fix. > > Just a comment on how to add a failing test: we can replace the actual > typing (i

Re: RFR: 8202296: Monocle MouseInput doesn't send keyboard modifiers in events.

On Fri, 10 Apr 2020 10:26:06 GMT, Tom Schindl wrote: > Extract keystate and add to the existing modifier mask, to support eg > multi-select > > https://bugs.openjdk.java.net/browse/JDK-8202296 The fix looks simple enough. Can you add a unit test? - PR: https://git.openjdk.java.net

Re: RFR: 8242548: Honor line spacing in Labeled reflow calculation

On Sun, 12 Apr 2020 21:21:07 GMT, John Hendrikx wrote: > This is a solution for 8242548. There was zero test coverage, so I added a > few tests for this as well. @aghaisas can you review this? - PR: https://git.openjdk.java.net/jfx/pull/173

Re: [Rev 01] RFR: 8241840: Memoryleak: Closed focused Stages are not collected with Monocle.

On Tue, 7 Apr 2020 09:51:18 GMT, Ambarish Rapte wrote: >> Florian Kirmaier has updated the pull request incrementally with one >> additional commit since the last revision: >> >> JDK-8241840 >> Some code cleanups > > tests/system/src/test/java/test/javafx/stage/FocusedWindowTest.java line 1

Re: [Rev 01] RFR: 8241840: Memoryleak: Closed focused Stages are not collected with Monocle.

> Closed focused Stages are not collected with Monocle > > This commit adds a unit-test and a fix for collecting focused closed stages. > > ticket: https://bugs.openjdk.java.net/browse/JDK-8241840 Florian Kirmaier has updated the pull request incrementally with one additional commit since the l

Re: RFR: 8241840: Memoryleak: Closed focused Stages are not collected with Monocle.

On Tue, 7 Apr 2020 09:44:34 GMT, Ambarish Rapte wrote: >> Closed focused Stages are not collected with Monocle >> >> This commit adds a unit-test and a fix for collecting focused closed stages. >> >> ticket: https://bugs.openjdk.java.net/browse/JDK-8241840 > > tests/system/src/test/java/test/ja

RFR: 8242577: Cell selection fails on iOS most of the times

There are cases when iOS sends one or more NSTouchPhaseMoved for a given touch event, in between NSTouchPhaseBegan and NSTouchPhaseEnded , even if the initial event location didn't change. By default, all these events are emulated as mouse enter/down, drag and up/exit events. However, when the

Mac: Supported MacOS JDKs

Hi everyone, it seems to me, that the newest JDK for Mac (MacOSX10.15.sdk) doesn't work to build JavaFX. It works for me with 10.14 but not with 10.15. Can anyone confirm this? It would be great to mention this in the build instructions here: https://wiki.openjdk.java.net/display/OpenJFX/Building+

Re: RFR: 8242490: Upgrade to gcc 9.2 on Linux

On Mon, 13 Apr 2020 16:12:38 GMT, Kevin Rushforth wrote: > This is a compiler upgrade on Linux from the current gcc 8.3 compiler to gcc > 9.2. This will match a recent upgrade done > for JDK 15 -- see > [JDK-8241721](https://bugs.openjdk.java.net/browse/JDK-8241721). > On a related note, using