Re: Is it possible to customise the theme of the Scene Builder itself?

2020-04-23 Thread Abhinay Agarwal
Hi, Scene Builder is open-sourced [1]. If you find something can be improved, please feel free to send a PR. All the style-sheets use to style Scene Builder can be found in the repository [2]. -- Abhinay [1] https://github.com/gluonhq/scenebuilder [2]

Re: [Rev 03] RFR: 8217472: Add attenuation for PointLight

2020-04-23 Thread Phil Race
On Fri, 24 Apr 2020 01:50:11 GMT, Kevin Rushforth wrote: >> I think most of those are good suggestions going forward. As for the >> performance drop, the only place we've seen it so >> far is on graphics accelerators that are a few years old by now. Integrated >> graphics chipsets (such as

Re: Scene Builder Support for javafx 14

2020-04-23 Thread Abhinay Agarwal
Hi Apurwa, Any FXML created by Scene Builder 11 can be used by JavaFX 14. > I tried downloading the latest version of Scene Builder but its not > compatible with javafx. Can you pleases explain what incompatibility issues are you facing? -- Abhinay From:

Re: [Rev 03] RFR: 8217472: Add attenuation for PointLight

2020-04-23 Thread Kevin Rushforth
On Sat, 18 Apr 2020 15:45:32 GMT, Kevin Rushforth wrote: >> I discussed this with a graphics engineer. He said that a couple of branches >> do not have any real performance impact >> even on modern mobile devices, and that, e.g., on iOS 7 using half floats >> instead of floats was improving

Re: RE; Community request to test 3D performance

2020-04-23 Thread Kevin Rushforth
That one had a compilation error (I think). Anyway, I uploaded a new one that is very slightly modified to allow setting the number of quads via a system property: https://github.com/openjdk/jfx/files/4526179/pointlighttest.zip -- Kevin On 4/23/2020 3:04 PM, Nir Lisker wrote: Isn't it this

Re: RFR: 8243255: Font size is large in JavaFX app with enabled Monocle on Raspberry Pi

2020-04-23 Thread John Neffenger
On Thu, 23 Apr 2020 23:58:19 GMT, John Neffenger wrote: >> I couldn't understand why I wasn't hitting this error on the embedded >> Monocle EPD platform. Stepping through the code >> with the debugger, I found that JavaFX is looking for the >> *javafx.platform.properties* file in the wrong

RFR: 8242523: Update the animation and clip envelope classes

2020-04-23 Thread Nir Lisker
Mostly refactoring in preparation of the upcoming fixes. The changes might look like a lot, but it's mostly rearranging of methods. Summery of changes: ### Animation * Added `isNearZero` and `areNearEqual` methods that deal with `EPSILON` checks. * Added `isStopped`, `isRunning` and `isPaused`

Re: RFR: 8243255: Font size is large in JavaFX app with enabled Monocle on Raspberry Pi

2020-04-23 Thread John Neffenger
On Thu, 23 Apr 2020 22:43:30 GMT, John Neffenger wrote: >> See the detailed issue description on: >> http://mail.openjdk.java.net/pipermail/openjfx-dev/2020-April/025975.html >> >> The fix 8236448 https://github.com/openjdk/jfx/pull/75 changes >>

Re: RFR: 8243255: Font size is large in JavaFX app with enabled Monocle on Raspberry Pi

2020-04-23 Thread John Neffenger
On Tue, 21 Apr 2020 16:47:44 GMT, Alexander Scherbatiy wrote: > See the detailed issue description on: > http://mail.openjdk.java.net/pipermail/openjfx-dev/2020-April/025975.html > > The fix 8236448 https://github.com/openjdk/jfx/pull/75 changes >

Re: RE; Community request to test 3D performance

2020-04-23 Thread Nir Lisker
Isn't it this one? https://github.com/openjdk/jfx/pull/43#issuecomment-599080407 On Fri, Apr 24, 2020 at 1:02 AM Kevin Rushforth wrote: > Thanks, David. > > I presume you will be running Windows? Ideally we would get results on > Windows and Mac. > > Nir: I can upload the modified version of

Re: RE; Community request to test 3D performance

2020-04-23 Thread Kevin Rushforth
Thanks, David. I presume you will be running Windows? Ideally we would get results on Windows and Mac. Nir: I can upload the modified version of the benchmark, unless you have a working version. -- Kevin On 4/23/2020 2:41 PM, Nir Lisker wrote: I think so. The test is relatively simple,

Re: RE; Community request to test 3D performance

2020-04-23 Thread Nir Lisker
I think so. The test is relatively simple, so it should be worth it. Thanks. On Fri, Apr 24, 2020 at 12:04 AM David Grieve wrote: > I have an NVIDIA Quadro P400. Will that help? > > -Original Message- > From: openjfx-dev On Behalf Of Nir > Lisker > Sent: Thursday, April 23, 2020 3:55

Community request to test 3D performance

2020-04-23 Thread Nir Lisker
Hi all, My PR [1] for adding attenuation for PointLight is pending tests from setups with recent NVidia or AMD GPUs. If anyone has such a setup, it would greatly help to get tests results from it. Thanks, Nir [1] https://github.com/openjdk/jfx/pull/43

Re: Gradle support for getting :web:test working properly

2020-04-23 Thread Kevin Rushforth
That's an interesting idea that might be worth pursuing. It would help mitigate what has been a long-standing pain point for developers who don't want to build media or web, but would like to run them. I would caution, though, that it is still not a substitute for building both media and

Re: White box / window flicker upon launch

2020-04-23 Thread David Grieve
It doesn't reproduce for me on windows with JavaFX 11.0.2. Whether this is a bug and/or a regression I cannot say. -Original Message- From: Dirk Lemmermann Sent: Thursday, April 23, 2020 10:20 AM To: David Grieve Cc: OpenJFX Subject: [EXTERNAL] Re: White box / window flicker upon

Re: White box / window flicker upon launch

2020-04-23 Thread Dirk Lemmermann
I tried as you suggested. Problem is still there. > On 23 Apr 2020, at 16:00, David Grieve wrote: > > Another possible workaround is to call Node#applyCss() before stage.show(). > There is an example in the Javadoc for the applyCss() method. > > -Original Message- > From: openjfx-dev

Re: White box / window flicker upon launch

2020-04-23 Thread Dirk Lemmermann
I notice the word “workaround” :-) So you would agree it is a bug? And if so …. regression? I never noticed it before. > On 23 Apr 2020, at 16:00, David Grieve wrote: > > Another possible workaround is to call Node#applyCss() before stage.show(). > There is an example in the Javadoc for the

RE: White box / window flicker upon launch

2020-04-23 Thread David Grieve
Another possible workaround is to call Node#applyCss() before stage.show(). There is an example in the Javadoc for the applyCss() method. -Original Message- From: openjfx-dev On Behalf Of Dirk Lemmermann Sent: Wednesday, April 22, 2020 1:46 PM To: OpenJFX Subject: [EXTERNAL] White box

Re: backport request: JDK-8235627

2020-04-23 Thread Kevin Rushforth
+1 On 4/23/2020 5:36 AM, Johan Vos wrote: Hi Kevin, I request permission to backport https://bugs.openjdk.java.net/browse/JDK-8235627 to JavaFX 11. Thanks, - Johan

backport request: JDK-8235627

2020-04-23 Thread Johan Vos
Hi Kevin, I request permission to backport https://bugs.openjdk.java.net/browse/JDK-8235627 to JavaFX 11. Thanks, - Johan

Re: [Rev 01] RFR: 8242861: Update ImagePattern to apply SVG pattern transforms

2020-04-23 Thread Arun Joseph
> fillPath() and fillRect() functions in > [GraphicsContextJava.cpp](https://github.com/openjdk/jfx/blob/master/modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/java/GraphicsContextJava.cpp) > use Image::drawPattern() for applying patterns as fill. But drawPattern() > doesn't

Re: [Rev 02] RFR: 8242548: Honor line spacing in Labeled reflow calculation

2020-04-23 Thread Kevin Rushforth
On Thu, 23 Apr 2020 11:22:18 GMT, John Hendrikx wrote: >> Marked as reviewed by aghaisas (Reviewer). > > I added a comment clarification and passed the line spacing to the ellipsis > height calculation as well (just in case > there is a multi line ellipsis). > The test indeed doesn't quite

Re: [Rev 01] RFR: 8198402: ToggleButton.setToggleGroup causes memory leak when button is removed via ToggleGroup.getToggles()

2020-04-23 Thread Kevin Rushforth
On Thu, 23 Apr 2020 07:55:06 GMT, Jesper Skov wrote: >> Ah, well. Ended with the same VM crash when building webkit myself. >> >> So I am kinda stuck. Suggestions? > > I have found out that my :web:test failed because I did not have the > media libs properly installed. > > So the changes in

Re: White box / window flicker upon launch

2020-04-23 Thread Dirk Lemmermann
Ticket created: ID 9064689 Dirk > On 23 Apr 2020, at 13:40, Dirk Lemmermann wrote: > > I think this is a bug … I will create a ticket for it. When this behaviour > was fixed for Swing in Java 6 it made a huge difference in the perception of > the quality and performance of Java applications.

Re: White box / window flicker upon launch

2020-04-23 Thread Dirk Lemmermann
I think this is a bug … I will create a ticket for it. When this behaviour was fixed for Swing in Java 6 it made a huge difference in the perception of the quality and performance of Java applications. Could do the same for JavaFX. Dirk > On 22 Apr 2020, at 20:17, Tom Schindl wrote: > > yes

Re: [Rev 02] RFR: 8242548: Honor line spacing in Labeled reflow calculation

2020-04-23 Thread John Hendrikx
On Thu, 23 Apr 2020 10:51:05 GMT, Ajit Ghaisas wrote: >> John Hendrikx has refreshed the contents of this pull request, and previous >> commits have been removed. The incremental >> views will show differences compared to the previous content of the PR. The >> pull request contains one new

Re: [Rev 02] RFR: 8242548: Honor line spacing in Labeled reflow calculation

2020-04-23 Thread John Hendrikx
> This is a solution for 8242548. There was zero test coverage, so I added a > few tests for this as well. John Hendrikx has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the

Re: [Rev 01] RFR: 8242548: Honor line spacing in Labeled reflow calculation

2020-04-23 Thread John Hendrikx
> This is a solution for 8242548. There was zero test coverage, so I added a > few tests for this as well. John Hendrikx has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the

Re: RFR: 8242548: Honor line spacing in Labeled reflow calculation

2020-04-23 Thread Ajit Ghaisas
On Tue, 21 Apr 2020 12:48:37 GMT, Kevin Rushforth wrote: >> @aghaisas can you review this? > > @aghaisas can you also review this? I tested with the test program in the bug and can confirm that this PR fixes the reported issue. I found that the unit test (together with stub) passes without

Re: RFR: 8242548: Honor line spacing in Labeled reflow calculation

2020-04-23 Thread Ajit Ghaisas
On Sun, 12 Apr 2020 21:21:07 GMT, John Hendrikx wrote: > This is a solution for 8242548. There was zero test coverage, so I added a > few tests for this as well. Marked as reviewed by aghaisas (Reviewer). - PR: https://git.openjdk.java.net/jfx/pull/173

Re: RFR: 8242548: Honor line spacing in Labeled reflow calculation

2020-04-23 Thread Ajit Ghaisas
On Wed, 22 Apr 2020 15:54:09 GMT, John Hendrikx wrote: >> modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/skin/Utils.java >> line 426: >> >>> 425: >>> 426: height += lineSpacing; >>> 427: >> >> Modifying 'height' parameter seems incorrect as this parameter is used

CONTRIBUTING.md suggestion

2020-04-23 Thread Jesper Skov
Hi again, I have an additional suggestion for CONTRIBUTING.md changes. In the Code Review section: If any changes are needed, you would push additional commits to the branch from which you made the pull request. Maybe add something to the effect that; These additional commits should have

Re: [Rev 01] RFR: 8198402: ToggleButton.setToggleGroup causes memory leak when button is removed via ToggleGroup.getToggles()

2020-04-23 Thread Jesper Skov
On Sun, 19 Apr 2020 13:50:18 GMT, Jesper Skov wrote: >> Uh, the exception is (as the comment note suggests) from using a prebuilt >> webkit. >> I will try a locally built one now. > > Ah, well. Ended with the same VM crash when building webkit myself. > > So I am kinda stuck. Suggestions? I