Re: RFR: 8244579: Windows "User Objects" leakage with WebView

2020-05-20 Thread Johan Vos
On Wed, 20 May 2020 19:17:28 GMT, Arun Joseph wrote: >> Is there a way to create a test? > > I think it will be difficult to write a test for this. While debugging, > RunLoop was mostly used by threads managing > heap. It can't be directly accessed via JavaScript. Also, this issue only > affect

Re: RFR: 8244579: Windows "User Objects" leakage with WebView

2020-05-20 Thread Arun Joseph
On Wed, 20 May 2020 15:16:11 GMT, Kevin Rushforth wrote: >> Cause: The Window Class `RunLoopMessageWindow` is never registered (this >> happens because >> registerRunLoopMessageWindowClass() is moved to MainThreadWin.cpp while >> openjfx uses MainThreadJava.cpp) and this >> causes every SetTime

Re: RFR: 8244579: Windows "User Objects" leakage with WebView

2020-05-20 Thread Kevin Rushforth
On Wed, 20 May 2020 14:30:11 GMT, Arun Joseph wrote: > Cause: The Window Class `RunLoopMessageWindow` is never registered (this > happens because > registerRunLoopMessageWindowClass() is moved to MainThreadWin.cpp while > openjfx uses MainThreadJava.cpp) and this > causes every SetTimer() call

RFR: 8244579: Windows "User Objects" leakage with WebView

2020-05-20 Thread Arun Joseph
Cause: The Window Class `RunLoopMessageWindow` is never registered (this happens because registerRunLoopMessageWindowClass() is moved to MainThreadWin.cpp while openjfx uses MainThreadJava.cpp) and this causes every setTimer() to create a new user object instead of reusing the same object over a

Re: Questions ad JavaScript in JavaFX' WebEngine

2020-05-20 Thread Rony G. Flatscher
Hi Mike, thank you for your pointers! On 14.05.2020 14:21, Mike Hearn wrote: > The WebKit binding code is some of the more complex code in JavaFX. Rather > than try to extend the > script tag you could instead look at the code for the tag and the > old support for > Netscape-style plugins.  >

Re: RFR: WIP: 8245282: ButtonBehavior: memory leak on dispose

2020-05-20 Thread Jeanette Winzenburg
On Wed, 20 May 2020 11:15:34 GMT, Jeanette Winzenburg wrote: > Reason for the memory leak is a listener on control's focusProperty that is > not correctly removed on dispose. For > details please see the report. > Added a test method to ButtonSkinTest that failed before and passes after the >

Re: [Integrated] RFR: 8245456: MacPasteboard throws ClassCastException on static builds

2020-05-20 Thread Jose Pereda
On Wed, 20 May 2020 11:47:29 GMT, Jose Pereda wrote: > Trying to paste on a JavaFX app statically built on Mac OS throws: > > Exception in thread "JavaFX Application Thread" java.lang.ClassCastException > at at > com.sun.glass.ui.mac.MacPasteboard._getUTFs(MacPasteboard.java) >

Re: RFR: 8245456: MacPasteboard throws ClassCastException on static builds

2020-05-20 Thread Kevin Rushforth
On Wed, 20 May 2020 11:47:29 GMT, Jose Pereda wrote: > Trying to paste on a JavaFX app statically built on Mac OS throws: > > Exception in thread "JavaFX Application Thread" java.lang.ClassCastException > at at > com.sun.glass.ui.mac.MacPasteboard._getUTFs(MacPasteboard.java) >

Re: RFR: 8245456: MacPasteboard throws ClassCastException on static builds

2020-05-20 Thread Kevin Rushforth
On Wed, 20 May 2020 11:47:29 GMT, Jose Pereda wrote: > Trying to paste on a JavaFX app statically built on Mac OS throws: > > Exception in thread "JavaFX Application Thread" java.lang.ClassCastException > at at > com.sun.glass.ui.mac.MacPasteboard._getUTFs(MacPasteboard.java) >

RFR: 8245456: MacPasteboard throws ClassCastException on static builds

2020-05-20 Thread Jose Pereda
Trying to paste on a JavaFX app statically built on Mac OS throws: Exception in thread "JavaFX Application Thread" java.lang.ClassCastException at at com.sun.glass.ui.mac.MacPasteboard._getUTFs(MacPasteboard.java) Checking the native method signature a `String[][]` type is expe

RFR: 8245457: [TestBug] Enable and fix ignored tests in ButtonBaseTest & ButtonTest

2020-05-20 Thread Ajit Ghaisas
Issue : https://bugs.openjdk.java.net/browse/JDK-8245457 Fix : It is a simple test fix. I have enabled the ignored tests from ButtonBaseTest & ButtonTest test classes & fixed them. Also removed a print to std.out. - Commit messages: - enable ignored unit tests Changes: https://git

RFR: 8245282: ButtonBehavior: memory leak on dispose

2020-05-20 Thread Jeanette Winzenburg
Reason for the memory leak is a listener on control's focusProperty that is not correctly removed on dispose. For details please see the report. Added a test method to ButtonSkinTest that failed before and passes after the fix. - Commit messages: - 8245282: ButtonBehavior: memory