Re: RFR: 8214699: Node.getPseudoClassStates must return the same instance on every call

On Thu, 18 Jun 2020 16:30:42 GMT, Ambarish Rapte wrote: > Node.getPseudoClassStates() returns a new UnmodifiableObservableSet of > PseudoClassState on each call. So in order to > listen to any changes in this set, user must call the method > Node.getPseudoClassStates() only once and keep a

Re: RFR: 8193800: TreeTableView selection changes on sorting [v5]

On Wed, 17 Jun 2020 12:28:41 GMT, Kevin Rushforth wrote: >> Ambarish Rapte has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Remove the un-required flag > > Marked as reviewed by kcr (Lead). Pending a second reviewer. @aghaisas or

Re: RFR: 8238080: FXMLLoader: if script engines implement javax.script.Compilable compile scripts [v3]

On Fri, 19 Jun 2020 15:49:43 GMT, Rony G. Flatscher wrote: > CSR-update: looks good! I have moved the CSR to the "proposed" state in preparation for formal review. - PR: https://git.openjdk.java.net/jfx/pull/192

Re: RFR: 8238080: FXMLLoader: if script engines implement javax.script.Compilable compile scripts [v3]

On Fri, 19 Jun 2020 15:49:36 GMT, Rony G. Flatscher wrote: >> modules/javafx.fxml/src/main/java/javafx/fxml/FXMLLoader.java line 1769: >> >>> 1768: try { >>> 1769: if (isCompiled) { >>> 1770:compiledScript.eval(localBindings); >> >> I think

Re: RFR: 8238080: FXMLLoader: if script engines implement javax.script.Compilable compile scripts [v3]

On Fri, 19 Jun 2020 00:04:37 GMT, Kevin Rushforth wrote: >> Rony G. Flatscher has updated the pull request with a new target base due to >> a merge or a rebase. The pull request now >> contains 27 commits: >> - Updates to meet Kevin's comment in PR 192 as of May 27th. >> - Merge

Re: RFR: 8238080: FXMLLoader: if script engines implement javax.script.Compilable compile scripts [v4]

> This PR adds a "compile" process instruction to FXML files with the optional > PI data "true" (default) and "false". The > PI data is turned into a boolean value using "Boolean.parseBoolean(String)". > This makes it possible to inject the compile PI everywhere in a FXML file and > turn on and

Re: backport requests for 11.0.8

+1 On 6/19/2020 7:32 AM, Johan Vos wrote: Hi Kevin, I request approval to backport the following fixes to OpenJFX 11 (11.0.8): JDK-8238249 : GetPrimitiveArrayCritical passed with hardcoded FALSE value JDK-8212034

backport requests for 11.0.8

Hi Kevin, I request approval to backport the following fixes to OpenJFX 11 (11.0.8): JDK-8238249 : GetPrimitiveArrayCritical passed with hardcoded FALSE value JDK-8212034 : Potential memory leaks

JavaFX HiDPI layout bugs

Hi, I've been doing some investigation into a layout bug in JavaFX on Windows with non-integer scaling values. I think it's related to JDK-8199592, and I've put a small example that will reproduce these layout bugs at the end of this email. The most obvious layout error is truncation of labels

Re: RFR: 8238954: Improve performance of tiled snapshot rendering [v12]

> Issue JDK-8088198, where an exception would be thrown when trying to capture > a snapshot whose final dimensions would be > larger than the running platform's maximum supported texture size, was > addressed in openjfx14. The fix, based around > the idea of capturing as many tiles of the

Re: OpenJFX: Follow HiDPI Scaling Settings in Fedora Workstation 32 (Gnome)

Dear Kevin, Dear Phil, thank you for your quick responses. I submitted a bug report (internal review ID: 9065523). Within the description I listed JDK-8137050 and additionally bug reports from Cryptomator which describe the issue also in Ubuntu 20.04 LTS and pop!OS. Kind regards and thanks,