On Mon, 29 Jun 2020 21:50:50 GMT, Kevin Rushforth wrote:
>> Frederic Thevenet has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fill test image with a bilinear gradient instead of random noise.
>
> I think I found the problem in the
On Mon, 29 Jun 2020 16:27:19 GMT, Frederic Thevenet
wrote:
>> Issue JDK-8088198, where an exception would be thrown when trying to capture
>> a snapshot whose final dimensions would be
>> larger than the running platform's maximum supported texture size, was
>> addressed in openjfx14. The
On Mon, 29 Jun 2020 16:41:53 GMT, Frederic Thevenet
wrote:
>> I have changed the test setup to fill up the scene with a gradient instead
>> of random noise; it should be as able to
>> catch misalignment, while not looking like something's gone horribly wrong.
>
> Also, while running the tests
The message from this sender included one or more files
which could not be scanned for virus detection; do not
open these files unless you are certain of the sender's intent.
--
On Mon, 29 Jun 2020 11:26:50 GMT, Johan Vos wrote:
On Mon, 29 Jun 2020 16:16:58 GMT, Frederic Thevenet
wrote:
>> Thanks for your review.
>>
>> I don't have access to a Mac so I can't check that directly.
>> The tests pass on both my Windows 10 and Ubuntu 20.04 environments and the
>> stack isn't very helpful (it simply
>> indicates the
On Mon, 29 Jun 2020 14:35:00 GMT, Frederic Thevenet
wrote:
>> I observed that the added tests are failing on mac machine(Mojave 10.14.6),
>> but they do pass on windows10. Can you
>> please verify ? Timeout and Unrecognized Image loader errors from the log,
>> test.javafx.scene.Snapshot2Test >
> Issue JDK-8088198, where an exception would be thrown when trying to capture
> a snapshot whose final dimensions would be
> larger than the running platform's maximum supported texture size, was
> addressed in openjfx14. The fix, based around
> the idea of capturing as many tiles of the
On Wed, 8 Apr 2020 08:37:27 GMT, Jose Pereda wrote:
> This PR comments out too verbose console logging, as it has been done with
> some other fprintf calls.
> As a follow up of this PR, a custom directive that enables this output if
> needed can be considered.
This pull request has now been
On Mon, 29 Jun 2020 14:02:11 GMT, Ambarish Rapte wrote:
>> I went ahead and wrote a bunch of tests that:
>> 1. Setup a scene to display an `ImageView` of a selected dimensions chosen
>> to trigger tiling in different ways when
>> taking snapshots. 2. Fill up the image with noise.
>> 3. Take a
On Wed, 17 Jun 2020 11:33:27 GMT, Frederic Thevenet
wrote:
>>> [...] I'd like to see some additional system tests that cover all of the
>>> cases of X and Y fitting/not-fitting exactly
>>> (and if you stick with your current approach, X or Y as the inner loop).
>>
>> What kind of tests do you
The message from this sender included one or more files
which could not be scanned for virus detection; do not
open these files unless you are certain of the sender's intent.
--
On Sun, 28 Jun 2020 18:34:01 GMT, Jose Pereda
Hi Ambarish,
Thanks for your review.
I don't have access to a Mac so I can't check that directly.
The tests pass on both my Windows 10 and Ubuntu 20.04 environments
and the stack isn't very helpful (it simply indicates the
renderImage method returned null).
There could be many reasons for
The message from this sender included one or more files
which could not be scanned for virus detection; do not
open these files unless you are certain of the sender's intent.
--
On Sun, 28 Jun 2020 01:56:26 GMT, John Neffenger
On Sat, 27 Jun 2020 00:12:41 GMT, John Neffenger
wrote:
> Fixes [JDK-8201570](https://bugs.openjdk.java.net/browse/JDK-8201570).
This fixes a bug that currently didn't cause any harm
(https://bugs.openjdk.java.net/browse/JDK-8201570?focusedCommentId=14172176) ,
but it's better to fix it now.
On Sat, 27 Jun 2020 00:21:06 GMT, John Neffenger
wrote:
> Fixes [JDK-8201568](https://bugs.openjdk.java.net/browse/JDK-8201568).
The rationale makes sense (open/open/close) instead of (open/close/open)
-
Marked as reviewed by jvos (Reviewer).
PR:
The message from this sender included one or more files
which could not be scanned for virus detection; do not
open these files unless you are certain of the sender's intent.
--
On Thu, 30 Apr 2020 18:56:40 GMT, Jesper Skov
16 matches
Mail list logo
