Re: RFR: 8254569: Remove hard dependency on Dispman in Monocle fb rendering [v6]

2020-11-05 Thread John Neffenger
On Thu, 5 Nov 2020 20:33:05 GMT, Kevin Rushforth wrote: >> Johan Vos has updated the pull request incrementally with one additional >> commit since the last revision: >> >> change invocation of getEGLDisplayHandle into getEglDisplayHandle >> Conditionally add dlfcn > > Marked as reviewed

Re: RFR: 8254569: Remove hard dependency on Dispman in Monocle fb rendering [v6]

2020-11-05 Thread Kevin Rushforth
On Thu, 5 Nov 2020 16:41:09 GMT, Johan Vos wrote: >> Allow the EGL functionality in monocle to leverage EGL-based systems. The >> low-level specific details about how the EGL calls should be constructed are >> left out, and a native interface (egl_ext.h) is created that can be mapped >> to

Re: RFR: 8254569: Remove hard dependency on Dispman in Monocle fb rendering [v6]

2020-11-05 Thread Johan Vos
On Thu, 5 Nov 2020 19:27:54 GMT, John Neffenger wrote: >> Marked as reviewed by jpereda (Committer). > > The fix for the compile-time error still fails for target *armv6hf*: > `MonocleGLFactory.c:110:19: error: ‘RTLD_DEFAULT’ undeclared (first use in > this function)`. Here's one solution: >

Re: RFR: 8254569: Remove hard dependency on Dispman in Monocle fb rendering [v6]

2020-11-05 Thread John Neffenger
On Thu, 5 Nov 2020 18:16:58 GMT, Jose Pereda wrote: >> Johan Vos has updated the pull request incrementally with one additional >> commit since the last revision: >> >> change invocation of getEGLDisplayHandle into getEglDisplayHandle >> Conditionally add dlfcn > > Marked as reviewed by

Re: RFR: 8254569: Remove hard dependency on Dispman in Monocle fb rendering [v6]

2020-11-05 Thread Jose Pereda
On Thu, 5 Nov 2020 16:41:09 GMT, Johan Vos wrote: >> Allow the EGL functionality in monocle to leverage EGL-based systems. The >> low-level specific details about how the EGL calls should be constructed are >> left out, and a native interface (egl_ext.h) is created that can be mapped >> to

Re: RFR: 8254569: Remove hard dependency on Dispman in Monocle fb rendering [v6]

2020-11-05 Thread Johan Vos
> Allow the EGL functionality in monocle to leverage EGL-based systems. The > low-level specific details about how the EGL calls should be constructed are > left out, and a native interface (egl_ext.h) is created that can be mapped to > any low-level system. Johan Vos has updated the pull

Re: RFR: 8242861: Update ImagePattern to apply SVG pattern transforms [v7]

2020-11-05 Thread Kevin Rushforth
On Wed, 4 Nov 2020 15:41:12 GMT, Arun Joseph wrote: >> modules/javafx.graphics/src/main/java/com/sun/prism/impl/ps/PaintHelper.java >> line 754: >> >>> 752: >>> 753: BaseTransform paintXform = paint.getPatternTransformNoClone(); >>> 754: if (paintXform != null) { >> >> Minor:

Re: RFR: 8254569: Remove hard dependency on Dispman in Monocle fb rendering [v5]

2020-11-05 Thread Kevin Rushforth
On Thu, 5 Nov 2020 13:38:08 GMT, Johan Vos wrote: >> Allow the EGL functionality in monocle to leverage EGL-based systems. The >> low-level specific details about how the EGL calls should be constructed are >> left out, and a native interface (egl_ext.h) is created that can be mapped >> to

Integrated: 8237491: [Linux] Undecorated stage cannot be maximized

2020-11-05 Thread Thiago Milczarek Sayao
On Mon, 2 Nov 2020 01:08:39 GMT, Thiago Milczarek Sayao wrote: > Simple fix to enable maximizing functionality on the window manager. > > Test provided > gradlew -PFULL_TEST=true -PUSE_ROBOT=true :systemTests:test --tests > test.javafx.stage.MaximizeUndecorated > > Fix for linux only. This

Re: RFR: 8237491: [Linux] Undecorated stage cannot be maximized [v2]

2020-11-05 Thread Kevin Rushforth
On Wed, 4 Nov 2020 01:12:02 GMT, Thiago Milczarek Sayao wrote: >> Simple fix to enable maximizing functionality on the window manager. >> >> Test provided >> gradlew -PFULL_TEST=true -PUSE_ROBOT=true :systemTests:test --tests >> test.javafx.stage.MaximizeUndecorated >> >> Fix for linux

Re: RFR: 8254569: Remove hard dependency on Dispman in Monocle fb rendering [v4]

2020-11-05 Thread Kevin Rushforth
On Thu, 5 Nov 2020 13:34:40 GMT, Johan Vos wrote: >> modules/javafx.graphics/src/main/java/com/sun/glass/ui/monocle/EGLAcceleratedScreen.java >> line 46: >> >>> 44: */ >>> 45: EGLAcceleratedScreen(int[] attributes) throws GLException { >>> 46: eglWindowHandle =

Re: RFR: 8254569: Remove hard dependency on Dispman in Monocle fb rendering [v4]

2020-11-05 Thread Johan Vos
On Thu, 5 Nov 2020 02:48:17 GMT, John Neffenger wrote: >> Johan Vos has updated the pull request incrementally with one additional >> commit since the last revision: >> >> add one more @override to process reviewer comments > >

Re: RFR: 8254569: Remove hard dependency on Dispman in Monocle fb rendering [v4]

2020-11-05 Thread Johan Vos
On Thu, 5 Nov 2020 02:45:00 GMT, John Neffenger wrote: >> Johan Vos has updated the pull request incrementally with one additional >> commit since the last revision: >> >> add one more @override to process reviewer comments > >

Re: RFR: 8254569: Remove hard dependency on Dispman in Monocle fb rendering [v5]

2020-11-05 Thread Johan Vos
> Allow the EGL functionality in monocle to leverage EGL-based systems. The > low-level specific details about how the EGL calls should be constructed are > left out, and a native interface (egl_ext.h) is created that can be mapped to > any low-level system. Johan Vos has updated the pull

Re: Request to backport issue to JavaFX 11

2020-11-05 Thread Kevin Rushforth
+1 This is a good one to get in. -- Kevin On 11/5/2020 5:23 AM, Johan Vos wrote: Hi Kevin, I ask permission to backport JDK-8237469 (Inherited styles don't update when node is moved) to JavaFX 11 (for 11.0.10). The patch applies clean. - Johan

Request to backport issue to JavaFX 11

2020-11-05 Thread Johan Vos
Hi Kevin, I ask permission to backport JDK-8237469 (Inherited styles don't update when node is moved) to JavaFX 11 (for 11.0.10). The patch applies clean. - Johan

Re: RFR: 8254569: Remove hard dependency on Dispman in Monocle fb rendering [v4]

2020-11-05 Thread Johan Vos
On Thu, 5 Nov 2020 02:44:01 GMT, John Neffenger wrote: >> Johan Vos has updated the pull request incrementally with one additional >> commit since the last revision: >> >> add one more @override to process reviewer comments > >