Re: RFR: 8260528: Clean glass-gtk sizing and positioning code

2021-03-20 Thread Thiago Milczarek Sayao
On Sat, 6 Mar 2021 23:53:06 GMT, Thiago Milczarek Sayao wrote: >> Changed to WIP while we run some more tests to make sure latest changes are >> ok. >> I'm fixing some residual "extra resize" issues (these issues exists on the >> current versions, so this makes it better, hopefully). > >

Re: Not really a nice comment but a real issue?

2021-03-20 Thread Tom Eugelink
And the reaction is interesting. I'll better leave it at that one comment. On 20-3-2021 20:10, Tom Eugelink wrote: I could not refrain from commenting on the tone of the blog, in line with what Johan often complains about. Apparently you guys are stronger than me. But I was polite and kept

Re: Not really a nice comment but a real issue?

2021-03-20 Thread Pedro Duque Vieira
Cool. Thanks Philip! On Sat, Mar 20, 2021 at 6:57 PM Philip Race wrote: > It was a P4 enhancement. I've made it a bug .. this or the new one should > be closed as a dup. > Normally I'd close the new one but not so clear here. I'll leave it to > Kevin to choose. > > -phil. > > On 3/20/21 11:54

Re: Not really a nice comment but a real issue?

2021-03-20 Thread Tom Eugelink
I could not refrain from commenting on the tone of the blog, in line with what Johan often complains about. Apparently you guys are stronger than me. But I was polite and kept it to myself. On 20-3-2021 19:57, Philip Race wrote: It was a P4 enhancement. I've made it a bug .. this or the new

Re: Not really a nice comment but a real issue?

2021-03-20 Thread Philip Race
It was a P4 enhancement. I've made it a bug .. this or the new one should be closed as a dup. Normally I'd close the new one but not so clear here. I'll leave it to Kevin to choose. -phil. On 3/20/21 11:54 AM, Philip Race wrote: Ah, I missed that. And with that, I've now found Gary's bug :

Re: Not really a nice comment but a real issue?

2021-03-20 Thread Philip Race
Ah, I missed that. And with that, I've now found Gary's bug : https://bugs.openjdk.java.net/browse/JDK-8239138 -phil. On 3/20/21 10:36 AM, Pedro Duque Vieira wrote: Hi Philip, Gary Bentley is the blog owner and author of the post. Scott Palmer is commenting on Gary Bentley's blog post. I

Re: Not really a nice comment but a real issue?

2021-03-20 Thread Michael Strauß
OpenJFX just doesn't feel like a community-driven project, in a large part because of how contributors are told to "report" an issue to Oracle. That's what you do as a customer, not as a contributor. Contributors want to discuss issues and share their findings, and a mailing list really is no

Re: Not really a nice comment but a real issue?

2021-03-20 Thread Pedro Duque Vieira
Hi Philip, Gary Bentley is the blog owner and author of the post. Scott Palmer is commenting on Gary Bentley's blog post. I was talking about Gary Bentley's comment to Scott Palmer's asking why he didn't file an issue. *Scott Palme*r: "*It’s Open Source… submit an issue and a pull request to at

Re: Not really a nice comment but a real issue?

2021-03-20 Thread Philip Race
Oracle has a very different mind set about privacy than Google or Facebook. It might be very hard to convince the powers that be to add a "please sell my personal information" checkbox .. -phil. On 3/20/21 8:16 AM, Abossolo Foh Guy wrote: I'm surprised credit is considered important ... .

Re: Not really a nice comment but a real issue?

2021-03-20 Thread Philip Race
Actually the way I read it, Scott Palmer added a comment with a link to the 2014 change that *introduced* the problem. No one is saying they reported this performance issue in 2014. -phil. On 3/20/21 7:37 AM, Pedro Duque Vieira wrote: Back to the discussion on why did the blog poster not raise

Integrated: 8263778: Fix monocle JNI signatures for instance methods

2021-03-20 Thread Johan Vos
On Sat, 20 Mar 2021 11:53:21 GMT, Johan Vos wrote: > Fix signatures (jclass/jobject), add UNUSED when unused > Fix for JDK-8263778 > > The monocle/egl native code now includes the javac generated header file > UNUSED() directives are used when a parameter is not used > jobject/jclass are used

Re: Not really a nice comment but a real issue?

2021-03-20 Thread Abossolo Foh Guy
I'm surprised credit is considered important ... . You're right, but for some of your external contributors it's a business model useful to communicate with their employers or patrons. I tried to explain it in a Twitter post but without success :) GitHub is like a vitrine where one can see

Re: Not really a nice comment but a real issue?

2021-03-20 Thread Pedro Duque Vieira
Back to the discussion on why did the blog poster not raise an issue for the problems he mentioned... Just FYI (in case you didn't see his recents comments), it appears he did. He says he did it in a recent comment on his blog post (yesterday):

Re: Re: Not really a nice comment but a real issue?

2021-03-20 Thread Eric Bresie
Just scanning the javafx ports/openjfx GitHub repository listed below, there appears to have been over 650 GitHub issues raised (and still growing). Some I see labeled as “bugs” but what about all the others? It looks that the port project has basically indicated moved to the official

Re: Consistent baseline layout algorithm

2021-03-20 Thread Michael Strauß
1) Pathological cases: So far, I haven't been able to produce pathological cases that exceed 3 layout passes by using standard layout containers and controls. If we need to have a threshold substantially higher than that depends on whether or not there are indeed legitimate cases where some kind

Re: RFR: 8239589: JavaFX UI will not repaint after reconnecting via Remote Desktop [v5]

2021-03-20 Thread Kevin Rushforth
> This is a fix for a long-standing bug where the D3D pipeline will stop > rendering when a Windows remote desktop session is disconnected and then > reconnected. > > A preliminary Draft PR #315 by @Schmidor was a good first step in solving > this. I took that and continued the work in my

Re: Building OpenJFX locally

2021-03-20 Thread Kevin Rushforth
This reminds me that after the fix for JDK-8255713 [1] it is no longer necessary (or recommended) to set the MSVC_VER env variable. I updated the Wiki to reflect that, and also to reflect that we now build using Visual Studio 2019 (although it will still work with VS 2017). -- Kevin [1]

Re: RFR: 8234920: Add SpotLight to the selection of 3D light types [v10]

2021-03-20 Thread Nir Lisker
> Added a SpotLight only to the D3D pipeline currently. > > ### API discussion points > > - [X] Added `SpotLight` as a subclass of `LightBase`. However, it could also > be a subclass of `PointLight` as it's a point light with direction and extra > factors. I saw that

Re: RFR: 8208088: Memory Leak in ControlAcceleratorSupport

2021-03-20 Thread Kevin Rushforth
On Thu, 18 Mar 2021 12:32:50 GMT, Ambarish Rapte wrote: >> Is there a unit test that can validate this fix? > >> Is there a unit test that can validate this fix? > > I have added a unit test using a new shim class. Test verifies size of the > map that is added as part of this fix. > So the

Re: RFR: 8239589: JavaFX UI will not repaint after reconnecting via Remote Desktop [v3]

2021-03-20 Thread Kevin Rushforth
On Fri, 19 Mar 2021 08:22:06 GMT, Ambarish Rapte wrote: >> Kevin Rushforth has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Minor typos + make verbose print less verbose > > The fix and Sanity testing looks all good. > I shall need some

Re: RFR: 8263778: Fix monocle JNI signatures for instance methods

2021-03-20 Thread Kevin Rushforth
On Sat, 20 Mar 2021 11:53:21 GMT, Johan Vos wrote: > Fix signatures (jclass/jobject), add UNUSED when unused > Fix for JDK-8263778 > > The monocle/egl native code now includes the javac generated header file > UNUSED() directives are used when a parameter is not used > jobject/jclass are used

RFR: 8263778: Fix monocle JNI signatures for instance methods

2021-03-20 Thread Johan Vos
Fix signatures (jclass/jobject), add UNUSED when unused Fix for JDK-8263778 The monocle/egl native code now includes the javac generated header file UNUSED() directives are used when a parameter is not used jobject/jclass are used when expected. - Commit messages: - Fix signatures