I noticed that my last commit used the address jgn...@openjdk.org
instead of the address I normally use to create and sign commits. GitHub
didn't recognize the commit as mine until I added the address to my account.
Do the openjdk.org addresses receive e-mail? If not, do we just leave
the
On Wed, 24 Mar 2021 12:09:27 GMT, Kevin Rushforth wrote:
>> The convertNSStringToJString function convert NSString to Java String using
>> NewStringUTF，NewStringUTF accept modified-UTF8 encoded str。This fix using
>> UTF-16 encoding for converting.
>
> I'll review this. The fix seems fine at
On Wed, 24 Mar 2021 23:39:21 GMT, Kevin Rushforth wrote:
> You might retry the "contributor" command with the `@` before their GitHub
> username.
Thanks. I'll try that now. I checked and Bernhard is on the list of "OCAs
submitted prior to 2021," but not on the OpenJDK Census list, in case
On Thu, 25 Mar 2021 00:54:33 GMT, Nir Lisker wrote:
>>> I would like to allow a developer to achieve a functionality like is shown
>>> in https://www.youtube.com/watch?v=CFgwZX5dkcM at 9:50. The rotations are
>>> intuitive there. If we allow both rotation transforms and a direction,
>>>
> Added a SpotLight only to the D3D pipeline currently.
>
> ### API discussion points
>
> - [X] Added `SpotLight` as a subclass of `LightBase`. However, it could also
> be a subclass of `PointLight` as it's a point light with direction and extra
> factors. I saw that
On Mon, 22 Mar 2021 23:55:34 GMT, Kevin Rushforth wrote:
> I the rotation needs to apply to whatever the direction vector is: whether
> that's implicitly (0,0,1) if we don't provide a separate direction vector or
> whether it's the user provided direction vector, it would be odd to ignore
>
On Tue, 23 Feb 2021 12:06:08 GMT, Jeanette Winzenburg
wrote:
>> Changes in Lambda..Handler:
>> - added api and implemenation to support invalidation and listChange
>> listeners in the same way as changeListeners
>> - added java doc
>> - added tests
>>
>> Changes in SkinBase
>> - added api
On Tue, 9 Mar 2021 22:20:10 GMT, John Neffenger wrote:
> This is a continuation of the [pull request][1] started by @bmwiedemann in
> January 2020. After this change is integrated, I can follow up immediately
> with additional pull requests that get us much closer to providing fully
>
On Tue, 23 Mar 2021 15:18:06 GMT, Kevin Rushforth wrote:
>> wondering about the sequence of next steps: should I create the csr before
>> or after (partial) review of this? Doing before feels like expecting
>> duplicate work (whenever doc changes are required, I'll have to change the
>> code
On Wed, 24 Mar 2021 18:17:59 GMT, Martin Fox
wrote:
>> The Function/arrow/number pad keys are handled using a hard-coded table
>> since they don’t vary based on keyboard layout. Beyond that you’re asking
>> exactly the right question.
>>
>> JavaFX KeyCodes seem to be modeled on similar
I just wanted to draw some attention to a recent proof of concept I made
in this pull request: https://github.com/openjdk/jfx/pull/434
It is based on the work I did in
https://github.com/hjohn/hs.jfx.eventstream which is in part based on
work done in ReactFX by Tomas Mikula. The PR itself
On Wed, 24 Mar 2021 21:06:08 GMT, John Neffenger wrote:
>> Thanks for providing / updating the instructions.
>>
>> My internal test build failed right off the bat, since we have a
>> supplemental closed gradle file that augments the build and downloads
>> additional build tools for our
On Wed, 24 Mar 2021 19:55:20 GMT, Kevin Rushforth wrote:
> I don't yet know to handle this ...
Would any of the following options work?
1. If you're using your own supplemental closed Gradle build file, create your
own supplemental closed Gradle verification file, too. Before the internal
> Added a SpotLight only to the D3D pipeline currently.
>
> ### API discussion points
>
> - [X] Added `SpotLight` as a subclass of `LightBase`. However, it could also
> be a subclass of `PointLight` as it's a point light with direction and extra
> factors. I saw that
On Wed, 24 Mar 2021 19:50:11 GMT, John Neffenger wrote:
>> This seems like a good idea to do. I have a couple overall questions before
>> reviewing / testing.
>>
>> 1. Can you add some sort of README file that describes the how to update the
>> checksums? Also, the instructions in
>>
On Tue, 23 Mar 2021 12:07:48 GMT, Kevin Rushforth wrote:
>> This pull request adds dependency verification to the Gradle builds of
>> JavaFX on Linux, macOS, and Windows. It is the third of three changes that
>> close the gaps in the JavaFX build security:
>>
>> * [JDK-8262236][1]: Configure
Please ignore this, as Jose Pereda is already a Committer in the OpenJFX
Project. I resent the results email with the correct subject line.
-- Kevin
[corrected subject line]
Voting for John Neffenger [1] to OpenJFX Committer [2] is now closed.
Yes: 7
Veto: 0
Abstain: 0
According to the Bylaws definition of Lazy Consensus, this is sufficient
to approve the nomination.
-- Kevin
[1] https://openjdk.java.net/census#jgneff
[2]
Voting for John Neffenger [1] to OpenJFX Committer [2] is now closed.
Yes: 7
Veto: 0
Abstain: 0
According to the Bylaws definition of Lazy Consensus, this is sufficient
to approve the nomination.
-- Kevin
[1] https://openjdk.java.net/census#jgneff
[2]
> This pull request adds dependency verification to the Gradle builds of JavaFX
> on Linux, macOS, and Windows. It is the third of three changes that close the
> gaps in the JavaFX build security:
>
> * [JDK-8262236][1]: Configure Gradle checksum verification
> * [JDK-8263204][2]: Add Gradle
I've done a quick test and it looks good to me, however I'm still on macOS
10.15.6.
I've tried a virtual keyboard with both Spanish and with Chinese input, and
I could verify that the change produces the same jStr result as before.
However I'm not sure if I can try those extended emoji
On Tue, 16 Mar 2021 19:48:56 GMT, Martin Fox
wrote:
>> Maybe this is a very dumb idea but why are we not using the char to map back
>> to the keycode? At least for everything in the ASCII-Range this would be ok
>> not? We'd only have to check for special keys (like NUM-Keys, F-Keys, ...)
>>
On Tue, 23 Mar 2021 14:30:56 GMT, Ambarish Rapte wrote:
>> The method `ControlAcceleratorSupport.doAcceleratorInstall(final List> extends MenuItem> items, final Scene scene)` adds a `ChangeListener` on
>> `MenuItem.acceleratorProperty()`. This listener is not removed when the
>> MenuItem is
Fixing ListCell editing status is true, when index changes while editing.
-
Commit messages:
- 8264127:
Changes: https://git.openjdk.java.net/jfx/pull/441/files
Webrev: https://webrevs.openjdk.java.net/?repo=jfx=441=00
Issue: https://bugs.openjdk.java.net/browse/JDK-8264127
If the macOS system settings for opening documents as tabs is set to "Always",
then all JavaFX windows, including Dialogs, are opened as tabs, unless they are
child windows (that is, a Window with an owner).
This is a real problem for certain types of dialogs, such as
`APPLICATION_MODAL`
On Sun, 21 Mar 2021 00:31:35 GMT, Thiago Milczarek Sayao
wrote:
>> Looks good now.
>
> Testing:
>
> **master**
> 
>
> **tsayao:glass_gtk_new_position_and_size**
>
On Sun, 21 Mar 2021 04:13:48 GMT, Hsiafan
wrote:
> The convertNSStringToJString function convert NSString to Java String using
> NewStringUTF，NewStringUTF accept modified-UTF8 encoded str。This fix using
> UTF-16 encoding for converting.
I'll review this. The fix seems fine at first glance.
Hi,
I'm currently adding a software-cursor on top of hardware rendering (in
case no hardware or OS-provided cursor is available).
On all desktop platforms (and on Monocle with X11), we use the cursor
provided by the window manager. In case there is no window manager, Monocle
can use a software
28 matches
Mail list logo
