On Mon, 5 Apr 2021 18:14:36 GMT, Arun Joseph wrote:
> We currently use ICU4C version 64.2. We should update to the latest stable
> version 68.2.
> http://site.icu-project.org/home
I did a review of all change not in the ThirdParty/icu. All looks good to me.
There is one more instance of the ha
On 07/04/2021 03:41, Nir Lisker wrote:
In the PoC I made I specifically also disallowed 'null' as an input
I like the way ReactFX does it where the property is empty. I think that
this is also what you mean by disallowing `null` (in other contexts,
"disallowing null" would mean throwing an
On Tue, 6 Apr 2021 12:24:36 GMT, Florian Kirmaier wrote:
>> Fixing leak in ProgressIndicator when treeShowing is false
>
> Florian Kirmaier has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8264677
> changes based on code review
Suggested
On Mon, 5 Apr 2021 18:14:36 GMT, Arun Joseph wrote:
> We currently use ICU4C version 64.2. We should update to the latest stable
> version 68.2.
> http://site.icu-project.org/home
build.gradle line 1914:
> 1912: }
> 1913: patternLayout {
> 1914:
On Wed, 7 Apr 2021 13:10:29 GMT, Kevin Rushforth wrote:
>> Florian Kirmaier has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8263402
>> Minor cleanup based on codereview
>
> modules/javafx.graphics/src/main/java/javafx/scene/CssStyleHel
On Fri, 26 Mar 2021 12:02:40 GMT, Florian Kirmaier
wrote:
>> Fixing a memory leak.
>> A node hard references its old parent after CSS layout and getting removed.
>> This shouldn't be the case, this is very counterintuitive.
>>
>> The fix uses a WeakReference in CSSStyleHelper for firstStyleab
On Mon, 5 Apr 2021 19:09:19 GMT, Kevin Rushforth wrote:
>> We currently use ICU4C version 64.2. We should update to the latest stable
>> version 68.2.
>> http://site.icu-project.org/home
>
> Overall this looks good. I'll review / test it in detail later.
>
> Quick comments on the PR:
>
> 1. Yo
On Mon, 5 Apr 2021 18:14:36 GMT, Arun Joseph wrote:
> We currently use ICU4C version 64.2. We should update to the latest stable
> version 68.2.
> http://site.icu-project.org/home
Overall this looks good. I'll review / test it in detail later.
Quick comments on the PR:
1. You need to update t
We currently use ICU4C version 64.2. We should update to the latest stable
version 68.2.
http://site.icu-project.org/home
-
Commit messages:
- Add UPDATING.txt file
- Update license
- Modify exec files
- Add icudt68l repo
- Remove icudt file
- 8260245: Update ICU4C to version 6
On Wed, 7 Apr 2021 11:06:53 GMT, Jeanette Winzenburg
wrote:
>> Changes in Lambda..Handler:
>> - added api and implemenation to support invalidation and listChange
>> listeners in the same way as changeListeners
>> - added java doc
>> - added tests
>>
>> Changes in SkinBase
>> - added api (and
On Mon, 5 Apr 2021 18:59:52 GMT, Jose Pereda wrote:
> This PR filters out `GDK_TOUCH_EVENT_MASK` from `GDK_ALL_EVENTS_MASK` to
> prevent touch events from being used instead of regular mouse events on Linux
> platforms. Note that the touch events will be delivered as mouse
> pressed/dragged ev
On Mon, 5 Apr 2021 18:59:52 GMT, Jose Pereda wrote:
> This PR filters out `GDK_TOUCH_EVENT_MASK` from `GDK_ALL_EVENTS_MASK` to
> prevent touch events from being used instead of regular mouse events on Linux
> platforms. Note that the touch events will be delivered as mouse
> pressed/dragged ev
On Mon, 5 Apr 2021 18:59:52 GMT, Jose Pereda wrote:
> This PR filters out `GDK_TOUCH_EVENT_MASK` from `GDK_ALL_EVENTS_MASK` to
> prevent touch events from being used instead of regular mouse events on Linux
> platforms. Note that the touch events will be delivered as mouse
> pressed/dragged ev
On Tue, 6 Apr 2021 12:35:02 GMT, Florian Kirmaier wrote:
>> @FlorianKirmaier The CSR needs to be updated (fixVersion set to `openjfx17`)
>> and moved to Finalize again.
>
> The fixVersion is now openfjx17 and it's moved to "Finalized"
Looks like the Skara bot is in a loop continually reprocessi
On Fri, 26 Mar 2021 12:02:40 GMT, Florian Kirmaier
wrote:
>> Fixing a memory leak.
>> A node hard references its old parent after CSS layout and getting removed.
>> This shouldn't be the case, this is very counterintuitive.
>>
>> The fix uses a WeakReference in CSSStyleHelper for firstStyleab
On Tue, 9 Mar 2021 21:49:36 GMT, Florian Kirmaier wrote:
> Fixing deadlock when calling Application.launch in the FXThread after
> Platform.startup
This pull request has now been integrated.
Changeset: 9796a83f
Author:Florian Kirmaier
Committer: Kevin Rushforth
URL: https://git.ope
On Wed, 7 Apr 2021 08:08:40 GMT, Johan Vos wrote:
>> If anyone would implement touch events, the change would need to be rolled
>> back?
>>
>> If you catch and consume touch events, would it also work?
>>
>> I mean on `GlassApplication.cpp` -> `process_events`:
>>
>> case GDK_TOUCH_BEGIN:
>>
> Changes in Lambda..Handler:
> - added api and implemenation to support invalidation and listChange
> listeners in the same way as changeListeners
> - added java doc
> - added tests
>
> Changes in SkinBase
> - added api (and implementation delegating to the handler)
> - copied java doc from the
Hi,
I'm not sure where to report this but it looks like the javafx-swt.jar
is not deployed on maven central. Is there a reason?
Tom
On Tue, 6 Apr 2021 23:32:53 GMT, Thiago Milczarek Sayao
wrote:
> If anyone would implement touch events, the change would need to be rolled
> back?
Yes, *if* touch events would be implemented properly at a native level, this
change will need to be rolled back. This can be a follow-up issue, b
20 matches
Mail list logo
