This PR fixes the implementation of `ControlUtils.reducingChange`, which
incorrectly computed adjacent removed indices, thus resulting in incorrect
removal notifications.
Since there were no unit tests for this method, I also added a bunch of tests.
After applying this fix, I can no longer
On Thu, 4 Mar 2021 06:41:53 GMT, Arun Joseph wrote:
> Fixing the Debug build of WebKit.
>
> Test: Build JavaFX using `-PCOMPILE_WEBKIT=true -PCONF=DebugNative` and test
> using a simple HelloWebView app.
This pull request has now been integrated.
Changeset: ed080c82
Author:Arun Joseph
Remote Desktop will change default audio device when connecting or
disconnecting to it's own audio device. Also, when remote desktop is
disconnect, then remote desktop default audio device is removed and system
default device is not restored until user logs back to computer. So, after
remote
On Mon, 1 Feb 2021 23:12:08 GMT, Jonathan Vusich
wrote:
>> As noted in the corresponding JBS issue, `Axis` does not properly compute
>> its preferred height when `autoRanging` is turned off. The simplest fix
>> seems to be changing `CategoryAxis` so that `tickLabelRotation` is set to 90
>>
On Tue, 20 Apr 2021 20:03:28 GMT, Arun Joseph wrote:
>> Fixing the Debug build of WebKit.
>>
>> Test: Build JavaFX using `-PCOMPILE_WEBKIT=true -PCONF=DebugNative` and test
>> using a simple HelloWebView app.
>
> Arun Joseph has updated the pull request with a new target base due to a
> merge
On Thu, 22 Apr 2021 11:44:41 GMT, Jeanette Winzenburg
wrote:
>> Florian Kirmaier has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8264127:
>> Fixed another index case based on code review
>
>
> Fixing ListCell editing status is true, when index changes while editing.
Florian Kirmaier has updated the pull request incrementally with one additional
commit since the last revision:
8264127:
Added missing test case
-
Changes:
- all:
On Fri, 23 Apr 2021 16:57:54 GMT, Florian Kirmaier
wrote:
>> Fixing ListCell editing status is true, when index changes while editing.
>
> Florian Kirmaier has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8264127:
> More changes based on
On Thu, 22 Apr 2021 11:58:33 GMT, Jeanette Winzenburg
wrote:
>> Florian Kirmaier has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8264127:
>> Fixed another index case based on code review
>
>
> Fixing ListCell editing status is true, when index changes while editing.
Florian Kirmaier has updated the pull request incrementally with one additional
commit since the last revision:
8264127:
More changes based on codereview.
Simplified the tests, we are now using for both cases
On Fri, 23 Apr 2021 16:25:48 GMT, Florian Kirmaier
wrote:
>> Fixing leak in ProgressIndicator when treeShowing is false
>
> Florian Kirmaier has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8264677
> Readded countdownlatch for onShown
> Fixing leak in ProgressIndicator when treeShowing is false
Florian Kirmaier has updated the pull request incrementally with one additional
commit since the last revision:
8264677
Readded countdownlatch for onShown based on code review
-
Changes:
- all:
On Thu, 22 Apr 2021 23:25:23 GMT, Kevin Rushforth wrote:
>> That's a good question.
>> OnShown is usually called in about 1 Frame.
>> The memory-leak test takes some times, usually longer as 1 Frame.
>> In the current configuration, it takes up to 1 seconds, with up to 10 checks.
>> Because the
On Fri, 23 Apr 2021 11:40:00 GMT, Johan Vos wrote:
>> thanks for the explanation and spelling it out to me :)
>>
>>> But my question is about the pre- and postconditions. What would happen if
>>> a subclass overrides `cancelEdit` and throws an exception, so that
>>> `updateEditingIndex =
> Issue is missing update of Tree-/TableCell's editiable state when changing
> its index from editingIndex to -1.
>
> Seems to be a left-over from fixing cell's editing update - done in
> [JDK-8150525](https://bugs.openjdk.java.net/browse/JDK-8150525) - on index
> change for the special case
On Tue, 20 Apr 2021 11:06:32 GMT, Jeanette Winzenburg
wrote:
> Issue is usage of JMemoryBuddy in module graphics (SceneTest, added in
> [JDK-8264330](https://bugs.openjdk.java.net/browse/JDK-8264330).
>
> Fix is to add-exports in Eclipse .classpath in graphics (same as done for
> controls
On Fri, 23 Apr 2021 13:48:16 GMT, Ajit Ghaisas wrote:
> The change as such is fine, but, I have two questions at a higher level -
Thanks. The answers are higher level as well, as they are more about the
expectations of updateItem()
>
> > (from JBS description) - "This will lead to a call to
On Thu, 22 Apr 2021 10:36:40 GMT, Ajit Ghaisas wrote:
> This PR fixes controls unit test failures that are observed with German
> locale.
>
> Fix :
> Code added to use US locale while running SpinnerTest and DatePicker test &
> restore locale to default after these tests are executed.
>
>
On Wed, 21 Apr 2021 13:45:57 GMT, Johan Vos wrote:
> Hide accumCell when the cell is released.
> Fix for JDK-8265669
The change as such is fine, but, I have two questions at a higher level -
> (from JBS description) - "This will lead to a call to Cell.updateItem(). That
> was already
On Tue, 20 Apr 2021 11:06:32 GMT, Jeanette Winzenburg
wrote:
> Issue is usage of JMemoryBuddy in module graphics (SceneTest, added in
> [JDK-8264330](https://bugs.openjdk.java.net/browse/JDK-8264330).
>
> Fix is to add-exports in Eclipse .classpath in graphics (same as done for
> controls
On Thu, 15 Apr 2021 02:21:50 GMT, Nir Lisker wrote:
>> Added a SpotLight only to the D3D pipeline currently.
>>
>> ### API discussion points
>>
>> - [X] Added `SpotLight` as a subclass of `LightBase`. However, it could
>> also be a subclass of `PointLight` as it's a point light with
On Tue, 20 Apr 2021 20:03:28 GMT, Arun Joseph wrote:
>> Fixing the Debug build of WebKit.
>>
>> Test: Build JavaFX using `-PCOMPILE_WEBKIT=true -PCONF=DebugNative` and test
>> using a simple HelloWebView app.
>
> Arun Joseph has updated the pull request with a new target base due to a
> merge
On Mon, 19 Apr 2021 19:57:50 GMT, Johan Vos wrote:
> Changes that allow to build linux configuration on Linux AArch64
> This PR introduces an `IS_AARCH64` parameter in build.gradle.
> This PR already contains the change from PR #465 so if this one gets
> integrated, that change needs to removed
On Fri, 23 Apr 2021 09:04:47 GMT, Johan Vos wrote:
>> Changes that allow to build linux configuration on Linux AArch64
>> This PR introduces an `IS_AARCH64` parameter in build.gradle.
>> This PR already contains the change from PR #465 so if this one gets
>> integrated, that change needs to
On Fri, 23 Apr 2021 08:47:49 GMT, Johan Vos wrote:
>> build.gradle line 2865:
>>
>>> 2863: "OUTPUT_DIR=${nativeOutputDir}",
>>> "BUILD_TYPE=${buildType}", "BASE_NAME=jfxmedia",
>>> 2864: "COMPILE_PARFAIT=${compileParfait}",
>>> 2865:
On Fri, 23 Apr 2021 09:04:47 GMT, Johan Vos wrote:
>> Changes that allow to build linux configuration on Linux AArch64
>> This PR introduces an `IS_AARCH64` parameter in build.gradle.
>> This PR already contains the change from PR #465 so if this one gets
>> integrated, that change needs to
On Fri, 23 Apr 2021 06:22:13 GMT, Arun Joseph wrote:
>> Johan Vos has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> remove classifier as per reviewer comment
>
> build.gradle line 3465:
>
>> 3463: def webkitProperties =
On Thu, 22 Apr 2021 10:40:15 GMT, Jeanette Winzenburg
wrote:
>> I see the updateEditingIndex is used as a hacky flag as the comment says,
>> and `table.edit(-1, null)` is called conditionally.
>> But my question is about the pre- and postconditions. What would happen if a
>> subclass
On Fri, 23 Apr 2021 04:58:46 GMT, mstr2
wrote:
>> The documentation for `ObservableListBase.nextRemove` states that a single
>> change always refers to the current state of the list, which likely means
>> that multiple disjoint removed ranges need to be applied in order, otherwise
>> the
> Changes that allow to build linux configuration on Linux AArch64
> This PR introduces an `IS_AARCH64` parameter in build.gradle.
> This PR already contains the change from PR #465 so if this one gets
> integrated, that change needs to removed from this PR.
Johan Vos has updated the pull
On Thu, 22 Apr 2021 20:07:40 GMT, Kevin Rushforth wrote:
>> Changes that allow to build linux configuration on Linux AArch64
>> This PR introduces an `IS_AARCH64` parameter in build.gradle.
>> This PR already contains the change from PR #465 so if this one gets
>> integrated, that change needs
On Thu, 22 Apr 2021 16:45:15 GMT, Kevin Rushforth wrote:
> This looks good. Saving and restoring global state in this manner represents
> a best practice. Two questions:
>
> 1. In the description you said that
> `test.javafx.scene.control.ControlTest.testRT18097` fails without your fix
>
On Mon, 19 Apr 2021 19:57:50 GMT, Johan Vos wrote:
> Changes that allow to build linux configuration on Linux AArch64
> This PR introduces an `IS_AARCH64` parameter in build.gradle.
> This PR already contains the change from PR #465 so if this one gets
> integrated, that change needs to removed
33 matches
Mail list logo
