Re: RFR: 8265206: Tree-/TableCell: editing state not updated on cell re-use [v2]

2021-04-28 Thread Johan Vos
On Fri, 23 Apr 2021 15:31:52 GMT, Jeanette Winzenburg wrote: >> Issue is missing update of Tree-/TableCell's editiable state when changing >> its index from editingIndex to -1. >> >> Seems to be a left-over from fixing cell's editing update - done in >> [JDK-8150525](https://bugs.openjdk.jav

Re: RFR: 8265206: Tree-/TableCell: editing state not updated on cell re-use [v2]

2021-04-28 Thread Ajit Ghaisas
On Fri, 23 Apr 2021 15:31:52 GMT, Jeanette Winzenburg wrote: >> Issue is missing update of Tree-/TableCell's editiable state when changing >> its index from editingIndex to -1. >> >> Seems to be a left-over from fixing cell's editing update - done in >> [JDK-8150525](https://bugs.openjdk.jav

Integrated: 8264737: JavaFX media stream stops playing after reconnecting via Remote Desktop

2021-04-28 Thread Alexander Matveev
On Sat, 24 Apr 2021 02:23:19 GMT, Alexander Matveev wrote: > Remote Desktop will change default audio device when connecting or > disconnecting to it's own audio device. Also, when remote desktop is > disconnect, then remote desktop default audio device is removed and system > default device

Re: RFR: 8264737: JavaFX media stream stops playing after reconnecting via Remote Desktop [v2]

2021-04-28 Thread Alexander Matveev
On Wed, 28 Apr 2021 19:02:41 GMT, Ambarish Rapte wrote: >> Alexander Matveev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8264737: JavaFX media stream stops playing after reconnecting via Remote >> Desktop [v2] > > The change fixes t

RFR: 8186904: TableColumnHeader: resize cursor lost on right click

2021-04-28 Thread Marius Hanl
This PR is fixing a bug, when a right click on a table column is performed. By doing that, the table columns will lose the resize cursor thus they can not be resized anymore. The reason for that is that the **columnDragLock** will not reset (to false). This flag is set to true, when a mouse pres

Re: JavaFX 11 updates moving to GitHub on Wed, Apr 28

2021-04-28 Thread Kevin Rushforth
This transition is now complete. The jfx11u repo on GitHub is now active, and the openjfx/11-dev/rt Mercurial repo is now read-only. -- Kevin On 4/21/2021 3:15 PM, Kevin Rushforth wrote: The JavaFX 11 updates repo is moving from HG to GIT on Wednesday, April 28, and will be hosted on GitHub i

Re: RFR: 8264737: JavaFX media stream stops playing after reconnecting via Remote Desktop [v2]

2021-04-28 Thread Ambarish Rapte
On Tue, 27 Apr 2021 02:09:54 GMT, Alexander Matveev wrote: >> Remote Desktop will change default audio device when connecting or >> disconnecting to it's own audio device. Also, when remote desktop is >> disconnect, then remote desktop default audio device is removed and system >> default dev

Re: Support :focus-visible CSS pseudoclass

2021-04-28 Thread Michael Strauß
It's certainly true that all JavaFX themes show a focus indicator for all controls, but that's not universally so. For example, Microsoft's Fluent theme doesn't show any focus indicators on mouse-based interaction except for text controls. In the end, the official CSS spec has named this pseudocla

Re: JavaFX 16 requires Visual C++ 2019 Redistributable on Windows?

2021-04-28 Thread thevenet . fred
Hi Kevin, Thanks for shedding some light on this. I looked into javafx-graphics-16-win.jar and I can see that vcruntime140.dll and vcruntime140_1.dll are indeed both present. It is not the case however in javafx.graphics.jmod (or any of the jmod files) that are used with jlink, so I suppose th

Re: Support :focus-visible CSS pseudoclass

2021-04-28 Thread Tom Schindl
Hi, As someone who had to implement this manually in our current project I would welcome if it would have been possible to use a pseudo-state to get a CSS only solution. What I don't know if the name of the pseudo-State is correct :focus-visible does not sound right to me because controls st

Re: RFR: 8265400: Update to gcc 10.3 on Linux

2021-04-28 Thread Ambarish Rapte
On Tue, 27 Apr 2021 21:30:25 GMT, Kevin Rushforth wrote: > This patch updates the compiler to gcc 10.3 on Linux, in order to match JDK > 17 -- see [JDK-8265373](https://bugs.openjdk.java.net/browse/JDK-8265373). > > I ran a full build and test, including media and WebKit. Marked as reviewed by

Re: Support :focus-visible CSS pseudoclass

2021-04-28 Thread Michael Strauß
Circling back to this proposal: does anyone want to comment on it?

Re: RFR: 8189354: ArrayIndexOutOfBoundsException when listening to selection changes on TreeTableView [v4]

2021-04-28 Thread mstr2
On Wed, 28 Apr 2021 10:50:29 GMT, Jeanette Winzenburg wrote: > Hmm .. doesn't seem to be throwing since fx9 as of Ajit's first comment, in > fact can't reproduce it with current fx16dev, neither with nor without this PR You're right, somehow I was under the impression it did throw. Maybe I cou

Re: JavaFX 16 requires Visual C++ 2019 Redistributable on Windows?

2021-04-28 Thread Kevin Rushforth
Yes, JavaFX 16 uses VS 2019, but those libraries should be distributed as part of the JavaFX 16 bundle. It's possible we have a bug in NaativeLibLoader where they are not getting loaded. -- Kevin On 4/28/2021 6:46 AM, thevenet.f...@free.fr wrote: Hi, I am facing an issue where, after updati

JavaFX 16 requires Visual C++ 2019 Redistributable on Windows?

2021-04-28 Thread thevenet . fred
Hi, I am facing an issue where, after updating to JFX 16, an application fail to start on Windows machines where the MS Visual C++ 2019 redistributable libraries are not installed, with the following exception: java.lang.RuntimeException: java.lang.UnsatisfiedLinkError: C:\binjr-3.0.2-SNAPS

Integrated: 8258777: SkinBase: add api to un-/register invalidation-/listChange listeners

2021-04-28 Thread Jeanette Winzenburg
On Mon, 22 Feb 2021 14:58:45 GMT, Jeanette Winzenburg wrote: > Changes in Lambda..Handler: > - added api and implemenation to support invalidation and listChange > listeners in the same way as changeListeners > - added java doc > - added tests > > Changes in SkinBase > - added api (and implem

Re: RFR: 8189354: ArrayIndexOutOfBoundsException when listening to selection changes on TreeTableView [v4]

2021-04-28 Thread Jeanette Winzenburg
On Wed, 28 Apr 2021 10:50:29 GMT, Jeanette Winzenburg wrote: > There is one more issue mentioned (2nd comment by OP): toggling selection > throws an NPE - that's still the case, both with and without this PR. *hach .. that's fixed by the most recent change in MultipleSelectionModelBase (wasn'

Re: RFR: 8265399: Update to Visual Studio 2019 version 16.9.3

2021-04-28 Thread Ambarish Rapte
On Tue, 27 Apr 2021 21:33:25 GMT, Kevin Rushforth wrote: > This patch updates the compiler to Visual Studio 2019 version 16.9.3 on > Windows, in order to match JDK 17 -- see > [JDK-8265371](https://bugs.openjdk.java.net/browse/JDK-8265371). > > I ran a full build and test, including media and

Re: RFR: 8258777: SkinBase: add api to un-/register invalidation-/listChange listeners [v10]

2021-04-28 Thread Ambarish Rapte
On Sat, 17 Apr 2021 13:48:23 GMT, Jeanette Winzenburg wrote: >> Changes in Lambda..Handler: >> - added api and implemenation to support invalidation and listChange >> listeners in the same way as changeListeners >> - added java doc >> - added tests >> >> Changes in SkinBase >> - added api (an

Re: RFR: 8189354: ArrayIndexOutOfBoundsException when listening to selection changes on TreeTableView [v8]

2021-04-28 Thread Jeanette Winzenburg
On Tue, 27 Apr 2021 19:18:59 GMT, mstr2 wrote: >> This PR fixes the implementation of `ControlUtils.reducingChange`, which >> incorrectly computed adjacent removed indices, thus resulting in incorrect >> removal notifications. >> >> Since there were no unit tests for this method, I also added

Re: RFR: 8189354: ArrayIndexOutOfBoundsException when listening to selection changes on TreeTableView [v3]

2021-04-28 Thread Jeanette Winzenburg
On Tue, 27 Apr 2021 16:30:52 GMT, mstr2 wrote: > I think you're right that the same test could also be added for > TreeTableView, and that the test should probably cover the entirety of the > change notification. However, my preference is to not create a test that > duplicates all aspects of

Re: RFR: 8189354: ArrayIndexOutOfBoundsException when listening to selection changes on TreeTableView [v3]

2021-04-28 Thread Jeanette Winzenburg
On Tue, 27 Apr 2021 19:10:29 GMT, mstr2 wrote: > > The only very minor drawback is that it requires to update the Eclipse > > classpath to add-exports for the base testing package (not a big deal). > > Can you share where specifically this needs to be added? Could do, but if you aren't using

Re: RFR: 8189354: ArrayIndexOutOfBoundsException when listening to selection changes on TreeTableView [v4]

2021-04-28 Thread Jeanette Winzenburg
On Tue, 27 Apr 2021 16:20:27 GMT, mstr2 wrote: > This JBS issue lists the following issues: > > 1. The SelectedItems list does not get Remove change notifications in > many cases > > 2. IndexOutOfBoundsException is thrown while changing the selection in > some cases > > 3. If th