RFR: 8266860: [macos] Incorrect duration reported for HLS live streams

2021-05-11 Thread Alexander Matveev
For indefinite durations CMTimeGetSeconds was returning NaN (not-a-number double value) and our code expects -1.0. Based on doc we should be using CMTIME_IS_INDEFINITE to test if duration is indefinite. Fixed by using CMTIME_IS_INDEFINITE to test if duration is indefinite and if true -1.0 will

RFR: 8266811: Openjfx controls test build broken (Eclipse)

2021-05-11 Thread Jeanette Winzenburg
was introduced with fix [JDK-8189354](https://bugs.openjdk.java.net/browse/JDK-8189354) which uses MockListObserver in tests. Fix is analogous to previous eclipse build problems (f.i. [JDK-8265513](https://bugs.openjdk.java.net/browse/JDK-8265513)): add-exports to allow access to base' test

Re: Build error with gradle (command line)

2021-05-11 Thread John Neffenger
On 5/11/21 10:27 AM, Johan Vos wrote: I'm still +1 to keep Gradle for OpenJFX. The OpenJFX build is shockingly complicated. It's not just a Gradle build. It's a Gradle, Groovy Custom Task, Apache Maven, Apache Ant, GNU Make, CMake, Ninja, ANTLR, JUnit, GNU GCC, XCode, Visual Studio,

Integrated: 8266757: Add entry for jdk-12_doc-all.zip to gradle/verification-metadata.xml

2021-05-11 Thread Kevin Rushforth
On Fri, 7 May 2021 17:30:37 GMT, Kevin Rushforth wrote: > As indicated in JBS this PR adds a missing entry for the JDK 12 API docs zip > bundle for javadoc offline processing. This missing entry is causing a build > failure on my system (which will soon propagate to our CI builds). This pull

Re: RFR: 8266757: Add entry for jdk-12_doc-all.zip to gradle/verification-metadata.xml

2021-05-11 Thread Pankaj Bansal
On Fri, 7 May 2021 17:30:37 GMT, Kevin Rushforth wrote: > As indicated in JBS this PR adds a missing entry for the JDK 12 API docs zip > bundle for javadoc offline processing. This missing entry is causing a build > failure on my system (which will soon propagate to our CI builds). Marked as

Re: Build error with gradle (command line)

2021-05-11 Thread Johan Vos
Hi John, Regardless of the issues some of us have now, I believe the verification is a good thing to add, so thank you for that enhancement. Security often comes with a price, and if removing caches is all that it takes, I'm happy. Unrelated to that, I'm worried about the maintenance cost of

Re: RFR: 8266757: Add entry for jdk-12_doc-all.zip to gradle/verification-metadata.xml

2021-05-11 Thread Ambarish Rapte
On Fri, 7 May 2021 17:30:37 GMT, Kevin Rushforth wrote: > As indicated in JBS this PR adds a missing entry for the JDK 12 API docs zip > bundle for javadoc offline processing. This missing entry is causing a build > failure on my system (which will soon propagate to our CI builds). Looks good

Integrated: 8266919: Gradle verification fails on windows x86

2021-05-11 Thread Joeri Sykora
On Tue, 11 May 2021 14:30:08 GMT, Joeri Sykora wrote: > This pull request fixes gradle verification failures when building JavaFX > with a Windows 32-bit JDK. This pull request has now been integrated. Changeset: 3ac6bf0c Author:Joeri Sykora Committer: Kevin Rushforth URL:

Re: Build error with gradle (command line)

2021-05-11 Thread John Neffenger
On 5/11/21 5:24 AM, Jeanette Winzenburg wrote: deleting the caches did work, at last ;) That's also what I had to do after similar errors. I thought there might be some bumps in the road when I proposed adding the Gradle dependency verification, but I hope we can retain enough of it to make

Re: RFR: 8266919: Gradle verification fails on windows x86

2021-05-11 Thread Kevin Rushforth
On Tue, 11 May 2021 14:30:08 GMT, Joeri Sykora wrote: > This pull request fixes gradle verification failures when building JavaFX > with a Windows 32-bit JDK. Marked as reviewed by kcr (Lead). That's up to you. If you think it would help, go ahead. - PR:

Re: RFR: 8266919: Gradle verification fails on windows x86

2021-05-11 Thread Joeri Sykora
On Tue, 11 May 2021 14:30:08 GMT, Joeri Sykora wrote: > This pull request fixes gradle verification failures when building JavaFX > with a Windows 32-bit JDK. I was wondering if the [README](https://github.com/openjdk/jfx/blob/master/gradle/README.txt) should be updated to include windows

RFR: 8266919: Gradle verification fails on windows x86

2021-05-11 Thread Joeri Sykora
This pull request fixes gradle verification failures when building JavaFX with a Windows 32-bit JDK. - Commit messages: - fix gradle verification for windows x86 Changes: https://git.openjdk.java.net/jfx/pull/494/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx=494=00

Re: Build error with gradle (command line)

2021-05-11 Thread Jeanette Winzenburg
deleting the caches did work, at last ;) To summarize: ./gradlew --refresh-dependencies got rid of the initial error (problems with dependencies around lucene libs), but then barked about junit cd MyProfile/.gradle rm -rf caches native made it work gain (hopefully permanent ;) Thanks

Re: Build error with gradle (command line)

2021-05-11 Thread Johan Vos
(I did a reply instead of a reply-all) Hi, I had that on one of my Linux systems too, after the fix for JDK-8264010. My first system went fine after I ran with ./gradlew --refresh-dependencies and I understood this worked for others as well. On the second system, that didn't work and I ended

Re: Build error with gradle (command line)

2021-05-11 Thread Johan Vos
On Tue, May 11, 2021 at 1:41 PM Kevin Rushforth wrote: > I see that Ajit answered already with option #1 and that you are going > to try option #2. We might want to document this on the "Building > JavaFX" Wiki page. > > To expand on this a bit, what I think must have happened is that the >

Re: Re: Build error with gradle (command line)

2021-05-11 Thread Eric Bresie
Assume it has to do with some of this.. https://docs.gradle.org/current/userguide/dependency_verification.html Eric Bresie ebre...@gmail.com (mailto:ebre...@gmail.com) > On May 11, 2021 at 6:41:05 AM CDT, Kevin Rushforth > mailto:kevin.rushfo...@oracle.com)> wrote: > I see that Ajit answered

Re: Build error with gradle (command line)

2021-05-11 Thread Kevin Rushforth
I see that Ajit answered already with option #1 and that you are going to try option #2. We might want to document this on the "Building JavaFX" Wiki page. To expand on this a bit, what I think must have happened is that the contents of the pom files changed some time in the

Re: Build error with gradle (command line)

2021-05-11 Thread Kevin Rushforth
We've had a couple other reports about this. The solutions that you can try (should only be needed one time) are: 1. gradle --refresh-dependencies ... 2. Remove the gradle cache before building:     cd $USERPROFILE/.gradle     rm -rf caches native     gradle ... If this doesn't work, I will

Re: Build error with gradle (command line)

2021-05-11 Thread Jeanette Winzenburg
Thanks Johan, Ajit --refresh-dependencies did it .. nearly ;) now the error is down to: * What went wrong: Execution failed for task ':base:compileTestJava'. Dependency verification failed for configuration ':base:testCompileClasspath' One artifact failed verification: junit-4.8.2.pom

Re: Build error with gradle (command line)

2021-05-11 Thread Ajit Ghaisas
Hi Jeanette, I had faced this on my local system last week. Although the root cause is unknown - "gradle --refresh-dependencies” command had helped to get rid of this error. I did not pursue it as this error is not seen in our CI builds. Regards, Ajit > On 11-May-2021, at 2:58 PM,

Build error with gradle (command line)

2021-05-11 Thread Jeanette Winzenburg
Just sync'ed my local repository with upstream .. now can't build with gradle, the error: * Where: Build file 'C:\Daten\data-for-work\eclipse\gitrep-openjdk\jfx-fork\build.gradle' line: 4249 * What went wrong: A problem occurred evaluating root project 'jfx-fork'. Dependency