RFR: 8267121: Illegal access to private "size" field of ArrayList from build.gradle
A test of our CI build with gradle 7.0.1 and JDK 16.0.1 revealed a latent bug in `build.gradle` in the `fetchExternalTools()` method. It checks the size of an `ArrayList` in two places, but rather than calling the `size()` method it omits the `()` which means it is accessing the private `size` field. Starting in JDK 16, which has default strong encapsulation, this no longer works, so we need to fix this before switching. We really should fix it anyway, since accessing the internal field is both unnecessary and wrong. - Commit messages: - 8267121: Illegal access to private "size" field of ArrayList from build.gradle Changes: https://git.openjdk.java.net/jfx/pull/503/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx=503=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8267121 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jfx/pull/503.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/503/head:pull/503 PR: https://git.openjdk.java.net/jfx/pull/503
Re: RFR: 8263760: Update gradle to version 7.0.1 [v2]
On Fri, 14 May 2021 23:33:44 GMT, Scott Palmer wrote: > Isn't that just the settings for running the gradle wrapper - i.e. it is not > setting the heap used by the gradle daemon process that will actually run the > build script? Ah yes, you are right. I just verified this with a test build. So this is definitely not an issue then. Thanks! - PR: https://git.openjdk.java.net/jfx/pull/498
Re: RFR: 8266860: [macos] Incorrect duration reported for HLS live streams
On Tue, 11 May 2021 23:43:36 GMT, Alexander Matveev wrote: > For indefinite durations CMTimeGetSeconds was returning NaN (not-a-number > double value) and our code expects -1.0. Based on doc we should be using > CMTIME_IS_INDEFINITE to test if duration is indefinite. Fixed by using > CMTIME_IS_INDEFINITE to test if duration is indefinite and if true -1.0 will > be return to our Java layer. I requested 2 reviewers before I reviewed the fix, since changes in media are usually complex enough that a second reviewer is needed. In this case the fix is simple and obvious, so I don't think a second reviewer is required. @sashamatveev I recommend to wait until later in the day Monday to integrate this in case anyone else wants to take a look. - PR: https://git.openjdk.java.net/jfx/pull/495
