Re: RFR: 8185447: The special high-contrast mode of JavaFX Controls in Japanese environment do not work.

2021-06-24 Thread Kevin Rushforth
On Wed, 26 May 2021 20:39:32 GMT, Jose Pereda wrote: > This PR adds several resource bundles with High Contrast Scheme possible > values for several locales. > > These values have been found by installing the required language packages on > Windows 10 Pro 20H2 (build 19042.985), enabling

Re: RFR: 8267554: Support loading stylesheets from data-URIs [v6]

2021-06-24 Thread Kevin Rushforth
On Thu, 24 Jun 2021 23:24:43 GMT, Michael Strauß wrote: >> This PR extends data URI support to allow stylesheets to be loaded from data >> URIs. > > Michael Strauß has updated the pull request incrementally with one additional > commit since the last revision: > > changes per review

Re: RFR: 8267554: Support loading stylesheets from data-URIs [v6]

2021-06-24 Thread Michael Strauß
On Thu, 24 Jun 2021 23:24:43 GMT, Michael Strauß wrote: >> This PR extends data URI support to allow stylesheets to be loaded from data >> URIs. > > Michael Strauß has updated the pull request incrementally with one additional > commit since the last revision: > > changes per review I

Re: RFR: 8267554: Support loading stylesheets from data-URIs [v6]

2021-06-24 Thread Michael Strauß
> This PR extends data URI support to allow stylesheets to be loaded from data > URIs. Michael Strauß has updated the pull request incrementally with one additional commit since the last revision: changes per review - Changes: - all:

Re: RFR: 8267554: Support loading stylesheets from data-URIs [v5]

2021-06-24 Thread Michael Strauß
On Thu, 24 Jun 2021 21:12:36 GMT, Kevin Rushforth wrote: >> Michael Strauß has updated the pull request incrementally with one >> additional commit since the last revision: >> >> cleaned up paragraph tags > > modules/javafx.graphics/src/main/java/javafx/css/Stylesheet.java line 316: > >>

Re: RFR: 8223717: javafx printing: Support Specifying Print to File in the API [v3]

2021-06-24 Thread Kevin Rushforth
On Thu, 24 Jun 2021 23:03:29 GMT, Phil Race wrote: >> As a potential user of this API I have to ask, why would this be a URL >> instead of a File or Path ? Particularly if only "file:" URLs will be >> valid. I can't think of a scenario where it won't always be an extra >> inconvenience to

Re: RFR: 8223717: javafx printing: Support Specifying Print to File in the API [v3]

2021-06-24 Thread Phil Race
On Thu, 24 Jun 2021 23:19:22 GMT, Kevin Rushforth wrote: >> We aren't ignoring it .. its just handed on, so its going to be the same as >> the other non-writable case .. file could not be created .. printing error >> .. >> we could do some up-front validation if that seems like the way we

Re: RFR: 8223717: javafx printing: Support Specifying Print to File in the API [v2]

2021-06-24 Thread Phil Race
On Thu, 24 Jun 2021 22:42:00 GMT, Kevin Rushforth wrote: >> Phil Race has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - 8223717: javafx printing: Support Specifying Print to File in the API >> - 8223717: javafx printing: Support

Re: RFR: 8223717: javafx printing: Support Specifying Print to File in the API [v3]

2021-06-24 Thread Phil Race
On Thu, 24 Jun 2021 22:53:57 GMT, Scott Palmer wrote: >> modules/javafx.graphics/src/main/java/javafx/print/JobSettings.java line 474: >> >>> 472: * encoded name of a filesystem file, to which the platform printer >>> 473: * driver should spool the rendered print data. >>> 474: *

Re: RFR: 8223717: javafx printing: Support Specifying Print to File in the API [v3]

2021-06-24 Thread Phil Race
> This enhancement adds the String property outputFileProperty() to the > JobSettings class. > The value should be a string that references a local file encoded as a URL. > If this is non-null and set to a location that the user has permission to > write to, > then the printer output will be

Re: RFR: 8223717: javafx printing: Support Specifying Print to File in the API [v3]

2021-06-24 Thread Phil Race
On Thu, 24 Jun 2021 22:38:40 GMT, Kevin Rushforth wrote: >> Phil Race has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8223717: javafx printing: Support Specifying Print to File in the API > >

Re: RFR: 8223717: javafx printing: Support Specifying Print to File in the API [v3]

2021-06-24 Thread Scott Palmer
On Thu, 24 Jun 2021 22:25:53 GMT, Kevin Rushforth wrote: >> Phil Race has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8223717: javafx printing: Support Specifying Print to File in the API > >

Re: RFR: 8223717: javafx printing: Support Specifying Print to File in the API [v2]

2021-06-24 Thread Kevin Rushforth
On Thu, 24 Jun 2021 22:34:36 GMT, Phil Race wrote: >> This enhancement adds the String property outputFileProperty() to the >> JobSettings class. >> The value should be a string that references a local file encoded as a URL. >> If this is non-null and set to a location that the user has

Re: RFR: 8223717: javafx printing: Support Specifying Print to File in the API [v2]

2021-06-24 Thread Kevin Rushforth
On Thu, 24 Jun 2021 22:34:36 GMT, Phil Race wrote: >> This enhancement adds the String property outputFileProperty() to the >> JobSettings class. >> The value should be a string that references a local file encoded as a URL. >> If this is non-null and set to a location that the user has

Re: RFR: 8223717: javafx printing: Support Specifying Print to File in the API [v2]

2021-06-24 Thread Phil Race
> This enhancement adds the String property outputFileProperty() to the > JobSettings class. > The value should be a string that references a local file encoded as a URL. > If this is non-null and set to a location that the user has permission to > write to, > then the printer output will be

RFR: 8223717: javafx printing: Support Specifying Print to File in the API

2021-06-24 Thread Phil Race
This enhancement adds the String property outputFileProperty() to the JobSettings class. The value should be a string that references a local file encoded as a URL. If this is non-null and set to a location that the user has permission to write to, then the printer output will be spooled there

Re: RFR: 8267554: Support loading stylesheets from data-URIs [v5]

2021-06-24 Thread Kevin Rushforth
On Wed, 23 Jun 2021 13:09:51 GMT, Michael Strauß wrote: >> This PR extends data URI support to allow stylesheets to be loaded from data >> URIs. > > Michael Strauß has updated the pull request incrementally with one additional > commit since the last revision: > > cleaned up paragraph tags

Re: Moving src.zip out of the lib directory of the JavaFX SDK

2021-06-24 Thread Kevin Rushforth
Ah, OK. If it won't cause you any problems, then it still seems worth considering. I would like to hear from at least one IntelliJ user as to whether this change affects users of that IDE -- either positively or negatively. Does anyone else have any concerns? -- Kevin On 6/24/2021 11:33

Re: RFR: 8234920: Add SpotLight to the selection of 3D light types [v29]

2021-06-24 Thread Nir Lisker
On Wed, 23 Jun 2021 22:37:11 GMT, Nir Lisker wrote: >> Added a SpotLight only to the D3D pipeline currently. >> >> ### API discussion points >> >> - [X] Added `SpotLight` as a subclass of `LightBase`. However, it could >> also be a subclass of `PointLight` as it's a point light with

Integrated: 8234920: Add SpotLight to the selection of 3D light types

2021-06-24 Thread Nir Lisker
On Thu, 22 Oct 2020 18:29:19 GMT, Nir Lisker wrote: > Added a SpotLight only to the D3D pipeline currently. > > ### API discussion points > > - [X] Added `SpotLight` as a subclass of `LightBase`. However, it could also > be a subclass of `PointLight` as it's a point light with direction and

Re: Moving src.zip out of the lib directory of the JavaFX SDK

2021-06-24 Thread Tom Schindl
well I can push a new release in a few days if I know your final decision? You proposed option 1 and to me that sounds fine to me. Tom Am 24.06.21 um 20:22 schrieb Kevin Rushforth: Since it seems that this change will cause Eclipse to not find the sources without changes on their part (see

Re: Moving src.zip out of the lib directory of the JavaFX SDK

2021-06-24 Thread Kevin Rushforth
Since it seems that this change will cause Eclipse to not find the sources without changes on their part (see Tom's message), and might not be as important any more for Netbeans users, it's less clear to me that we should make this change. Netbeans users who download and use the JavaFX SDK can

Re: Proposed schedule for JavaFX 17

2021-06-24 Thread Kevin Rushforth
As a reminder, Rampdown Phase 1 (RDP1) for JavaFX 17 starts on July 8, 2021 at 16:00 UTC (09:00 Pacific time), which is two weeks from today. During rampdown of JavaFX 17, the "master" branch of the jfx repo will be open for JavaFX 18 fixes. Please allow sufficient time for any feature that

Re: RFR: 8234920: Add SpotLight to the selection of 3D light types [v29]

2021-06-24 Thread Ambarish Rapte
On Wed, 23 Jun 2021 22:37:11 GMT, Nir Lisker wrote: >> Added a SpotLight only to the D3D pipeline currently. >> >> ### API discussion points >> >> - [X] Added `SpotLight` as a subclass of `LightBase`. However, it could >> also be a subclass of `PointLight` as it's a point light with

Re: RFR: 8269147: Update GStreamer to version 1.18.4

2021-06-24 Thread Kevin Rushforth
On Thu, 24 Jun 2021 02:50:08 GMT, Alexander Matveev wrote: > - GStreamer updated to 1.18.4. > - Tested on all platforms with all formats. The code changes look good. I tested it on all three platforms. No problems. @tiainen can be the second reviewer on this. - Marked as

Re: Moving src.zip out of the lib directory of the JavaFX SDK

2021-06-24 Thread Ty Young
Netbeans no longer defaults to creating Ant based projects unlike years ago & there has been, IIRC, some talk on further retiring support for it and Maven works just fine provided that you use the JavaFX Maven plugin*. Still maybe worth fixing since support isn't completely removed and there

Re: RFR: 8269147: Update GStreamer to version 1.18.4

2021-06-24 Thread Johan Vos
On Thu, 24 Jun 2021 02:50:08 GMT, Alexander Matveev wrote: > - GStreamer updated to 1.18.4. > - Tested on all platforms with all formats. Those changes look reasonable. It seems that mainly windows is impacted. @tiainen can you double-check the static windows builds are ok with those

Re: Moving src.zip out of the lib directory of the JavaFX SDK

2021-06-24 Thread Tom Schindl
well I guess eclipse users won't see the sources anymore if they are moved, as we expect the src.zip next to the jar file [1] if I read my code appropriately. I filed [2] to adapt our code Tom [1]