Re: [External] : Re: Pivot properties [was: Enhancements for JavaFX 18]

2021-08-21 Thread Michael Strauß
I think that „computed pivot“ is both an unnecessary terminology, and really only one special case of a pivot coordinate in unit space where 0/0 is the top-left corner of the node, and 1/1 is the bottom-right corner of the node (which is what I referred to as „relative“ coordinates). Quite often,

Re: [External] : Re: Pivot properties [was: Enhancements for JavaFX 18]

2021-08-21 Thread Kevin Rushforth
I didn't page in enough of the discussion before. I remember now why we need separate pivots for rotate and scale, so thank you for reminding me. Btw, I don't think that necessarily means we need a separate switch for whether to use computed vs explicit for each (but that would be a

Re: RFR: 8172095: Let Node.managed become CSS-styleable

2021-08-21 Thread Kevin Rushforth
On Wed, 18 Aug 2021 06:45:37 GMT, Abhinay Agarwal wrote: > Is there anything else pending to move this PR forward? Nothing else needed for now. The review can proceed. - PR: https://git.openjdk.java.net/jfx/pull/602

Re: Pivot properties [was: Enhancements for JavaFX 18]

2021-08-21 Thread Nir Lisker
In the previous time this was discussed I suggested a 3rd option, in addition to ObjectProperty and 3 DoubleProperties, which is 3 ObjectPropertys. Advantages: 1. Allows using null to remove any specified user values (null would also be the default), similar to how we would do it with

Re: RFR: 8271398: GTK3 drag view image swaps red and blue color channels [v4]

2021-08-21 Thread Pankaj Bansal
On Fri, 20 Aug 2021 22:22:51 GMT, Thiago Milczarek Sayao wrote: >> It seems raw images need to be converted BRGA -> RGBA. >> >> It was being converted on gtk2 code path, but gtk3 only uses >> `gtk_drag_set_icon_pixbuf`. >> >> I have simplified the gtk2 `DragView::View::expose` to paint with