RFR: 8279640: ListView with null SelectionModel/FocusModel throws NPE

2022-01-07 Thread Marius Hanl
This PR fixes a bunch of NPEs when a null `SelectionModel` or `FocusModel` is set on a `ListView`. The following NPEs are fixed (all are also covered by exactly one test case): NPEs with null selection model: - Mouse click on a `ListCell` - SPACE key press - KP_UP (arrow up) key press - HOME key

Re: RFR: 8274066: Polygon filled outside its area when very large coordinates are used

2022-01-07 Thread Laurent Bourgès
On Fri, 7 Jan 2022 23:35:37 GMT, Kevin Rushforth wrote: > Would a targeted test for the failing case from the bug report make sense? I agree the rule is to have a test, I will write a basic test derived from user's case asap. - PR: https://git.openjdk.java.net/jfx/pull/674

Re: RFR: 8274066: Polygon filled outside its area when very large coordinates are used

2022-01-07 Thread Kevin Rushforth
On Wed, 17 Nov 2021 22:05:25 GMT, Laurent Bourgès wrote: > Changelog for this MarlinFX 0.9.4.5 release: > > The Marlin-renderer 0.9.4.5 release provides bug fixes on Marlin's path > clipper: > - removed simple-precision (float) variant > - improved Stroker to handle huge coordinates, up to

Re: RFR: 8274066: Polygon filled outside its area when very large coordinates are used

2022-01-07 Thread Laurent Bourgès
On Wed, 17 Nov 2021 22:05:25 GMT, Laurent Bourgès wrote: > Changelog for this MarlinFX 0.9.4.5 release: > > The Marlin-renderer 0.9.4.5 release provides bug fixes on Marlin's path > clipper: > - removed simple-precision (float) variant > - improved Stroker to handle huge coordinates, up to

RFR: 8273339: IOOBE with ListChangeListener added to the selectedItems list of a TableView

2022-01-07 Thread Jose Pereda
This PR converts the change's `from` field from a list of tablePositions into a list of selected indices of rows. It includes two tests for TableView and one for TreeTableView (the second test wasn't included due to an [issue|https://bugs.openjdk.java.net/browse/JDK-8232825] with key

RFR: 8273336: Clicking a selected cell from a group of selected cells in a TableView clears the selected items list but remains selected

2022-01-07 Thread Jose Pereda
This PR adds a predicate to TableView and TreeTableView selection models order to remove rows from the selection only when there are no selected cells in that given row, when cell selection is enabled. Two tests have been added as well, that fail without this PR and pass with it. -

RFR: 8273998: Clarify specification for Window properties controlled by the window manager

2022-01-07 Thread Kevin Rushforth
Update the API specification for the `Window` and `Stage` classes to clarify that the values for some properties and methods can be changed or ignored by the platform. Several of the properties already have a comment to the effect that the value can change externally, and thus the properties

Re: RFR: 8279228 Leak in ScrollPaneSkin, related to touch events

2022-01-07 Thread Florian Kirmaier
On Thu, 23 Dec 2021 17:43:19 GMT, Florian Kirmaier wrote: > Fixing memoryleak, related to touch events in ScrollPaneWhen touchDetected or > mouseDown is true, the sbTouch animation is running, > and the node is removed from the Scene, then the animation will never stop, > causing a memory

Re: RFR: 8279615: Change JavaFX release version to 19

2022-01-07 Thread Johan Vos
On Fri, 7 Jan 2022 12:55:33 GMT, Kevin Rushforth wrote: > Bump the version number of JavaFX to 19. I will integrate this immediately > after forking the `jfx18` stabilization branch, which is scheduled for > Thursday, January 13, 2022 at 16:00 UTC. ok (once 18 is branched) -

Re: RFR: 8279615: Change JavaFX release version to 19

2022-01-07 Thread Ambarish Rapte
On Fri, 7 Jan 2022 12:55:33 GMT, Kevin Rushforth wrote: > Bump the version number of JavaFX to 19. I will integrate this immediately > after forking the `jfx18` stabilization branch, which is scheduled for > Thursday, January 13, 2021 at 16:00 UTC. Marked as reviewed by arapte (Reviewer).

RFR: 8279615: Change JavaFX release version to 19

2022-01-07 Thread Kevin Rushforth
Bump the version number of JavaFX to 19. I will integrate this immediately after forking the `jfx18` stabilization branch, which is scheduled for Thursday, January 13, 2021 at 16:00 UTC. - Commit messages: - 8279615: Change JavaFX release version to 19 Changes:

Integrated: 8267059: Gradle :clean and :apps tasks fail on Windows if ANT_HOME contains spaces

2022-01-07 Thread Michael Strauß
On Thu, 13 May 2021 00:07:15 GMT, Michael Strauß wrote: > This PR fixes an issue when building OpenJFX on Windows and command-line > arguments contain paths with spaces. > > The problem is that on Windows, `ant` is invoked via `cmd`, which leads to > quotes being interpreted twice. This can

Re: RFR: 8197991: Selecting many items in a TableView is very slow [v6]

2022-01-07 Thread Kevin Rushforth
On Fri, 7 Jan 2022 08:04:53 GMT, Abhinay Agarwal wrote: >> This work improves the performance of `MultipleSelectionModel` over large >> data sets by caching some values and avoiding unnecessary calls to >> `SelectedIndicesList#size`. It further improves the performance by reducing >> the

Re: RFR: 8274066: Polygon filled outside its area when very large coordinates are used

2022-01-07 Thread Johan Vos
On Wed, 17 Nov 2021 22:05:25 GMT, Laurent Bourgès wrote: > Draft PR to see how big is the MarlinFX 0.9.4.5 patch (DPQS, Path clipper > fixes to handle huge coords) @bourgesl can you rename the title of this PR to 8274066: Polygon filled outside its area when very large coordinates are used

Re: RFR: 8274066: Polygon filled outside its area when very large coordinates are used

2022-01-07 Thread Laurent Bourgès
On Wed, 17 Nov 2021 22:05:25 GMT, Laurent Bourgès wrote: > Draft PR to see how big is the MarlinFX 0.9.4.5 patch (DPQS, Path clipper > fixes to handle huge coords) I will add changelog asap - PR: https://git.openjdk.java.net/jfx/pull/674

RFR: 8274066: Polygon filled outside its area when very large coordinates are used

2022-01-07 Thread Laurent Bourgès
Draft PR to see how big is the MarlinFX 0.9.4.5 patch (DPQS, Path clipper fixes to handle huge coords) - Commit messages: - fixed jcheck warning (tab) - Merge branch 'openjdk:master' into marlinFX-0.9.4.5 - minor changes (syntax, warnings) + merge with marlin 0.9.4.5 (jdk) -

Re: RFR: 8267059: Gradle :clean and :apps tasks fail on Windows if ANT_HOME contains spaces [v2]

2022-01-07 Thread Joeri Sykora
On Fri, 4 Jun 2021 05:04:17 GMT, Michael Strauß wrote: >> This PR fixes an issue when building OpenJFX on Windows and command-line >> arguments contain paths with spaces. >> >> The problem is that on Windows, `ant` is invoked via `cmd`, which leads to >> quotes being interpreted twice. This

Re: RFR: 8197991: Selecting many items in a TableView is very slow [v6]

2022-01-07 Thread Abhinay Agarwal
> This work improves the performance of `MultipleSelectionModel` over large > data sets by caching some values and avoiding unnecessary calls to > `SelectedIndicesList#size`. It further improves the performance by reducing > the number of iterations required to find the index of an element in