Integrated: 8197991: Selecting many items in a TableView is very slow

2022-01-10 Thread Abhinay Agarwal
On Wed, 17 Nov 2021 05:34:46 GMT, Abhinay Agarwal wrote: > This work improves the performance of `MultipleSelectionModel` over large > data sets by caching some values and avoiding unnecessary calls to > `SelectedIndicesList#size`. It further improves the performance by reducing > the number

Re: RFR: 8273998: Clarify specification for Window properties controlled by the window manager

2022-01-10 Thread Johan Vos
On Fri, 7 Jan 2022 18:19:23 GMT, Kevin Rushforth wrote: > Update the API specification for the `Window` and `Stage` classes to clarify > that the values for some properties and methods can be changed or ignored by > the platform. Several of the properties already have a comment to the effect

Re: RFR: 8274771: Map, FlatMap and OrElse fluent bindings for ObservableValue [v4]

2022-01-10 Thread John Hendrikx
On Thu, 6 Jan 2022 16:25:33 GMT, Nir Lisker wrote: >> John Hendrikx has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Apply changes suggested in review and updated copyright years to 2022 > >

Re: RFR: 8274771: Map, FlatMap and OrElse fluent bindings for ObservableValue [v5]

2022-01-10 Thread John Hendrikx
> This is an implementation of the proposal in > https://bugs.openjdk.java.net/browse/JDK-8274771 that me and Nir Lisker > (@nlisker) have been working on. It's a complete implementation including > good test coverage. > > This was based on https://github.com/openjdk/jfx/pull/434 but with a

Re: RFR: 8242544: CMD+ENTER key event crashes the application when invoked on dialog

2022-01-10 Thread Jose Pereda
On Wed, 29 Dec 2021 00:44:44 GMT, Andreas Heger wrote: > This also solves [JDK-8205915 [macOS] Accelerator assigned to button in > dialog fires menuItem in owning > stage](https://bugs.openjdk.java.net/browse/JDK-8205915l). > > I must admit that I don't have 100% insight about what actually

Re: RFR: 8256397: MultipleSelectionModel throws IndexOutOfBoundException [v3]

2022-01-10 Thread Florian Kirmaier
On Mon, 10 Jan 2022 12:29:04 GMT, Florian Kirmaier wrote: >> Fixing IndexOutOfBoundsException in the MultipleSelectionModelBase and added >> a unit-test for it. >> ticket: https://bugs.openjdk.java.net/browse/JDK-8256397 >> run test: `./gradlew --continue -PFULL_TEST=true controls:test --tests

Re: RFR: 8274066: Polygon filled outside its area when very large coordinates are used

2022-01-10 Thread Laurent Bourgès
On Fri, 7 Jan 2022 23:35:37 GMT, Kevin Rushforth wrote: >> Changelog for this MarlinFX 0.9.4.5 release: >> >> The Marlin-renderer 0.9.4.5 release provides bug fixes on Marlin's path >> clipper: >> - improved Stroker to handle huge coordinates, up to 1E15 >> - improved PathClipFilter (filler)

Re: RFR: 8256397: MultipleSelectionModel throws IndexOutOfBoundException [v3]

2022-01-10 Thread Florian Kirmaier
> Fixing IndexOutOfBoundsException in the MultipleSelectionModelBase and added > a unit-test for it. > ticket: https://bugs.openjdk.java.net/browse/JDK-8256397 > run test: `./gradlew --continue -PFULL_TEST=true controls:test --tests > "*MultipleSelectionModelImplTest*"` Florian Kirmaier has

Re: RFR: 8197991: Selecting many items in a TableView is very slow [v6]

2022-01-10 Thread Ajit Ghaisas
On Fri, 7 Jan 2022 08:04:53 GMT, Abhinay Agarwal wrote: >> This work improves the performance of `MultipleSelectionModel` over large >> data sets by caching some values and avoiding unnecessary calls to >> `SelectedIndicesList#size`. It further improves the performance by reducing >> the

Re: RFR: 8256397: MultipleSelectionModel throws IndexOutOfBoundException [v2]

2022-01-10 Thread Florian Kirmaier
> Fixing IndexOutOfBoundsException in the MultipleSelectionModelBase and added > a unit-test for it. > ticket: https://bugs.openjdk.java.net/browse/JDK-8256397 > run test: `./gradlew --continue -PFULL_TEST=true controls:test --tests > "*MultipleSelectionModelImplTest*"` Florian Kirmaier has

Re: RFR: 8277785: ListView scrollTo jumps to wrong location when CellHeight is changed

2022-01-10 Thread Florian Kirmaier
On Sun, 9 Jan 2022 15:20:36 GMT, Johan Vos wrote: > When the size of a ListCell is changed and a scrollTo method is invoked > without having a layout calculation in between, the old (wrong) size is used > to calculcate the total estimate. This happens e.g. when the size is changed > in the