Re: [jfx18] RFR: 8205915: [macOS] Accelerator assigned to button in dialog fires menuItem in owning stage [v2]

2022-01-13 Thread Martin Fox
> When a window is closed while handling performKeyEquivalent the same NSEvent > might be passed to the new key window causing it to being processed twice. > Long ago a fix was put in for this case; when the GlassWindow was closed a > flag was set to ensure that we would return YES from

RFR: 8255940: localStorage is null after window.close()

2022-01-13 Thread Jay Bhaskar
Issue: The current implementation of DOMWindow ::localStorage(..) returns null pointer in case of page is being closed. Fix: It should not return nullptr , as per the [w3c web storage spec](https://www.w3.org/TR/2016/REC-webstorage-20160419/) "User agents should expire data from the local

RFR: 8251481: TableCell accessing row: NPE on auto-sizing

2022-01-13 Thread Marius Hanl
This PR will fix a simple NPE which may happens when using the `TableRow` inside a `TableCell` during the initial auto sizing. In the auto sizing code, no `TableRow` is set, therefore `getTableRow()` will return null and it is not possible to e.g. access the row item. This is fixed by adding

Re: RFR: 8205915: [macOS] Accelerator assigned to button in dialog fires menuItem in owning stage

2022-01-13 Thread Kevin Rushforth
On Thu, 13 Jan 2022 19:18:33 GMT, Martin Fox wrote: > When a window is closed while handling performKeyEquivalent the same NSEvent > might be passed to the new key window causing it to being processed twice. > Long ago a fix was put in for this case; when the GlassWindow was closed a > flag

RFR: 8205915: [macOS] Accelerator assigned to button in dialog fires menuItem in owning stage

2022-01-13 Thread Martin Fox
When a window is closed while handling performKeyEquivalent the same NSEvent might be passed to the new key window causing it to being processed twice. Long ago a fix was put in for this case; when the GlassWindow was closed a flag was set to ensure that we would return YES from

Re: [jfx18] RFR: 8273998: Clarify specification for Window properties controlled by the window manager

2022-01-13 Thread Johan Vos
On Fri, 7 Jan 2022 18:19:23 GMT, Kevin Rushforth wrote: > Update the API specification for the `Window` and `Stage` classes to clarify > that the values for some properties and methods can be changed or ignored by > the platform. Several of the properties already have a comment to the effect

Re: [jfx18] RFR: 8273998: Clarify specification for Window properties controlled by the window manager

2022-01-13 Thread Kevin Rushforth
On Fri, 7 Jan 2022 18:19:23 GMT, Kevin Rushforth wrote: > Update the API specification for the `Window` and `Stage` classes to clarify > that the values for some properties and methods can be changed or ignored by > the platform. Several of the properties already have a comment to the effect

JavaFX 18 is in Rampdown Phase One (RDP1)

2022-01-13 Thread Kevin Rushforth
JavaFX 18 is now in Rampdown Phase One (RDP1) [1]. We have forked a new jfx18 branch [2] for stabilizing the JavaFX 18 release. Here is the short summary of what this means: - The master branch of the jfx repo is available for integrating bug fixes or enhancements for openjfx19. Most fixes

Integrated: 8279615: Change JavaFX release version to 19

2022-01-13 Thread Kevin Rushforth
On Fri, 7 Jan 2022 12:55:33 GMT, Kevin Rushforth wrote: > Bump the version number of JavaFX to 19. I will integrate this immediately > after forking the `jfx18` stabilization branch, which is scheduled for > Thursday, January 13, 2022 at 16:00 UTC. This pull request has now been integrated.

Re: RFR: 8274066: Polygon filled outside its area when very large coordinates are used [v2]

2022-01-13 Thread Laurent Bourgès
On Mon, 10 Jan 2022 00:04:00 GMT, Laurent Bourgès wrote: >> Changelog for this MarlinFX 0.9.4.5 release: >> >> The Marlin-renderer 0.9.4.5 release provides bug fixes on Marlin's path >> clipper: >> - improved Stroker to handle huge coordinates, up to 1E15 >> - improved PathClipFilter (filler)

Re: RFR: 8273998: Clarify specification for Window properties controlled by the window manager

2022-01-13 Thread Johan Vos
On Fri, 7 Jan 2022 18:19:23 GMT, Kevin Rushforth wrote: > Update the API specification for the `Window` and `Stage` classes to clarify > that the values for some properties and methods can be changed or ignored by > the platform. Several of the properties already have a comment to the effect

Re: RFR: 8273998: Clarify specification for Window properties controlled by the window manager

2022-01-13 Thread Ajit Ghaisas
On Fri, 7 Jan 2022 18:19:23 GMT, Kevin Rushforth wrote: > Update the API specification for the `Window` and `Stage` classes to clarify > that the values for some properties and methods can be changed or ignored by > the platform. Several of the properties already have a comment to the effect

Re: RFR: 8273998: Clarify specification for Window properties controlled by the window manager

2022-01-13 Thread Kevin Rushforth
On Thu, 13 Jan 2022 11:35:22 GMT, Ajit Ghaisas wrote: >> Update the API specification for the `Window` and `Stage` classes to clarify >> that the values for some properties and methods can be changed or ignored by >> the platform. Several of the properties already have a comment to the effect

Re: RFR: 8273998: Clarify specification for Window properties controlled by the window manager

2022-01-13 Thread Ajit Ghaisas
On Fri, 7 Jan 2022 18:19:23 GMT, Kevin Rushforth wrote: > Update the API specification for the `Window` and `Stage` classes to clarify > that the values for some properties and methods can be changed or ignored by > the platform. Several of the properties already have a comment to the effect

Re: RFR: 8277785: ListView scrollTo jumps to wrong location when CellHeight is changed

2022-01-13 Thread Florian Kirmaier
On Sun, 9 Jan 2022 15:20:36 GMT, Johan Vos wrote: > When the size of a ListCell is changed and a scrollTo method is invoked > without having a layout calculation in between, the old (wrong) size is used > to calculcate the total estimate. This happens e.g. when the size is changed > in the

Re: RFR: 8274066: Polygon filled outside its area when very large coordinates are used [v2]

2022-01-13 Thread Johan Vos
On Mon, 10 Jan 2022 00:04:00 GMT, Laurent Bourgès wrote: >> Changelog for this MarlinFX 0.9.4.5 release: >> >> The Marlin-renderer 0.9.4.5 release provides bug fixes on Marlin's path >> clipper: >> - improved Stroker to handle huge coordinates, up to 1E15 >> - improved PathClipFilter (filler)