Re: RFR: 8278980: Update WebKit to 613.1

2022-02-02 Thread Ambarish Rapte
On Wed, 2 Feb 2022 13:42:53 GMT, yosbits wrote: > You may have noticed ... The change file contains changes that are not > related to the WebKit upgrade. It looks like you're reverting to an older > version. Thanks for pointing it out. It is corrected now. Thanks @kevinrushforth for quick

Re: RFR: 8278980: Update WebKit to 613.1 [v2]

2022-02-02 Thread Ambarish Rapte
> Update JavaFX WebKit to GTK WebKit 2.34 (613.1). > > Verified the updated version build, tests run and sanity testing. > This does not cause any issues except a unit test failure > `IrresponsiveScriptTest`. > It is recorded and ignored using >

RFR: 8187309: TreeCell must not change tree's data

2022-02-02 Thread Jeanette Winzenburg
Issue was TreeView commit editing implementation violated the spec'ed mechanism: - no default commit handler on TreeView - TreeCell modifying the data directly Fix is to move the saving of the edited value from cell into a default commit handler in tree and set that handler in the constructor.

Re: RFR: 8278980: Update WebKit to 613.1

2022-02-02 Thread Kevin Rushforth
On Wed, 2 Feb 2022 13:42:53 GMT, yosbits wrote: > The change file contains changes that are not related to the WebKit upgrade. Thanks for pointing this out! It looks like the patch was applied incorrectly. @arapte please fix this. - PR: https://git.openjdk.java.net/jfx/pull/723

Re: RFR: 8278980: Update WebKit to 613.1

2022-02-02 Thread yosbits
On Wed, 2 Feb 2022 07:34:55 GMT, Ambarish Rapte wrote: > Update JavaFX WebKit to GTK WebKit 2.34 (613.1). > > Verified the updated version build, tests run and sanity testing. > This does not cause any issues except a unit test failure > `IrresponsiveScriptTest`. > It is recorded and ignored

Re: RFR: 8278980: Update WebKit to 613.1

2022-02-02 Thread Johan Vos
Hi Kevin, Thanks for filing [JDK-8281089]. I think this is the way forward indeed. The longer we delay moving to VS 2019, the more problems we can expect. I'll build/test the WebKit 613.1 as well. - Johan On Wed, Feb 2, 2022 at 1:49 PM Kevin Rushforth wrote: > On Wed, 2 Feb 2022 07:34:55 GMT,

Re: RFR: 8278980: Update WebKit to 613.1

2022-02-02 Thread Kevin Rushforth
On Wed, 2 Feb 2022 07:34:55 GMT, Ambarish Rapte wrote: > Update JavaFX WebKit to GTK WebKit 2.34 (613.1). > > Verified the updated version build, tests run and sanity testing. > This does not cause any issues except a unit test failure > `IrresponsiveScriptTest`. > It is recorded and ignored

Integrated: 8251481: TableCell accessing row: NPE on auto-sizing

2022-02-02 Thread Marius Hanl
On Fri, 14 Jan 2022 00:04:49 GMT, Marius Hanl wrote: > This PR will fix a simple NPE which may happens when using the `TableRow` > inside a `TableCell` during the initial auto sizing. > In the auto sizing code, no `TableRow` is set, therefore `getTableRow()` will > return null and it is not

Re: RFR: 8251481: TableCell accessing row: NPE on auto-sizing [v4]

2022-02-02 Thread Jeanette Winzenburg
On Tue, 1 Feb 2022 17:41:47 GMT, Marius Hanl wrote: >> This PR will fix a simple NPE which may happens when using the `TableRow` >> inside a `TableCell` during the initial auto sizing. >> In the auto sizing code, no `TableRow` is set, therefore `getTableRow()` >> will return null and it is not

RFR: 8278980: Update to 613.1 version of WebKit

2022-02-02 Thread Ambarish Rapte
Update JavaFX WebKit to GTK WebKit 2.34 (613.1). Verified the updated version build, tests run and sanity testing. This does not cause any issues except a unit test failure `IrresponsiveScriptTest`. It is recorded and ignored using [JDK-8280421](https://bugs.openjdk.java.net/browse/JDK-8280421)