On Wed, 9 Feb 2022 14:04:55 GMT, Jeanette Winzenburg
wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/control/TreeView.java
>> line 341:
>>
>>> 339: setFocusModel(new TreeViewFocusModel(this));
>>> 340:
>>> 341: setOnEditCommit(DEFAULT_EDIT_COMMIT_HANDLER);
>>
>>
On Wed, 2 Feb 2022 14:18:18 GMT, Jeanette Winzenburg
wrote:
> Issue was TreeView commit editing implementation violated the spec'ed
> mechanism:
>
> - no default commit handler on TreeView
> - TreeCell modifying the data directly
>
> Fix is to move the saving of the edited value from cell
On Wed, 9 Feb 2022 13:44:09 GMT, Kevin Rushforth wrote:
>> Hima Bindu Meda has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Create UPDATING.txt to explain SQLite version update
>
>
> Updated SQLite to 3.37.2 released on 2022-01-06 from the current version
> 3.32.3.
>
> Website : https://www.sqlite.org/index.html
> Source code can be found from https://www.sqlite.org/download.html at
>
On Wed, 9 Feb 2022 19:14:47 GMT, Ambarish Rapte wrote:
> This seems like a bad merge issue.
> There were duplicate copies of four methods in `MacroAssemblerARM64.h` which
> caused WebKit build failure on Mac M1 machines.
> Just removing the methods removes the error.
> With the changes in
On Wed, 9 Feb 2022 19:14:47 GMT, Ambarish Rapte wrote:
> This seems like a bad merge issue.
> There were duplicate copies of four methods in `MacroAssemblerARM64.h` which
> caused WebKit build failure on Mac M1 machines.
> Just removing the methods removes the error.
> With the changes in
This seems like a bad merge issue.
There were duplicate copies of four methods in `MacroAssemblerARM64.h` which
caused WebKit build failure on Mac M1 machines.
Just removing the methods removes the error.
With the changes in this PR, now the file `MacroAssemblerARM64.h` matches with
the WebKit
On Wed, 9 Feb 2022 18:27:55 GMT, Ajit Ghaisas wrote:
>> This is a Javadoc cleanup and correction fix for the TabPane as described in
>> the JBS.
>>
>> Changes done for all the Properties of the TabPane -
>> - Moved the property description to be over the property field.
>> - Removed the
On Wed, 9 Feb 2022 13:34:13 GMT, Nir Lisker wrote:
>> Good suggestion.
>>
>> Also optional, you can remove the `` since they are not needed for the
>> initial paragraph.
>
> There are many redundant `` tags in the property docs too if you want to
> deal with them as well for consistency (not
> This is a Javadoc cleanup and correction fix for the TabPane as described in
> the JBS.
>
> Changes done for all the Properties of the TabPane -
> - Moved the property description to be over the property field.
> - Removed the unnecessary docs on property setter/getter and Property method.
Hi,
When reviewing the docs changes to TabPane, I saw that some properties
mention the CSS that is related to them. I was wondering if we could
standardize it through something like a @css tag that is given the css
string constant, or read automatically through the CssMetaData.
As an example:
On Wed, 9 Feb 2022 04:40:49 GMT, Hima Bindu Meda wrote:
>> Updated SQLite to 3.37.2 released on 2022-01-06 from the current version
>> 3.32.3.
>>
>> Website : https://www.sqlite.org/index.html
>> Source code can be found from https://www.sqlite.org/download.html at
>>
On Wed, 9 Feb 2022 10:51:54 GMT, Ajit Ghaisas wrote:
>> Issue was TreeView commit editing implementation violated the spec'ed
>> mechanism:
>>
>> - no default commit handler on TreeView
>> - TreeCell modifying the data directly
>>
>> Fix is to move the saving of the edited value from cell
On Wed, 9 Feb 2022 13:17:14 GMT, Kevin Rushforth wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/control/TabPane.java line
>> 738:
>>
>>> 736:
>>> 737: /**
>>> 738: * This specifies how the {@code TabPane} handles tab closing
>>> from an end-user's
>>
>> Since you are
On Wed, 9 Feb 2022 13:06:58 GMT, Nir Lisker wrote:
>> Ajit Ghaisas has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Address review comments
>
> modules/javafx.controls/src/main/java/javafx/scene/control/TabPane.java line
> 738:
>
>>
On Wed, 9 Feb 2022 07:32:20 GMT, Ajit Ghaisas wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/control/TabPane.java line
>> 295:
>>
>>> 293: *
>>> 294: * This value can also be set via CSS using {@code
>>> -fx-tab-min-width}.
>>> 295: *
>>
>> I would write
>>
>>
On Wed, 9 Feb 2022 09:39:46 GMT, Ajit Ghaisas wrote:
>> This is a Javadoc cleanup and correction fix for the TabPane as described in
>> the JBS.
>>
>> Changes done for all the Properties of the TabPane -
>> - Moved the property description to be over the property field.
>> - Removed the
Since there aren't any further comments on this, I assume there isn't much
interest in this. Deprecating it is probably the right move, if it never worked
as intended on any platform. I think I'm going to try and get this working as
some kind of library instead.
> On 3. Feb 2022, at 20:55,
Hi,
With JDK 11 (or with com.sun.webkit.useHTTP2Loader=false) WebView defaults
to the old HTTP 1.1 and via HttpURLConnection [2] it has access to basic
and digest authentication.
But since JDK 12+ (or with com.sun.webkit.useHTTP2Loader=true) WebView uses
HTTP/2 and HttpClient [1], which doesn't
On Wed, 2 Feb 2022 14:18:18 GMT, Jeanette Winzenburg
wrote:
> Issue was TreeView commit editing implementation violated the spec'ed
> mechanism:
>
> - no default commit handler on TreeView
> - TreeCell modifying the data directly
>
> Fix is to move the saving of the edited value from cell
> This is a Javadoc cleanup and correction fix for the TabPane as described in
> the JBS.
>
> Changes done for all the Properties of the TabPane -
> - Moved the property description to be over the property field.
> - Removed the unnecessary docs on property setter/getter and Property method.
On Mon, 7 Feb 2022 16:17:32 GMT, Nir Lisker wrote:
>> This is a Javadoc cleanup and correction fix for the TabPane as described in
>> the JBS.
>>
>> Changes done for all the Properties of the TabPane -
>> - Moved the property description to be over the property field.
>> - Removed the
On Mon, 7 Feb 2022 16:24:46 GMT, Kevin Rushforth wrote:
>> This is a Javadoc cleanup and correction fix for the TabPane as described in
>> the JBS.
>>
>> Changes done for all the Properties of the TabPane -
>> - Moved the property description to be over the property field.
>> - Removed the
On Fri, 7 Jan 2022 19:36:45 GMT, Jose Pereda wrote:
> This PR adds a predicate to TableView and TreeTableView selection models
> order to remove rows from the selection only when there are no selected cells
> in that given row, when cell selection is enabled.
>
> Two tests have been added as
24 matches
Mail list logo
