Integrated: 8280841: Update SQLite to 3.37.2

2022-02-10 Thread Hima Bindu Meda
On Fri, 4 Feb 2022 12:53:51 GMT, Hima Bindu Meda wrote: > Updated SQLite to 3.37.2 released on 2022-01-06 from the current version > 3.32.3. > > Website : https://www.sqlite.org/index.html > Source code can be found from https://www.sqlite.org/download.html at >

Re: RFR: 8280841: Update SQLite to 3.37.2 [v3]

2022-02-10 Thread Ambarish Rapte
On Thu, 10 Feb 2022 05:56:47 GMT, Hima Bindu Meda wrote: >> Updated SQLite to 3.37.2 released on 2022-01-06 from the current version >> 3.32.3. >> >> Website : https://www.sqlite.org/index.html >> Source code can be found from https://www.sqlite.org/download.html at >>

[jfx18] Integrated: 8271085: TabPane: Redundant API docs

2022-02-10 Thread Ajit Ghaisas
On Mon, 7 Feb 2022 10:53:00 GMT, Ajit Ghaisas wrote: > This is a Javadoc cleanup and correction fix for the TabPane as described in > the JBS. > > Changes done for all the Properties of the TabPane - > - Moved the property description to be over the property field. > - Removed the unnecessary

Re: RFR: 8280020: Underline and line-through not straight in WebView

2022-02-10 Thread Kevin Rushforth
On Thu, 10 Feb 2022 11:36:38 GMT, Jay Bhaskar wrote: > Issue: The end point of line in drawLinesForText , add thickness to the > endPoint.y(). In this case origin which is start point and the end point > would not be same, and line would be drawn not straight. > Solution: Do not add thickness

Re: RFR: 8271054: [REDO] Wrong stage gets focused after modal stage creation [v9]

2022-02-10 Thread Kevin Rushforth
On Tue, 25 Jan 2022 23:57:09 GMT, Thiago Milczarek Sayao wrote: >> Found the problem thru this path: >> >> **WindowStage.java** >> >> final void handleFocusDisabled() { >> if (activeWindows.isEmpty()) { >> return; >> } >> WindowStage window =

Re: [jfx18] RFR: 8271085: TabPane: Redundant API docs [v3]

2022-02-10 Thread Kevin Rushforth
On Wed, 9 Feb 2022 18:27:55 GMT, Ajit Ghaisas wrote: >> This is a Javadoc cleanup and correction fix for the TabPane as described in >> the JBS. >> >> Changes done for all the Properties of the TabPane - >> - Moved the property description to be over the property field. >> - Removed the

Re: Use pure X11 backend for glass native

2022-02-10 Thread Thiago Milczarek Sayão
Hi, So far, it seems native Xlib is a good fit: https://github.com/openjdk/jfx-sandbox/tree/tsayao_xlib It's still a big mess since I'm porting gradually while learning X11. -- Thiago. Em ter., 25 de jan. de 2022 às 12:06, Thiago Milczarek Sayão < thiago.sa...@gmail.com> escreveu: > > I put

Integrated: 8281459: WebKit 613.1 build broken on M1

2022-02-10 Thread Ambarish Rapte
On Wed, 9 Feb 2022 19:14:47 GMT, Ambarish Rapte wrote: > This seems like a bad merge issue. > There were duplicate copies of four methods in `MacroAssemblerARM64.h` which > caused WebKit build failure on Mac M1 machines. > Just removing the methods removes the error. > With the changes in

Re: RFR: 8280841: Update SQLite to 3.37.2 [v3]

2022-02-10 Thread Kevin Rushforth
On Thu, 10 Feb 2022 05:56:47 GMT, Hima Bindu Meda wrote: >> Updated SQLite to 3.37.2 released on 2022-01-06 from the current version >> 3.32.3. >> >> Website : https://www.sqlite.org/index.html >> Source code can be found from https://www.sqlite.org/download.html at >>

RFR: 8280020: Underline and line-through not straight in WebView

2022-02-10 Thread Jay Bhaskar
Issue: The end point of line in drawLinesForText , add thickness to the endPoint.y(). In this case origin which is start point and the end point would not be same, and line would be drawn not straight. Solution: Do not add thickness to the y position of end point of line. Start Point(x,y)

Integrated: 8187309: TreeCell must not change tree's data

2022-02-10 Thread Jeanette Winzenburg
On Wed, 2 Feb 2022 14:18:18 GMT, Jeanette Winzenburg wrote: > Issue was TreeView commit editing implementation violated the spec'ed > mechanism: > > - no default commit handler on TreeView > - TreeCell modifying the data directly > > Fix is to move the saving of the edited value from cell

Re: RFR: 8187309: TreeCell must not change tree's data

2022-02-10 Thread Jeanette Winzenburg
On Tue, 8 Feb 2022 12:49:59 GMT, Marius Hanl wrote: >> Issue was TreeView commit editing implementation violated the spec'ed >> mechanism: >> >> - no default commit handler on TreeView >> - TreeCell modifying the data directly >> >> Fix is to move the saving of the edited value from cell into

Re: RFR: 8273339: IOOBE with ListChangeListener added to the selectedItems list of a TableView [v2]

2022-02-10 Thread Jose Pereda
On Fri, 14 Jan 2022 20:18:57 GMT, Jose Pereda wrote: >> This PR converts the change's `from` field from a list of tablePositions >> into a list of selected indices of rows. >> >> It includes two tests for TableView and one for TreeTableView (the second >> test wasn't included due to an >>

Re: RFR: 8273339: IOOBE with ListChangeListener added to the selectedItems list of a TableView [v3]

2022-02-10 Thread Jose Pereda
> This PR converts the change's `from` field from a list of tablePositions into > a list of selected indices of rows. > > It includes two tests for TableView and one for TreeTableView (the second > test wasn't included due to an > [issue|https://bugs.openjdk.java.net/browse/JDK-8232825] with

Re: RFR: 8281459: WebKit 613.1 build broken on M1

2022-02-10 Thread Johan Vos
On Wed, 9 Feb 2022 19:14:47 GMT, Ambarish Rapte wrote: > This seems like a bad merge issue. > There were duplicate copies of four methods in `MacroAssemblerARM64.h` which > caused WebKit build failure on Mac M1 machines. > Just removing the methods removes the error. > With the changes in