Re: RFR: 8280020: Underline and line-through not straight in WebView

2022-02-11 Thread yosbits
On Thu, 10 Feb 2022 11:36:38 GMT, Jay Bhaskar wrote: > Issue: The end point of line in drawLinesForText , add thickness to the > endPoint.y(). In this case origin which is start point and the end point > would not be same, and line would be drawn not straight. > Solution: Do not add thickness

Re: RFR: 8280020: Underline and line-through not straight in WebView

2022-02-11 Thread Kevin Rushforth
On Sat, 12 Feb 2022 01:00:46 GMT, Kevin Rushforth wrote: > 2. The text is always drawn as a thin line... That should be "the text _underline or line-through_ is always drawn as a thin line...". - PR: https://git.openjdk.java.net/jfx/pull/731

Re: RFR: 8280020: Underline and line-through not straight in WebView

2022-02-11 Thread Kevin Rushforth
On Thu, 10 Feb 2022 11:36:38 GMT, Jay Bhaskar wrote: > Issue: The end point of line in drawLinesForText , add thickness to the > endPoint.y(). In this case origin which is start point and the end point > would not be same, and line would be drawn not straight. > Solution: Do not add thickness

Re: JavaFX Launch Failure on Ubuntu from JNI

2022-02-11 Thread Steve Hannah
Just wanted to share that I sorted out all of my issues with this launcher, and I'm proud to present the result: jDeploy https://www.jdeploy.com You can now deploy your JavaFX apps as native bundles to your Mac, Linux, and Windows users without requiring a Mac/Windows/Linux box to produce the

[jfx17u] Integrated: 8281459: WebKit 613.1 build broken on M1

2022-02-11 Thread Kevin Rushforth
On Fri, 11 Feb 2022 18:35:37 GMT, Kevin Rushforth wrote: > Clean backport to jfx17u. This pull request has now been integrated. Changeset: 9bf1feb0 Author:Kevin Rushforth URL: https://git.openjdk.java.net/jfx17u/commit/9bf1feb0abf9a4f28c80f655aa1e63325b6383ab Stats: 20 lines in

[jfx17u] Integrated: 8281459: WebKit 613.1 build broken on M1

2022-02-11 Thread Kevin Rushforth
Clean backport to jfx17u. - Commit messages: - 8281459: WebKit 613.1 build broken on M1 Changes: https://git.openjdk.java.net/jfx17u/pull/34/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx17u=34=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8281459 Stats: 20

[jfx17u] Integrated: 8278980: Update WebKit to 613.1

2022-02-11 Thread Kevin Rushforth
On Fri, 11 Feb 2022 16:48:47 GMT, Kevin Rushforth wrote: > Clean backport to jfx17u. CI build passed on three platforms. Tested locally > on macOS. This pull request has now been integrated. Changeset: 4c944064 Author:Kevin Rushforth URL:

[jfx17u] Integrated: 8242544: CMD+ENTER key event crashes the application when invoked on dialog

2022-02-11 Thread Kevin Rushforth
On Fri, 11 Feb 2022 16:48:35 GMT, Kevin Rushforth wrote: > Clean backport to jfx17u. CI build passed on three platforms. Tested locally > on macOS. This pull request has now been integrated. Changeset: b0ae8b6b Author:Kevin Rushforth URL:

[jfx17u] Integrated: 8278260: JavaFX shared libraries not stripped on Linux or macOS

2022-02-11 Thread Kevin Rushforth
On Fri, 11 Feb 2022 16:48:27 GMT, Kevin Rushforth wrote: > Clean backport to jfx17u. CI build passed on three platforms. Tested locally > on macOS. This pull request has now been integrated. Changeset: f52ded76 Author:Kevin Rushforth URL:

[jfx17u] Integrated: 8277457: AccessControlException: access denied ("java.net.NetPermission" "getCookieHandler")

2022-02-11 Thread Kevin Rushforth
On Fri, 11 Feb 2022 16:48:20 GMT, Kevin Rushforth wrote: > Clean backport to jfx17u. CI build passed on three platforms. Tested locally > on macOS. This pull request has now been integrated. Changeset: 0ab83722 Author:Kevin Rushforth URL:

Re: [jfx17u] RFR: 8278980: Update WebKit to 613.1

2022-02-11 Thread Kevin Rushforth
On Fri, 11 Feb 2022 16:48:47 GMT, Kevin Rushforth wrote: > Clean backport to jfx17u. CI build passed on three platforms. Tested locally > on macOS. Skara didn't mark this one as clean, although it is. See [SKARA-1332](https://bugs.openjdk.java.net/browse/SKARA-1332). I double-checked by

[jfx17u] RFR: 8278980: Update WebKit to 613.1

2022-02-11 Thread Kevin Rushforth
Clean backport to jfx17u. CI build passed on three platforms. Tested locally on macOS. - Commit messages: - 8278980: Update WebKit to 613.1 Changes: https://git.openjdk.java.net/jfx17u/pull/33/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx17u=33=00 Issue:

Sneak preview: cell edit api to support commit-on-focusLost

2022-02-11 Thread Jeanette Winzenburg
Hi folks, after fixing a bunch of edit-related issues, time feels right for nudging elephant out of the room :) Which is the bigger goal of supporting commit-on-focusLost. Working on a PoC (ListView/-Cell only) in a branch of my fork

[jfx17u] RFR: 8242544: CMD+ENTER key event crashes the application when invoked on dialog

2022-02-11 Thread Kevin Rushforth
Clean backport to jfx17u. CI build passed on three platforms. Tested locally on macOS. - Commit messages: - 8242544: CMD+ENTER key event crashes the application when invoked on dialog Changes: https://git.openjdk.java.net/jfx17u/pull/32/files Webrev:

[jfx17u] RFR: 8278260: JavaFX shared libraries not stripped on Linux or macOS

2022-02-11 Thread Kevin Rushforth
Clean backport to jfx17u. CI build passed on three platforms. Tested locally on macOS. - Commit messages: - 8278260: JavaFX shared libraries not stripped on Linux or macOS Changes: https://git.openjdk.java.net/jfx17u/pull/31/files Webrev:

[jfx17u] RFR: 8277457: AccessControlException: access denied ("java.net.NetPermission" "getCookieHandler")

2022-02-11 Thread Kevin Rushforth
Clean backport to jfx17u. CI build passed on three platforms. Tested locally on macOS. - Commit messages: - 8277457: AccessControlException: access denied ("java.net.NetPermission" "getCookieHandler") Changes: https://git.openjdk.java.net/jfx17u/pull/30/files Webrev:

Integrated: Merge jfx18

2022-02-11 Thread Kevin Rushforth
On Fri, 11 Feb 2022 14:19:08 GMT, Kevin Rushforth wrote: > Merge `jfx18` into `master`. This pull request has now been integrated. Changeset: 2561e313 Author:Kevin Rushforth URL: https://git.openjdk.java.net/jfx/commit/2561e3137f955ba151a84ae49bed683b96280406 Stats: 325 lines

RFR: Merge jfx18

2022-02-11 Thread Kevin Rushforth
Merge `jfx18` into `master`. - Commit messages: - Merge jfx18 - 8271085: TabPane: Redundant API docs - 8279345: Realign class docs of LightBase and subclasses The merge commit only contains trivial merges, so no merge-specific webrevs have been generated. Changes:

Re: RFR: 8280020: Underline and line-through not straight in WebView

2022-02-11 Thread yosbits
On Thu, 10 Feb 2022 11:36:38 GMT, Jay Bhaskar wrote: > Issue: The end point of line in drawLinesForText , add thickness to the > endPoint.y(). In this case origin which is start point and the end point > would not be same, and line would be drawn not straight. > Solution: Do not add thickness

Re: RFR: 8280020: Underline and line-through not straight in WebView

2022-02-11 Thread Jay Bhaskar
On Thu, 10 Feb 2022 11:36:38 GMT, Jay Bhaskar wrote: > Issue: The end point of line in drawLinesForText , add thickness to the > endPoint.y(). In this case origin which is start point and the end point > would not be same, and line would be drawn not straight. > Solution: Do not add thickness

Re: RFR: 8280020: Underline and line-through not straight in WebView

2022-02-11 Thread yosbits
On Thu, 10 Feb 2022 11:36:38 GMT, Jay Bhaskar wrote: > Issue: The end point of line in drawLinesForText , add thickness to the > endPoint.y(). In this case origin which is start point and the end point > would not be same, and line would be drawn not straight. > Solution: Do not add thickness

Re: RFR: 8280020: Underline and line-through not straight in WebView

2022-02-11 Thread Jay Bhaskar
On Thu, 10 Feb 2022 11:36:38 GMT, Jay Bhaskar wrote: > Issue: The end point of line in drawLinesForText , add thickness to the > endPoint.y(). In this case origin which is start point and the end point > would not be same, and line would be drawn not straight. > Solution: Do not add thickness