Re: RFR: 8270867: Debug build of WebKit 613.1 fails on Linux

2022-03-16 Thread Jay Bhaskar
On Wed, 16 Mar 2022 07:54:57 GMT, Peter Zhelezniakov wrote: > The file `wtf/linux/MemoryPressureLinux.cpp` was renamed > `wtf/unix/MemoryPressureUnix.cpp` in https://trac.webkit.org/changeset/261428 > . In the openjfx workspace, both files are present. I'm removing the old file. Since there

Integrated: 8283183: Skip failing PredefinedMeshManagerTest tests

2022-03-16 Thread Kevin Rushforth
On Tue, 15 Mar 2022 18:50:15 GMT, Kevin Rushforth wrote: > We continue to get intermittent test failures in `PredefinedMeshManagerTest` > due to an OOM error. See the GitHub Actions run for [PR > 753](https://github.com/openjdk/jfx/pull/753/checks?check_run_id=5559141397) > for a recent

Re: RFR: 8274771: Map, FlatMap and OrElse fluent bindings for ObservableValue [v10]

2022-03-16 Thread John Hendrikx
On Thu, 10 Mar 2022 17:49:38 GMT, John Hendrikx wrote: >> This is an implementation of the proposal in >> https://bugs.openjdk.java.net/browse/JDK-8274771 that me and Nir Lisker >> (@nlisker) have been working on. It's a complete implementation including >> good test coverage. >> >> This

Re: RFR: 8283183: Skip failing PredefinedMeshManagerTest tests

2022-03-16 Thread Johan Vos
On Tue, 15 Mar 2022 18:50:15 GMT, Kevin Rushforth wrote: > We continue to get intermittent test failures in `PredefinedMeshManagerTest` > due to an OOM error. See the GitHub Actions run for [PR > 753](https://github.com/openjdk/jfx/pull/753/checks?check_run_id=5559141397) > for a recent

Re: RFR: 8270867: Debug build of WebKit 613.1 fails on Linux

2022-03-16 Thread Kevin Rushforth
On Wed, 16 Mar 2022 07:54:57 GMT, Peter Zhelezniakov wrote: > The file `wtf/linux/MemoryPressureLinux.cpp` was renamed > `wtf/unix/MemoryPressureUnix.cpp` in https://trac.webkit.org/changeset/261428 > . In the openjfx workspace, both files are present. I'm removing the old file. I was able to

Re: RFR: 8270867: Debug build of WebKit 613.1 fails on Linux

2022-03-16 Thread Jay Bhaskar
On Wed, 16 Mar 2022 07:54:57 GMT, Peter Zhelezniakov wrote: > The file `wtf/linux/MemoryPressureLinux.cpp` was renamed > `wtf/unix/MemoryPressureUnix.cpp` in https://trac.webkit.org/changeset/261428 > . In the openjfx workspace, both files are present. I'm removing the old file. Yes , The PR

Re: RFR: 8270867: Debug build of WebKit 613.1 fails on Linux

2022-03-16 Thread Kevin Rushforth
On Wed, 16 Mar 2022 07:54:57 GMT, Peter Zhelezniakov wrote: > The file `wtf/linux/MemoryPressureLinux.cpp` was renamed > `wtf/unix/MemoryPressureUnix.cpp` in https://trac.webkit.org/changeset/261428 > . In the openjfx workspace, both files are present. I'm removing the old file. There are two

Re: RFR: 8283183: Skip failing PredefinedMeshManagerTest tests

2022-03-16 Thread Kevin Rushforth
On Tue, 15 Mar 2022 18:50:15 GMT, Kevin Rushforth wrote: > We continue to get intermittent test failures in `PredefinedMeshManagerTest` > due to an OOM error. See the GitHub Actions run for [PR > 753](https://github.com/openjdk/jfx/pull/753/checks?check_run_id=5559141397) > for a recent

Re: RFR: 8270867: Debug build of WebKit 613.1 fails on Linux

2022-03-16 Thread Jay Bhaskar
On Wed, 16 Mar 2022 07:54:57 GMT, Peter Zhelezniakov wrote: > The file `wtf/linux/MemoryPressureLinux.cpp` was renamed > `wtf/unix/MemoryPressureUnix.cpp` in https://trac.webkit.org/changeset/261428 > . In the openjfx workspace, both files are present. I'm removing the old file. The patch

Re: RFR: 8251480: TableColumnHeader: calc of cell width must respect row styling

2022-03-16 Thread Robert Lichtenberger
On Wed, 16 Mar 2022 11:46:07 GMT, Marius Hanl wrote: > Might make sense to also adjust the TreeTableView sizing implementation? Yes I think that may be a good idea. True to the idea of specific, narrow commits I've not integrated this into this PR but would be willing to open a new issue /

Re: RFR: 8283246: WebKit fails to build on Linux

2022-03-16 Thread Kevin Rushforth
On Wed, 16 Mar 2022 07:54:57 GMT, Peter Zhelezniakov wrote: > The file `wtf/linux/MemoryPressureLinux.cpp` was renamed > `wtf/unix/MemoryPressureUnix.cpp` in https://trac.webkit.org/changeset/261428 > . In the openjfx workspace, both files are present. I'm removing the old file. Thanks for

Re: RFR: 8251480: TableColumnHeader: calc of cell width must respect row styling

2022-03-16 Thread Marius Hanl
On Wed, 16 Mar 2022 08:20:59 GMT, Robert Lichtenberger wrote: > This fix respects a row factory, if present. > It will put the cell that is used to measure the column width as child below > the row. > In that way the row's style will be used. Might make sense to also adjust the TreeTableView

RFR: 8251480: TableColumnHeader: calc of cell width must respect row styling

2022-03-16 Thread Robert Lichtenberger
This fix respects a row factory, if present. It will put the cell that is used to measure the column width as child below the row. In that way the row's style will be used. - Commit messages: - 8251480: TableColumnHeader: calc of cell width must respect row styling Changes:

RFR: 8283246: WebKit fails to build on Linux

2022-03-16 Thread Peter Zhelezniakov
The file `wtf/linux/MemoryPressureLinux.cpp` was renamed `wtf/unix/MemoryPressureUnix.cpp` in https://trac.webkit.org/changeset/261428 . In the openjfx workspace, both files are present. I'm removing the old file. - Commit messages: - 8283246: WebKit fails to build on Linux