Re: RFR: 8283509: Invisible menus can lead to IndexOutOfBoundsException

2022-03-29 Thread Ajit Ghaisas
On Tue, 29 Mar 2022 12:11:54 GMT, Robert Lichtenberger wrote: > > Have you considered keeping the same while loop in findSibling() method and > > skipping invisible Menus in it? This is to avoid creating and traversing a > > new list. > > This would not give the correct result. findSibling

Re: RFR: 8251480: TableColumnHeader: calc of cell width must respect row styling [v2]

2022-03-29 Thread Marius Hanl
On Thu, 24 Mar 2022 06:14:42 GMT, Robert Lichtenberger wrote: >> This fix respects a row factory, if present. >> It will put the cell that is used to measure the column width as child below >> the row. >> In that way the row's style will be used. > > Robert Lichtenberger has updated the pull

TextField in the main window steals the focus of the Windows emoji keyboard of another TextField in Popup

2022-03-29 Thread Glavo
When using MaterialFX, I encountered such a problem: When the focus of a window is on a TextField, another TextField in a Popup that pops up on this window cannot use the Windows emoji keyboard or IME for input. In this case, all input from the windows emoji keyboard or IME will go into the

Re: RFR: 8283402: Update to gcc 11.2 on Linux

2022-03-29 Thread Kevin Rushforth
On Fri, 25 Mar 2022 12:19:10 GMT, Kevin Rushforth wrote: > This patch updates the compiler to gcc 11.2 on Linux, in order to match JDK > 17 -- see [JDK-8283057](https://bugs.openjdk.java.net/browse/JDK-8283057). > > I ran a full build and test, including media and WebKit. > are there

Re: RFR: 8283402: Update to gcc 11.2 on Linux

2022-03-29 Thread Johan Vos
On Tue, 29 Mar 2022 11:50:32 GMT, Kevin Rushforth wrote: >> No, it will use whatever the latest is for GitHub actions. There doesn't >> seem to be an 11.2 package for GHA. It should be sufficient for most >> testing, but highlights one of the limitations of relying on GitHub Actions >> for

Integrated: 8280369: native library cache should be platform/arch specific

2022-03-29 Thread Glavo
On Fri, 25 Mar 2022 18:12:23 GMT, Glavo wrote: > Currently, OpenJFX extracts the native library into a local folder and loads > it when it is not part of the JRE. > > Now we have a notable problem with the fact that a platform may actually run > programs of multiple CPU architectures. > >

Re: RFR: 8283509: Invisible menus can lead to IndexOutOfBoundsException

2022-03-29 Thread Robert Lichtenberger
On Tue, 29 Mar 2022 09:23:24 GMT, Ajit Ghaisas wrote: > Have you considered keeping the same while loop in findSibling() method and > skipping invisible Menus in it? This is to avoid creating and traversing a > new list. This would not give the correct result. findSibling must return the

Integrated: 8283517: Update boot JDK to 18

2022-03-29 Thread Kevin Rushforth
On Fri, 25 Mar 2022 12:16:18 GMT, Kevin Rushforth wrote: > JDK 18 has been released, so we should update the default boot JDK used to > build JavaFX to JDK 18. This will not affect the minimum boot JDK version. I > have confirmed that gradle 7.3 works with JDK 18, so we don't need to update >

Re: RFR: 8283402: Update to gcc 11.2 on Linux

2022-03-29 Thread Kevin Rushforth
On Tue, 29 Mar 2022 11:49:14 GMT, Kevin Rushforth wrote: >> .github/workflows/submit.yml line 86: >> >>> 84: set -x >>> 85: sudo apt-get update >>> 86: sudo apt-get install libgl1-mesa-dev libx11-dev >>> libxxf86vm-dev libxt-dev pkg-config libgtk2.0-dev

Re: RFR: 8283402: Update to gcc 11.2 on Linux

2022-03-29 Thread Kevin Rushforth
On Tue, 29 Mar 2022 09:42:38 GMT, Johan Vos wrote: >> This patch updates the compiler to gcc 11.2 on Linux, in order to match JDK >> 17 -- see [JDK-8283057](https://bugs.openjdk.java.net/browse/JDK-8283057). >> >> I ran a full build and test, including media and WebKit. > >

Re: RFR: 8283517: Update boot JDK to 18

2022-03-29 Thread Johan Vos
On Fri, 25 Mar 2022 12:16:18 GMT, Kevin Rushforth wrote: > JDK 18 has been released, so we should update the default boot JDK used to > build JavaFX to JDK 18. This will not affect the minimum boot JDK version. I > have confirmed that gradle 7.3 works with JDK 18, so we don't need to update >

Re: RFR: 8283402: Update to gcc 11.2 on Linux

2022-03-29 Thread Johan Vos
On Fri, 25 Mar 2022 12:19:10 GMT, Kevin Rushforth wrote: > This patch updates the compiler to gcc 11.2 on Linux, in order to match JDK > 17 -- see [JDK-8283057](https://bugs.openjdk.java.net/browse/JDK-8283057). > > I ran a full build and test, including media and WebKit.

Re: RFR: 8280369: native library cache should be platform/arch specific

2022-03-29 Thread Johan Vos
On Fri, 25 Mar 2022 18:12:23 GMT, Glavo wrote: > Currently, OpenJFX extracts the native library into a local folder and loads > it when it is not part of the JRE. > > Now we have a notable problem with the fact that a platform may actually run > programs of multiple CPU architectures. > >

Re: RFR: 8283509: Invisible menus can lead to IndexOutOfBoundsException

2022-03-29 Thread Ajit Ghaisas
On Tue, 22 Mar 2022 14:42:07 GMT, Robert Lichtenberger wrote: > findSibling adapted to only use visible menus when calculating the > index. Have you considered keeping the same while loop in findSibling() method and skipping invisible Menus in it? This is to avoid creating and traversing a

Re: RFR: 8280369: native library cache should be platform/arch specific

2022-03-29 Thread Johan Vos
On Fri, 25 Mar 2022 18:12:23 GMT, Glavo wrote: > Currently, OpenJFX extracts the native library into a local folder and loads > it when it is not part of the JRE. > > Now we have a notable problem with the fact that a platform may actually run > programs of multiple CPU architectures. > >