Re: RFR: 8251480: TableColumnHeader: calc of cell width must respect row styling [v4]

2022-03-30 Thread Marius Hanl
On Wed, 30 Mar 2022 12:22:23 GMT, Robert Lichtenberger wrote: >> This fix respects a row factory, if present. >> It will put the cell that is used to measure the column width as child below >> the row. >> In that way the row's style will be used. > > Robert Lichtenberger has updated the pull

Re: Self built openjfx 17.0.2

2022-03-30 Thread Kevin Rushforth
No. What you want is the jfx17u repo. https://github.com/openjdk/jfx17u/tree/master If you look at the tags you will see 17.0.2+3 is the latest (GA) sources. -- Kevin On 3/30/2022 12:23 PM, Thiago Milczarek Sayão wrote: Hi, Does the "jfx17" branch contain the latest javafx 17.0.2 code ?

Self built openjfx 17.0.2

2022-03-30 Thread Thiago Milczarek Sayão
Hi, Does the "jfx17" branch contain the latest javafx 17.0.2 code ? https://github.com/openjdk/jfx/tree/jfx17 Also, I have built jmods of this branch with "gradlew jmodLinux" and the resulting jmods are quite bigger comparing to the released ones. I guess it's some debug symbols or something.

Re: RFR: 8277785: ListView scrollTo jumps to wrong location when CellHeight is changed [v3]

2022-03-30 Thread Johan Vos
On Fri, 25 Mar 2022 16:26:34 GMT, Kevin Rushforth wrote: > It looks like there are some failing unit tests now. I fixed them. - PR: https://git.openjdk.java.net/jfx/pull/712

Re: RFR: 8277785: ListView scrollTo jumps to wrong location when CellHeight is changed [v4]

2022-03-30 Thread Johan Vos
> When the size of a ListCell is changed and a scrollTo method is invoked > without having a layout calculation in between, the old (wrong) size is used > to calculcate the total estimate. This happens e.g. when the size is changed > in the `updateItem` method. > This PR will immediately resize

Integrated: 8283509: Invisible menus can lead to IndexOutOfBoundsException

2022-03-30 Thread Robert Lichtenberger
On Tue, 22 Mar 2022 14:42:07 GMT, Robert Lichtenberger wrote: > findSibling adapted to only use visible menus when calculating the > index. This pull request has now been integrated. Changeset: cff84e24 Author:Robert Lichtenberger Committer: Ajit Ghaisas URL:

Re: RFR: 8251480: TableColumnHeader: calc of cell width must respect row styling [v4]

2022-03-30 Thread Kevin Rushforth
On Wed, 30 Mar 2022 12:22:23 GMT, Robert Lichtenberger wrote: >> This fix respects a row factory, if present. >> It will put the cell that is used to measure the column width as child below >> the row. >> In that way the row's style will be used. > > Robert Lichtenberger has updated the pull

Re: RFR: 8251480: TableColumnHeader: calc of cell width must respect row styling [v4]

2022-03-30 Thread Robert Lichtenberger
> This fix respects a row factory, if present. > It will put the cell that is used to measure the column width as child below > the row. > In that way the row's style will be used. Robert Lichtenberger has updated the pull request incrementally with one additional commit since the last

Re: RFR: 8251480: TableColumnHeader: calc of cell width must respect row styling [v2]

2022-03-30 Thread Robert Lichtenberger
On Wed, 30 Mar 2022 12:10:19 GMT, Kevin Rushforth wrote: >> I found assertions in various other parts of the code (e.g. >> `javafx.scene.control.skin.VirtualFlow`) so I assumed this is ok. > > Some old code has assertions, but library code should not use them. Please > delete them from any new

Re: RFR: 8251480: TableColumnHeader: calc of cell width must respect row styling [v2]

2022-03-30 Thread Kevin Rushforth
On Wed, 30 Mar 2022 10:57:38 GMT, Robert Lichtenberger wrote: >> modules/javafx.controls/src/main/java/javafx/scene/control/skin/TableColumnHeader.java >> line 715: >> >>> 713: tableRow = createMeasureRow(tv, tableSkin, null); >>> 714: } >>> 715: assert

Re: RFR: 8283402: Update to gcc 11.2 on Linux

2022-03-30 Thread Kevin Rushforth
On Fri, 25 Mar 2022 12:19:10 GMT, Kevin Rushforth wrote: > This patch updates the compiler to gcc 11.2 on Linux, in order to match JDK > 17 -- see [JDK-8283057](https://bugs.openjdk.java.net/browse/JDK-8283057). > > I ran a full build and test, including media and WebKit. Given that the gcc

Re: RFR: 8283509: Invisible menus can lead to IndexOutOfBoundsException [v2]

2022-03-30 Thread Ajit Ghaisas
On Wed, 30 Mar 2022 10:57:48 GMT, Robert Lichtenberger wrote: >> findSibling adapted to only use visible menus when calculating the >> index. > > Robert Lichtenberger has updated the pull request incrementally with one > additional commit since the last revision: > > 8251480:

Re: RFR: 8283402: Update to gcc 11.2 on Linux

2022-03-30 Thread Ambarish Rapte
On Fri, 25 Mar 2022 12:19:10 GMT, Kevin Rushforth wrote: > This patch updates the compiler to gcc 11.2 on Linux, in order to match JDK > 17 -- see [JDK-8283057](https://bugs.openjdk.java.net/browse/JDK-8283057). > > I ran a full build and test, including media and WebKit. Build on Ubuntu

Re: RFR: 8251480: TableColumnHeader: calc of cell width must respect row styling [v3]

2022-03-30 Thread Robert Lichtenberger
> This fix respects a row factory, if present. > It will put the cell that is used to measure the column width as child below > the row. > In that way the row's style will be used. Robert Lichtenberger has updated the pull request incrementally with one additional commit since the last

Re: RFR: 8251480: TableColumnHeader: calc of cell width must respect row styling [v2]

2022-03-30 Thread Robert Lichtenberger
On Tue, 29 Mar 2022 20:35:10 GMT, Marius Hanl wrote: >> Robert Lichtenberger has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8251480: TableColumnHeader: calc of cell width must respect row styling >> >> Old behaviour restored for

Re: RFR: 8283509: Invisible menus can lead to IndexOutOfBoundsException [v2]

2022-03-30 Thread Robert Lichtenberger
> findSibling adapted to only use visible menus when calculating the > index. Robert Lichtenberger has updated the pull request incrementally with one additional commit since the last revision: 8251480: TableColumnHeader: calc of cell width must respect row styling Comment improved.

Re: RFR: 8283509: Invisible menus can lead to IndexOutOfBoundsException

2022-03-30 Thread Robert Lichtenberger
On Wed, 30 Mar 2022 04:48:30 GMT, Ajit Ghaisas wrote: > > Only one minor correction needed is in comment. Right. Just pushed a correction. - PR: https://git.openjdk.java.net/jfx/pull/759