Integrated: 8281564: Update cmake to 3.22.3

2022-04-05 Thread Ambarish Rapte
On Tue, 5 Apr 2022 04:54:55 GMT, Ambarish Rapte wrote: > Update cmake to 3.22.3 > Verified build on all three platforms. > The sanity test looks good. This pull request has now been integrated. Changeset: d960d639 Author:Ambarish Rapte URL:

Re: RFR: 8283786: Update to Visual Studio 2022 version 17.1.0 on Windows

2022-04-05 Thread Ambarish Rapte
On Sat, 2 Apr 2022 17:34:46 GMT, Kevin Rushforth wrote: > This patch updates the compiler to Visual Studio 2022 version 17.1.0 on > Windows, in order to match JDK 19 -- see > [JDK-8283723](https://bugs.openjdk.java.net/browse/JDK-8283723). > > I ran a full build and test, including media and

Re: RFR: 8281564: Update cmake to 3.22.3

2022-04-05 Thread Johan Vos
On Tue, 5 Apr 2022 04:54:55 GMT, Ambarish Rapte wrote: > Update cmake to 3.22.3 > Verified build on all three platforms. > The sanity test looks good. Marked as reviewed by jvos (Reviewer). - PR: https://git.openjdk.java.net/jfx/pull/767

Re: RFR: 8283786: Update to Visual Studio 2022 version 17.1.0 on Windows

2022-04-05 Thread Kevin Rushforth
On Mon, 4 Apr 2022 11:14:27 GMT, Joeri Sykora wrote: > Which versions were chosen for the build tools, redistributables and the CRT? > Do we still use the same ones as with Visual Studio 2019? Each version of Visual Studio has its own set of compilers and redistributables. Visual Studio 2022

Re: RFR: 8281564: Update cmake to 3.22.3

2022-04-05 Thread Kevin Rushforth
On Tue, 5 Apr 2022 04:54:55 GMT, Ambarish Rapte wrote: > Update cmake to 3.22.3 > Verified build on all three platforms. > The sanity test looks good. Looks good. - Marked as reviewed by kcr (Lead). PR: https://git.openjdk.java.net/jfx/pull/767

Integrated: 8251480: TableColumnHeader: calc of cell width must respect row styling

2022-04-05 Thread Robert Lichtenberger
On Wed, 16 Mar 2022 08:20:59 GMT, Robert Lichtenberger wrote: > This fix respects a row factory, if present. > It will put the cell that is used to measure the column width as child below > the row. > In that way the row's style will be used. This pull request has now been integrated.

Re: RFR: 8251480: TableColumnHeader: calc of cell width must respect row styling [v4]

2022-04-05 Thread Ajit Ghaisas
On Wed, 30 Mar 2022 12:22:23 GMT, Robert Lichtenberger wrote: >> This fix respects a row factory, if present. >> It will put the cell that is used to measure the column width as child below >> the row. >> In that way the row's style will be used. > > Robert Lichtenberger has updated the pull