Integrated: 8285034: Skip ServiceTest.testManyServicesRunConcurrently on Windows

2022-04-21 Thread Ambarish Rapte
On Thu, 21 Apr 2022 15:44:57 GMT, Ambarish Rapte wrote: > The test ServiceTest.testManyServicesRunConcurrently fails intermittently on > Windows platform with a time out error. > Test needs to be skipped until fixed. This pull request has now been integrated. Changeset: 5a023bd8 Author:

Integrated: 8282449: Intermittent OOM error in PredefinedMeshManagerTest

2022-04-21 Thread Ambarish Rapte
On Thu, 21 Apr 2022 15:07:38 GMT, Ambarish Rapte wrote: > This is a test only fix. The tests used to create Sphere and Cylinder of > large divisions, which could fail intermittently with OOM. > The tests were added along with the fix for >

Re: RFR: 8278430 : Several tests use terminally deprecated System.runFinalization method

2022-04-21 Thread Kevin Rushforth
On Thu, 21 Apr 2022 15:03:04 GMT, Hima Bindu Meda wrote: > This PR is to remove calls to deprecated method System.runFinalization. > Here is the list of module wise test cases affected by the removal: > > **web**: > test.javafx.scene.web.LeakTest > > **systemTests**: >

Integrated: 8283218: Update GStreamer to 1.20.1

2022-04-21 Thread Alexander Matveev
On Fri, 8 Apr 2022 06:49:59 GMT, Alexander Matveev wrote: > - GStreamer updated to 1.20.1 and GLib updated to 2.72.0. > - No changes to our code, except in GstAudioSpectrum.cpp > g_atomic_pointer_compare_and_exchange() was changed to > g_atomic_pointer_set(). For some reason I was not able to

Re: RFR: 8282449: Intermittent OOM error in PredefinedMeshManagerTest

2022-04-21 Thread Kevin Rushforth
On Thu, 21 Apr 2022 15:07:38 GMT, Ambarish Rapte wrote: > This is a test only fix. The tests used to create Sphere and Cylinder of > large divisions, which could fail intermittently with OOM. > The tests were added along with the fix for >

Re: RFR: 8285034: Skip ServiceTest.testManyServicesRunConcurrently on Windows

2022-04-21 Thread Kevin Rushforth
On Thu, 21 Apr 2022 15:44:57 GMT, Ambarish Rapte wrote: > The test ServiceTest.testManyServicesRunConcurrently fails intermittently on > Windows platform with a time out error. > Test needs to be skipped until fixed. LGTM - Marked as reviewed by kcr (Lead). PR:

Re: RFR: 8283218: Update GStreamer to 1.20.1 [v5]

2022-04-21 Thread Kevin Rushforth
On Wed, 20 Apr 2022 23:08:00 GMT, Alexander Matveev wrote: >> - GStreamer updated to 1.20.1 and GLib updated to 2.72.0. >> - No changes to our code, except in GstAudioSpectrum.cpp >> g_atomic_pointer_compare_and_exchange() was changed to >> g_atomic_pointer_set(). For some reason I was not

Re: RFR: 8283218: Update GStreamer to 1.20.1 [v5]

2022-04-21 Thread Johan Vos
On Wed, 20 Apr 2022 23:08:00 GMT, Alexander Matveev wrote: >> - GStreamer updated to 1.20.1 and GLib updated to 2.72.0. >> - No changes to our code, except in GstAudioSpectrum.cpp >> g_atomic_pointer_compare_and_exchange() was changed to >> g_atomic_pointer_set(). For some reason I was not

RFR: 8285034: Skip ServiceTest.testManyServicesRunConcurrently on Windows

2022-04-21 Thread Ambarish Rapte
The test ServiceTest.testManyServicesRunConcurrently fails intermittently on Windows platform with a time out error. Test needs to be skipped until fixed. - Commit messages: - skip-test Changes: https://git.openjdk.java.net/jfx/pull/783/files Webrev:

RFR: 8282449: Intermittent OOM error in PredefinedMeshManagerTest

2022-04-21 Thread Ambarish Rapte
This is a test only fix. The tests used to create Sphere and Cylinder of large divisions, which could fail intermittently with OOM. The tests were added along with the fix for [JDK-8180151](https://bugs.openjdk.java.net/browse/JDK-8180151). The attributes of Sphere and Cylinder were chosen such

RFR: 8278430 : Several tests use terminally deprecated System.runFinalization method

2022-04-21 Thread Hima Bindu Meda
This PR is to remove calls to deprecated method System.runFinalization. Here is the list of module wise test cases affected by the removal: **web**: test.javafx.scene.web.LeakTest **systemTests**: test.memoryleak.JSCallbackMemoryTest test.javafx.embed.swing.SwingNodeDnDMemoryLeakTest

Not finding installed font family on Windows

2022-04-21 Thread Rony G. Flatscher
Having installed the "IBM Plex" (otf) fonts (e.g. a file like "IBMPlexMono-Text.otf") to the global Windows font directory at "C:\Windows\Fonts" (%windir%\Fonts) the font family "IBM Plex Mono" and the like does not get listed with "javafx.scene.text.Font.getFamilies()". Using

Question ad css' -fx-font-family

2022-04-21 Thread Rony G. Flatscher
Not sure whether these are bugs or working as intended: * setting in a css "-fx-font-family" to:     -fx-font-family: "IBM Plex Mono","Liberation Mono",Consolas,Monaco,Terminus,Courier,monospace; If the first listed font is not found then JavaFX uses the "family=System" rather than

RFR: 8285360: [TestBug] Cleanup a few ignored javafx.controls unit tests

2022-04-21 Thread Ajit Ghaisas
This PR is to cleanup a few `javafx.controls` unit tests that were ignored. Here is the list of targeted unit test classes- - Ignored tests re-enabled and fixed - `DateCellTest`, `CellTest`, `PaginationTest` - Ignored tests removed - `RadioMenuItemTest`, `PopupControlTest` Results of

RFR: 8285197: TableColumnHeader: calc of cell width must respect row styling (TreeTableView)

2022-04-21 Thread Robert Lichtenberger
Separate test class added for TreeTableView case. Fix is analogous to JDK-8251480. - Commit messages: - 8285197: TableColumnHeader: calc of cell width must respect row styling (TreeTableView) Changes: https://git.openjdk.java.net/jfx/pull/779/files Webrev:

Re: RFR: 8193442: Removing TreeItem from a TreeTableView sometime changes selectedItem [v3]

2022-04-21 Thread Jose Pereda
> This PR fixes > JDK-[8193442](https://bugs.openjdk.java.net/browse/JDK-8193442), but also > [JDK-8187596](https://bugs.openjdk.java.net/browse/JDK-8187596), and verifies > that the tests mentioned in > [JDK-8088157](https://bugs.openjdk.java.net/browse/JDK-8088157) are working > (with a