Integrated: 8285217: [Android] Window's screen is not updated after native screen was disposed

2022-05-10 Thread Jose Pereda
On Wed, 20 Apr 2022 18:26:06 GMT, Jose Pereda wrote: > This PR updates the screen for each window even for the case where the old > screen has been disposed but there is a new screen instance found for such > window. > > This is the case of Android, where the lifecycle of the application

RFR: 8286552: TextFormatter: UpdateValue/UpdateText is called, when no ValueConverter is set

2022-05-10 Thread Marius Hanl
A common reason for using the `TextFormatter` is the need for a `filter`. Therefore, the following constructor is typically used: `public TextFormatter(@NamedArg("filter") UnaryOperator filter) { ... }` With that, no `valueConverter` is set in the `TextFormatter`. When a `TextField` will commit

What can I do with the GStreamer bundled in JavaFX? Can I record the screen?

2022-05-10 Thread Davide Perini
Hi all, I haven't understood what part of GStreamer is included in JavaFX. Can I record the screen with it using d3d11screencapturesrc or ximagesrc? Thanks Davide

Re: RFR: 8285197: TableColumnHeader: calc of cell width must respect row styling (TreeTableView)

2022-05-10 Thread Marius Hanl
On Thu, 21 Apr 2022 08:38:20 GMT, Robert Lichtenberger wrote: > Separate test class added for TreeTableView case. > Fix is analogous to JDK-8251480. Looks good! Verified that the fix works. I can also confirm, that this fix is the same as previously done for `TableView` in PR:

Integrated: 8283869: Update attribution in webkit.md file

2022-05-10 Thread Kevin Rushforth
On Tue, 10 May 2022 16:37:57 GMT, Kevin Rushforth wrote: > Doc-only change to update the license attribution in our `webkit.md` file. This pull request has now been integrated. Changeset: 7bb48194 Author:Kevin Rushforth URL:

Re: RFR: 8283869: Update attribution in webkit.md file

2022-05-10 Thread Ambarish Rapte
On Tue, 10 May 2022 16:37:57 GMT, Kevin Rushforth wrote: > Doc-only change to update the license attribution in our `webkit.md` file. LGTM - Marked as reviewed by arapte (Reviewer). PR: https://git.openjdk.java.net/jfx/pull/793

RFR: 8283869: Update attribution in webkit.md file

2022-05-10 Thread Kevin Rushforth
Doc-only change to update the license attribution in our `webkit.md` file. - Commit messages: - 8283869: Update attribution in webkit.md file Changes: https://git.openjdk.java.net/jfx/pull/793/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx=793=00 Issue:

Re: [jfx17u] RFR: 8283218: Update GStreamer to 1.20.1

2022-05-10 Thread Kevin Rushforth
On Mon, 9 May 2022 21:07:39 GMT, Kevin Rushforth wrote: > Almost clean backport to `jfx17u`. Tested in connection with libffi update in > the `test-kcr-17.0.4` branch. > > The only difference from the mainline patch is that the following file is not > present in `jfx17u`, so that part of the

[jfx17u] Integrated: 8280275: JUnit5 tests using Assumptions API fail to compile in some cases

2022-05-10 Thread Kevin Rushforth
On Mon, 9 May 2022 21:20:29 GMT, Kevin Rushforth wrote: > This PR is dependent on #58 so it is in Draft for now. Once #58 is > integrated, I will rebase this and submit it, at which time it will be a > clean backport, and the diffs will only show the updated test and build > changes

Re: RFR: 8285217: [Android] Window's screen is not updated after native screen was disposed [v4]

2022-05-10 Thread Johan Vos
On Tue, 10 May 2022 15:19:58 GMT, Jose Pereda wrote: >> This PR updates the screen for each window even for the case where the old >> screen has been disposed but there is a new screen instance found for such >> window. >> >> This is the case of Android, where the lifecycle of the application

Re: RFR: 8285217: [Android] Window's screen is not updated after native screen was disposed [v4]

2022-05-10 Thread Jose Pereda
> This PR updates the screen for each window even for the case where the old > screen has been disposed but there is a new screen instance found for such > window. > > This is the case of Android, where the lifecycle of the application allows > destroying the native screen when the app goes to

[jfx17u] RFR: 8280275: JUnit5 tests using Assumptions API fail to compile in some cases

2022-05-10 Thread Kevin Rushforth
This PR is dependent on #58 so it is in Draft for now. Once #58 is integrated, I will rebase this and submit it, at which time it will be a clean backport, and the diffs will only show the updated test and build changes associated with just this fix. - Commit messages: - 8280275:

Re: RFR: 8284654: Modal behavior returns to wrong stage [v3]

2022-05-10 Thread Thiago Milczarek Sayao
On Tue, 10 May 2022 12:56:53 GMT, Thiago Milczarek Sayao wrote: >> When there's an APPLICATION_MODAL window, all other windows are disabled and >> re-enabled when the APPLICATION_MODAL window closes. This causes >> `requestToFront()` to be called on every window, and it does not guarantee >>

[jfx17u] Integrated: 8276142: Update gradle to version 7.3

2022-05-10 Thread Kevin Rushforth
On Mon, 9 May 2022 21:14:23 GMT, Kevin Rushforth wrote: > Clean backport to `jfx17u`. This pull request has now been integrated. Changeset: be207ddb Author:Kevin Rushforth URL: https://git.openjdk.java.net/jfx17u/commit/be207ddb7249b369a028bc6fb6985adda7841648 Stats: 227 lines

[jfx17u] Integrated: 8276174: JavaFX build fails on macOS aarch64

2022-05-10 Thread Kevin Rushforth
On Mon, 9 May 2022 21:22:04 GMT, Kevin Rushforth wrote: > Clean backport to `jfx17u` so we can build on macOS / aarch64 without needing > to specify `-PCOMPILE_TARGET=arm64`. This pull request has now been integrated. Changeset: a5edae13 Author:Kevin Rushforth URL:

[jfx17u] Integrated: 8273998: Clarify specification for Window properties controlled by the window manager

2022-05-10 Thread Kevin Rushforth
On Mon, 9 May 2022 21:15:34 GMT, Kevin Rushforth wrote: > Clean backport to `jfx17u`. This pull request has now been integrated. Changeset: bdb8d28e Author:Kevin Rushforth URL: https://git.openjdk.java.net/jfx17u/commit/bdb8d28ecc7bb10278a9a8385da79b5f5652bb09 Stats: 84 lines

Re: RFR: 8284654: Modal behavior returns to wrong stage [v3]

2022-05-10 Thread Thiago Milczarek Sayao
> When there's an APPLICATION_MODAL window, all other windows are disabled and > re-enabled when the APPLICATION_MODAL window closes. This causes > `requestToFront()` to be called on every window, and it does not guarantee > order. > > The fix also works for: >

[jfx17u] Integrated: 8274274: Update JUnit to version 5.8.1

2022-05-10 Thread Kevin Rushforth
On Mon, 9 May 2022 21:18:07 GMT, Kevin Rushforth wrote: > Clean backport to `jfx17u`. This pull request has now been integrated. Changeset: 2ab0e82e Author:Kevin Rushforth URL: https://git.openjdk.java.net/jfx17u/commit/2ab0e82ee9cf2516b32914e2df4725becf8a2664 Stats: 161 lines

[jfx17u] Integrated: 8281564: Update cmake to 3.22.3

2022-05-10 Thread Kevin Rushforth
On Mon, 9 May 2022 21:13:07 GMT, Kevin Rushforth wrote: > Clean backport to `jfx17u`. Tested along with the rest of the fixes in the > `test-kcr-17.0.4` branch. This pull request has now been integrated. Changeset: 684c80fc Author:Kevin Rushforth URL:

Re: RFR: 8261221: Tooltip bigger than screen size blinks - shows and hides over and over again

2022-05-10 Thread Paweł Kruszczyński
On Wed, 17 Feb 2021 18:50:54 GMT, Kevin Rushforth wrote: >> `Tooltip` is no longer hiding upon receiving >> `MouseEvent.MOUSE_ENTERED_TARGET` event inside it. Pressing mouse on >> overlaying tooltip also kills the tooltip, so the infinite duration tooltip >> can be closed. > > One more

Re: RFR: 8261221: Tooltip bigger than screen size blinks - shows and hides over and over again [v3]

2022-05-10 Thread Paweł Kruszczyński
> `Tooltip` is no longer hiding upon receiving > `MouseEvent.MOUSE_ENTERED_TARGET` event inside it. Pressing mouse on > overlaying tooltip also kills the tooltip, so the infinite duration tooltip > can be closed. Paweł Kruszczyński has updated the pull request with a new target base due to a

Re: RFR: 8284654: Modal behavior returns to wrong stage [v2]

2022-05-10 Thread Ambarish Rapte
On Mon, 9 May 2022 14:54:55 GMT, Thiago Milczarek Sayao wrote: >> When there's an APPLICATION_MODAL window, all other windows are disabled and >> re-enabled when the APPLICATION_MODAL window closes. This causes >> `requestToFront()` to be called on every window, and it does not guarantee >>

Re: RFR: 8285217: [Android] Window's screen is not updated after native screen was disposed [v3]

2022-05-10 Thread Johan Vos
On Wed, 4 May 2022 16:55:30 GMT, Jose Pereda wrote: >> This PR updates the screen for each window even for the case where the old >> screen has been disposed but there is a new screen instance found for such >> window. >> >> This is the case of Android, where the lifecycle of the application

Re: RFR: 8285217: [Android] Window's screen is not updated after native screen was disposed [v3]

2022-05-10 Thread Johan Vos
On Wed, 4 May 2022 16:55:30 GMT, Jose Pereda wrote: >> This PR updates the screen for each window even for the case where the old >> screen has been disposed but there is a new screen instance found for such >> window. >> >> This is the case of Android, where the lifecycle of the application