Re: [10] Review request for 8185634, 8185634: Java Fx-Swing dialogs appearing behind main stage

[Alexander Zvegintsev]

HI Semyon,

Please see my answer to Dmitry


Hi Dmitry,

 From my understanding JavaFX stage can't be easily integrated in JDK to 
support orderWindow() approach,

addChildWindow() is a native(and the simplest) way to maintain one window above 
other one, should be called only once.

IIUC the main concert of JDK-8080729 that child windows jumping to parent's 
display upon focus receiving, this is not an issue with current fix,

because addChildWindow() will be called only upon dialog creation in case of 
JavaFX-Swing interop.

Jump may happen if user want to create a child swing dialog on display other 
than JavaFX stage's one,

but such rare scenario can be easily workarounded on a user side by calling 
setLocation() right after setVisible() call.

So I would prefer to use addChildWindow() to make this fix as simple as 
possible.


Thanks,
Alexander.

On 08/11/2017 02:45, Semyon Sadetsky wrote:


Hi Alexander,

In CPlatformWindow.java change you used addChildWindow(), but we get 
rig of addChildWindow() in 8080729 and start to manage windows order 
on java side. Can you test that this change doesn't cause any ordering 
issues with modal and non-modal child and sibling windows on mac?


--Semyon

On 11/07/2017 10:11 AM, Alexander Zvegintsev wrote:


Hi Sergey,

I am not able to crash it on several platforms, except one case:

if we are terminating JavaFX application while EDT processing some 
long task. But it is unrelated to the fix and reproducible on current 
builds.


I've filed a separate bug JDK-8190329 
<https://bugs.openjdk.java.net/browse/JDK-8190329>.


Will the current fix cover the native dialogs like 
FileDialog/PrintDialog on linux and windows? 
It will not, Windows already fixed by JDK-8088395 
<https://bugs.openjdk.java.net/browse/JDK-8088395>



Test added:
http://cr.openjdk.java.net/~azvegint/jdk/10/8185634/05/
Thanks,
Alexander.
On 13/10/2017 01:14, Sergey Bylokhov wrote:

Looks fine.
I am not sure but it looks like the fix has an assumption that the 
CPlatformWindow.setVisible() code will be executed on EDT/Appkit but 
it is not the case. This code can be executed on any 
thread(intentionally for crash), and it will be good to check that 
it works as expected by some stress test which will try to force the 
possible crash: 4 threads:

 - show/dispose Swing Node
 - show/dispose Dialog1/2/3 using different timeouts

Will the current fix cover the native dialogs like 
FileDialog/PrintDialog on linux and windows?


On 10/10/2017 13:54, Kevin Rushforth wrote:

Note that there is now a 04 version.

It looks good to me, although someone more familiar with AWT should 
also check the AWT changes.


We will need a test program for this (as a follow-on issue if not 
now).


-- Kevin


Alexander Zvegintsev wrote:

Please review the updated version

http://cr.openjdk.java.net/~azvegint/jdk/10/8185634/02/
Now we are postponing actual window closing, it happens only after 
we ensure that native window pointer is valid on Swing side.


Thanks,
Alexander.

On 23/09/2017 08:01, Sergey Bylokhov wrote:

Hi, Alexander.
How can we be sure that the parent frame will not be disposed 
while we use a pointer?


long ownerWindowPtr = peer.getOverridenWindowHandle();
<<<<< Dispose the peer
if (ownerWindowPtr != 0) {
    //Place window above JavaFX stage
    CWrapper.NSWindow.addChildWindow(
    ownerWindowPtr, ptr, CWrapper.NSWindow.NSWindowAbove);
<<<<< Boom
}


On 9/21/17 22:56, Alexander Zvegintsev wrote:

Hi Phil,

Please review the updated fix with reflection incorporated
http://cr.openjdk.java.net/~azvegint/jdk/10/8185634/01/

New issue created JDK-8187803 
<https://bugs.openjdk.java.net/browse/JDK-8187803> as JDK 
counterpart of this issue.


Thanks,
Alexander.

On 21/09/2017 22:25, Phil Race wrote:

Some procedural comments :
Since 90% of this is in AWT code, I'd have thought awt-dev 
should be included here.

I've added that list.

And apart from needing separate bug ids, I don't see why the 
bug below is confidential.



I agree with what Kevin pointed out off-line that as in the 
dialog case, the FX side
of the code can use reflection and simply be a harmless 
non-functional no-op

if the SwingAccessor does not provide the new method.

BTW
264 inline HWND GetOverridenHWnd() { return m_overridenHwnd; }
should be "dd" not "d".

-phil.

On 09/21/2017 03:38 AM, Alexander Zvegintsev wrote:

Hello,

please review the fix

http://cr.openjdk.java.net/~azvegint/jdk/10/8185634/00/

for the issue

https://bugs.openjdk.java.net/browse/JDK-8185634

Re: [10] Review request for 8185634, 8185634: Java Fx-Swing dialogs appearing behind main stage

[Alexander Zvegintsev]

Hi Sergey,

I am not able to crash it on several platforms, except one case:

if we are terminating JavaFX application while EDT processing some long 
task. But it is unrelated to the fix and reproducible on current builds.


I've filed a separate bug JDK-8190329 
<https://bugs.openjdk.java.net/browse/JDK-8190329>.


Will the current fix cover the native dialogs like 
FileDialog/PrintDialog on linux and windows? 
It will not, Windows already fixed by JDK-8088395 
<https://bugs.openjdk.java.net/browse/JDK-8088395>



Test added:
http://cr.openjdk.java.net/~azvegint/jdk/10/8185634/05/

Thanks,
Alexander.

On 13/10/2017 01:14, Sergey Bylokhov wrote:

Looks fine.
I am not sure but it looks like the fix has an assumption that the 
CPlatformWindow.setVisible() code will be executed on EDT/Appkit but 
it is not the case. This code can be executed on any 
thread(intentionally for crash), and it will be good to check that it 
works as expected by some stress test which will try to force the 
possible crash: 4 threads:

 - show/dispose Swing Node
 - show/dispose Dialog1/2/3 using different timeouts

Will the current fix cover the native dialogs like 
FileDialog/PrintDialog on linux and windows?


On 10/10/2017 13:54, Kevin Rushforth wrote:

Note that there is now a 04 version.

It looks good to me, although someone more familiar with AWT should 
also check the AWT changes.


We will need a test program for this (as a follow-on issue if not now).

-- Kevin


Alexander Zvegintsev wrote:

Please review the updated version

http://cr.openjdk.java.net/~azvegint/jdk/10/8185634/02/
Now we are postponing actual window closing, it happens only after 
we ensure that native window pointer is valid on Swing side.


Thanks,
Alexander.

On 23/09/2017 08:01, Sergey Bylokhov wrote:

Hi, Alexander.
How can we be sure that the parent frame will not be disposed while 
we use a pointer?


long ownerWindowPtr = peer.getOverridenWindowHandle();
<<<<< Dispose the peer
if (ownerWindowPtr != 0) {
    //Place window above JavaFX stage
    CWrapper.NSWindow.addChildWindow(
    ownerWindowPtr, ptr, CWrapper.NSWindow.NSWindowAbove);
<<<<< Boom
}


On 9/21/17 22:56, Alexander Zvegintsev wrote:

Hi Phil,

Please review the updated fix with reflection incorporated
http://cr.openjdk.java.net/~azvegint/jdk/10/8185634/01/

New issue created JDK-8187803 
<https://bugs.openjdk.java.net/browse/JDK-8187803> as JDK 
counterpart of this issue.


Thanks,
Alexander.

On 21/09/2017 22:25, Phil Race wrote:

Some procedural comments :
Since 90% of this is in AWT code, I'd have thought awt-dev should 
be included here.

I've added that list.

And apart from needing separate bug ids, I don't see why the bug 
below is confidential.



I agree with what Kevin pointed out off-line that as in the 
dialog case, the FX side
of the code can use reflection and simply be a harmless 
non-functional no-op

if the SwingAccessor does not provide the new method.

BTW
264 inline HWND GetOverridenHWnd() { return m_overridenHwnd; }
should be "dd" not "d".

-phil.

On 09/21/2017 03:38 AM, Alexander Zvegintsev wrote:

Hello,

please review the fix

http://cr.openjdk.java.net/~azvegint/jdk/10/8185634/00/

for the issue

https://bugs.openjdk.java.net/browse/JDK-8185634

[10] Review request for 8181406: [linux] Stage resizing bug

[Alexander Zvegintsev]

Hi all,

please review the fix

http://cr.openjdk.java.net/~azvegint/jdk/10/8181406/00/

for the issue

https://bugs.openjdk.java.net/browse/JDK-8181406

--
Thanks,

Alexander.

Re: CFV: New OpenJFX Committer: Ambarish Rapte

[Alexander Zvegintsev]

Vote: yes

Thanks,
Alexander.

On 01/11/2017 01:48, Kevin Rushforth wrote:

I hereby nominate Ambarish Rapte [1] to OpenJFX Committer.

Ambarish is a member of JavaFX team at Oracle, who has contributed 10 
changesets [2][3] to OpenJFX.


Votes are due by November 14, 2017.

Only current OpenJFX Committers [4] are eligible to vote on this 
nomination. Votes must be cast in the open by replying to this mailing 
list.


For Lazy Consensus voting instructions, see [5]. Nomination to a 
project Committer is described in [6].


Thanks.

-- Kevin

[1] http://openjdk.java.net/census#arapte

[2] 
http://hg.openjdk.java.net/openjfx/10-dev/rt/log?revcount=20=author%28arapte%29

[3] http://hg.openjdk.java.net/openjfx/10-dev/rt/rev/f7d38650fa15

[4] http://openjdk.java.net/census#openjfx

[5] http://openjdk.java.net/bylaws#lazy-consensus

[6] http://openjdk.java.net/projects#project-committer

[10] Review request for 8165562: Upgrade to newer version of SWT for build/test

[Alexander Zvegintsev]

Hello,

please review the fix

http://cr.openjdk.java.net/~azvegint/jdk/10/8165562/00/

for the issue

https://bugs.openjdk.java.net/browse/JDK-8165562

--
Thanks,
Alexander.

[10] Review request 8185827: SEGV in com.sun.glass.ui.mac.MacCommonDialogs.

[Alexander Zvegintsev]

Hello,

please review the fix

http://cr.openjdk.java.net/~azvegint/jdk/10/8185827/01/

for the issue

https://bugs.openjdk.java.net/browse/JDK-8185827

--
Thanks,
Alexander.

Re: [10] Review request for 8185634, 8185634: Java Fx-Swing dialogs appearing behind main stage

[Alexander Zvegintsev]

Please review the updated version

http://cr.openjdk.java.net/~azvegint/jdk/10/8185634/02/
Now we are postponing actual window closing, it happens only after we 
ensure that native window pointer is valid on Swing side.


Thanks,
Alexander.

On 23/09/2017 08:01, Sergey Bylokhov wrote:

Hi, Alexander.
How can we be sure that the parent frame will not be disposed while we 
use a pointer?


long ownerWindowPtr = peer.getOverridenWindowHandle();
<<<<< Dispose the peer
if (ownerWindowPtr != 0) {
    //Place window above JavaFX stage
    CWrapper.NSWindow.addChildWindow(
    ownerWindowPtr, ptr, CWrapper.NSWindow.NSWindowAbove);
<<<<< Boom
}


On 9/21/17 22:56, Alexander Zvegintsev wrote:

Hi Phil,

Please review the updated fix with reflection incorporated
http://cr.openjdk.java.net/~azvegint/jdk/10/8185634/01/

New issue created JDK-8187803 
<https://bugs.openjdk.java.net/browse/JDK-8187803> as JDK counterpart 
of this issue.


Thanks,
Alexander.

On 21/09/2017 22:25, Phil Race wrote:

Some procedural comments :
Since 90% of this is in AWT code, I'd have thought awt-dev should be 
included here.

I've added that list.

And apart from needing separate bug ids, I don't see why the bug 
below is confidential.



I agree with what Kevin pointed out off-line that as in the dialog 
case, the FX side
of the code can use reflection and simply be a harmless 
non-functional no-op

if the SwingAccessor does not provide the new method.

BTW
264 inline HWND GetOverridenHWnd() { return m_overridenHwnd; }
should be "dd" not "d".

-phil.

On 09/21/2017 03:38 AM, Alexander Zvegintsev wrote:

Hello,

please review the fix

http://cr.openjdk.java.net/~azvegint/jdk/10/8185634/00/

for the issue

https://bugs.openjdk.java.net/browse/JDK-8185634

Re: CFV: New OpenJFX Committer: Prasanta Sadhukhan

[Alexander Zvegintsev]

Vote: YES

Thanks,
Alexander.

On 28/09/2017 06:40, Kevin Rushforth wrote:

I hereby nominate Prasanta Sadhukhan [1] to OpenJFX Committer.

Prasanta is a member of JavaFX team at Oracle, who has contributed 12 
changesets [2] to OpenJFX.


Votes are due by October 11, 2017.

Only current OpenJFX Committers [3] are eligible to vote on this 
nomination. Votes must be cast in the open by replying to this mailing 
list.


For Lazy Consensus voting instructions, see [4]. Nomination to a 
project Committer is described in [5].


Thanks.

-- Kevin

[1] http://openjdk.java.net/census#psadhukhan

[2] 
http://hg.openjdk.java.net/openjfx/10-dev/rt/log?revcount=20=author%28psadhukhan%29


[3] http://openjdk.java.net/census#openjfx

[4] http://openjdk.java.net/bylaws#lazy-consensus

[5] http://openjdk.java.net/projects#project-committer

Re: [10] Review request for 8185634, 8185634: Java Fx-Swing dialogs appearing behind main stage

[Alexander Zvegintsev]

Hi Sergey,

Thanks for catching this, this is an issue which should be addressed.

Thanks,
Alexander.

On 23/09/2017 08:01, Sergey Bylokhov wrote:

Hi, Alexander.
How can we be sure that the parent frame will not be disposed while we 
use a pointer?


long ownerWindowPtr = peer.getOverridenWindowHandle();
<<<<< Dispose the peer
if (ownerWindowPtr != 0) {
    //Place window above JavaFX stage
    CWrapper.NSWindow.addChildWindow(
    ownerWindowPtr, ptr, CWrapper.NSWindow.NSWindowAbove);
<<<<< Boom
}


On 9/21/17 22:56, Alexander Zvegintsev wrote:

Hi Phil,

Please review the updated fix with reflection incorporated
http://cr.openjdk.java.net/~azvegint/jdk/10/8185634/01/

New issue created JDK-8187803 
<https://bugs.openjdk.java.net/browse/JDK-8187803> as JDK counterpart 
of this issue.


Thanks,
Alexander.

On 21/09/2017 22:25, Phil Race wrote:

Some procedural comments :
Since 90% of this is in AWT code, I'd have thought awt-dev should be 
included here.

I've added that list.

And apart from needing separate bug ids, I don't see why the bug 
below is confidential.



I agree with what Kevin pointed out off-line that as in the dialog 
case, the FX side
of the code can use reflection and simply be a harmless 
non-functional no-op

if the SwingAccessor does not provide the new method.

BTW
264 inline HWND GetOverridenHWnd() { return m_overridenHwnd; }
should be "dd" not "d".

-phil.

On 09/21/2017 03:38 AM, Alexander Zvegintsev wrote:

Hello,

please review the fix

http://cr.openjdk.java.net/~azvegint/jdk/10/8185634/00/

for the issue

https://bugs.openjdk.java.net/browse/JDK-8185634

Re: [10] Review request for 8185634, 8185634: Java Fx-Swing dialogs appearing behind main stage

[Alexander Zvegintsev]

Hi Dmitry,

From my understanding JavaFX stage can't be easily integrated in JDK to 
support orderWindow() approach,


addChildWindow() is a native(and the simplest) way to maintain one 
window above other one, should be called only once.


IIUC the main concert of JDK-8080729 that child windows jumping to 
parent's display upon focus receiving, this is not an issue with current 
fix,


because addChildWindow() will be called only upon dialog creation in 
case of JavaFX-Swing interop.


Jump may happen if user want to create a child swing dialog on display 
other than JavaFX stage's one,


but such rare scenario can be easily workarounded on a user side by 
calling setLocation() right after setVisible() call.


So I would prefer to use addChildWindow() to make this fix as simple as 
possible.



Thanks,
Alexander.

On 23/09/2017 21:21, Dmitry Markov wrote:

Hi Alexander,

In CPlatformWindow class you call CWrapper.NSWindow.addChildWindow() to place a 
window above JavaFX stage. The usage of addChilWindow() or/and 
removeChildWindow() may cause ‘jumping window issue’ in multi-monitor 
environment, see JDK-8080729 for more details.

To avoid possible problems in multi monitor set-up I suggest that you should 
replace addChildWindow() with orderWindow() or use some another approach to 
locate the window above the stage.

Thanks,
Dmitry

On 22 Sep 2017, at 06:56, Alexander Zvegintsev 
<alexander.zvegint...@oracle.com> wrote:

Hi Phil,

Please review the updated fix with reflection incorporated
http://cr.openjdk.java.net/~azvegint/jdk/10/8185634/01/

New issue created JDK-8187803 
<https://bugs.openjdk.java.net/browse/JDK-8187803> as JDK counterpart of this 
issue.

Thanks,
Alexander.

On 21/09/2017 22:25, Phil Race wrote:

Some procedural comments :
Since 90% of this is in AWT code, I'd have thought awt-dev should be included 
here.
I've added that list.

And apart from needing separate bug ids, I don't see why the bug below is 
confidential.


I agree with what Kevin pointed out off-line that as in the dialog case, the FX 
side
of the code can use reflection and simply be a harmless non-functional no-op
if the SwingAccessor does not provide the new method.

BTW
264 inline HWND GetOverridenHWnd() { return m_overridenHwnd; }
should be "dd" not "d".

-phil.

On 09/21/2017 03:38 AM, Alexander Zvegintsev wrote:

Hello,

please review the fix

http://cr.openjdk.java.net/~azvegint/jdk/10/8185634/00/

for the issue

https://bugs.openjdk.java.net/browse/JDK-8185634

Re: [10] Review request for 8185634, 8185634: Java Fx-Swing dialogs appearing behind main stage

[Alexander Zvegintsev]

Hi Phil,

Please review the updated fix with reflection incorporated
http://cr.openjdk.java.net/~azvegint/jdk/10/8185634/01/

New issue created JDK-8187803 
<https://bugs.openjdk.java.net/browse/JDK-8187803> as JDK counterpart of 
this issue.


Thanks,
Alexander.

On 21/09/2017 22:25, Phil Race wrote:

Some procedural comments :
Since 90% of this is in AWT code, I'd have thought awt-dev should be 
included here.

I've added that list.

And apart from needing separate bug ids, I don't see why the bug below 
is confidential.



I agree with what Kevin pointed out off-line that as in the dialog 
case, the FX side
of the code can use reflection and simply be a harmless non-functional 
no-op

if the SwingAccessor does not provide the new method.

BTW
264 inline HWND GetOverridenHWnd() { return m_overridenHwnd; }
should be "dd" not "d".

-phil.

On 09/21/2017 03:38 AM, Alexander Zvegintsev wrote:

Hello,

please review the fix

http://cr.openjdk.java.net/~azvegint/jdk/10/8185634/00/

for the issue

https://bugs.openjdk.java.net/browse/JDK-8185634

[10] Review request for 185634: Java Fx-Swing dialogs appearing behind main stage

[Alexander Zvegintsev]

Hello,

please review the fix

http://cr.openjdk.java.net/~azvegint/jdk/10/8185634/00/

for the issue

https://bugs.openjdk.java.net/browse/JDK-8185634

--
Thanks,
Alexander.

[10] request for review 8181779: Memory leak in FX Glass Embedded Window

[Alexander Zvegintsev]

Hello,

please review the fix

http://cr.openjdk.java.net/~azvegint/jdk/10/8181779/00/

for the issue

https://bugs.openjdk.java.net/browse/JDK-8181779

--
Thanks,
Alexander.

[10] Review request for 8181476 [macos] Stages with StageStyle.UTILITY are always on-top when initialized without an owner

[Alexander Zvegintsev]

Hello,

please review the fix

http://cr.openjdk.java.net/~azvegint/jdk/10/8181476/00/

for the issue

https://bugs.openjdk.java.net/browse/JDK-8181476

--
Thanks,
Alexander.

Re: CFV: New OpenJFX Committer: Ajit Ghaisas

[Alexander Zvegintsev]

Vote: yes

--
Thanks,
Alexander.

On 26.05.2017 15:20, Kevin Rushforth wrote:

I hereby nominate Ajit Ghaisas [1] to OpenJFX Committer.

Ajit is a member of JavaFX team at Oracle, who has contributed 10 
changesets to OpenJFX. A list of these changesets is available by the 
following link:


http://hg.openjdk.java.net/openjfx/10-dev/rt/log?revcount=40=author%28aghaisas%29 



Votes are due by June 9, 2017.

Only current OpenJFX Committers [2] are eligible to vote on this 
nomination. Votes must be cast in the open by replying to this mailing 
list.


For Lazy Consensus voting instructions, see [3]. Nomination to a 
project Committer is described in [4].


Thanks.

-- Kevin

[1] http://openjdk.java.net/census#aghaisas

[2] http://openjdk.java.net/census#openjfx

[3] http://openjdk.java.net/bylaws#lazy-consensus

[4] http://openjdk.java.net/projects#project-committer

Re: CFV: New OpenJFX Committer: Semyon Sadetsky

[Alexander Zvegintsev]

Vote: yes

--
Thanks,
Alexander.

On 25.01.2017 22:39, David Hill wrote:


I hereby nominate Semyon Sadetsky to OpenJFX Committer.

Semyon Sadetsky is part of the JavaFX team focusing on glass.

A list of Semyon's commits and reviews is available by the following 
links


http://hg.openjdk.java.net/openjfx/9-dev/rt/log?rev=author%28ssadetsky%29

Votes are due by Feb 9th, 2017.

Only current OpenJFX Committers [1] are eligible to vote on this 
nomination. Votes must be cast in the open by replying to this mailing 
list.


For Lazy Consensus voting instructions, see [2]. Nomination to a 
project Committer is described in [3].


[1] http://openjdk.java.net/census#openjfx

[2] http://openjdk.java.net/bylaws#lazy-consensus

[3] http://openjdk.java.net/projects#project-committer

Thanks,

Dave

Re: CFV: New OpenJFX Committer: Ramesh Gangadhar

[Alexander Zvegintsev]

Vote: yes

Thanks,
Alexander.

On 19/01/2017 00:53, Kevin Rushforth wrote:

I hereby nominate Ramesh Gangadhar [1] to OpenJFX Committer.

Ramesh is a member of JavaFX SQE team at Oracle working on test 
development for the Java packager, who has contributed 20 changesets 
to OpenJFX, at least 8 of which [5] are significant.


Votes are due by February 1, 2017.

Only current OpenJFX Committers [2] are eligible to vote on this 
nomination. Votes must be cast in the open by replying to this mailing 
list.


For Lazy Consensus voting instructions, see [3]. Nomination to a 
project Committer is described in [4].


Thanks,

-- Kevin


[1] http://openjdk.java.net/census#rgangadhar

[2] http://openjdk.java.net/census#openjfx

[3] http://openjdk.java.net/bylaws#lazy-consensus

[4] http://openjdk.java.net/projects#project-committer

[5]  List of significant changesets:
http://hg.openjdk.java.net/openjfx/9-dev/tests/rev/0b702e5db31c
http://hg.openjdk.java.net/openjfx/9-dev/tests/rev/0787febc9b94
http://hg.openjdk.java.net/openjfx/9-dev/tests/rev/b80a8efca46c
http://hg.openjdk.java.net/openjfx/9-dev/tests/rev/9fe019fe7f5c
http://hg.openjdk.java.net/openjfx/9-dev/tests/rev/bf6ae1d345ce
http://hg.openjdk.java.net/openjfx/9-dev/tests/rev/be0c0e2d0d31
http://hg.openjdk.java.net/openjfx/9-dev/tests/rev/b743144c5e11
http://hg.openjdk.java.net/openjfx/9-dev/tests/rev/0181e5e6b9bb
http://hg.openjdk.java.net/openjfx/9-dev/tests/rev/a141695f4a7f
http://hg.openjdk.java.net/openjfx/9-dev/tests/rev/16542d3f79a9
http://hg.openjdk.java.net/openjfx/9-dev/tests/rev/78f45d216138
http://hg.openjdk.java.net/openjfx/9-dev/tests/rev/92b56a32ebd1

[9] Review request for 8166106: JVM crash on resizing JavaFX application with title and icon

[Alexander Zvegintsev]

Hello,

please review the fix

http://cr.openjdk.java.net/~azvegint/jdk/9/8166106/00/

for the issue

https://bugs.openjdk.java.net/browse/JDK-8166106

--
Thanks,
Alexander.

Re: CFV: New OpenJFX Committer: Victor Drozdov

[Alexander Zvegintsev]

Vote: yes

Thanks,
Alexander.

On 12/14/16 3:21 AM, Chris Bensen wrote:

I hereby nominate Victor Drozdov [1] to OpenJFX Committer.

Victor is a member of Java Deployment team at Oracle working on the Java 
Packager tool, who has contributed 11 changesets [5] to OpenJFX, at least 8 of 
which are significant.

Votes are due by January 4, 2017.

Only current OpenJFX Committers [2] are eligible to vote on this nomination. 
Votes must be cast in the open by replying to this mailing list.

For Lazy Consensus voting instructions, see [3]. Nomination to a project 
Committer is described in [4].

Thanks,

[1] http://openjdk.java.net/census#vdrozdov 


[2] http://openjdk.java.net/census#openjfx 


[3] http://openjdk.java.net/bylaws#lazy-consensus 


[4] http://openjdk.java.net/projects#project-committer 


[5] List of changesets:

http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/81268b9c41f6 

http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/4272317a42ad 

http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/3ca13b05a699 

http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/6dfb3daf92cf 

http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/2b649093eb50 

http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/2538169ab7bb 

http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/a6fafaa51082 

http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/ac334db87ed6 

http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/12e6cb1e78af 

http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/32cc74546935 

http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/6b55a303625d 

[9] Review request for 8150175: Need replacement in FXDnD for DropTargetContext::addNotify, removeNotify

[Alexander Zvegintsev]

Hello,

please review the fix

http://cr.openjdk.java.net/~azvegint/jdk/9/8150175/00/

for the issue

https://bugs.openjdk.java.net/browse/JDK-8150175


--
Thanks,
Alexander.

Re: [9] Review request for 8087498 [Mac] : Full screen mode fails for certain StageStyles

[Alexander Zvegintsev]

please see the updated webrev

http://cr.openjdk.java.net/~azvegint/jdk/9/8087498/01/

Thanks,
Alexander.

On 8/4/16 3:40 AM, Alexander Zvegintsev wrote:

Hello,

please review the fix
http://cr.openjdk.java.net/~azvegint/jdk/9/8087498/00
for the issue
https://bugs.openjdk.java.net/browse/JDK-8087498

Re: [PATCH] 8161282: FXCanvas does not forward horizontal mouse scroll events to the embedded scene

[Alexander Zvegintsev]

Hi Alexander,

The fix looks good to me, except the wild card import change in 
FXCanvas.java(there is no need for a new patch, if it is the only issue 
found)



On 8/16/16 10:24 AM, Alexander Nyssen wrote:

You might even take the one I attached. I just recognized I still had some 
unused imports in the manual test case (I am still not familiar with IntelliJ).

Regards,
Alexander




Am 15.08.2016 um 19:26 schrieb Kevin Rushforth :

OK, I'll upload this revised version of the patch today.

-- Kevin


Alexander Nyssen wrote:

Hi Kevin,

please consider the following updated patch instead, which contains an 
additional null-check.

Regards
Alexander





Am 12.08.2016 um 16:04 schrieb Alexander Nyssen >:

Hi Kevin,

attached please find an initial patch for 
https://bugs.openjdk.java.net/browse/JDK-8161282 
.

The patch is not as minimal as I had hoped, as the EmbeddedSceneInterface had 
to be changed to differentiate between mouse and scroll events (while up to 
now, scroll events are handled as mouse events), but for me this seemed 
necessary to fix this issue properly. As a result, JFXPanel had to be adjusted 
as well to comply to the changes in the EmbeddedSceneInterface, while its 
behavior should not have changed.

As horizontal mouse events cannot be synthesized via Display.post(Event) yet 
(an open issue for SWT), I did not add an automated test, but instead added a 
manual one (FXCanvasMouseWheelEventsTest). Therefore, this patch does not 
depend on the patch I provided earlier for JDK-8160325.

Best Regards,
Alexander





=


--
Thanks,
Alexander.

Re: [PATCH] 8160325: Provide a public API to obtain the FXCanvas for an embedded scene.

[Alexander Zvegintsev]

Looks fine to me too.


On 8/16/16 1:45 AM, Kevin Rushforth wrote:
The 2016-08-12 revision looks fine to me, except for a missing space 
as noted in JBS (no need for a new patch if that is the only issue found).


While we wait for approval from the JDK 9 release team, we need 
another reviewer for this.


Alexander Z: can you take a look?

-- Kevin


Alexander Nyssen wrote:

Hi Kevin,

attached please find a revised patch that contains the corrections 
you requested. The patch is now applicable to the new module 
structure (modues with 'javafx.' prefix).


Regards,
Alexander





Am 12.08.2016 um 00:00 schrieb Kevin Rushforth 
>:




Alexander Nyssen wrote:

Hi Kevin,

thanks for your feedback. Please fin my comments inline.

   

Am 09.08.2016 um 03:10 schrieb Kevin Rushforth:

I uploaded the patch, reviewed it, and provided comments in the bug report. The 
short version is:

* The new API looks good

* There is a missing '@since 9' in the javadoc comments along with a few typos 
/ style issues
 

I will take care of it. Is there a style guide?
   


Not a current one. The ones I pointed out in the JBS issue were 
either grammatical or capitalization (other than the '@since' which 
is required for all new API).



* Rather than using reflection and setAccessible in the implementation, please 
add a public getHostContainer method to EmbeddedWindow (since it is an internal 
method, there is no concern with doing that -- it isn't API).
 

Such a getHost() method was already introduced to EmbeddedWindow as part of the 
patch (to obtain the HostContainer from it). The reflection code within 
getFXCanvas() is used to access the enclosing instance (i.e. the FXCanvas) of 
the HostContainer. We could only circumvent this by introducing a constructor 
to HostContainer and by passing in the enclosing FXCanvas instance explicitly 
(so we can query it via an explicit getter, which would have to be introduced 
in addition). Would you prefer that?
   


Ah, I see what you are doing now. There is an easier way, then. Just 
add a default (package) scope 'fxCanvas' variable in the inner class 
initialized to 'FXCanvas.this' and you will be able to access it 
directly, since an instance of an inner class can always get access 
to the instance of the enclosing class.


private class HostContainer implements HostInterface {
final FXCanvas fxCanvas = FXCanvas.this;
...

I updated the bug report with this and the other style issues. I 
haven't tested it yet, but other than the listed issues it looks 
very close to being done.


-- Kevin


   

Additionally, I requested JDK 9 release team approval for this. The approval 
process can proceed in parallel with your addressing the issues I raised.

— Kevin
 

Regards,
Alexander

   

Alexander Nyssen wrote:
 

Hi Kevin,

attached please find a revised patch. My comments are inlined.

   

Am 28.07.2016 um 18:03 schrieb Kevin Rushforth >:

Hi

Alexander Nyssen wrote:
 

Hi,

I have added my comments below:


   

Am 28.07.2016 um 17:22 schrieb Kevin Rushforth >:

I got the attachment, since Alexander also CCed me directly. I will attach it 
shortly.
 

Thanks!
   

Done.

 

I do have two comments on this:

1) We are past Feature Freeze, so all Enhancements need formal JDK 9 R-team 
approval [1][2]. In this case, the justification can be internal API that is no 
longer accessible in JDK 9 due to Jigsaw (I would be very reluctant to consider 
any other Enhancement request this late in the process), but I will need to 
look at it and then take it through the approval process, provided that I feel 
it is in scope.
 

I was not aware about this, but I would of course appreciate if it could be 
included (due to Jigsaw). Thanks for considering it at least.
   

I'll take a closer look tomorrow or Monday (no more time today). At first 
glance it seems like something reasonable to take forward.
 

That sounds promising. Thanks!

   

2) Some of the changes you list seem unrelated to this enhancement and are 
better done as separate issues (e.g., the rework of the SWTCursorsTest). Also, 
I am unconvinced of the need to force GTK 2; in fact it seems at odds with the 
work we have done with JEP 283 [3].
 

Well, the test case refactoring is somehow related, as I introduced the common 
SWT rule while introducing the second SWT test. However, I could provide it as 
a separate contribution if that was wished (and a JIRA issue was provided), but 
the rest of this contribution of course requires it as a prerequisite. If this 
enhancement could not be included in JDK 9, I would have 

[9] Review request for 8087498 [Mac] : Full screen mode fails for certain StageStyles

[Alexander Zvegintsev]

Hello,

please review the fix
http://cr.openjdk.java.net/~azvegint/jdk/9/8087498/00
for the issue
https://bugs.openjdk.java.net/browse/JDK-8087498

--
--
Thanks,
Alexander.

[9] Review request for 8163137 [Mac] : Maximizing a window with Cmd+Green button with Screen-Size hides it

[Alexander Zvegintsev]

Hello,

please review the fix
http://cr.openjdk.java.net/~azvegint/jdk/9/8163137/00
for the issue
https://bugs.openjdk.java.net/browse/JDK-8163137

--
--
Thanks,
Alexander.

Re: CFV: New OpenJFX Committer: Arunprasad Rajkumar

[Alexander Zvegintsev]

vote: yes

Thanks,
Alexander.

On 21/04/16 19:48, Kevin Rushforth wrote:

I hereby nominate Arunprasad Rajkumar [1] to OpenJFX Committer.

Arunprasad is a member of JavaFX team at Oracle working on WebKit, who 
has contributed 10 changesets [5] to OpenJFX, at least 8 of which are 
significant.


Votes are due by May 5, 2016.

Only current OpenJFX Committers [2] are eligible to vote on this 
nomination. Votes must be cast in the open by replying to this mailing 
list.


For Lazy Consensus voting instructions, see [3]. Nomination to a 
project Committer is described in [4].


Thanks,

-- Kevin

[1] http://openjdk.java.net/census#arajkumar

[2] http://openjdk.java.net/census#openjfx

[3] http://openjdk.java.net/bylaws#lazy-consensus

[4] http://openjdk.java.net/projects#project-committer

[5] List of changesets:
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/66eee7a12e81
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/3f15f2e59063
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/b75591ee263b
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/84e09aadadf1
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/4166cbca577f
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/de87459ed168
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/bccedad1f44b
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/71a5499bcda4
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/251198e174cd
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/67a83054f43b

[9] Review request: 8088916: Replace sun.net.www.ParseUtil#decode with public API

[Alexander Zvegintsev]

Hi Kevin,

please review  the fix
http://cr.openjdk.java.net/~azvegint/jdk/9/8088916/00/
for the issue
https://bugs.openjdk.java.net/browse/JDK-8088916

--
--
Thanks,
Alexander.

Re: CFV: New OpenJFX Committer: Murali Billa

[Alexander Zvegintsev]

Vote: yes

--
Thanks,
Alexander.

On 01.04.2016 0:04, Kevin Rushforth wrote:

I hereby nominate Murali Billa [1] to OpenJFX Committer.

Murali is a member of JavaFX team at Oracle working on WebKit, who has 
contributed 10 changesets [5] to OpenJFX, at least 8 of which are 
significant.


Votes are due by April 14, 2016.

Only current OpenJFX Committers [2] are eligible to vote on this 
nomination. Votes must be cast in the open by replying to this mailing 
list.


For Lazy Consensus voting instructions, see [3]. Nomination to a 
project Committer is described in [4].


Thanks,

-- Kevin

[1] http://openjdk.java.net/census#mbilla

[2] http://openjdk.java.net/census#openjfx

[3] http://openjdk.java.net/bylaws#lazy-consensus

[4] http://openjdk.java.net/projects#project-committer

[5] List of changesets:
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/a251a1d65932
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/ecea43f5734c
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/42b461505f27
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/82ecaebd44cf
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/8643ca988cef
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/765fd07f22fc
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/ae75f92d5e53
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/25db4b2e47a1
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/51c2129d282c
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/cb8a24f5db2a

Re: CFV: New OpenJFX Committer: Anton Nashatyrev

[Alexander Zvegintsev]

Vote: yes

--
Thanks,
Alexander.

On 05/29/2015 04:16 PM, Kevin Rushforth wrote:

I hereby nominate Anton Nashatyrev to OpenJFX Committer.

Anton is a member of JavaFX team at Oracle working on WebKit and Media.

A list of Anton's contributions is available via the following link:

http://hg.openjdk.java.net/openjfx/8u-dev/rt/log?rev=nashat

Votes are due by June 12, 2015.

Only current OpenJFX Committers [1] are eligible to vote on this 
nomination. Votes must be cast in the open by replying to this mailing 
list.


For Lazy Consensus voting instructions, see [2]. Nomination to a 
project Committer is described in [3].


[1] http://openjdk.java.net/census#openjfx
[2] http://openjdk.java.net/bylaws#lazy-consensus
[3] http://openjdk.java.net/projects#project-committer

Thank you.

-- Kevin

[8u60, 9] Review request for RT-40548: [GTK] Gdk-ERROR **: g_thread_init() must be called before gdk_threads_init()

[Alexander Zvegintsev]

Hello,

please review the fix
http://cr.openjdk.java.net/~azvegint/fx/8u60/40548/00/
for the issue
https://javafx-jira.kenai.com/browse/RT-40548

--
Thanks,

Alexander.

Re: CFV: New OpenJFX Committer: Elina Kleyman

[Alexander Zvegintsev]

Vote:  YES

--
Thanks,
Alexander.

On 04/10/2014 04:31 PM, David Hill wrote:


I hereby nominate Elina Kleyman to OpenJFX Committer.

Elina is a member of JavaFX Embedded team at Oracle. Elina's changes 
are in Glass support code, as well as our test and sample applications.


  hg log -M -u Elina Kleyman

A list of Elina's commits is also available by the following links (be 
sure to click the more link to see more than 10):


http://hg.openjdk.java.net/openjfx/8u-dev/rt/log?rev=elina.kley...@oracle.com 



Votes are due by April 25, 2013.

Only current OpenJFX Committers [1] are eligible to vote on this 
nomination. Votes must be cast in the open by replying to this mailing 
list.


For Lazy Consensus voting instructions, see [2]. Nomination to a 
project Committer is described in [3].


[1] http://openjdk.java.net/census#openjfx

[2] http://openjdk.java.net/bylaws#lazy-consensus

[3] http://openjdk.java.net/projects#project-committer

Thanks,

Dave

[8] Review request for RT-34750 [TextField, PasswordField, TextArea, Linux] selected text is removed on focus leaving

[Alexander Zvegintsev]

Hello Anthony,

Please review fix for https://javafx-jira.kenai.com/browse/RT-34750

--
Thanks,

Alexander.

[8] Review request for RT-34196 [Controls, Menus] Gtk: JAVAFX default menu items are difficult to click

[Alexander Zvegintsev]

Hello Anthony, Martin,

Please review fix for https://javafx-jira.kenai.com/browse/RT-34196

--
Thanks,

Alexander.

[8] Review request for RT-30457 Gtk: setDragView doesn't work on linux

[Alexander Zvegintsev]

Hello Anthony,

Please review fix for https://javafx-jira.kenai.com/browse/RT-30457
http://cr.openjdk.java.net/~azvegint/fx/8/30457/webrev.00/

--
Thanks,

Alexander.

[8] Review request for RT-34272 Gtk: Linux Input Method, partial composed text is not canceled when losing focus.

[Alexander Zvegintsev]

Hello,

Please review fix for https://javafx-jira.kenai.com/browse/RT-34272
http://cr.openjdk.java.net/~azvegint/fx/8/34272/webrev.00/

--
Thanks,

Alexander.

[8] Review request for RT-32477 Gtk: TextField: Ctrl+A don't work with Russian keyboard layout.

[Alexander Zvegintsev]

Hello,

Please review fix for https://javafx-jira.kenai.com/browse/RT-32477
http://cr.openjdk.java.net/~azvegint/fx/8/32477/webrev.00/

--
Thanks,

Alexander.

[8] Review request for RT-32436 Gtk: OpenGL with JavaFX causes Gthread error and halts

[Alexander Zvegintsev]

Hello,

Please review fix for https://javafx-jira.kenai.com/browse/RT-32436

--
Thanks,

Alexander.