Review Request for: JDK-8171229: StringIndexOutOfBoundsException when programmatically replace text in TextArea

Hi Jonathan, Can you please review the fix related to TextArea: Webrev: http://cr.openjdk.java.net/~arapte/fx/8171229/webrev.00/ Bug: https://bugs.openjdk.java.net/browse/JDK-8171229 Regards, Ambarish

Review request: JDK-8145887: ListView selectionModel selectedIndices ListIterator nextIndex broken

Hi Jonathan, Ajit Please review this fix: Webrev : http://cr.openjdk.java.net/~arapte/fx/8145887/webrev.00/ Bug : https://bugs.openjdk.java.net/browse/JDK-8145887 Issue: The private class SelectionListIterator implements the interface java.util.ListItera

Review Request: JDK-8175963: ChoiceBox using events from ComboBox

Hi Jonathan, Ajit, Please review this fix, Bug : https://bugs.openjdk.java.net/browse/JDK-8175963 Webrev: http://cr.openjdk.java.net/~arapte/fx/8175963/webrev.03/ Issue: EventType from class ComboBoxBase were used with ChoiceBox class in

Review Request: 8090192 : [TextArea] Previous char wrong at line start

Hi Jonathan, Ajit, Please review this bug fix: Bug: https://bugs.openjdk.java.net/browse/JDK-8090192 Webrev: http://cr.openjdk.java.net/~arapte/fx/8090192/webrev.00/ Regards, Ambarish

Review Request: 8178417 : TextArea/TextField: Undo operation reverts the caret position.

Hi Jonathan, Ajit, Please review a small fix: Bug: https://bugs.openjdk.java.net/browse/JDK-8178417 Webrev: http://cr.openjdk.java.net/~arapte/fx/8178417/webrev.00/ Regards, Ambarish

Review request : JDK-8181213 : [Tab] Tab content is not disabled when tab is disabled before content is set

Hi Jonathan & Ajit, Request you to review the fix: Bug: https://bugs.openjdk.java.net/browse/JDK-8181213 Webrev: http://cr.openjdk.java.net/~arapte/fx/8181213/webrev.00/ Regards, Ambarish

Review request for : JDK-8092206 : TabPane renders content of all tabs even only one is active

Hi Jonathan, Please review the below fix, Bug: https://bugs.openjdk.java.net/browse/JDK-8092206 Webrev: http://cr.openjdk.java.net/~arapte/fx/8092206/webrev.00/ Regards, Ambarish

Review request for JDK-8130904: disabled tabs in a inner tabpane show like enabled

Hi Jonathan, Hi Ajit, Request you to review this fix: Bug: https://bugs.openjdk.java.net/browse/JDK-8130904 Webrev: http://cr.openjdk.java.net/~arapte/fx/8130904/webrev.00/ Regards, Ambarish

Review request for 8181930 : Adding a null icon to a Stage prevents application startup

Hi Chien, Hi Kevin, Request you to review the fix for JDK 10. Bug: https://bugs.openjdk.java.net/browse/JDK-8181930 Webrev: http://cr.openjdk.java.net/~arapte/fx/8181930/webrev.00/ Regards, Ambarish

Review request for : JDK-8092206 : TabPane renders content of all tabs even only one is active

Hi Kevin, Hi Jonathan, Request you to review the fix, Bug: https://bugs.openjdk.java.net/browse/JDK-8092206 Webrev: http://cr.openjdk.java.net/~arapte/fx/8092206/webrev.04/ Regards, Ambarish

RFR JDK-8177633: [MenuButton] Add setOn* APIs to set event handlers for show/hide event types.

Hi All, Request you to review a fix: Fix : http://cr.openjdk.java.net/~arapte/fx/8177633/webrev.00/ Bug : https://bugs.openjdk.java.net/browse/JDK-8177633 Regards, Ambarish

RFR : JDK-8178418 : TextArea/TextField: Undo removes entire text at once

Hi, Please review this bug fix: Bug: https://bugs.openjdk.java.net/browse/JDK-8178418 Fix: http://cr.openjdk.java.net/~arapte/fx/8178418/webrev.00/ Regards, Ambarish

[10] Review request : JDK-8172856 : Out of memory exception due to repeated style class changes

Hi, Please review the fix: Bug: https://bugs.openjdk.java.net/browse/JDK-8172856 Webrev.00: http://cr.openjdk.java.net/~arapte/fx/8172856/webrev.00/ Webrev.01: http://cr.openjdk.java.net/~arapte/fx/8172856/webrev.01/

RFR : JDK-8189424 : Event is not consumed in Tab.setOnCloseRequest()

Hi Kevin & Ajit, Request you to review a small fix: Webrev: http://cr.openjdk.java.net/~arapte/fx/8189424/webrev.00/ Bug: https://bugs.openjdk.java.net/browse/JDK-8189424 Regards, Ambarish

[10] RFR : JDK-8187074 : [TabPane] Support reordering of Tabs within a TabPane

Hi, Request you to review the following fix, Issue: https://bugs.openjdk.java.net/browse/JDK-8187074 Webrev: http://cr.openjdk.java.net/~arapte/fx/8187074/webrev.04/ Regards, Ambarish

[10] Review request : JDK-8183520 : [linux] NPE when switching Scene

Hi Kevin & Ajit, Request you to review this fix, Issue: https://bugs.openjdk.java.net/browse/JDK-8183520 Webrev: http://cr.openjdk.java.net/~arapte/fx/8183520/webrev.00/ Regards, Ambarish

[10] RFR : 8193426 : [TEST BUG] Exceptions, warnings when running TabPaneDragPolicyTest

Hi Kevin & Ajit, Please review this test bug fix, Issue: https://bugs.openjdk.java.net/browse/JDK-8193426 Webrev: http://cr.openjdk.java.net/~arapte/fx/8193426/webrev.00/ Regards, Ambarish

RFR : JDK-8192056 : Memory leak when removing javafx.scene.shape.Sphere-objects from a group or container

Hi Kevin & Ajit, Request you to review this fix Issue: https://bugs.openjdk.java.net/browse/JDK-8192056 Webrev: http://cr.openjdk.java.net/~arapte/fx/8192056/webrev.02 Regards, Ambarish

RFR : JDK-8157690 : [TabPane] Sorting tabs makes tab selection menu empty

Hi Kevin & Ajit, Request you to review this fix, Webrev: http://cr.openjdk.java.net/~arapte/fx/8157690/webrev.00/ Issue: https://bugs.openjdk.java.net/browse/JDK-8157690 Regards, Ambarish

RFR : JDK-8193495 : TabPane does not update correctly tab positions in the header area after a quick remove and add operations

Hi Kevin & Ajit, Please review this fix: Webrev: http://cr.openjdk.java.net/~arapte/fx/8193495/webrev.00/ Bug: https://bugs.openjdk.java.net/browse/JDK-8193495 This patch also fixes an another bug: https://bugs.openjdk.java.n

RFR : JDK-8154039 : Memory leak when selecting a tab which is not contained in TabPane::getTabs()

Hi Kevin & Ajit, Please review this fix, Webrev: http://cr.openjdk.java.net/~arapte/fx/8154039/webrev.00/ Issue: https://bugs.openjdk.java.net/browse/JDK-8154039 Regards, Ambarish

[11] RFR : JDK-8193311 : [Spinner] Default button not activated on ENTER

Hi Kevin & Ajit, Request you to review this fix, Issue: https://bugs.openjdk.java.net/browse/JDK-8193311 Webrev: http://cr.openjdk.java.net/~arapte/fx/8193311/webrev.00/ Regards, Ambarish

[11] RFR : JDK-8195802 : Eliminate use of jdk.internal.misc security utilities in javafx.graphics

Hi Kevin & Ajit, Please review this fix, webrev: http://cr.openjdk.java.net/~arapte/fx/8195802/webrev.00/ Bug: https://bugs.openjdk.java.net/browse/JDK-8195802 Regards, Ambarish

[11] RFR : JDK-8195800 : Eliminate dependency on sun.reflect.misc in javafx modules

Hi Kevin, Alan & Mandy, Request you to review this fix: Webrev: http://cr.openjdk.java.net/~arapte/fx/8195800/webrev.00/ JBS: https://bugs.openjdk.java.net/browse/JDK-8195800 Regards, Ambarish

RE: CFV: New OpenJFX Committer: Rajath Kamath

Vote: Yes -Original Message- From: Guru Sent: Tuesday, April 03, 2018 2:12 PM To: Kevin Rushforth Cc: [email protected] Subject: Re: CFV: New OpenJFX Committer: Rajath Kamath Vote: YES > On 29-Mar-2018, at 10:12 PM, Kevin Rushforth > wrote: > > I hereby nominate Rajath Ka

[11] RFR JDK-8198602 : [TestBug] test.javafx.css.StylesheetTest logs IllegalArgumentException

Hi Kevin & Ajit, Please review this small fix, Bug: https://bugs.openjdk.java.net/browse/JDK-8198602 Webrev: http://cr.openjdk.java.net/~arapte/fx/8198602/webrev.00/ Regards, Ambarish

[11] RFR : JDK-8196844 : [TestBug] IllegalArgumentException gets logged in some of test.javafx.scene.* tests

Hi Kevin & Ajit, Please review this test fix: Webrev: http://cr.openjdk.java.net/~arapte/fx/8196844/webrev.00/ Bug: https://bugs.openjdk.java.net/browse/JDK-8196844 Regards, Ambarish

[11] JDK-8199344: [testbug] Illegal reflective access by NGTestBase

Hi Kevin & Ajit, Request you to review this fix, Webrev: http://cr.openjdk.java.net/~arapte/fx/8199344/webrev.00/ Bug: https://bugs.openjdk.java.net/browse/JDK-8199344 Regards, Ambarish

[11] JDK-8202623 : Some launcher tests will hang if underlying process exits too early

Hi Kevin & Ajit, Request you to review this fix. Webrev: http://cr.openjdk.java.net/~arapte/fx/8202623/webrev.00/ Bug: https://bugs.openjdk.java.net/browse/JDK-8202623 Regards, Ambarish

[11] RFR : JDK-8203365: [TESTBUG] Mark MeshManagerCacheLeakTest as unstable until test is fixed

Hi Kevin & Ajit, Please review this small fix: Webrev: http://cr.openjdk.java.net/~arapte/fx/8203365/webrev.00/ JBS: https://bugs.openjdk.java.net/browse/JDK-8203365 Regards, Ambarish

[11] JDK-8200285 : TabDragPolicy.REORDER prevents ContextMenu from showing

Hi Kevin & Ajit, Please review this fix, Webrev: http://cr.openjdk.java.net/~arapte/fx/8200285/webrev.00/ JBS: https://bugs.openjdk.java.net/browse/JDK-8200285 Regards, Ambarish

[11] RFR JDK-8204956 : Cleanup whitespace after fix for JDK-8200285

Hi Kevin, Please review this correction fix : Bug: https://bugs.openjdk.java.net/browse/JDK-8204956 Webrev: http://cr.openjdk.java.net/~arapte/fx/8204956/webrev.00/ Regards, Ambarish

[11] RFR : JDK-8205008 : GeneralTransform3D transform function with single Vec3d argument wrong results

Hi Kevin & All, Please review this small corrective fix, Webrev: http://cr.openjdk.java.net/~arapte/fx/8205008/webrev.00/ Bug: https://bugs.openjdk.java.net/browse/JDK-8205008 Regards, Ambarish

[openjfx11] RFR : JDK-8197846 : ComboBox: becomes unclickable after removal and re-adding

Hi Kevin, Ajit, Request you to review this fix: Webrev: http://cr.openjdk.java.net/~arapte/fx/8197846/webrev.00/ JBS: https://bugs.openjdk.java.net/browse/JDK-8197846 Regards, Ambarish

[openjfx11] RFR : JDK-8197985 : Pressing Shift + DOWN in ListView causes Exception to be thrown

Hi Kevin & Jeanette, Please review this fix: JBS: https://bugs.openjdk.java.net/browse/JDK-8197985 Webrev: http://cr.openjdk.java.net/~arapte/fx/8197985/webrev.00/ Regards, Ambarish

[12] RFR : JDK-8203884 : Update libjpeg to version 9c

Hi All, Please review this change for updating libjpeg7 to libjpeg9c. Webrev: http://cr.openjdk.java.net/~arapte/fx/8203884/webrev.00_for_checkin/ -> Complete patch with changes in make files and Netbeans project files. Webrev: http://cr.

Fix proposal: boolean flag & public API for JDK-8204060 - Disable smoothing at javafx.scene.canvas.GraphicsContext.drawImage()

Hi All, This email is for discussion regarding the fix https://bugs.openjdk.java.net/browse/JDK-8204060 . Issue: Images drawn using javafx.scene.canvas .GraphicsContext::drawImage() always apply filtering to the image. Solution: javafx.scene.canvas.GraphicsContext should provide an

RE: Fix proposal: boolean flag & public API for JDK-8204060 - Disable smoothing at javafx.scene.canvas.GraphicsContext.drawImage()

ay, October 16, 2018 4:25 AM To: Dan Howard ; Ambarish Rapte ; [email protected] Subject: Re: Fix proposal: boolean flag & public API for JDK-8204060 - Disable smoothing at javafx.scene.canvas.GraphicsContext.drawImage() Yes, it should be "isImageSmoothing", thanks for catchi

RE: Fix proposal: boolean flag & public API for JDK-8204060 - Disable smoothing at javafx.scene.canvas.GraphicsContext.drawImage()

Thanks Kevin, Nir & Dan for the review.   I shall make these changes and share the fix for review on new email.   Regards, Ambarish   From: Nir Lisker Sent: Wednesday, October 17, 2018 1:24 PM To: Ambarish Rapte Cc: [email protected] Mailing Subject: Re: Fix proposal: boo

[12] RFR : JDK-802040 : Disable smoothing at javafx.scene.canvas.GraphicsContext.drawImage()

Hi All, Please review this fix: JBS: https://bugs.openjdk.java.net/browse/JDK-8204060 Webrev: http://cr.openjdk.java.net/~arapte/fx/8204060/webrev.00/ Regards, Ambarish

[Openjfx12] RFR : JDK-8189926 : Elevated energy use due to constant CPU use on Mac

Hi All, Please review this mac specific fix, Webrev: http://cr.openjdk.java.net/~arapte/fx/8189926/webrev.05/ JBS: https://bugs.openjdk.java.net/browse/JDK-8189926 Regards, Ambarish

[openjfx12] RFR : 8214508 : [TestBug] [Canvas] Add missing test image.

Hi, Please review this correction fix, Webrev: http://cr.openjdk.java.net/~arapte/fx/8204060/8214508/webrev.00/ JBS: https://bugs.openjdk.java.net/browse/JDK-8214508 Regards, Ambarish

[12] RFR : JDK-8214035 : Unable to render cmyk jpeg image

Hi, Please take a look at this bug fix, Webrev: http://cr.openjdk.java.net/~arapte/fx/8214035/webrev.00/ JBS: https://bugs.openjdk.java.net/browse/JDK-8214035 Regards, Ambarish

[12] RFR: JDK-8212102: [TextField] IOOBE on paste/replace text with control characters

Hi Kevin, Ajit, Please review this fix: JBS: https://bugs.openjdk.java.net/browse/JDK-8212102 Webrev: http://cr.openjdk.java.net/~arapte/fx/8212102/webrev.00/ Regards, Ambarish

[13] RFR : JDK-8222222 : Gradients defined in CSS always use "reflect" even when "repeat" is specified

Hi Kevin, Ajit, Please review this small fix, JBS: https://bugs.openjdk.java.net/browse/JDK-822 Webrev: http://cr.openjdk.java.net/~arapte/fx/822/webrev.00/ Regards, Ambarish

[13] RFR : JDK-8213572 : InitialSizeTest::testInitialSize fails on Windows 10 1803 with 125% Hi-DPI

Hi All, Please take a look at this small fix, Webrev: http://cr.openjdk.java.net/~arapte/fx/8213572/webrev.00/ JBS: https://bugs.openjdk.java.net/browse/JDK-8213572 Regards, Ambarish

[13] RFR : JDK-8222183 : Remove commented out tests from javafx.base

Hi, Please review this test cleanup change, Webrev: http://cr.openjdk.java.net/~arapte/fx/8222183/webrev.00/ JBS: https://bugs.openjdk.java.net/browse/JDK-8222183 Regards, Ambarish

[openjfx13] RFR : JDK-8222211 : Creating animated gif image from non FX App thread causes exception

Hi All, Please review this fix, JBS: https://bugs.openjdk.java.net/browse/JDK-811 Webrev: http://cr.openjdk.java.net/~arapte/fx/811/webrev.00/ Regards, Ambarish

[openjfx13] RFR : JDK-8222457 : TabPane doesn't respect order of TabPane.getTabs() list

Hi All, Please review this fix, Webrev: http://cr.openjdk.java.net/~arapte/fx/8222457/webrev.00/ JBS: https://bugs.openjdk.java.net/browse/JDK-8222457 Regards, Ambarish

RE: CFV: New OpenJFX Committer: Nir Lisker

Vote: YES -Original Message- From: Kevin Rushforth Sent: Wednesday, June 26, 2019 3:14 AM To: [email protected]; Nir Lisker Subject: CFV: New OpenJFX Committer: Nir Lisker I hereby nominate Nir Lisker [1] to OpenJFX Committer. Nir is an OpenJFX community member, who has con

[Openjfx13] RFR : JDK-8209938 : Default and Cancel button cause memory leak

Hi All, Please review this fix: JBS: https://bugs.openjdk.java.net/browse/JDK-8209938 Webrev: http://cr.openjdk.java.net/~arapte/fx/8209938/webrev.00/ Regards, Ambarish

Re: [Approved] RFR: 8232522: FX: Update copyright year in docs, readme files to 2020

On Sat, 19 Oct 2019 15:04:27 GMT, Kevin Rushforth wrote: > As indicated in the JBS bug, this makes the needed change for releasing in > 2020. > > > > Commits: > - 85c03ad9: 8232522: FX: Update copyright year in docs, readme files to 2020 > > Changes: https://git.openjdk.java

Re: RFR: 8263322: Calling Application.launch on FX thread should throw IllegalStateException, but causes deadlock [v9]

On Sun, 21 Mar 2021 22:30:11 GMT, Florian Kirmaier wrote: >> Fixing deadlock when calling Application.launch in the FXThread after >> Platform.startup > > Florian Kirmaier has updated the pull request incrementally with one > additional commit since the last revision: > > JDK-8263322 > fi

Re: RFR: 8263402: MemoryLeak: Node hardreferences it's previous Parent after csslayout and getting removed from the scene

On Mon, 22 Mar 2021 14:35:58 GMT, Florian Kirmaier wrote: > I think it's also quite important to support fast removing/adding subtrees. Yes, Adding listener seems over kill here. Lets go with `WeakReference` approach. I will take a look at the test update. - PR: https://git.open

Re: RFR: 8263402: MemoryLeak: Node hardreferences it's previous Parent after csslayout and getting removed from the scene [v3]

On Mon, 22 Mar 2021 14:30:58 GMT, Florian Kirmaier wrote: >> Fixing a memory leak. >> A node hard references its old parent after CSS layout and getting removed. >> This shouldn't be the case, this is very counterintuitive. >> >> The fix uses a WeakReference in CSSStyleHelper for firstStyleab

Re: RFR: 8208088: Memory Leak in ControlAcceleratorSupport [v3]

utton` is created by `MenuBarSkin` to show > a `Menu`. This `MenuBarButton` gets disposed when the related `Menu` is > removed from scenegraph, and so the added `ListChangeListener` gets GCed. > Hence it is not required to explicitly remove the listener. > Added a comment explaining this beh

Re: RFR: 8208088: Memory Leak in ControlAcceleratorSupport

On Sat, 20 Mar 2021 13:11:55 GMT, Kevin Rushforth wrote: > The new unit test fails on all platforms, as you can see from the GitHub > actions log: The test failed because, change listeners added by other tests get accumulated in the `changeListenerMap`. These listeners can get GCed only if the

Re: RFR: 8239589: JavaFX UI will not repaint after reconnecting via Remote Desktop [v5]

On Sat, 20 Mar 2021 13:40:51 GMT, Kevin Rushforth wrote: >> This is a fix for a long-standing bug where the D3D pipeline will stop >> rendering when a Windows remote desktop session is disconnected and then >> reconnected. >> >> A preliminary Draft PR #315 by @Schmidor was a good first step in

Re: RFR: 8263402: MemoryLeak: Node hardreferences it's previous Parent after csslayout and getting removed from the scene [v4]

On Fri, 26 Mar 2021 12:02:40 GMT, Florian Kirmaier wrote: >> Fixing a memory leak. >> A node hard references its old parent after CSS layout and getting removed. >> This shouldn't be the case, this is very counterintuitive. >> >> The fix uses a WeakReference in CSSStyleHelper for firstStyleab

Re: RFR: 8264677 MemoryLeak: Progressindicator leaks, when treeShowing is false [v2]

On Tue, 6 Apr 2021 12:24:36 GMT, Florian Kirmaier wrote: >> Fixing leak in ProgressIndicator when treeShowing is false > > Florian Kirmaier has updated the pull request incrementally with one > additional commit since the last revision: > > 8264677 > changes based on code review Suggested

Re: RFR: 8208088: Memory Leak in ControlAcceleratorSupport [v4]

utton` is created by `MenuBarSkin` to show > a `Menu`. This `MenuBarButton` gets disposed when the related `Menu` is > removed from scenegraph, and so the added `ListChangeListener` gets GCed. > Hence it is not required to explicitly remove the listener. > Added a comment explaining this beh

Re: RFR: 8208088: Memory Leak in ControlAcceleratorSupport [v5]

utton` is created by `MenuBarSkin` to show > a `Menu`. This `MenuBarButton` gets disposed when the related `Menu` is > removed from scenegraph, and so the added `ListChangeListener` gets GCed. > Hence it is not required to explicitly remove the listener. > Added a comment explaining this beh

Re: RFR: 8208088: Memory Leak in ControlAcceleratorSupport [v3]

On Wed, 24 Mar 2021 15:03:36 GMT, Kevin Rushforth wrote: > Is there a way to test it more directly? `ControlTestUtils` provides a way to get the number of listeners added to a property. Please check the updated test. With this direct way, should we keep the indirect way of testing which uses `

Re: RFR: 8264928: Update to Xcode 12.4

On Thu, 8 Apr 2021 17:21:43 GMT, Kevin Rushforth wrote: > This updates the compiler used to build JavaFX on macOS to Xcode 12.4 (which > includes the MacOSX11.1 sdk), which matches the compiler that will be used to > build JDK 17, once openjdk/jdk#3388 is integrated. > > As noted in the bug re

Re: RFR: 8208088: Memory Leak in ControlAcceleratorSupport [v6]

utton` is created by `MenuBarSkin` to show > a `Menu`. This `MenuBarButton` gets disposed when the related `Menu` is > removed from scenegraph, and so the added `ListChangeListener` gets GCed. > Hence it is not required to explicitly remove the listener. > Added a comment explaining this beh

Re: RFR: 8208088: Memory Leak in ControlAcceleratorSupport [v5]

On Sat, 10 Apr 2021 14:58:14 GMT, Kevin Rushforth wrote: > I'd recommend to get rid of the indirect way of testing I have removed the indirect way, please take a look. - PR: https://git.openjdk.java.net/jfx/pull/429

Re: RFR: [WIP] 8088739: [TestBug] RegionBackgroundImageUITest fail with timeout error [v2]

nly the tests that extend from > `RegionUITestBase` test class and does not affect other tests. > Verified that `RegionBackgroundImageUITest` and `RegionBackgroundFillUITest` > tests pass on all three platforms(except > RegionBackgroundImageUITest.unalignedImage_Cover which fails o

Re: RFR: 8265031: Change default macOS min version for x86_64 to 10.12 and aarch64 to 11.0

On Mon, 12 Apr 2021 20:30:55 GMT, Kevin Rushforth wrote: > As noted in the JBS bug, the minimum macOS version on which JavaFX will run > is currently set to 10.10 in `mac.gradle`. macOS 10.10 is many years out of > support, so we should update this minimum. Further, macOS / aarch64 (aka > arm6

Re: RFR: 8265031: Change default macOS min version for x86_64 to 10.12 and aarch64 to 11.0 [v2]

On Wed, 14 Apr 2021 12:40:29 GMT, Kevin Rushforth wrote: >> As noted in the JBS bug, the minimum macOS version on which JavaFX will run >> is currently set to 10.10 in `mac.gradle`. macOS 10.10 is many years out of >> support, so we should update this minimum. Further, macOS / aarch64 (aka >>

Re: RFR: [WIP] 8088739: [TestBug] RegionBackgroundImageUITest fail with timeout error [v2]

On Mon, 12 Apr 2021 14:33:08 GMT, Ambarish Rapte wrote: >> Each test in RegionBackgroundImageUITest makes several calls to >> `robot.getPixelColor()` on App thread. Due to this each test requires more >> than **60** seconds for execution. >> >> Fix is to save a s

Re: RFR: [WIP] 8088739: [TestBug] RegionBackgroundImageUITest fail with timeout error [v3]

nly the tests that extend from > `RegionUITestBase` test class and does not affect other tests. > Verified that `RegionBackgroundImageUITest` and `RegionBackgroundFillUITest` > tests pass on all three platforms(except > RegionBackgroundImageUITest.unalignedImage_Cover which fails on

Re: RFR: [WIP] 8088739: [TestBug] RegionBackgroundImageUITest fail with timeout error [v4]

nly the tests that extend from > `RegionUITestBase` test class and does not affect other tests. > Verified that `RegionBackgroundImageUITest` and `RegionBackgroundFillUITest` > tests pass on all three platforms(except > RegionBackgroundImageUITest.unalignedImage_Cover which fails on

Re: RFR: 8088739: [TestBug] RegionBackgroundImageUITest fail with timeout error [v4]

On Mon, 2 Nov 2020 14:12:25 GMT, Kevin Rushforth wrote: > this might be a bug in Robot itself It seems like a robot issue. These failures can also be observed without this change and with increased timeout (7 ms). > The fix for [JDK-8170026](https://bugs.openjdk.java.net/browse/JDK-817002

Integrated: 8208088: Memory Leak in ControlAcceleratorSupport

On Wed, 17 Mar 2021 17:35:34 GMT, Ambarish Rapte wrote: > The method `ControlAcceleratorSupport.doAcceleratorInstall(final List extends MenuItem> items, final Scene scene)` adds a `ChangeListener` on > `MenuItem.acceleratorProperty()`. This listener is not removed when the >

RFR: 8234077: Evaluate ignored unit tests in RenderRootTest

These are 2 corner case test cases for getRenderRoot() method. 1. `emptyDirtyRegion():` When the dirty region rect is empty i.e. (0, 0, -1, -1) 2. `zeroSizeDirtyRegionWithinOpaqueRegion()`: When the dirty region rect is of zero dimensions, for example (20, 20, 0, 0) - emptyDirtyRegion(): When the

Re: RFR: 8234920: Add SpotLight to the selection of 3D light types [v14]

On Thu, 15 Apr 2021 02:21:50 GMT, Nir Lisker wrote: >> Added a SpotLight only to the D3D pipeline currently. >> >> ### API discussion points >> >> - [X] Added `SpotLight` as a subclass of `LightBase`. However, it could >> also be a subclass of `PointLight` as it's a point light with direction

Re: RFR: 8234920: Add SpotLight to the selection of 3D light types [v14]

On Fri, 16 Apr 2021 10:35:29 GMT, Ambarish Rapte wrote: >> Nir Lisker has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Combined rotation and direction > > modules/javafx.graphics/src/main/java/javaf

Integrated: 8088739: [TestBug] RegionBackgroundImageUITest fail with timeout error

On Fri, 30 Oct 2020 16:04:51 GMT, Ambarish Rapte wrote: > Each test in RegionBackgroundImageUITest makes several calls to > `robot.getPixelColor()` on App thread. Due to this each test requires more > than **60** seconds for execution. > > Fix is to save a screen capture o

Re: RFR: 8234077: Evaluate ignored unit tests in RenderRootTest

On Fri, 16 Apr 2021 22:29:04 GMT, Kevin Rushforth wrote: > Yes, filing a new bug to evaluate case 1 seems like the best option Thanks for the comment, I have created a new JBS issue and updated id in the ignore tags. - PR: https://git.openjdk.java.net/jfx/pull/463

Re: RFR: 8234077: Evaluate ignored unit tests in RenderRootTest [v2]

n then the current > behavior seems valid. I have added a couple more similar tests. Ambarish Rapte has updated the pull request incrementally with one additional commit since the last revision: update ignore tags with jbs id - Changes: - all: https://git.openjdk.java.net/jfx/pul

RFR: 8234084: [TEST_BUG] Remove unexecuted performance benchmark tests

This PR removes two benchmark tests that are ignored since they were added [here](https://github.com/openjdk/jfx/commit/0dea6d6790ae4eeff3e5ec5a7750251caf91e40b) test.javafx.scene.input.TouchEventTest.saneOrderingBenchmark test.javafx.scene.input.TouchEventTest.crazyOrderingBenchmark Since the t

Re: RFR: 8263402: MemoryLeak: Node hardreferences it's previous Parent after csslayout and getting removed from the scene [v5]

On Sun, 11 Apr 2021 15:48:11 GMT, Florian Kirmaier wrote: >> Fixing a memory leak. >> A node hard references its old parent after CSS layout and getting removed. >> This shouldn't be the case, this is very counterintuitive. >> >> The fix uses a WeakReference in CSSStyleHelper for firstStyleab

Integrated: 8234084: [TEST_BUG] Remove unexecuted performance benchmark tests

On Tue, 20 Apr 2021 09:12:40 GMT, Ambarish Rapte wrote: > This PR removes two benchmark tests that are ignored since they were added > [here](https://github.com/openjdk/jfx/commit/0dea6d6790ae4eeff3e5ec5a7750251caf91e40b) > > test.javafx.scene.input.TouchEventTest.saneOrder

Integrated: 8234077: Evaluate ignored unit tests in RenderRootTest

On Fri, 16 Apr 2021 09:25:47 GMT, Ambarish Rapte wrote: > These are 2 corner case test cases for getRenderRoot() method. > 1. `emptyDirtyRegion():` When the dirty region rect is empty i.e. (0, 0, -1, > -1) > 2. `zeroSizeDirtyRegionWithinOpaqueRegion()`: When the dirty region rect i

RFR: 8239880: CSS tests should cleanup any global state they modify

The tests that are modified in this PR set a stylesheet using API `StyleManager.getInstance().setDefaultUserAgentStylesheet()`. This is a global state and should be reset after execution of each test. It does not cause any test failures currently, but this has caused a test failure in past report

RFR: 8265514: Openjfx controls running tests broken (Eclipse)

As mentioned in JBS the unit test execution fails when tests have a duplicate package name. This was introduced by JDK-8204568: it created a test in a new package `test.javafx.css` in controls tests. A similar package already existed in graphics unit tests. This is a simple fix to rename the pac

Re: RFR: 8265514: Openjfx controls running tests broken (Eclipse) [v2]

is a simple fix to rename the package. Test is moved to existing package > in controls test under `test.javafx.scene.control` Ambarish Rapte has updated the pull request incrementally with one additional commit since the last revision: change package - Changes: - all: https:/

Re: RFR: 8265514: Openjfx controls running tests broken (Eclipse) [v2]

On Wed, 21 Apr 2021 11:37:30 GMT, Jeanette Winzenburg wrote: >> Ambarish Rapte has updated the pull request incrementally with one >> additional commit since the last revision: >> >> change package > > modules/javafx.controls/src/test/java/test/javafx/scene

Integrated: 8239880: CSS tests should cleanup any global state they modify

On Wed, 21 Apr 2021 09:01:45 GMT, Ambarish Rapte wrote: > The tests that are modified in this PR set a stylesheet using API > `StyleManager.getInstance().setDefaultUserAgentStylesheet()`. > This is a global state and should be reset after execution of each test. > It does not ca

Integrated: 8265514: Openjfx controls running tests broken (Eclipse)

On Wed, 21 Apr 2021 10:49:25 GMT, Ambarish Rapte wrote: > As mentioned in JBS the unit test execution fails when tests have a duplicate > package name. > This was introduced by JDK-8204568: it created a test in a new package > `test.javafx.css` in controls tests. A similar pac

Re: RFR: 8264677 MemoryLeak: Progressindicator leaks, when treeShowing is false [v4]

On Fri, 23 Apr 2021 16:25:48 GMT, Florian Kirmaier wrote: >> Fixing leak in ProgressIndicator when treeShowing is false > > Florian Kirmaier has updated the pull request incrementally with one > additional commit since the last revision: > > 8264677 > Readded countdownlatch for onShown bas

Re: RFR: 8258777: SkinBase: add api to un-/register invalidation-/listChange listeners [v10]

On Sat, 17 Apr 2021 13:48:23 GMT, Jeanette Winzenburg wrote: >> Changes in Lambda..Handler: >> - added api and implemenation to support invalidation and listChange >> listeners in the same way as changeListeners >> - added java doc >> - added tests >> >> Changes in SkinBase >> - added api (an

Re: RFR: 8265399: Update to Visual Studio 2019 version 16.9.3

On Tue, 27 Apr 2021 21:33:25 GMT, Kevin Rushforth wrote: > This patch updates the compiler to Visual Studio 2019 version 16.9.3 on > Windows, in order to match JDK 17 -- see > [JDK-8265371](https://bugs.openjdk.java.net/browse/JDK-8265371). > > I ran a full build and test, including media and

Re: RFR: 8265400: Update to gcc 10.3 on Linux

On Tue, 27 Apr 2021 21:30:25 GMT, Kevin Rushforth wrote: > This patch updates the compiler to gcc 10.3 on Linux, in order to match JDK > 17 -- see [JDK-8265373](https://bugs.openjdk.java.net/browse/JDK-8265373). > > I ran a full build and test, including media and WebKit. Marked as reviewed by

Re: RFR: 8264737: JavaFX media stream stops playing after reconnecting via Remote Desktop [v2]

On Tue, 27 Apr 2021 02:09:54 GMT, Alexander Matveev wrote: >> Remote Desktop will change default audio device when connecting or >> disconnecting to it's own audio device. Also, when remote desktop is >> disconnect, then remote desktop default audio device is removed and system >> default dev

Re: RFR: 8196065: ListChangeListener getRemoved() returns items that were not removed. [v3]

On Mon, 26 Apr 2021 18:58:02 GMT, mstr2 wrote: >> The documentation for `ObservableListBase.nextRemove` states that a single >> change always refers to the current state of the list, which likely means >> that multiple disjoint removed ranges need to be applied in order, otherwise >> the next

Re: RFR: 8265399: Update to Visual Studio 2019 version 16.9.3 [v2]

On Thu, 29 Apr 2021 13:17:07 GMT, Kevin Rushforth wrote: >> This patch updates the compiler to Visual Studio 2019 version 16.9.3 on >> Windows, in order to match JDK 17 -- see >> [JDK-8265371](https://bugs.openjdk.java.net/browse/JDK-8265371). >> >> I ran a full build and test, including media

Re: RFR: 8196065: ListChangeListener getRemoved() returns items that were not removed. [v3]

On Mon, 26 Apr 2021 18:58:02 GMT, mstr2 wrote: >> The documentation for `ObservableListBase.nextRemove` states that a single >> change always refers to the current state of the list, which likely means >> that multiple disjoint removed ranges need to be applied in order, otherwise >> the next

Re: RFR: 8189354: ArrayIndexOutOfBoundsException when listening to selection changes on TreeTableView [v8]

On Tue, 27 Apr 2021 19:18:59 GMT, mstr2 wrote: >> This PR fixes the implementation of `ControlUtils.reducingChange`, which >> incorrectly computed adjacent removed indices, thus resulting in incorrect >> removal notifications. >> >> Since there were no unit tests for this method, I also added

RFR: 8264157: Items of non-editable ComboBox cannot be selected using up/down keys

This issue [JDK-8264157](https://bugs.openjdk.java.net/browse/JDK-8264157) is a regression of [JDK-8209788](https://bugs.openjdk.java.net/browse/JDK-8209788), which removed two KeyMappings from `ComboBoxListViewBehavior`. That removal was not required to fix [JDK-8209788](https://bugs.openjdk.j

  1   2   3   4   5   6   7   8   >