he bug
>> [https://bugs.openjdk.java.net/browse/JDK-8255015](url)
>
> @andreas-heger Welcome to the `jfx` project. At a quick glance, the fix looks
> promising. Have you tested this on Windows with Hi-DPI to make sure there is
> no impact? Would you be able add an automated test
The inconsistent illumination happens on Macs with retina displays only if the
3D shape is placed in a SubScene. The light sources are located with wrong
coordinates in sub scenes and this causes a different illumination. The wrong
coordinates for the light sources come from the fact that the
rom the fact that the retina
> pixel scale factors are not used in a SubScene.
>
> With this pull request, the retina pixel scale factors will be also used in
> SubScenes and this should resolve the bug
> [https://bugs.openjdk.java.net/browse/JDK-8255015](url)
Andreas Heger
On Wed, 9 Jun 2021 18:02:30 GMT, Andreas Heger
wrote:
> The inconsistent illumination happens on Macs with retina displays only if
> the 3D shape is placed in a SubScene. The light sources are located with
> wrong coordinates in sub scenes and this causes a different ill
The inconsistent illumination happens on Macs with retina displays only if the
3D shape is placed in a SubScene. The light sources are located with wrong
coordinates in sub scenes and this causes a different illumination. The wrong
coordinates for the light sources come from the fact that the
On Wed, 9 Jun 2021 18:46:16 GMT, Kevin Rushforth wrote:
> @andreas-heger Welcome to the `jfx` project. At a quick glance, the fix looks
> promising. Have you tested this on Windows with Hi-DPI to make sure there is
> no impact?
No, I only have got MacOS on retina / non retina and a n
rom the fact that the retina
> pixel scale factors are not used in a SubScene.
>
> With this pull request, the retina pixel scale factors will be also used in
> SubScenes and this should resolve the bug
> [https://bugs.openjdk.java.net/browse/JDK-8255015](url)
Andreas Heger h
rom the fact that the retina
> pixel scale factors are not used in a SubScene.
>
> With this pull request, the retina pixel scale factors will be also used in
> SubScenes and this should resolve the bug
> [https://bugs.openjdk.java.net/browse/JDK-8255015](url)
Andreas Heger h
rom the fact that the retina
> pixel scale factors are not used in a SubScene.
>
> With this pull request, the retina pixel scale factors will be also used in
> SubScenes and this should resolve the bug
> [https://bugs.openjdk.java.net/browse/JDK-8255015](url)
Andreas Heger h
the calculated average does not differ from the
>> excepted average color by a certain tolerance value. I'm not sure if I will
>> manage to do this... but I will give it a try.
>
> @andreas-heger are you able to come up with an automated test for this bug?
@kevinrushforth ye
rom the fact that the retina
> pixel scale factors are not used in a SubScene.
>
> With this pull request, the retina pixel scale factors will be also used in
> SubScenes and this should resolve the bug
> [https://bugs.openjdk.java.net/browse/JDK-8255015](url)
Andreas Heger h
the calculated average does not differ from the
>> excepted average color by a certain tolerance value. I'm not sure if I will
>> manage to do this... but I will give it a try.
>
> @andreas-heger are you able to come up with an automated test for this bug?
@kevinrushforth I've final
rom the fact that the retina
> pixel scale factors are not used in a SubScene.
>
> With this pull request, the retina pixel scale factors will be also used in
> SubScenes and this should resolve the bug
> [https://bugs.openjdk.java.net/browse/JDK-8255015](url)
Andreas Heger h
rom the fact that the retina
> pixel scale factors are not used in a SubScene.
>
> With this pull request, the retina pixel scale factors will be also used in
> SubScenes and this should resolve the bug
> [https://bugs.openjdk.java.net/browse/JDK-8255015](url)
Andreas Heger h
rom the fact that the retina
> pixel scale factors are not used in a SubScene.
>
> With this pull request, the retina pixel scale factors will be also used in
> SubScenes and this should resolve the bug
> [https://bugs.openjdk.java.net/browse/JDK-8255015](url)
Andreas Heger
rom the fact that the retina
> pixel scale factors are not used in a SubScene.
>
> With this pull request, the retina pixel scale factors will be also used in
> SubScenes and this should resolve the bug
> [https://bugs.openjdk.java.net/browse/JDK-8255015](url)
Andreas Heger h
rom the fact that the retina
> pixel scale factors are not used in a SubScene.
>
> With this pull request, the retina pixel scale factors will be also used in
> SubScenes and this should resolve the bug
> [https://bugs.openjdk.java.net/browse/JDK-8255015](url)
Andreas Heger h
This also solves [JDK-8205915 [macOS] Accelerator assigned to button in dialog
fires menuItem in owning
stage](https://bugs.openjdk.java.net/browse/JDK-8205915l).
I must admit that I don't have 100% insight about what actually caused the
problems and how the event flow completely works.
In
On Wed, 29 Dec 2021 00:44:44 GMT, Andreas Heger wrote:
> This also solves [JDK-8205915 [macOS] Accelerator assigned to button in
> dialog fires menuItem in owning
> stage](https://bugs.openjdk.java.net/browse/JDK-8205915l).
>
> I must admit that I don't have 100% insight abou
> By changing the value for the clang -arch parameter to "arm64", the jfx
> project compiles on an apple silicon system. Are there any side effects which
> I might be missing in this simple solution?
Andreas Heger has updated the pull request incrementally with one addit
On Thu, 11 Nov 2021 13:37:37 GMT, Kevin Rushforth wrote:
>> By changing the value for the clang -arch parameter to "arm64", the jfx
>> project compiles on an apple silicon system. Are there any side effects
>> which I might be missing in this simple solution?
>
> Did you build WebKit and media
On Thu, 11 Nov 2021 10:46:26 GMT, Andreas Heger wrote:
> By changing the value for the clang -arch parameter to "arm64", the jfx
> project compiles on an apple silicon system. Are there any side effects which
> I might be missing in this simple solution?
This pull r
By changing the value for the clang -arch parameter to "arm64", the jfx project
compiles on an apple silicon system. Are there any side effects which I might
be missing in this simple solution?
-
Commit messages:
- Merge branch 'openjdk:master' into fix-8276174
- 8276174: Use
On Wed, 9 Jun 2021 18:22:31 GMT, Andreas Heger wrote:
> The inconsistent illumination happens on Macs with retina displays only if
> the 3D shape is placed in a SubScene. The light sources are located with
> wrong coordinates in sub scenes and this causes a different illumination. The
On Wed, 27 Oct 2021 09:36:20 GMT, Ambarish Rapte wrote:
>> Andreas Heger has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8255015: testScene variable must be volatile and new line at the end of
>> the f
rom the fact that the retina
> pixel scale factors are not used in a SubScene.
>
> With this pull request, the retina pixel scale factors will be also used in
> SubScenes and this should resolve the bug
> [https://bugs.openjdk.java.net/browse/JDK-8255015](url)
Andreas Heger h
On Mon, 25 Oct 2021 23:50:09 GMT, Kevin Rushforth wrote:
>> Andreas Heger has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request cont
rom the fact that the retina
> pixel scale factors are not used in a SubScene.
>
> With this pull request, the retina pixel scale factors will be also used in
> SubScenes and this should resolve the bug
> [https://bugs.openjdk.java.net/browse/JDK-8255015](url)
Andreas Heger h
rom the fact that the retina
> pixel scale factors are not used in a SubScene.
>
> With this pull request, the retina pixel scale factors will be also used in
> SubScenes and this should resolve the bug
> [https://bugs.openjdk.java.net/browse/JDK-8255015](url)
Andreas Heger h
29 matches
Mail list logo
