In the HTMLEditor, when positioning the caret in a text and trying to set a
font-family that has a number in it is not working.
Issue: In
[CSSPropertyParser.cpp](https://github.com/openjdk/jfx/blob/master/modules/javafx.web/src/main/native/Source/WebCore/css/parser/CSSPropertyParser.cpp),
On Wed, 30 Oct 2019 13:27:32 GMT, Kevin Rushforth wrote:
> On Wed, 30 Oct 2019 11:09:38 GMT, Hadzic Samir wrote:
>
>> On Wed, 30 Oct 2019 10:07:42 GMT, Arun Joseph
>> wrote:
>>
>>> In the HTMLEditor, when positioning the caret in a text and trying to set a
We currently use SQLite version 3.28.0. We should update to the latest stable
release version 3.30.1 released.
https://www.sqlite.org/index.html
Commits:
- 24c6375d: 8231188: Update SQLite to version 3.30.1
Changes: https://git.openjdk.java.net/jfx/pull/31/files
Webrev:
The following tests can be reenabled:
CookieManager.testPutOverwriteExpired
CookieManager.testPutPurgeDomainAfterExpiry
CookieManager.testPutPurgeCookiesGlobally2
CookieManager.testPutPurgeCookiesGlobally3
CookieManager.testPutPurgeCookiesGloballyAfterExpiry
CallbackTest.testCustomPopup
The pull request has been updated with additional changes.
Added commits:
- ca460353: Remove ignore imports and update copyright
Changes:
- all: https://git.openjdk.java.net/jfx/pull/42/files
- new: https://git.openjdk.java.net/jfx/pull/42/files/f2f121d9..ca460353
On Fri, 15 Nov 2019 23:03:46 GMT, Kevin Rushforth wrote:
> On Fri, 15 Nov 2019 10:01:51 GMT, Arun Joseph wrote:
>
>> The pull request has been updated with additional changes.
>>
>>
>>
>> Added commits:
>> - ca460353:
The pull request has been updated with additional changes.
Added commits:
- 8c2b988d: Modified LeakTest.testOleg
Changes:
- all: https://git.openjdk.java.net/jfx/pull/42/files
- new: https://git.openjdk.java.net/jfx/pull/42/files/ca460353..8c2b988d
Webrevs:
- full:
We need to update the version of libxslt to the latest version, 1.1.34.
Commits:
- 2d9c0bf3: 8234056: Upgrade to libxslt 1.1.34
Changes: https://git.openjdk.java.net/jfx/pull/45/files
Webrev: https://webrevs.openjdk.java.net/jfx/45/webrev.00
Issue:
On Tue, 5 Nov 2019 09:26:56 GMT, Arun Joseph
wrote:
> On Thu, 10 Oct 2019 14:56:19 GMT, Hadzic Samir wrote:
>
>> On Thu, 10 Oct 2019 12:19:18 GMT, Kevin Rushforth wrote:
>>
>>> On Thu, 10 Oct 2019 09:12:57 GMT, Hadzic Samir wrote:
>>>
>>>>
On Thu, 10 Oct 2019 14:56:19 GMT, Hadzic Samir wrote:
> On Thu, 10 Oct 2019 12:19:18 GMT, Kevin Rushforth wrote:
>
>> On Thu, 10 Oct 2019 09:12:57 GMT, Hadzic Samir wrote:
>>
>>> On Wed, 9 Oct 2019 20:09:58 GMT, Kevin Rushforth wrote:
>>>
On Wed, 9 Oct 2019 16:09:58 GMT, Hadzic Samir
The pull request has been updated with additional changes.
Added commits:
- afc7f17a: Minor formatting
Changes:
- all: https://git.openjdk.java.net/jfx/pull/27/files
- new: https://git.openjdk.java.net/jfx/pull/27/files/5a1fbade..afc7f17a
Webrevs:
- full:
The test.javafx.scene.web.LeakTest.testGarbageCollectability unit test is
failing intermittently.
Commits:
- 1f7c5c8e: 8234593: Mark LeakTest.testGarbageCollectability as unstable
Changes: https://git.openjdk.java.net/jfx/pull/49/files
Webrev:
The pull request has been updated with additional changes.
Added commits:
- 7f6ed5bf: Added test for createAttribute
Changes:
- all: https://git.openjdk.java.net/jfx/pull/47/files
- new: https://git.openjdk.java.net/jfx/pull/47/files/2bd56c11..7f6ed5bf
Webrevs:
- full:
On Thu, 28 Nov 2019 13:16:19 GMT, Arun Joseph wrote:
> On Wed, 20 Nov 2019 15:04:07 GMT, Kevin Rushforth wrote:
>
>> On Wed, 20 Nov 2019 07:05:40 GMT, Arun Joseph wrote:
>>
>>> Issue: Native part of WebView throws a DOMException and then, continues
>>>
The pull request has been updated with additional changes.
Added commits:
- 472d77cf: Added spaces
Changes:
- all: https://git.openjdk.java.net/jfx/pull/47/files
- new: https://git.openjdk.java.net/jfx/pull/47/files/7f6ed5bf..472d77cf
Webrevs:
- full:
This bug can be reproduced when the screen resolution is at 125%, 150% and 175%
for Windows, which correpsonds to `pixelScale` values of 1.25, 1.5 and 1.75,
respectively.
Issue: The rectangle inside canvas is rendered on `pixelScale` while the
borders are rendered on `Math.ceil(pixelScale)`
Modified the test to work with WebView's ordering of capturing and bubbling
event listeners.
Commits:
- cbef0069: DOMTest::testEventListenerCascade fails
Changes: https://git.openjdk.java.net/jfx/pull/46/files
Webrev: https://webrevs.openjdk.java.net/jfx/46/webrev.00
The pull request has been updated with additional changes.
Added commits:
- 2bd56c11: Modified only raiseOnDOMError
Changes:
- all: https://git.openjdk.java.net/jfx/pull/47/files
- new: https://git.openjdk.java.net/jfx/pull/47/files/acc52780..2bd56c11
Webrevs:
- full:
On Wed, 20 Nov 2019 15:04:07 GMT, Kevin Rushforth wrote:
> On Wed, 20 Nov 2019 07:05:40 GMT, Arun Joseph wrote:
>
>> Issue: Native part of WebView throws a DOMException and then, continues
>> executing the rest of the function assuming that value is present. This
>>
We currently use ICU4C version 62.1. We should update to the latest stable
version 64.2.
http://site.icu-project.org/home
Commits:
- b56b720e: 8218640: Update ICU4C to version 64.2
Changes: https://git.openjdk.java.net/jfx/pull/10/files
Webrev:
Issue: The stack pointer is checked close to the stack limit during the last
iteration of calling frameLoaded() and then, grows beyond the thread's stack
range causing a stack overflow and crashes. This occurs as the stack grows by
an amount larger than the reserved zone at the end of the
> This bug can be reproduced when the screen resolution is at 125%, 150% and
> 175% for Windows, which correpsonds to `pixelScale` values of 1.25, 1.5 and
> 1.75, respectively.
>
> Issue: The rectangle inside canvas is rendered on `pixelScale` while the
> borders are rendered on
On Mon, 20 Jan 2020 16:39:15 GMT, Guru Hb wrote:
> Updated GTK Webkit 2.26 (609.1) into jfx.
Marked as reviewed by ajoseph (Author).
-
PR: https://git.openjdk.java.net/jfx/pull/91
With new bytecode format introduced in Webkit 608.1, the unlinked and linked
bytecodes were replaced by narrow (1-byte operand) and wide (4-byte operand)
bytecodes. These were extended to narrow, wide16 and wide32 bytecodes in WebKit
609.1. In narrow instructions, each argument of the opcode
> We currently use libxml2 version 2.9.9. We should update to the latest stable
> release 2.9.10.
The pull request has been updated with 1 additional commit.
-
Added commits:
- 9c76239b: 8237889: Update libxml2 to version 2.9.10
Changes:
- all:
We currently use libxml2 version 2.9.9. We should update to the latest stable
release 2.9.10.
-
Commits:
- eaf8d1b1: 8237889: Update libxml2 to version 2.9.10
Changes: https://git.openjdk.java.net/jfx/pull/120/files
Webrev: https://webrevs.openjdk.java.net/jfx/120/webrev.00
On Thu, 20 Feb 2020 05:58:03 GMT, Guru Hb wrote:
> Updating SQLite to version 3.31.1 (Currently used version is 3.30.1).
Marked as reviewed by ajoseph (Author).
-
PR: https://git.openjdk.java.net/jfx/pull/119
SVGTest.testSVGRenderingWithPattern is failing frequently due to
[JDK-8243110](https://bugs.openjdk.java.net/browse/JDK-8243110). We should skip
this test until it is fixed.
-
Commit messages:
- 8243112: Skip failing test SVGTest.testSVGRenderingWithPattern
Changes:
On Wed, 1 Apr 2020 10:49:22 GMT, Ajit Ghaisas wrote:
> Bug : https://bugs.openjdk.java.net/browse/JDK-8230809
>
> Root Cause :
> Turned out to be a simpler issue than thought.
> Atomicity check was missed while updating toolbar state (which in turn
> updates styles).
>
> Fix :
> Added the
Issue: Assuming the pixelScale is 2, the tile image size is doubled at the
native side which is propagated to the java
side as well. But, as transform initialization takes place after scaling, the
transform is reset to default value.
Fix: Override scale() method in WCBufferedContext class to
On Wed, 12 Feb 2020 20:34:55 GMT, Kevin Rushforth wrote:
>> I have indeed let this bug on the side. I would like to investigate but my
>> time is limited these days. Especially that
>> my patch is apparently creating another issue. I will try to give it another
>> shot in the upcoming week.
BufferedContext class to call init() before
> scaling.
Arun Joseph has updated the pull request incrementally with one additional
commit since the last revision:
Update copyright year
-
Changes:
- all: https://git.openjdk.java.net/jfx/pull/164/files
- new: https://git.openjdk
d on `Math.ceil(pixelScale)`
>
> Fix: Use `Math.ceil(pixelScale)` for calculating `pixelScaleTransform`
Arun Joseph has updated the pull request incrementally with one additional
commit since the last revision:
Updated test
-
Changes:
- all: https://git.openjdk.java.net/jfx/
CLoop interpreter used in 32-bit Windows uses 87 KB of stack space each time
CLoop::execute() is called. For web native
threads which has a default stack size of 320 KB, a Stack Overflow Error is
raised just after two calls to execute()
function. While 64-bit windows has a default stack size of
On Mon, 27 Apr 2020 23:56:37 GMT, Kevin Rushforth wrote:
>> fillPath() and fillRect() functions in
>> [GraphicsContextJava.cpp](https://github.com/openjdk/jfx/blob/master/modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/java/GraphicsContextJava.cpp)
>> use Image::drawPattern()
fillPath() and fillRect() functions in
[GraphicsContextJava.cpp](https://github.com/openjdk/jfx/blob/master/modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/java/GraphicsContextJava.cpp)
use Image::drawPattern() for applying patterns as fill. But drawPattern()
doesn't use
> doesn't use patternTransform argument as
> ImagePattern doesn't have the same attribute. So, the final image won't be
> transformed.
Arun Joseph has updated the pull request incrementally with one additional
commit since the last revision:
Add CanvasTest
-
Chang
On Wed, 29 Apr 2020 06:45:04 GMT, Arun Joseph wrote:
>> Since this is in a common method used by all shapes, and not just WebView,
>> we will need to ensure no regressions.
>
> All ImagePattern objects, other than the one from WebView, uses the second
> constructor whic
On Tue, 28 Apr 2020 21:41:19 GMT, Kevin Rushforth wrote:
>> ScrollbarThemeJava delegates scrollbar thickness calculation to
>> ScrollBarWidget::initializeThickness()
>> [ScrollBarWidget.java] method. Since
>> "ScrollbarThemeJava::scrollbarThickness" is not associated with any
>>
BufferedContext class to call init() before
> scaling.
Arun Joseph has updated the pull request incrementally with one additional
commit since the last revision:
Added SVGTest
-
Changes:
- all: https://git.openjdk.java.net/jfx/pull/164/files
- new: https://git.openjdk.jav
On Sun, 10 May 2020 20:49:07 GMT, Bhawesh Choudhary
wrote:
>> Root cause of issue is Specifying a image mask from GraphicsContextJava.cpp
>> in WebKit was not implemented, so masking
>> doesn't take place at all while rendering SVGRect. to fix this issue add
>> implementation of function
On Mon, 27 Apr 2020 08:17:50 GMT, Arun Joseph wrote:
> ScrollbarThemeJava delegates scrollbar thickness calculation to
> ScrollBarWidget::initializeThickness()
> [ScrollBarWidget.java] method. Since "ScrollbarThemeJava::scrollbarThickness"
> is not associated with
On Mon, 18 May 2020 08:00:38 GMT, Bhawesh Choudhary
wrote:
>> Root cause of issue is Specifying a image mask from GraphicsContextJava.cpp
>> in WebKit was not implemented, so masking
>> doesn't take place at all while rendering SVGRect. to fix this issue add
>> implementation of function
On Thu, 12 Mar 2020 10:43:37 GMT, Ambarish Rapte wrote:
> Currently we use IJG libjpeg version 9c released on 14-Jan-2018
> We should update the libjpeg to latest version [9d](http://www.ijg.org/)
> released on 12-Jan-2020
>
> reference: https://jpegclub.org/reference/reference-sources/
Cause: The Window Class `RunLoopMessageWindow` is never registered (this
happens because
registerRunLoopMessageWindowClass() is moved to MainThreadWin.cpp while openjfx
uses MainThreadJava.cpp) and this
causes every setTimer() to create a new user object instead of reusing the same
object over
On Wed, 20 May 2020 15:16:11 GMT, Kevin Rushforth wrote:
>> Cause: The Window Class `RunLoopMessageWindow` is never registered (this
>> happens because
>> registerRunLoopMessageWindowClass() is moved to MainThreadWin.cpp while
>> openjfx uses MainThreadJava.cpp) and this
>> causes every
On Wed, 20 May 2020 14:30:11 GMT, Arun Joseph wrote:
> Cause: The Window Class `RunLoopMessageWindow` is never registered (this
> happens because
> registerRunLoopMessageWindowClass() is moved to MainThreadWin.cpp while
> openjfx uses MainThreadJava.cpp) and this
> causes every
On Tue, 1 Sep 2020 06:29:17 GMT, Bhawesh Choudhary
wrote:
>> ImageJava.cpp ignores CompositeOperator parameter in drawImage function due
>> to which shadow was getting drawn on top of
>> actual image. apply given composite operator to graphics context before
>> drawing image to fix this
On Tue, 1 Sep 2020 06:29:17 GMT, Bhawesh Choudhary
wrote:
>> ImageJava.cpp ignores CompositeOperator parameter in drawImage function due
>> to which shadow was getting drawn on top of
>> actual image. apply given composite operator to graphics context before
>> drawing image to fix this
The WebKit build fails with recent VS 2019 compiler.
Bug: This MediaQueryEvaluator constructor takes a String parameter, but the
conversion of char* to String is failing.
Fix: Use the default constructor of MediaQueryEvaluator, which also returns
true for "all".
Test: Build webkit with the
On Wed, 2 Sep 2020 11:22:45 GMT, Arun Joseph wrote:
> The WebKit build fails with recent VS 2019 compiler.
>
> Bug: This MediaQueryEvaluator constructor takes a String parameter, but the
> conversion of char* to String is failing.
>
> Fix: Use the default constructor of M
On Thu, 3 Sep 2020 06:07:10 GMT, Bhawesh Choudhary
wrote:
>> ImageJava.cpp ignores CompositeOperator parameter in drawImage function due
>> to which shadow was getting drawn on top of
>> actual image. apply given composite operator to graphics context before
>> drawing image to fix this
On Mon, 5 Oct 2020 07:08:33 GMT, Arun Joseph wrote:
> Issue: In JDK15,
> [URLConnection](https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/sun/net/www/URLConnection.java)
> class overrode the getHeaderFields() methods to return properties, which
> previou
Issue: In JDK15,
[URLConnection](https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/sun/net/www/URLConnection.java)
class overrode the getHeaderFields() methods to return properties, which
previously returned an empty map from its
super class.
Fix: Extract headers only when
On Fri, 9 Oct 2020 22:14:15 GMT, Kevin Rushforth wrote:
>> Arun Joseph has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Update copyright year
>> - Minor refactoring
>
> modules/javafx.web/src/m
On Fri, 9 Oct 2020 21:48:40 GMT, Kevin Rushforth wrote:
>> Arun Joseph has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Update copyright year
>> - Minor refactoring
>
> modules/javafx.grap
> doesn't use patternTransform argument as
> ImagePattern doesn't have the same attribute. So, the final image won't be
> transformed.
Arun Joseph has updated the pull request incrementally with one additional
commit since the last revision:
Fix incorrect concat param order
On Mon, 12 Oct 2020 13:42:08 GMT, Kevin Rushforth wrote:
>> Instead of negation, it should have been at the opposite positions. I have
>> fixed this in the latest commit. The arg
>> list order for
>>
On Mon, 19 Oct 2020 04:29:13 GMT, Arun Joseph wrote:
> We should use the public_suffix_list.dat file in the JDK instead. Reading the
> public_suffix_list.dat file is modified
> to be similar to
> [DomainName.java](https://github.com/openjdk/jdk/blob/master/src/java.base/share
We should use the public_suffix_list.dat file in the JDK instead. Reading the
public_suffix_list.dat file is modified
to be similar to
[DomainName.java](https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/sun/security/util/DomainName.java).
If the file is not present,
On Tue, 11 Aug 2020 16:18:37 GMT, Bhawesh Choudhary
wrote:
> ImageJava.cpp ignores CompositeOperator parameter in drawImage function due
> to which shadow was getting drawn on top of
> actual image. apply given composite operator to graphics context before
> drawing image to fix this issue.
On Wed, 12 Aug 2020 15:59:20 GMT, Kevin Rushforth wrote:
> With your patch installed, I see a race condition that manifests in one of
> two ways:
I couldn't reproduce the race condition or crash with the fix.
> I suspect this might be related to the gc.setCompositeOperation call.
This may
On Thu, 27 Aug 2020 14:59:56 GMT, Arun Joseph wrote:
> Update to GTK WebKit 2.28.4
> https://webkitgtk.org/2020/07/28/webkitgtk2.28.4-released.html
This pull request has now been integrated.
Changeset: 88c0f978
Author: Arun Joseph
URL: https://git.openjdk.java.net/jfx/commit/88
> doesn't use patternTransform argument as
> ImagePattern doesn't have the same attribute. So, the final image won't be
> transformed.
Arun Joseph has updated the pull request incrementally with one additional
commit since the last revision:
Incorect axis of rotational
-
Update to GTK WebKit 2.28.4
https://webkitgtk.org/2020/07/28/webkitgtk2.28.4-released.html
-
Commit messages:
- 8252381: Cherry pick GTK WebKit 2.28.4 changes
Changes: https://git.openjdk.java.net/jfx/pull/289/files
Webrev: https://webrevs.openjdk.java.net/jfx/289/webrev.00
> doesn't use patternTransform argument as
> ImagePattern doesn't have the same attribute. So, the final image won't be
> transformed.
Arun Joseph has updated the pull request incrementally with three additional
commits since the last revision:
- Exclude TYPE_IDENTITY case
- Anothe
> doesn't use patternTransform argument as
> ImagePattern doesn't have the same attribute. So, the final image won't be
> transformed.
Arun Joseph has updated the pull request incrementally with two additional
commits since the last revision:
- Update copyright year
-
On Fri, 14 Aug 2020 06:23:18 GMT, Tobias Diez
wrote:
>> Currently, loading a style sheet file using
>> `WebView.getEngine().setUserStyleSheetLocation(url)` fails if the url
>> start's with `jrt`, i.e. if the file is packaged in an application image
>> using jlink. This is fixed with this PR.
On Mon, 14 Sep 2020 13:47:28 GMT, Bhawesh Choudhary
wrote:
>> Root cause of issue is Specifying a image mask from GraphicsContextJava.cpp
>> in WebKit was not implemented, so masking
>> doesn't take place at all while rendering SVGRect. to fix this issue add
>> implementation of function
On Thu, 17 Sep 2020 06:29:36 GMT, Arun Joseph wrote:
>> Bhawesh Choudhary has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Updates as per review comments
>
> The fix works when the shape is displayed init
Issue: Snapshot taken before webpage is rendered
Fix: Use stateProperty and sleep to wait for the page to finish rendering
-
Commit messages:
- Add sleep
- 8243110: SVGTest.testSVGRenderingWithPattern fails intermittently
Changes: https://git.openjdk.java.net/jfx/pull/240/files
Cause: The test assumes that WebView/WebPage will be GCed right after
`System.gc()`
Fix: Use `runFinalization()` and `sleep()` to wait for objects to get GCed
-
Commit messages:
- Update copyright year
- Remove unwanted line
- 8234540: javafx.web
> Issue: Snapshot taken before webpage is rendered
>
> Fix: Use stateProperty and sleep to wait for the page to finish rendering
Arun Joseph has updated the pull request incrementally with one additional
commit since the last revision:
Review comments
-
Changes:
- a
On Thu, 28 May 2020 08:45:36 GMT, Arun Joseph wrote:
> Issue: Snapshot taken before webpage is rendered
>
> Fix: Use stateProperty and sleep to wait for the page to finish rendering
This pull request has now been integrated.
Changeset: 9edba9cc
Author:Arun Joseph
URL:
On Tue, 26 May 2020 09:27:52 GMT, Arun Joseph wrote:
> Cause: The test assumes that WebView/WebPage will be GCed right after
> `System.gc()`
>
> Fix: Use `runFinalization()` and `sleep()` to wait for objects to get GCed
This pull request has now been integrated.
Changeset: 891
Vote: YES
— Arun Joseph
> On 01-Jun-2020, at 7:22 PM, Kevin Rushforth
> wrote:
>
> I hereby nominate Jeanette Winzenburg [1] to OpenJFX Committer.
>
> Jeanette is an OpenJFX community member, who has contributed 16 changesets
> [2][3] to OpenJFX.
>
> Vot
Vote: YES
— Arun Joseph
> On 01-Jun-2020, at 7:23 PM, Kevin Rushforth
> wrote:
>
> I hereby nominate Jose Pereda [1] to OpenJFX Committer.
>
> Jose is an OpenJFX community member, who has contributed 16 changesets [2][3]
> to OpenJFX.
>
> Votes are due by June
Vote: YES
> On 23-Oct-2020, at 8:08 PM, Kevin Rushforth
> wrote:
>
> I hereby nominate Pankaj Bansal [1] to OpenJFX Committer.
>
> Pankaj is a member of Java client team at Oracle, who has contributed 11
> commits [2] to OpenJFX.
>
> Votes are due by November 6, 2020.
>
> Only current
Issue: Tests using `WebPageShim::paint` fails around 1/10 times.
Fix: Execute `WebPageShim::paint` in the render thread using `PrismInvoker`.
Ran tests over 100 times, no failures.
Used the initial unit test in the PR for
[JDK-8202990](https://bugs.openjdk.java.net/browse/JDK-8202990).
On Thu, 23 Jul 2020 09:43:36 GMT, Bhawesh Choudhary
wrote:
>> root cause of issue is prism's fillRoundedRect() API doesn't allow rendering
>> of rounded corner rectangle if four
>> corners have different radii. but same can be achieved via Path. to fix the
>> issue, in GraphicsContextJava.cpp
On Wed, 1 Jul 2020 17:14:30 GMT, Arun Joseph wrote:
> We currently use SQLite version 3.31.1. We should update to the latest stable
> release version 3.32.3 released on
> 2020-06-18. https://www.sqlite.org/index.html
This pull request has now been integrated.
Changeset: f3a044
We currently use SQLite version 3.31.1. We should update to the latest stable
release version 3.32.3 released on
2020-06-18. https://www.sqlite.org/index.html
-
Commit messages:
- 8247963: Update SQLite to version 3.32.3
Changes: https://git.openjdk.java.net/jfx/pull/261/files
Update JavaFX WebKit to GTK WebKit 2.28 (610.1)
-
Commit messages:
- Fix exec files
- 8245284: Update to 610.1 version of WebKit
Changes: https://git.openjdk.java.net/jfx/pull/263/files
Webrev: https://webrevs.openjdk.java.net/jfx/263/webrev.00
Issue:
On Sun, 14 Jun 2020 19:13:41 GMT, Bhawesh Choudhary
wrote:
>> Print function of WebEngine.java ignores page range setting and prints given
>> number of pages starting from first page,
>> which is the root cause of this issue. To fix it, put check for page ranges
>> and if it available, use it
On Tue, 2 Jun 2020 17:52:37 GMT, Johan Vos wrote:
> add changes to build a static version of libjfxwebkit.a
> Fox for JDK-8246357
Changes looks good to me.
-
Marked as reviewed by ajoseph (Committer).
PR: https://git.openjdk.java.net/jfx/pull/245
On Thu, 23 Jul 2020 05:34:50 GMT, Arun Joseph wrote:
> Update to GTK WebKit 2.28.3
> https://webkitgtk.org/2020/07/09/webkitgtk2.28.3-released.html
This pull request has now been integrated.
Changeset: 926b5b6b
Author: Arun Joseph
URL: https://git.openjdk.java.net/jfx/commit/92
On Tue, 21 Jul 2020 21:50:39 GMT, Bhawesh Choudhary
wrote:
>> Root cause of issue is Specifying a image mask from GraphicsContextJava.cpp
>> in WebKit was not implemented, so masking
>> doesn't take place at all while rendering SVGRect. to fix this issue add
>> implementation of function
Update to GTK WebKit 2.28.3
https://webkitgtk.org/2020/07/09/webkitgtk2.28.3-released.html
-
Commit messages:
- Cherry pick GTK WebKit 2.28.3 changes
Changes: https://git.openjdk.java.net/jfx/pull/271/files
Webrev: https://webrevs.openjdk.java.net/jfx/271/webrev.00
Issue:
On Fri, 10 Jul 2020 05:26:39 GMT, Arun Joseph wrote:
> Update JavaFX WebKit to GTK WebKit 2.28 (610.1)
This pull request has now been integrated.
Changeset: 5e7e452c
Author: Arun Joseph
URL: https://git.openjdk.java.net/jfx/commit/5e7e452c
Stats: 300855 lines in 5370 fi
On Mon, 27 Jul 2020 21:16:41 GMT, Nir Lisker wrote:
>> Fixes https://bugs.openjdk.java.net/browse/JDK-8246343 and some additional
>> fixes in the vicinity.
>
> Nir Lisker has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Addressed review
> doesn't use patternTransform argument as
> ImagePattern doesn't have the same attribute. So, the final image won't be
> transformed.
Arun Joseph has updated the pull request incrementally with one additional
commit since the last revision:
Modify SW pipeline
-
Chang
not present, `isPublicSuffix()` returns `false`, which is
> similar to how WebKit ignores the public suffix check when it is disabled.
>
> Test: Run PublicSuffixesTest.java
Arun Joseph has updated the pull request incrementally with one additional
commit since the last revision:
A
The WebKit build fails with recent Xcode 12.
Bug: `getVTablePointer()` should return a const void*
Fix: Use const void* and remove dependency on JavaVM.framework in Xcode
Upstream fix: https://bugs.webkit.org/show_bug.cgi?id=207871
Test: Build webkit with the Xcode 12 compiler with and without
On Tue, 8 Dec 2020 17:29:56 GMT, Arun Joseph wrote:
> The WebKit build fails with recent Xcode 12.
>
> Bug: `getVTablePointer()` should return a const void*
>
> Fix: Use const void* and remove dependency on JavaVM.framework in Xcode
> Upstream fix: https://bugs.webkit.o
not present, `isPublicSuffix()` returns `false`, which is
> similar to how WebKit ignores the public suffix check when it is disabled.
>
> Test: Run PublicSuffixesTest.java
Arun Joseph has updated the pull request incrementally with one additional
commit since the last revision:
Cr
On Mon, 19 Oct 2020 04:29:13 GMT, Arun Joseph wrote:
> We should use the public_suffix_list.dat file in the JDK instead. Reading the
> public_suffix_list.dat file is modified to be similar to
> [DomainName.java](https://github.com/openjdk/jdk/blob/master/src/java.base/share/cl
not present, `isPublicSuffix()` returns `false`, which is
> similar to how WebKit ignores the public suffix check when it is disabled.
>
> Test: Run PublicSuffixesTest.java
Arun Joseph has updated the pull request incrementally with one additional
commit since the last revision:
On Tue, 15 Dec 2020 16:57:13 GMT, Matthias Bläsing
wrote:
>> The code in WTF::scheduleDispatchFunctionsOnMainThread assumes, that
>> the java class com.sun.webkit.MainThread can be found be the JNI
>> function FindClass. This is only true if the class is loadable by the
>> system class loader.
On Wed, 16 Dec 2020 19:07:17 GMT, Matthias Bläsing
wrote:
>> The code in WTF::scheduleDispatchFunctionsOnMainThread assumes, that
>> the java class com.sun.webkit.MainThread can be found be the JNI
>> function FindClass. This is only true if the class is loadable by the
>> system class loader.
not present, `isPublicSuffix()` returns `false`, which is
> similar to how WebKit ignores the public suffix check when it is disabled.
>
> Test: Run PublicSuffixesTest.java
Arun Joseph has updated the pull request incrementally with one additional
commit since the last revision:
C
1 - 100 of 158 matches
Mail list logo
