On Sat, 25 Sep 2021 13:55:15 GMT, John Hendrikx wrote:
>> I've added JUnit 5 as a test dependency and made sure that the JUnit 4 tests
>> still work. Also added a single JUnit 5 tests, and confirmed it works.
>>
>> I've updated the Eclipse project file for the base module only.
>
> John
On Thu, 14 Oct 2021 12:32:24 GMT, Kevin Rushforth wrote:
> The failure was caused by a change that was done in connection with the
> WebKit 610.2 update,
> [JDK-8259635](https://bugs.openjdk.java.net/browse/JDK-8259635). The
> `FrameLoaderClient::userAgent` function was chang
On Wed, 20 Oct 2021 11:53:30 GMT, Ambarish Rapte wrote:
> Copyright year in these 3 docs needs to be updated to 2022.
Marked as reviewed by kcr (Lead).
-
PR: https://git.openjdk.java.net/jfx/pull/645
On Mon, 18 Oct 2021 12:59:17 GMT, Abhinay Agarwal wrote:
> Release Notes for 17.0.1
Marked as reviewed by kcr (Lead).
-
PR: https://git.openjdk.java.net/jfx17u/pull/14
On Mon, 18 Oct 2021 03:42:37 GMT, Abhinay Agarwal wrote:
> Release notes for 17.0.1
@abhinayagarwal This should be done as a PR in the
[openjdk/jfx17u](https://github.com/openjdk/jfx17u) repo, which is the repo we
use for JavaFX 17 update releases. You will need to close this PR and create a
On Fri, 15 Oct 2021 14:24:15 GMT, Nir Lisker wrote:
>> Replacements of more immutable collections.
>>
>> One thing I found was that the field `idMap` in
>> `com.sun.java.scene.web.WebViewHelper.WebView` seems unused. I can remove it
>> if that's indeed the case.
>
> Nir Lisker has updated the
On Fri, 15 Oct 2021 16:23:10 GMT, Kevin Rushforth wrote:
> > Do you want to do something about `idMap` in
> > `com.sun.java.scene.web.WebViewHelper.WebView` that I pointed out in the PR?
>
> I missed that comment. Where do you see this field? I can't find it anywhere.
Oh,
On Fri, 15 Oct 2021 15:04:00 GMT, Nir Lisker wrote:
> Do you want to do something about `idMap` in
> `com.sun.java.scene.web.WebViewHelper.WebView` that I pointed out in the PR?
I missed that comment. Where do you see this field? I can't find it anywhere.
-
PR:
On Thu, 23 Sep 2021 19:01:52 GMT, Marius Hanl wrote:
> This PR fixes an issue which is probably in JavaFX since VirtualFlow exists.
> While horizontal scrolling any VirtualFlow control the left blue border
> sometimes disappear/gets smaller. (see also image below)
>
> This can be fixed by
On Tue, 21 Sep 2021 11:13:06 GMT, Nir Lisker wrote:
> Replacements of more immutable collections.
>
> One thing I found was that the field `idMap` in
> `com.sun.java.scene.web.WebViewHelper.WebView` seems unused. I can remove it
> if that's indeed the case.
Marked as reviewed by kcr (Lead).
ing breaks, but it's relatively small.
On the related question, I like the idea of nulling out the current
value
when a property is bound.
I can pick up from where the older PR stopped. It's a simple change.
On Wed, Oct 6, 2021 at 3:15 AM Kevin Rushforth
wrote:
Given that the
invalid all the time, so they won't receive an
invalidation event.
On Wed, Oct 6, 2021 at 2:16 AM Kevin Rushforth
mailto:kevin.rushfo...@oracle.com>>
wrote:
>
> Given that the intention of InvalidationListener was to be a
> light-weight way to listen to properties
On Thu, 14 Oct 2021 21:47:16 GMT, Marius Hanl wrote:
>> This PR fixes a bug where the blend mode will be falsely recognized as a
>> color and therefore won't be set.
>> Also a ClassCastException is thrown (The converter expects a String, but
>> gets a Color).
>>
>> Note: There is another
On Wed, 6 Oct 2021 07:43:15 GMT, Marius Hanl wrote:
> This PR fixes a bug where the blend mode will be falsely recognized as a
> color and therefore won't be set.
> Also a ClassCastException is thrown (The converter expects a String, but gets
> a Color).
>
> Note: There is another similar
On Tue, 28 Sep 2021 12:07:36 GMT, Florian Kirmaier
wrote:
>> When using Swing it's possible to generate a Deadlock.
>> It's related to the nested eventloop started in enterFullScreenExitingLoop
>> - and the RenderLock aquired when using setView in Scene.
>> Sample Programm and Threaddump are
On Tue, 5 Oct 2021 20:36:37 GMT, Martin Fox wrote:
> The test case for JDK-8160241 creates a window in a zoomed state (as defined
> by macOS). When the OS later goes to unzoom the window it will try to shrink
> it down to 1 point wide. This was entered as JDK-8163137 but the fix for that
>
On Sat, 25 Sep 2021 13:55:15 GMT, John Hendrikx wrote:
>> I've added JUnit 5 as a test dependency and made sure that the JUnit 4 tests
>> still work. Also added a single JUnit 5 tests, and confirmed it works.
>>
>> I've updated the Eclipse project file for the base module only.
>
> John
On Thu, 22 Jul 2021 11:50:11 GMT, Florian Kirmaier
wrote:
>> After thinking about this issue for some time, I've now got a solution.
>> I know put the scene in the state it is, before is was shown, when the
>> dirtyNodes are unset, the whole scene is basically considered dirty.
>> This has
On Tue, 28 Sep 2021 12:07:36 GMT, Florian Kirmaier
wrote:
>> When using Swing it's possible to generate a Deadlock.
>> It's related to the nested eventloop started in enterFullScreenExitingLoop
>> - and the RenderLock aquired when using setView in Scene.
>> Sample Programm and Threaddump are
On Tue, 28 Sep 2021 12:07:36 GMT, Florian Kirmaier
wrote:
>> When using Swing it's possible to generate a Deadlock.
>> It's related to the nested eventloop started in enterFullScreenExitingLoop
>> - and the RenderLock aquired when using setView in Scene.
>> Sample Programm and Threaddump are
On Wed, 13 Oct 2021 23:59:40 GMT, Phil Race wrote:
> On an external (non-retina) monitor JavaFX LCD text on macOS is painful on
> the eyes.
> Retina diminishes it rather than cures it.
>
> The problem is a mix of a couple of things
> 1) CoreText no longer generates LCD glyphs (except perhaps
On Wed, 13 Oct 2021 23:59:40 GMT, Phil Race wrote:
> On an external (non-retina) monitor JavaFX LCD text on macOS is painful on
> the eyes.
> Retina diminishes it rather than cures it.
>
> The problem is a mix of a couple of things
> 1) CoreText no longer generates LCD glyphs (except perhaps
The failure was caused by a change that was done in connection with the WebKit
610.2 update, [JDK-8259635](https://bugs.openjdk.java.net/browse/JDK-8259635).
The `FrameLoaderClient::userAgent` function was changed in WebKit itself to be
a const method in WebKit 610.2. We override that method in
On Mon, 27 Sep 2021 05:27:25 GMT, Robert Lichtenberger
wrote:
>> This PR fixes JDK-8274137 by removing the optimization from updateHbar()
>> that will no-op the method in case the VirtualFlow is invisible or currently
>> has no scene.
>> Since changes to the hBar's value can happen even if
On Wed, 22 Sep 2021 16:39:15 GMT, Thiago Milczarek Sayao
wrote:
>> Found the problem thru this path:
>>
>> **WindowStage.java**
>>
>> final void handleFocusDisabled() {
>> if (activeWindows.isEmpty()) {
>> return;
>> }
>> WindowStage window =
On Wed, 22 Sep 2021 16:39:15 GMT, Thiago Milczarek Sayao
wrote:
>> Found the problem thru this path:
>>
>> **WindowStage.java**
>>
>> final void handleFocusDisabled() {
>> if (activeWindows.isEmpty()) {
>> return;
>> }
>> WindowStage window =
Given that the intention of InvalidationListener was to be a
light-weight way to listen to properties without causing a binding chain
to be revalidated, it does seem reasonable to me that the listener is
only fired on the valid --> invalid transition, which is the specified
behavior, even if
On Sun, 19 Sep 2021 01:40:11 GMT, Nir Lisker wrote:
>> Added convenience factory factory methods for Background and Border.
>
> Nir Lisker has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Added null tests and changed doc as per comments
On Fri, 1 Oct 2021 21:11:01 GMT, John Nader
wrote:
> Here is the minimal application I am using to recreate the issue.
I'll attach the test case you provided to the bug report.
> The question now is should the work done on this PR be abandoned. It
> addresses a current performance limitation
value of 10.4 (scale 1.25). As we can just
render on a whole pixel, what will happen?
- Marius
*Gesendet:* Dienstag, 28. September 2021 um 01:57 Uhr
*Von:* "Kevin Rushforth"
*An:* openjfx-dev@openjdk.java.net
*Betreff:* Re: JavaFX snapping and scale
The basic idea behind snapping to pixel
If changing the default behavior makes it consistent with native apps on
macOS and with JavaFX apps on other platforms, then it seems like the
right thing to do. We would want a CSR for the behavior change
As for your question about finding the bug using the old "RT-" bug
ID, you can just
On Thu, 30 Sep 2021 13:24:26 GMT, Michael Paus wrote:
>> Fixes the issue by using the "open" command as discussed before.
>> See: https://bugs.openjdk.java.net/browse/JDK-8214158
>
> Michael Paus has updated the pull request incrementally with one additional
> commit since the last revision:
>
On Wed, 29 Sep 2021 13:20:08 GMT, Michael Paus wrote:
>> Fixes the issue by using the "open" command as discussed before.
>> See: https://bugs.openjdk.java.net/browse/JDK-8214158
>
> Michael Paus has updated the pull request incrementally with one additional
> commit since the last revision:
>
On Tue, 27 Jul 2021 05:45:50 GMT, Marius Hanl wrote:
>> This PR fixes a long standing issue with the TreeTableView indentation.
>>
>> ![image](https://user-images.githubusercontent.com/66004280/124681647-473e7380-dec9-11eb-906d-4228fc39cbf9.png)
>>
>> In short:
>> **TreeTableCellSkin**
I can see the original submission you sent (and yes, Praveen didn't
attach it). I can attach it, but I have a question about it. Also, it
will need some modifications before we can take a look at it.
1. There are differences between the one you originally sent and the one
pointed two in your
on this addition.
On Fri, Sep 24, 2021 at 2:47 PM Kevin Rushforth
mailto:kevin.rushfo...@oracle.com>> wrote:
I don't have an objection to adding this one additional convenience
method if it is generally useful. If there aren't a lot of
applications
that would use it, it seems better
On Tue, 28 Sep 2021 17:19:38 GMT, Michael Paus wrote:
> First of all. Shall I follow the bot request above and create a new pull
> request? Wouldn't we loose the discussion here then?
As long as you don't otherwise need to update your `master` branch, you can
wait to reset it until after this
On Tue, 28 Sep 2021 16:06:30 GMT, Michael Paus wrote:
> Fixes the issue by using the "open" command as discussed before.
> See: https://bugs.openjdk.java.net/browse/JDK-8214158
This seems like a good RFE. I have a couple overall questions.
First, calling `open` was originally proposed in the
The basic idea behind snapping to pixel boundaries (which is optional,
but on by default) is that 2D primitives will look more crisp if they
are rendered on whole pixel boundaries. When there is no HiDPI involved,
the operation of snapping to a pixel boundary can be done with a simple
floor,
On Mon, 27 Sep 2021 16:59:42 GMT, Kevin Rushforth wrote:
> Clean backport to `jfx11u` of WebKit GTK 2.32.4 fixes.
This pull request has now been integrated.
Changeset: 070c2435
Author: Kevin Rushforth
URL:
https://git.openjdk.java.net/jfx11u/com
On Mon, 27 Sep 2021 16:59:37 GMT, Kevin Rushforth wrote:
> Clean backport to `jfx17u` of WebKit GTK 2.32.4 fixes.
This pull request has now been integrated.
Changeset: 90a7c28c
Author: Kevin Rushforth
URL:
https://git.openjdk.java.net/jfx17u/com
Clean backport to `jfx17u` of WebKit GTK 2.32.4 fixes.
-
Commit messages:
- 8274107: Cherry pick GTK WebKit 2.32.4 changes
Changes: https://git.openjdk.java.net/jfx17u/pull/13/files
Webrev: https://webrevs.openjdk.java.net/?repo=jfx17u=13=00
Issue:
Clean backport to `jfx11u` of WebKit GTK 2.32.4 fixes.
-
Commit messages:
- 8274107: Cherry pick GTK WebKit 2.32.4 changes
Changes: https://git.openjdk.java.net/jfx11u/pull/54/files
Webrev: https://webrevs.openjdk.java.net/?repo=jfx11u=54=00
Issue:
Voting for Thiago Sayao [1] to OpenJFX Committer [2] is now closed.
Yes: 8
Veto: 0
Abstain: 0
According to the Bylaws definition of Lazy Consensus, this is sufficient
to approve the nomination.
-- Kevin
[1] https://openjdk.java.net/census#tsayao
[2]
I also see advantages in moving to JUnit 5, given that we can still
support both JUint 4 and JUnit 5 in the same project using
jupiter-vintage (thus avoiding the need to rewrite existing tests).
Do any other contributors have experiences with JUnit 5 that they could
share?
-- Kevin
On
On Fri, 24 Sep 2021 21:20:19 GMT, John Hendrikx wrote:
>> I've added JUnit 5 as a test dependency and made sure that the JUnit 4 tests
>> still work. Also added a single JUnit 5 tests, and confirmed it works.
>>
>> I've updated the Eclipse project file for the base module only.
>
> John
On Fri, 24 Sep 2021 20:25:48 GMT, John Hendrikx wrote:
> Sorry for the force push, forgot I already submitted it as a PR.
That's OK. I deleted the couple of comments I had added relating to blocks that
disappeared.
-
PR: https://git.openjdk.java.net/jfx/pull/633
On Fri, 24 Sep 2021 20:41:19 GMT, John Hendrikx wrote:
>> I've added JUnit 5 as a test dependency and made sure that the JUnit 4 tests
>> still work. Also added a single JUnit 5 tests, and confirmed it works.
>>
>> I've updated the Eclipse project file for the base module only.
>
> John
as a
convenience method.
Any other use case is likely to be so complex that it makes sense to
use the normal existing constructors.
Feel free to share you opinion.
- Marius
Gesendet: Dienstag, 08. Juni 2021 um 03:19 Uhr
Von: "Nir Lisker"
An: "
On Fri, 24 Sep 2021 06:16:55 GMT, Robert Lichtenberger
wrote:
> > First, this has the potential to hurt performance for applications that do
> > a lot of setup on tables that aren't visible.
>
> That would be possible if the hbar changes its visibility or its value. I
> can't really see how
On Fri, 24 Sep 2021 06:28:30 GMT, Robert Lichtenberger
wrote:
>> This PR fixes JDK-8274137 by removing the optimization from updateHbar()
>> that will no-op the method in case the VirtualFlow is invisible or currently
>> has no scene.
>> Since changes to the hBar's value can happen even if
On Thu, 23 Sep 2021 19:26:47 GMT, Ambarish Rapte wrote:
> Cherry pick the GTK webkit 2.32.4 changes
> https://webkitgtk.org/2021/09/17/webkitgtk2.32.4-released.html
Looks good. I built and tested it on all platforms.
-
Marked as reviewed by kcr (Lead).
PR:
On Thu, 23 Sep 2021 13:48:44 GMT, Robert Lichtenberger
wrote:
> This PR fixes JDK-8274137 by removing the optimization from updateHbar() that
> will no-op the method in case the VirtualFlow is invisible or currently has
> no scene.
> Since changes to the hBar's value can happen even if the
On Tue, 21 Sep 2021 11:13:06 GMT, Nir Lisker wrote:
> Replacements of more immutable collections.
>
> One thing I found was that the field `idMap` in
> `com.sun.java.scene.web.WebViewHelper.WebView` seems unused. I can remove it
> if that's indeed the case.
This is a pretty simple change,
On Wed, 22 Sep 2021 21:36:26 GMT, delvh
wrote:
>> Replacements of more immutable collections.
>>
>> One thing I found was that the field `idMap` in
>> `com.sun.java.scene.web.WebViewHelper.WebView` seems unused. I can remove it
>> if that's indeed the case.
>
>
On Wed, 22 Sep 2021 13:59:43 GMT, Nir Lisker wrote:
> > We added `@SuppressWarnings("removal")` annotations for JDK-8264139, so I'm
> > surprised the IDE is still flagging it.
>
> The warning is on the `import` of the class, which can be suppressed by
> adding the annotation to the class
On Tue, 21 Sep 2021 12:45:20 GMT, Kevin Rushforth wrote:
> As mentioned in JBS, the `clearQuad` methods in `D3DGraphics` and
> `ES2Graphics` are now identical, which should have been the case all along.
> The fact that they weren't identical was the source of a bug that was only
>
On Tue, 21 Sep 2021 12:45:20 GMT, Kevin Rushforth wrote:
> As mentioned in JBS, the `clearQuad` methods in `D3DGraphics` and
> `ES2Graphics` are now identical, which should have been the case all along.
> The fact that they weren't identical was the source of a bug that was only
>
On Wed, 22 Sep 2021 10:18:09 GMT, Florian Kirmaier
wrote:
>> Probably my most boring PR. ;)
>> Setting the lambda to null, after it has been used, fixes the leak.
>
> Florian Kirmaier has updated the pull request incrementally with one
> additional commit since the last revision:
>
>
As mentioned in JBS, the `clearQuad` methods in `D3DGraphics` and `ES2Graphics`
are now identical, which should have been the case all along. The fact that
they weren't identical was the source of a bug that was only discovered during
the testing of
On Tue, 21 Sep 2021 08:53:07 GMT, Hadzic Samir wrote:
>> JBS bug: [JDK-8090158](https://bugs.openjdk.java.net/browse/JDK-8090158)
>>
>> The javadoc of the ScrollBar#adjustValue specifically says that it will
>> adjust the value based on the block increment value. Therefore, there is no
>>
On Mon, 14 Jun 2021 11:05:25 GMT, Andreas Heger
wrote:
>> @andreas-heger Welcome to the `jfx` project. At a quick glance, the fix
>> looks promising. Have you tested this on Windows with Hi-DPI to make sure
>> there is no impact? Would you be able add an automated test case that fails
>>
On Sun, 19 Sep 2021 15:33:46 GMT, Florian Kirmaier
wrote:
> Probably my most boring PR. ;)
> Setting the lambda to null, after it has been used, fixes the leak.
The fix looks obviously correct. I verified that the test catches the bug
(fails without the fix and passes with the fix). I left a
On Mon, 14 Jun 2021 20:53:50 GMT, John Neffenger wrote:
>> This pull request allows for reproducible builds of JavaFX on Linux, macOS,
>> and Windows by defining the `SOURCE_DATE_EPOCH` environment variable. For
>> example, the following commands create a reproducible build:
>>
>>
>> $
On Mon, 14 Jun 2021 20:53:50 GMT, John Neffenger wrote:
>> This pull request allows for reproducible builds of JavaFX on Linux, macOS,
>> and Windows by defining the `SOURCE_DATE_EPOCH` environment variable. For
>> example, the following commands create a reproducible build:
>>
>>
>> $
away from window management as well?
-- Thiago.
Em qua., 1 de set. de 2021 às 08:42, Kevin Rushforth <
kevin.rushfo...@oracle.com> escreveu:
This seems reasonable to me as well, at least for JavaFX since we
already rely on Gtk for most of the windowing toolkit on Linux.
-- Kevin
On
On Tue, 17 Aug 2021 13:12:41 GMT, Pankaj Bansal wrote:
>> Thiago Milczarek Sayao has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Change test to manual
>
> The fix works fine and the test passes on all platforms. I have given minor
>
On Fri, 17 Sep 2021 13:00:20 GMT, Thiago Milczarek Sayao
wrote:
>> It seems raw images need to be converted BRGA -> RGBA.
>>
>> It was being converted on gtk2 code path, but gtk3 only uses
>> `gtk_drag_set_icon_pixbuf`.
>>
>> I have simplified the gtk2 `DragView::View::expose` to paint with
On Thu, 16 Sep 2021 13:22:32 GMT, Florian Kirmaier
wrote:
>> When using Swing it's possible to generate a Deadlock.
>> It's related to the nested eventloop started in enterFullScreenExitingLoop
>> - and the RenderLock aquired when using setView in Scene.
>> Sample Programm and Threaddump are
On Thu, 16 Sep 2021 13:22:32 GMT, Florian Kirmaier
wrote:
>> When using Swing it's possible to generate a Deadlock.
>> It's related to the nested eventloop started in enterFullScreenExitingLoop
>> - and the RenderLock aquired when using setView in Scene.
>> Sample Programm and Threaddump are
On Thu, 16 Sep 2021 22:25:27 GMT, Jose Pereda wrote:
>> Currently, `WebPage` has already a public `setBackgroundColor()` method, but
>> the class is not public. Therefore, public API is needed in `WebView` to
>> allow developers access to it.
>>
>> In line with the `fontSmoothingType`
On Thu, 5 Aug 2021 23:38:06 GMT, Thiago Milczarek Sayao
wrote:
> Found the problem thru this path:
>
> **WindowStage.java**
>
> final void handleFocusDisabled() {
> if (activeWindows.isEmpty()) {
> return;
> }
> WindowStage window =
On Fri, 20 Aug 2021 22:22:51 GMT, Thiago Milczarek Sayao
wrote:
>> It seems raw images need to be converted BRGA -> RGBA.
>>
>> It was being converted on gtk2 code path, but gtk3 only uses
>> `gtk_drag_set_icon_pixbuf`.
>>
>> I have simplified the gtk2 `DragView::View::expose` to paint with
On Thu, 9 Sep 2021 23:43:29 GMT, Nir Lisker wrote:
>> Added convenience factory factory methods for Background and Border.
>
> Nir Lisker has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Removed whitespaces
> - Added tests and doc
On Sat, 4 Sep 2021 15:44:17 GMT, Abhinay Agarwal
wrote:
>> 8172095: Let Node.managed become CSS-styleable
>
> Abhinay Agarwal has updated the pull request incrementally with two
> additional commits since the last revision:
>
> - Add default value tests for setting / getting the managed
On Fri, 10 Sep 2021 18:15:21 GMT, Jose Pereda wrote:
>> Currently, `WebPage` has already a public `setBackgroundColor()` method, but
>> the class is not public. Therefore, public API is needed in `WebView` to
>> allow developers access to it.
>>
>> In line with the `fontSmoothingType`
On Fri, 10 Sep 2021 18:15:21 GMT, Jose Pereda wrote:
>> Currently, `WebPage` has already a public `setBackgroundColor()` method, but
>> the class is not public. Therefore, public API is needed in `WebView` to
>> allow developers access to it.
>>
>> In line with the `fontSmoothingType`
On Thu, 16 Sep 2021 12:27:00 GMT, Kevin Rushforth wrote:
> Clean backport of update to `CONTRIBUTING.md` to clarify that clean backports
> of approved fixes can be integrated without further review.
This pull request has now been integrated.
Changeset: 896089eb
Author: Kevin Rushfort
Clean backport of update to `CONTRIBUTING.md` to clarify that clean backports
of approved fixes can be integrated without further review.
-
Commit messages:
- 8273732: Clarify review policies for clean backports in JavaFX update
releases
Changes:
On Wed, 15 Sep 2021 22:05:26 GMT, Kevin Rushforth wrote:
> Added a paragraph indicating that a review of a clean backport to an update
> release is optional, if the bug in question has been approved for inclusion
> into the release.
This pull request has now been integrated.
> Added a paragraph indicating that a review of a clean backport to an update
> release is optional, if the bug in question has been approved for inclusion
> into the release.
Kevin Rushforth has updated the pull request incrementally with one additional
commit since the last
On Wed, 15 Sep 2021 21:23:17 GMT, Kevin Rushforth wrote:
> Clean backport to `jfx17u`. This has been tested on all platforms along with
> other pending fixes in the `test-kcr-17.0.1` branch.
This pull request has now been integrated.
Changeset: 2947986a
Author: Kevin Rushfort
Added a paragraph indicating that a review of a clean backport to an update
release is optional, if the bug in question has been approved for inclusion
into the release.
-
Commit messages:
- 8273732: Clarify review policies for clean backports in JavaFX update
releases
Changes:
On Wed, 15 Sep 2021 21:22:49 GMT, Kevin Rushforth wrote:
> Clean backport to `jfx17u`. This has been tested on all platforms along with
> other pending fixes in the `test-kcr-17.0.1` branch.
This pull request has now been integrated.
Changeset: 5397290f
Author: Kevin Rushfort
Clean backport to `jfx17u`. This has been tested on all platforms along with
other pending fixes in the `test-kcr-17.0.1` branch.
-
Commit messages:
- 8272329: Cherry pick GTK WebKit 2.32.3 changes
Changes: https://git.openjdk.java.net/jfx17u/pull/8/files
Webrev:
On Wed, 15 Sep 2021 21:23:17 GMT, Kevin Rushforth wrote:
> Clean backport to `jfx17u`. This has been tested on all platforms along with
> other pending fixes in the `test-kcr-17.0.1` branch.
NOTE: I verified that after this PR and PR #7 are applied,
`modules/javafx.web/src/main/
On Wed, 15 Sep 2021 21:22:49 GMT, Kevin Rushforth wrote:
> Clean backport to `jfx17u`. This has been tested on all platforms along with
> other pending fixes in the `test-kcr-17.0.1` branch.
NOTE: I verified that after this PR and PR #8 are applied,
`modules/javafx.web/src/main/
Clean backport to `jfx17u`. This has been tested on all platforms along with
other pending fixes in the `test-kcr-17.0.1` branch.
-
Commit messages:
- 8270479: WebKit 612.1 build fails with Visual Studio 2017
Changes: https://git.openjdk.java.net/jfx17u/pull/7/files
Webrev:
On Mon, 13 Sep 2021 19:53:47 GMT, Kevin Rushforth wrote:
> Clean backport to `jfx17u`. This has been tested on all platforms along with
> other pending fixes in the `test-kcr-17.0.1` branch.
Thanks for the review and the sanity check.
> There are only differences of copyright ye
On Mon, 13 Sep 2021 19:53:47 GMT, Kevin Rushforth wrote:
> Clean backport to `jfx17u`. This has been tested on all platforms along with
> other pending fixes in the `test-kcr-17.0.1` branch.
This pull request has now been integrated.
Changeset: 092c20b0
Author: Kevin Rushfort
On Wed, 15 Sep 2021 18:56:37 GMT, Kevin Rushforth wrote:
> Clean backport to `jfx17u`. This has been tested along with other pending
> fixes in the `test-kcr-17.0.1` branch.
This pull request has now been integrated.
Changeset: 62355c90
Author: Kevin Rushforth
URL:
On Wed, 15 Sep 2021 18:56:07 GMT, Kevin Rushforth wrote:
> Clean backport to `jfx17u`. This has been tested along with other pending
> fixes in the `test-kcr-17.0.1` branch.
This pull request has now been integrated.
Changeset: ff4a6259
Author: Kevin Rushforth
URL:
On Wed, 15 Sep 2021 18:55:23 GMT, Kevin Rushforth wrote:
> Clean backport to `jfx17u`. This has been tested along with other pending
> fixes in the `test-kcr-17.0.1` branch.
This pull request has now been integrated.
Changeset: 3c6596b3
Author: Kevin Rushforth
URL:
Clean backport to `jfx17u`. This has been tested along with other pending fixes
in the `test-kcr-17.0.1` branch.
-
Commit messages:
- 8273324: IllegalArgumentException: fromIndex(0) > toIndex(-1) after clear
and select TableCell
Changes:
Clean backport to `jfx17u`. This has been tested along with other pending fixes
in the `test-kcr-17.0.1` branch.
-
Commit messages:
- 8268718: [macos] Video stops, but audio continues to play when stopTime is
reached
Changes: https://git.openjdk.java.net/jfx17u/pull/4/files
Clean backport to `jfx17u`. This has been tested along with other pending fixes
in the `test-kcr-17.0.1` branch.
-
Commit messages:
- 8273138: BidirectionalBinding fails to observe changes of invalid properties
Changes: https://git.openjdk.java.net/jfx17u/pull/5/files
Webrev:
On Mon, 13 Sep 2021 19:53:47 GMT, Kevin Rushforth wrote:
> Clean backport to `jfx17u`. This has been tested on all platforms along with
> other pending fixes in the `test-kcr-17.0.1` branch.
For some reason, Skara didn't mark this as clean, so it needs a (sanity) review.
@arapte C
We just pushed an early prototype of a new JavaFX Metal rendering
pipeline for macOS to a new "metal" branch of jfx-sandbox. We called it
"metal" with no bug ID or username prefix, to highlight that it is more
than an experiment: It is intended to be the branch where we will
develop the metal
On Wed, 15 Sep 2021 14:50:03 GMT, Johan Vos wrote:
> This release is needed with a backport of JDK-8273754
Marked as reviewed by kcr (Lead).
-
PR: https://git.openjdk.java.net/jfx/pull/624
On Thu, 9 Sep 2021 23:43:29 GMT, Nir Lisker wrote:
>> Added convenience factory factory methods for Background and Border.
>
> Nir Lisker has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Removed whitespaces
> - Added tests and doc
601 - 700 of 4744 matches
Mail list logo