Review request : RT-32332

2013-11-19 Thread Rafi Tayar
Hi, Would you review a fix for this Jira ? RT-32332 DFB: Application is being aborted during inserting text to Pop-up window https://javafx-jira.kenai.com/browse/RT-32332 The patch is attached to the jira. Thanks, Rafi

[8u] Rweview request: RT-35165 [iOS,Android] Defender Methods in ObservableList do not compile on iOS or Android

2014-01-30 Thread Rafi Tayar
Hi Martin, Please review the following. The webrev is attached to the Jira, please see the last comment. https://javafx-jira.kenai.com/browse/RT-35165#comment-383586 Thanks, Rafi

[8u] review request : RT-35618 IMX6-SDP / Yocto hard float : hello.HelloButton : the highlighting blue rectangle is missing the bottom blue line in each of the top two buttons

2014-03-19 Thread Rafi Tayar
Lisa, Daniel, Please review the patch attached to the Jira : https://javafx-jira.kenai.com/browse/RT-35618 Thanks, Rafi

[8u20] Review request for RT-36487 : IMX6/monocle/touch - single touch events sequence is interpreted as multi-touch events

2014-04-16 Thread Rafi Tayar
Hi Daniel, Would you please review the fix for https://javafx-jira.kenai.com/browse/RT-36487 ? A webrev is attached to the Jira. Thanks, Rafi

Review request : RT-34913 TextField in Ensemble 8 appears too narrow to fit characters with descenders

2014-06-11 Thread Rafi Tayar
Lisa, Please review the proposed fix for https://javafx-jira.kenai.com/browse/RT-34913 Details in the jira. Thanks, Rafi

Review Request : RT-34933 Ensemble: some samples have too small edit boxes

2014-06-11 Thread Rafi Tayar
Lisa, Please review the proposed fix for https://javafx-jira.kenai.com/browse/RT-34933 Details in the jira. Thanks, Rafi

Review request : RT-37483 : [Embedded] null pointer exception in HelloListView

2014-06-24 Thread Rafi Tayar
Daniel, Please review the proposed fix for https://javafx-jira.kenai.com/browse/RT-37483 Details in the jira. Thanks, Rafi

hg: openjfx/8u-dev/rt: RT-37483 : [Embedded] null pointer exception in HelloListView

2014-06-29 Thread rafi . tayar
Changeset: 73e79f23096b Author:Rafi Tayar rafi.ta...@oracle.com Date: 2014-06-29 14:37 +0300 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/73e79f23096b RT-37483 : [Embedded] null pointer exception in HelloListView Reviewed-by : dblaukopf. ! modules/graphics/src/main/java

[8u40] Review request : RT-36451 : [Combobox, Touch] HelloSanity: cannot scroll long combobox popup with touch, something gets selected before scroll is performed

2014-07-15 Thread Rafi Tayar
Daniel, Please review the proposed fix for https://javafx-jira.kenai.com/browse/RT-36451 Webrev: http://cr.openjdk.java.net/~ratayar/RT-36451/ Thanks, Rafi

hg: openjfx/8u-dev/rt: RT-36451 : [Combobox, Touch] HelloSanity: cannot scroll long combobox popup with touch, something gets selected before scroll is performed

2014-07-15 Thread rafi . tayar
Changeset: 2507b139676a Author:Rafi Tayar rafi.ta...@oracle.com Date: 2014-07-15 17:33 +0300 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/2507b139676a RT-36451 : [Combobox, Touch] HelloSanity: cannot scroll long combobox popup with touch, something gets selected before

[8u40] Review request: RT-36241: [Monocle] Scroll with the wheel test failed

2014-07-20 Thread Rafi Tayar
Daniel, Please review the fix for https://javafx-jira.kenai.com/browse/RT-36241 Details are in the Jira, webrev : http://cr.openjdk.java.net/~ratayar/RT-36241/webrev.00/ Thanks, Rafi

hg: openjfx/8u-dev/rt: RT-36241: [Monocle] Scroll with the wheel test failed

2014-07-21 Thread rafi . tayar
Changeset: 5d14f564282f Author:Rafi Tayar rafi.ta...@oracle.com Date: 2014-07-21 15:48 +0300 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/5d14f564282f RT-36241: [Monocle] Scroll with the wheel test failed Reviewed-by : dblaukopf ! modules/graphics/src/main/java/com/sun

RE: hg: openjfx/8u-dev/rt: RT-36241: [Monocle] Scroll with the wheel test failed

2014-07-21 Thread Rafi Tayar
Sorry it was a mistake, somehow I forgot it , will not happen again I've also consulted within the embedded team and it seems to be OK to leave the fix in and not revert it. Thanks Rafi -Original Message- From: Kevin Rushforth Sent: Monday, July 21, 2014 4:01 PM To: Rafi Tayar Cc

[8u] Review request : (RT-37982) Create a unit test for RT-36241

2014-07-21 Thread Rafi Tayar
Daniel, Please review the unit test in : https://javafx-jira.kenai.com/browse/RT-37982 Webrev: http://cr.openjdk.java.net/~ratayar/RT-37982/webrev.00/ Thanks, Rafi

hg: openjfx/8u-dev/rt: RT-37982 : Create a unit test for RT-36241

2014-07-22 Thread rafi . tayar
Changeset: f07260b4dcda Author:Rafi Tayar rafi.ta...@oracle.com Date: 2014-07-22 15:39 +0300 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/f07260b4dcda RT-37982 : Create a unit test for RT-36241 Reviewed-by : dblaukopf ! tests/system/src/test/java/com/sun/glass/ui/monocle

hg: openjfx/8u-dev/rt: RT-37686 : [Monocle] Robot screen/pixel capture is broken

2014-08-05 Thread rafi . tayar
Changeset: bda1da3ab917 Author:Rafi Tayar rafi.ta...@oracle.com Date: 2014-08-05 16:44 +0300 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/bda1da3ab917 RT-37686 : [Monocle] Robot screen/pixel capture is broken Reviewed-by : dblaukopf ! modules/graphics/src/main/java/com