Integrated: 8283318: Videos with unusual sizes cannot be played on windows

2022-05-06 Thread Alexander Matveev
On Tue, 19 Apr 2022 22:38:13 GMT, Alexander Matveev wrote: > Fixed by removing check which enables dynamic format change, since it > requires for portrait videos, not standard resolutions and anything that has > width > 1920 or/and height > 1080. This pull request has now

Integrated: 8283218: Update GStreamer to 1.20.1

2022-04-21 Thread Alexander Matveev
On Fri, 8 Apr 2022 06:49:59 GMT, Alexander Matveev wrote: > - GStreamer updated to 1.20.1 and GLib updated to 2.72.0. > - No changes to our code, except in GstAudioSpectrum.cpp > g_atomic_pointer_compare_and_exchange() was changed to > g_atomic_pointer_set(). For some reason I

Re: RFR: 8283218: Update GStreamer to 1.20.1 [v4]

2022-04-20 Thread Alexander Matveev
On Mon, 18 Apr 2022 18:38:03 GMT, Alexander Matveev wrote: >> - GStreamer updated to 1.20.1 and GLib updated to 2.72.0. >> - No changes to our code, except in GstAudioSpectrum.cpp >> g_atomic_pointer_compare_and_exchange() was changed to >> g_atomic_pointer_

Re: RFR: 8283218: Update GStreamer to 1.20.1 [v5]

2022-04-20 Thread Alexander Matveev
ode compiled > with g_atomic_pointer_compare_and_exchange() used from C++ code. Also, I do > not see a need to use g_atomic_pointer_compare_and_exchange(), since > m_pHolder always equals to old_holder. > - Tested on all platforms with all supported media streams. Alexander Matveev has updated the pull request incrementa

RFR: 8283318: Videos with unusual sizes cannot be played on windows

2022-04-19 Thread Alexander Matveev
Fixed by removing check which enables dynamic format change, since it requires for portrait videos, not standard resolutions and anything that has width > 1920 or/and height > 1080. - Commit messages: - 8283318: Videos with unusual sizes cannot be played on windows Changes:

Re: RFR: 8283218: Update GStreamer to 1.20.1 [v3]

2022-04-18 Thread Alexander Matveev
On Fri, 15 Apr 2022 23:29:54 GMT, Alexander Matveev wrote: >> - GStreamer updated to 1.20.1 and GLib updated to 2.72.0. >> - No changes to our code, except in GstAudioSpectrum.cpp >> g_atomic_pointer_compare_and_exchange() was changed to >> g_atomic_pointer_

Re: RFR: 8283218: Update GStreamer to 1.20.1 [v4]

2022-04-18 Thread Alexander Matveev
ode compiled > with g_atomic_pointer_compare_and_exchange() used from C++ code. Also, I do > not see a need to use g_atomic_pointer_compare_and_exchange(), since > m_pHolder always equals to old_holder. > - Tested on all platforms with all supported media streams. Alexander Matveev has updated the pull request incrementa

Re: RFR: 8283218: Update GStreamer to 1.20.1 [v3]

2022-04-15 Thread Alexander Matveev
On Fri, 15 Apr 2022 23:29:54 GMT, Alexander Matveev wrote: >> - GStreamer updated to 1.20.1 and GLib updated to 2.72.0. >> - No changes to our code, except in GstAudioSpectrum.cpp >> g_atomic_pointer_compare_and_exchange() was changed to >> g_atomic_pointer_

Re: RFR: 8283218: Update GStreamer to 1.20.1 [v3]

2022-04-15 Thread Alexander Matveev
ode compiled > with g_atomic_pointer_compare_and_exchange() used from C++ code. Also, I do > not see a need to use g_atomic_pointer_compare_and_exchange(), since > m_pHolder always equals to old_holder. > - Tested on all platforms with all supported media streams. Alexander Matveev has updated the pull request incrementa

Re: RFR: 8283218: Update GStreamer to 1.20.1 [v2]

2022-04-13 Thread Alexander Matveev
ode compiled > with g_atomic_pointer_compare_and_exchange() used from C++ code. Also, I do > not see a need to use g_atomic_pointer_compare_and_exchange(), since > m_pHolder always equals to old_holder. > - Tested on all platforms with all supported media streams. Alexander Matveev has updated the pull request incrementa

Integrated: 8282054: Mediaplayer not working with HTTP Live Stream link with query parameter appended with file extension m3u8

2022-04-12 Thread Alexander Matveev
On Fri, 11 Mar 2022 03:01:39 GMT, Alexander Matveev wrote: > - Problem was that our code which checks if URI ends with file extension was > not considering that URI can have query parameters. Fixed by checking URI > path, instead of actual URI. > - Also, creation of HLS Conne

RFR: 8283218: Update GStreamer to 1.20.1

2022-04-08 Thread Alexander Matveev
- GStreamer updated to 1.20.1 and GLib updated to 2.72.0. - No changes to our code, except in GstAudioSpectrum.cpp g_atomic_pointer_compare_and_exchange() was changed to g_atomic_pointer_set(). For some reason I was not able to get code compiled with g_atomic_pointer_compare_and_exchange() used

Integrated: 8277309: Add support for H.265/HEVC to HTTP Live Streaming

2022-03-23 Thread Alexander Matveev
On Fri, 4 Feb 2022 11:24:48 GMT, Alexander Matveev wrote: > - Added support for fragmented MP4 with HEVC/H.265, H.264 and AAC. > - Added support for elementary AAC streams without any container for audio > only streams. > - Added "aacparse" plugin from GStreamer. Re

Re: RFR: 8277309: Add support for H.265/HEVC to HTTP Live Streaming [v3]

2022-03-17 Thread Alexander Matveev
On Fri, 18 Mar 2022 02:20:11 GMT, Alexander Matveev wrote: >> - Added support for fragmented MP4 with HEVC/H.265, H.264 and AAC. >> - Added support for elementary AAC streams without any container for audio >> only streams. >> - Added "aacparse" plugin

Re: RFR: 8277309: Add support for H.265/HEVC to HTTP Live Streaming [v3]

2022-03-17 Thread Alexander Matveev
ementary streams directly. DirectShow decoder works > without it. > - DirectShow H.264 decoder on Windows and H.265/H.264 decoder on Linux will > be reloaded when fMP4 stream changes resolution. Dynamic format change did > not worked for these streams on Windows and Linux. Alexander

RFR: 8282054: Mediaplayer not working with HTTP Live Stream link with query parameter appended with file extension m3u8

2022-03-10 Thread Alexander Matveev
- Problem was that our code which checks if URI ends with file extension was not considering that URI can have query parameters. Fixed by checking URI path, instead of actual URI. - Also, creation of HLS Connection holder was missing checking for mimetype, since we do support URI without

Re: RFR: 8277309: Add support for H.265/HEVC to HTTP Live Streaming [v2]

2022-03-08 Thread Alexander Matveev
On Tue, 8 Mar 2022 23:50:57 GMT, Kevin Rushforth wrote: >> Alexander Matveev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8277309: Add support for H.265/HEVC to HTTP Live Streaming [v2] > > module

Re: RFR: 8277309: Add support for H.265/HEVC to HTTP Live Streaming [v2]

2022-03-08 Thread Alexander Matveev
ementary streams directly. DirectShow decoder works > without it. > - DirectShow H.264 decoder on Windows and H.265/H.264 decoder on Linux will > be reloaded when fMP4 stream changes resolution. Dynamic format change did > not worked for these streams on Windows and Linux. Alexander

Re: RFR: 8277309: Add support for H.265/HEVC to HTTP Live Streaming

2022-03-08 Thread Alexander Matveev
On Sat, 26 Feb 2022 00:30:10 GMT, Kevin Rushforth wrote: >> - Added support for fragmented MP4 with HEVC/H.265, H.264 and AAC. >> - Added support for elementary AAC streams without any container for audio >> only streams. >> - Added "aacparse" plugin from GStreamer. Required on Linux, since

Integrated: 8280840: Update libFFI to 3.4.2

2022-03-07 Thread Alexander Matveev
On Sat, 19 Feb 2022 07:45:43 GMT, Alexander Matveev wrote: > LibFFI updated to 3.4.2. No additional changes to our code, libffi code or > build system were required. Tested on all platforms. This pull request has now been integrated. Changeset: 1beb3235 Author:Alexander Matvee

Re: RFR: 8280840: Update libFFI to 3.4.2

2022-02-23 Thread Alexander Matveev
On Sat, 19 Feb 2022 07:45:43 GMT, Alexander Matveev wrote: > LibFFI updated to 3.4.2. No additional changes to our code, libffi code or > build system were required. Tested on all platforms. [v2] - Fixed TAB issue. [v3] - Fixed space alignment issue in aarch64/ffitarget.h. ---

Re: RFR: 8280840: Update libFFI to 3.4.2 [v2]

2022-02-23 Thread Alexander Matveev
> LibFFI updated to 3.4.2. No additional changes to our code, libffi code or > build system were required. Tested on all platforms. Alexander Matveev has updated the pull request incrementally with one additional commit since the last revision: 8280840: Update libFFI to 3.4

RFR: 8280840: Update libFFI to 3.4.2

2022-02-23 Thread Alexander Matveev
LibFFI updated to 3.4.2. No additional changes to our code, libffi code or build system were required. Tested on all platforms. - Commit messages: - 8280840: Update libFFI to 3.4.2 [v2] - 8280840: Update libFFI to 3.4.2 Changes: https://git.openjdk.java.net/jfx/pull/738/files

RFR: 8277309: Add support for H.265/HEVC to HTTP Live Streaming

2022-02-04 Thread Alexander Matveev
- Added support for fragmented MP4 with HEVC/H.265, H.264 and AAC. - Added support for elementary AAC streams without any container for audio only streams. - Added "aacparse" plugin from GStreamer. Required on Linux, since decoder cannot handle AAC elementary streams directly. DirectShow

Integrated: 8273096: Add support for H.265/HEVC to JavaFX Media

2021-12-20 Thread Alexander Matveev
On Thu, 21 Oct 2021 07:51:20 GMT, Alexander Matveev wrote: > - Added support for H.265/HEVC for all 3 platforms. > - Support is added only for .mp4 files over FILE/HTTP/HTTPS protocols. HTTP > Live Streaming with H.265/HEVC is not supported. > - On Windows mfwrapper was introduce

Re: RFR: 8273096: Add support for H.265/HEVC to JavaFX Media [v4]

2021-12-17 Thread Alexander Matveev
On Fri, 17 Dec 2021 17:15:22 GMT, Kevin Rushforth wrote: >> Alexander Matveev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8273096: Add support for H.265/HEVC to JavaFX Media [v5] > > modules/javafx.m

Re: RFR: 8273096: Add support for H.265/HEVC to JavaFX Media [v2]

2021-12-14 Thread Alexander Matveev
On Fri, 10 Dec 2021 18:56:43 GMT, Kevin Rushforth wrote: >> Alexander Matveev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8273096: Add support for H.265/HEVC to JavaFX Media [v3] > > modules/javafx.m

Re: RFR: 8273096: Add support for H.265/HEVC to JavaFX Media [v3]

2021-12-14 Thread Alexander Matveev
On Mon, 13 Dec 2021 19:29:59 GMT, Kevin Rushforth wrote: >> Alexander Matveev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8273096: Add support for H.265/HEVC to JavaFX Media [v4] > > modules/javafx.m

Re: RFR: 8273096: Add support for H.265/HEVC to JavaFX Media [v4]

2021-12-13 Thread Alexander Matveev
ependency requirements: > Windows: Windows 10 with HEVC Video Extensions installed. > macOS: macOS High Sierra and later > Linux: at least libavcodec56 and libswscale5 > > Additional build dependency: > Linux: libswscale-dev Alexander Matveev has updated the pull request incre

Re: RFR: 8273096: Add support for H.265/HEVC to JavaFX Media [v2]

2021-12-10 Thread Alexander Matveev
On Tue, 16 Nov 2021 02:24:11 GMT, Alexander Matveev wrote: >> - Added support for H.265/HEVC for all 3 platforms. >> - Support is added only for .mp4 files over FILE/HTTP/HTTPS protocols. HTTP >> Live Streaming with H.265/HEVC is not supported. >> - On Windows mfwrap

Re: RFR: 8273096: Add support for H.265/HEVC to JavaFX Media [v2]

2021-12-10 Thread Alexander Matveev
On Fri, 10 Dec 2021 19:34:25 GMT, Kevin Rushforth wrote: >> Alexander Matveev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8273096: Add support for H.265/HEVC to JavaFX Media [v3] > > modules/javafx.m

Re: RFR: 8273096: Add support for H.265/HEVC to JavaFX Media [v3]

2021-12-10 Thread Alexander Matveev
ependency requirements: > Windows: Windows 10 with HEVC Video Extensions installed. > macOS: macOS High Sierra and later > Linux: at least libavcodec56 and libswscale5 > > Additional build dependency: > Linux: libswscale-dev Alexander Matveev has updated the pull request incre

Re: RFR: 8273096: Add support for H.265/HEVC to JavaFX Media [v2]

2021-11-15 Thread Alexander Matveev
On Tue, 16 Nov 2021 02:24:11 GMT, Alexander Matveev wrote: >> - Added support for H.265/HEVC for all 3 platforms. >> - Support is added only for .mp4 files over FILE/HTTP/HTTPS protocols. HTTP >> Live Streaming with H.265/HEVC is not supported. >> - On Windows mfwrap

Re: RFR: 8273096: Add support for H.265/HEVC to JavaFX Media [v2]

2021-11-15 Thread Alexander Matveev
ependency requirements: > Windows: Windows 10 with HEVC Video Extensions installed. > macOS: macOS High Sierra and later > Linux: at least libavcodec56 and libswscale5 > > Additional build dependency: > Linux: libswscale-dev Alexander Matveev has updated the pull request incre

RFR: 8273096: Add support for H.265/HEVC to JavaFX Media

2021-10-21 Thread Alexander Matveev
- Added support for H.265/HEVC for all 3 platforms. - Support is added only for .mp4 files over FILE/HTTP/HTTPS protocols. HTTP Live Streaming with H.265/HEVC is not supported. - On Windows mfwrapper was introduced which uses Media Foundation APIs to decode HEVC. - 10 and 12-bit HEVC was

Integrated: 8270107: Open source FXMediaPlayer test app

2021-09-14 Thread Alexander Matveev
On Fri, 27 Aug 2021 22:06:31 GMT, Alexander Matveev wrote: > - Added FXMediaPlayer test application. > - This app uses all media APIs and very handy in verifying media builds > during development. > - It can be compiled and run by running "ant" and "ant ru

RFR: 8270107: Open source FXMediaPlayer test app

2021-08-27 Thread Alexander Matveev
- Added FXMediaPlayer test application. - This app uses all media APIs and very handy in verifying media builds during development. - It can be compiled and run by running "ant" and "ant run" in tests/manual/media/FXMediaPlayer. - Commit messages: - 8270107: Open source

Integrated: 8242531: [macos] JavaFX OSXPlatform tries to load nonexistent libjfxmedia_qtkit

2021-07-30 Thread Alexander Matveev
On Fri, 30 Jul 2021 00:42:30 GMT, Alexander Matveev wrote: > Removed code which loads nonexistent libjfxmedia_qtkit. This pull request has now been integrated. Changeset: ba61a173 Author: Alexander Matveev URL: https://git.openjdk.java.net/jfx/com

RFR: 8242531: [macos] JavaFX OSXPlatform tries to load nonexistent libjfxmedia_qtkit

2021-07-29 Thread Alexander Matveev
Removed code which loads nonexistent libjfxmedia_qtkit. - Commit messages: - 8242531: [macos] JavaFX OSXPlatform tries to load nonexistent libjfxmedia_qtkit Changes: https://git.openjdk.java.net/jfx/pull/597/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx=597=00 Issue:

Integrated: 8253351: MediaPlayer does not display an mp4 if there no speakers connected to the PC's

2021-07-28 Thread Alexander Matveev
On Sat, 24 Jul 2021 02:59:52 GMT, Alexander Matveev wrote: > Fixed by not failing initialization if DSERR_NODRIVER is returned, which will > be return if device is not present at all. Fixed format initialization even > if DirectSound device was not created in case if audio device wi

Re: RFR: 8253351: MediaPlayer does not display an mp4 if there no speakers connected to the PC's [v2]

2021-07-26 Thread Alexander Matveev
audio) and then enabling device and once enabled audio > will start playing. Alexander Matveev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additio

RFR: 8253351: MediaPlayer does not display an mp4 if there no speakers connected to the PC's

2021-07-23 Thread Alexander Matveev
Fixed by not failing initialization if DSERR_NODRIVER is returned, which will be return if device is not present at all. Fixed format initialization even if DirectSound device was not created in case if audio device will arrive after playback started. Since we already handle correctly device

Integrated: 8268718: [macos] Video stops, but audio continues to play when stopTime is reached

2021-07-08 Thread Alexander Matveev
On Thu, 1 Jul 2021 01:38:14 GMT, Alexander Matveev wrote: > Not sure why, but our finish() handle was not implemented on OSXPlatform. > This handle should pause media stream when called. Also, seek should restart > playback when we finish playing video. With proposed fix OS

RFR: 8268718: [macos] Video stops, but audio continues to play when stopTime is reached

2021-06-30 Thread Alexander Matveev
Not sure why, but our finish() handle was not implemented on OSXPlatform. This handle should pause media stream when called. Also, seek should restart playback when we finish playing video. With proposed fix OSXPlatform will behave same as GSTPlatform. Stop playback when stopTime is reached and

Integrated: 8268683: JavaFX MediaPlayer onEndOfMedia behaviour different from Javadoc

2021-06-30 Thread Alexander Matveev
On Tue, 29 Jun 2021 03:07:11 GMT, Alexander Matveev wrote: > Fixed javadoc to indicate that onEndOfMedia is invoked each time when end of > cycle is reached regardless if it is repeating or not. This pull request has now been integrated. Changeset: cfa60ff7 Author:Alexander Matvee

Integrated: 8269147: Update GStreamer to version 1.18.4

2021-06-30 Thread Alexander Matveev
On Thu, 24 Jun 2021 02:50:08 GMT, Alexander Matveev wrote: > - GStreamer updated to 1.18.4. > - Tested on all platforms with all formats. This pull request has now been integrated. Changeset: 098c0f39 Author:Alexander Matveev URL: https://git.openjdk.java.net/jfx/

Re: RFR: 8268683: JavaFX MediaPlayer onEndOfMedia behaviour different from Javadoc [v2]

2021-06-29 Thread Alexander Matveev
On Tue, 29 Jun 2021 22:55:50 GMT, Kevin Rushforth wrote: >> Alexander Matveev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8268683: JavaFX MediaPlayer onEndOfMedia behaviour different from Javadoc >>

Re: RFR: 8268683: JavaFX MediaPlayer onEndOfMedia behaviour different from Javadoc [v2]

2021-06-29 Thread Alexander Matveev
> Fixed javadoc to indicate that onEndOfMedia is invoked each time when end of > cycle is reached regardless if it is repeating or not. Alexander Matveev has updated the pull request incrementally with one additional commit since the last revision: 8268683: JavaFX MediaPlayer onEndO

RFR: 8268683: JavaFX MediaPlayer onEndOfMedia behaviour different from Javadoc

2021-06-28 Thread Alexander Matveev
Fixed javadoc to indicate that onEndOfMedia is invoked each time when end of cycle is reached regardless if it is repeating or not. - Commit messages: - 8268683: JavaFX MediaPlayer onEndOfMedia behaviour different from Javadoc Changes:

RFR: 8269147: Update GStreamer to version 1.18.4

2021-06-23 Thread Alexander Matveev
- GStreamer updated to 1.18.4. - Tested on all platforms with all formats. - Commit messages: - 8269147: Update GStreamer to version 1.18.4 Changes: https://git.openjdk.java.net/jfx/pull/541/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx=541=00 Issue:

Integrated: 8268219: hlsprogressbuffer should provide PTS after GStreamer update

2021-06-16 Thread Alexander Matveev
On Sat, 12 Jun 2021 00:10:55 GMT, Alexander Matveev wrote: > - Reverted JDK-8268152 fix in gstbaseparse.c, since it is no longer needed. > - Our hlsprogressbuffer outputs buffers in time format, but without any PTS. > After GStreamer update mpregparser no longer tries to figure out t

RFR: 8268219: Investigate gstmpegaudioparse PTS issue

2021-06-11 Thread Alexander Matveev
- Reverted JDK-8268152 fix in gstbaseparse.c, since it is no longer needed. - Our hlsprogressbuffer outputs buffers in time format, but without any PTS. After GStreamer update mpregparser no longer tries to figure out timestamps if stream in time format and it will assume that upstream provides

Integrated: 8268152: gstmpegaudioparse does not provides timestamps for HLS MP3 streams

2021-06-04 Thread Alexander Matveev
On Thu, 3 Jun 2021 09:37:18 GMT, Alexander Matveev wrote: > With recent GStreamer update gstmpegaudioparse no longer provides audio > buffers with valid timestamps. This issue is only reproducible with MP3 HTTP > Live Stream and was noticed on Linux. I think Windows audio decode

Re: RFR: 8267819: CoInitialize/CoUninitialize should be called on same thread

2021-06-02 Thread Alexander Matveev
On Wed, 2 Jun 2021 14:29:41 GMT, Ambarish Rapte wrote: >> JDK-8264737 introduced new code for audio device removal/arrival >> notifications which calls CoInitialize/CoUninitialize on separate threads. >> CoInitialize/CoUninitialize should be called on same thread, since >> initialization is

Re: RFR: 8267819: CoInitialize/CoUninitialize should be called on same thread

2021-05-27 Thread Alexander Matveev
On Thu, 27 May 2021 04:18:24 GMT, Alexander Matveev wrote: > JDK-8264737 introduced new code for audio device removal/arrival > notifications which calls CoInitialize/CoUninitialize on separate threads. > CoInitialize/CoUninitialize should be called on same thread, since > in

RFR: 8267819: CoInitialize/CoUninitialize should be called on same thread

2021-05-26 Thread Alexander Matveev
JDK-8264737 introduced new code for audio device removal/arrival notifications which calls CoInitialize/CoUninitialize on separate threads. CoInitialize/CoUninitialize should be called on same thread, since initialization is per thread. Doing it on separate thread will result in unloading COM

Integrated: 8266860: [macos] Incorrect duration reported for HLS live streams

2021-05-17 Thread Alexander Matveev
On Tue, 11 May 2021 23:43:36 GMT, Alexander Matveev wrote: > For indefinite durations CMTimeGetSeconds was returning NaN (not-a-number > double value) and our code expects -1.0. Based on doc we should be using > CMTIME_IS_INDEFINITE to test if duration is indefinite. Fixed

RFR: 8266860: [macos] Incorrect duration reported for HLS live streams

2021-05-11 Thread Alexander Matveev
For indefinite durations CMTimeGetSeconds was returning NaN (not-a-number double value) and our code expects -1.0. Based on doc we should be using CMTIME_IS_INDEFINITE to test if duration is indefinite. Fixed by using CMTIME_IS_INDEFINITE to test if duration is indefinite and if true -1.0 will

Integrated: 8264737: JavaFX media stream stops playing after reconnecting via Remote Desktop

2021-04-28 Thread Alexander Matveev
On Sat, 24 Apr 2021 02:23:19 GMT, Alexander Matveev wrote: > Remote Desktop will change default audio device when connecting or > disconnecting to it's own audio device. Also, when remote desktop is > disconnect, then remote desktop default audio device is removed and system > de

Re: RFR: 8264737: JavaFX media stream stops playing after reconnecting via Remote Desktop [v2]

2021-04-28 Thread Alexander Matveev
On Wed, 28 Apr 2021 19:02:41 GMT, Ambarish Rapte wrote: >> Alexander Matveev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8264737: JavaFX media stream stops playing after reconnecting via Remote >> Des

Re: RFR: 8264737: JavaFX media stream stops playing after reconnecting via Remote Desktop

2021-04-26 Thread Alexander Matveev
On Sat, 24 Apr 2021 02:23:19 GMT, Alexander Matveev wrote: > Remote Desktop will change default audio device when connecting or > disconnecting to it's own audio device. Also, when remote desktop is > disconnect, then remote desktop default audio device is removed and system > de

Re: RFR: 8264737: JavaFX media stream stops playing after reconnecting via Remote Desktop [v2]

2021-04-26 Thread Alexander Matveev
between > remote and normal desktop. In second case audio will switch between remote or > speakers. > > Since audio device is gone and not restored after disconnect, there will be > no audio on machine local speakers, until user logs back again. Alexander Matveev has updated t

RFR: 8264737: JavaFX media stream stops playing after reconnecting via Remote Desktop

2021-04-23 Thread Alexander Matveev
Remote Desktop will change default audio device when connecting or disconnecting to it's own audio device. Also, when remote desktop is disconnect, then remote desktop default audio device is removed and system default device is not restored until user logs back to computer. So, after remote

Re: RFR: 8265469: Allow to build media and webkit for Linux-AArch64

2021-04-22 Thread Alexander Matveev
On Mon, 19 Apr 2021 19:57:50 GMT, Johan Vos wrote: > Changes that allow to build linux configuration on Linux AArch64 > This PR introduces an `IS_AARCH64` parameter in build.gradle. > This PR already contains the change from PR #465 so if this one gets > integrated, that change needs to removed

Integrated: 8259356: MediaPlayer's seek freezes video

2021-04-19 Thread Alexander Matveev
On Sat, 17 Apr 2021 01:39:17 GMT, Alexander Matveev wrote: > This is regression (introduced) by JDK-8199527. JDK-8199527 added fix for HLS > streams (unfortunately I was not able to find repro case and more details on > why it was added) in gstappsink.c line 659-678 to store cur

RFR: 8259356: MediaPlayer's seek freezes video

2021-04-16 Thread Alexander Matveev
This is regression (introduced) by JDK-8199527. JDK-8199527 added fix for HLS streams (unfortunately I was not able to find repro case and more details on why it was added) in gstappsink.c line 659-678 to store current caps which can be lost during seek/flush. However, this workaround broke

Integrated: 8262366: Update glib to version 2.66.7

2021-04-05 Thread Alexander Matveev
On Wed, 31 Mar 2021 05:15:20 GMT, Alexander Matveev wrote: > - GLib was updated to version 2.66.7 and GStreamer to version 1.18.3 > - One bug was discovered in updated GStreamer which was causing deadlock or > infinite loop during seek on macOS. See gstsystemclock.c for change

Re: RFR: 8262366: Update glib to version 2.66.7

2021-04-02 Thread Alexander Matveev
On Thu, 1 Apr 2021 23:47:15 GMT, Kevin Rushforth wrote: >> All my testing looks good on all three platforms. I'll take a look at the >> diffs next. >> >> One thing I did spot is that you need to update `gstreamer.md` and `glib.md` >> to bump the version numbers. > > It now builds for me on my

Re: RFR: 8264449: Enable reproducible builds with SOURCE_DATE_EPOCH [v2]

2021-04-01 Thread Alexander Matveev
On Thu, 1 Apr 2021 19:14:37 GMT, John Neffenger wrote: >> This pull request allows for reproducible builds of JavaFX on Linux, macOS, >> and Windows by defining the `SOURCE_DATE_EPOCH` environment variable. For >> example, the following commands create a reproducible build: >> >> $ export

Re: RFR: 8262366: Update glib to version 2.66.7 [v2]

2021-04-01 Thread Alexander Matveev
> - GLib was updated to version 2.66.7 and GStreamer to version 1.18.3 > - One bug was discovered in updated GStreamer which was causing deadlock or > infinite loop during seek on macOS. See gstsystemclock.c for changes between > ifdef GSTREAMER_LITE. Otherwise no changes. Alexa

Re: RFR: 8262366: Update glib to version 2.66.7

2021-03-31 Thread Alexander Matveev
On Wed, 31 Mar 2021 19:25:09 GMT, Kevin Rushforth wrote: >> - GLib was updated to version 2.66.7 and GStreamer to version 1.18.3 >> - One bug was discovered in updated GStreamer which was causing deadlock or >> infinite loop during seek on macOS. See gstsystemclock.c for changes between >>

RFR: 8262366: Update glib to version 2.66.7

2021-03-30 Thread Alexander Matveev
- GLib was updated to version 2.66.7 and GStreamer to version 1.18.3 - One bug was discovered in updated GStreamer which was causing deadlock or infinite loop during seek on macOS. See gstsystemclock.c for changes between ifdef GSTREAMER_LITE. Otherwise no changes. - Commit

Integrated: 8257895: Allow building of JavaFX media libs for Apple Silicon

2021-03-15 Thread Alexander Matveev
On Fri, 26 Feb 2021 03:58:17 GMT, Alexander Matveev wrote: > - Added support to compile media on arm. > - libffi is based on 3.3. This pull request has now been integrated. Changeset: 8adbc673 Author:Alexander Matveev URL: https://git.openjdk.java.net/jfx/commit/8adbc673

Re: RFR: 8257895: Allow building of JavaFX media libs for Apple Silicon [v2]

2021-03-10 Thread Alexander Matveev
> - Added support to compile media on arm. > - libffi is based on 3.3. Alexander Matveev has updated the pull request incrementally with one additional commit since the last revision: 8257895: Allow building of JavaFX media libs for Apple Silicon [v2] - Changes: - all:

Re: RFR: 8257895: Allow building of JavaFX media libs for Apple Silicon [v2]

2021-03-10 Thread Alexander Matveev
On Wed, 10 Mar 2021 23:46:39 GMT, Kevin Rushforth wrote: >> Alexander Matveev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8257895: Allow building of JavaFX media libs for Apple Silicon [v2] > > Th

RFR: 8257895: Allow building of JavaFX media libs for Apple Silicon

2021-02-25 Thread Alexander Matveev
- Added support to compile media on arm. - libffi is based on 3.3. - Commit messages: - 8257895: Allow building of JavaFX media libs for Apple Silicon Changes: https://git.openjdk.java.net/jfx/pull/412/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx=412=00 Issue:

Integrated: 8252060: gstreamer fails to build with gcc 10

2020-08-25 Thread Alexander Matveev
On Tue, 25 Aug 2020 01:00:31 GMT, Alexander Matveev wrote: > Fixed by defining GST_API as GST_EXPORT for gcc compiler as per Kevin > proposed solution. On Windows we do not need to > define GST_API, since we using .def file to export symbols. This pull request has now been i

RFR: 8252060: gstreamer fails to build with gcc 10

2020-08-24 Thread Alexander Matveev
Fixed by defining GST_API as GST_EXPORT for gcc compiler as per Kevin proposed solution. On Windows we do not need to define GST_API, since we using .def file to export symbols. - Commit messages: - 8252060: gstreamer fails to build with gcc 10 Changes:

Integrated: 8252107: Media pipeline initialization can crash if audio or video bin state change fails

2020-08-24 Thread Alexander Matveev
On Thu, 20 Aug 2020 23:32:24 GMT, Alexander Matveev wrote: > https://bugs.openjdk.java.net/browse/JDK-8252107 > > - Fixed by checking return value of audio/video bin state change and stopping > pipeline initialization if error occurred. This pull request has now been integrated

Re: RFR: 8252107: Media pipeline initializtion can crash if audio or video bin state change fails

2020-08-20 Thread Alexander Matveev
On Thu, 20 Aug 2020 23:59:24 GMT, Kevin Rushforth wrote: > The PR title doesn't match the JBS title. Can you fix it? Fixed. It looks like github auto truncate long titles. - PR: https://git.openjdk.java.net/jfx/pull/285

Re: RFR: 8252107: Media pipeline initializtion can crash if audio or video bin state change fails

2020-08-20 Thread Alexander Matveev
On Thu, 20 Aug 2020 23:57:12 GMT, Kevin Rushforth wrote: > I built and tested it on Linux and it looks good. Have you done a build / > test on Mac and Windows as well? Yes, Mac and Windows was tested with all formats. - PR: https://git.openjdk.java.net/jfx/pull/285

RFR: 8252107: Media pipeline initializtion can crash if audio or video bin…

2020-08-20 Thread Alexander Matveev
https://bugs.openjdk.java.net/browse/JDK-8252107 - Fixed by checking return value of audio/video bin state change and stopping pipeline initialization if error occurred. - Commit messages: - 8252107: Media pipeline initializtion can crash if audio or video bin state change fails

Re: [jfx15] RFR: 8250238: Media fails to load libav 58 library when using modules from maven central

2020-07-23 Thread Alexander Matveev
On Thu, 23 Jul 2020 21:40:05 GMT, Kevin Rushforth wrote: > When running a JavaFX application using the JavaFX modules from maven > central, the native libraries are packed into the > jar file, and then unpacked as needed by the JavaFX runtime. This fails for > libavplugin-ffmpeg-58.so, because

Re: [jfx15] RFR: 8250238: Media fails to load libav 58 library when using modules from maven central

2020-07-23 Thread Alexander Matveev
On Thu, 23 Jul 2020 21:44:22 GMT, Kevin Rushforth wrote: >> NOTE: This is targeted to `jfx15`. As such I would like a second reviewer. > > @sashamatveev can you review? > > @tiainen or @johanvos can one of you review as well? Looks good. - PR:

Integrated: 8248365: Debug build crashes on Windows when playing media file

2020-07-13 Thread Alexander Matveev
On Sat, 11 Jul 2020 03:04:16 GMT, Alexander Matveev wrote: > According to information found for similar bugs filed against libffi, this is > known issue with libffi. libffi modifies > stack frames and it triggers stack frame run-time error checking. Fixed by > disabling stack

RFR: 8248365: Debug build crashes on Windows when playing media file

2020-07-10 Thread Alexander Matveev
According to information found for similar bugs filed against libffi, this is known issue with libffi. libffi modifies stack frames and it triggers stack frame run-time error checking. Fixed by disabling stack frame error checking in debug build. It was already off in release build.

Integrated: 8247947: Build DirectShow Samples (Base Classes) from source checked into repo

2020-06-30 Thread Alexander Matveev
On Thu, 25 Jun 2020 23:19:05 GMT, Alexander Matveev wrote: > - Added DirectShow baseclasses to repository. > - Dependency on Windows SDK 7.1 DirectShow baseclasses was removed. This pull request has now been integrated. Changeset: 62f8cee7 Author:Alexander Matveev URL:

RFR: 8247947: Build DirectShow Samples (Base Classes) from source checked into repo

2020-06-25 Thread Alexander Matveev
- Added DirectShow baseclasses to repository. - Dependency on Windows SDK 7.1 DirectShow baseclasses was removed. - Commit messages: - 8247947: Fixed files permissions - 8247947: Build DirectShow Samples (Base Classes) from source checked into repo Changes:

Re: RFR: 8247360: Add missing license file for Microsoft DirectShow Samples

2020-06-16 Thread Alexander Matveev
On Tue, 16 Jun 2020 22:25:48 GMT, Kevin Rushforth wrote: > This adds a missing third-party license file for the Microsoft DirectShow > Samples. Marked as reviewed by almatvee (Reviewer). - PR: https://git.openjdk.java.net/jfx/pull/252

Re: [Integrated] RFR: 8239095: Upgrade libFFI to the latest 3.3 version

2020-06-02 Thread Alexander Matveev
On Fri, 29 May 2020 01:24:29 GMT, Alexander Matveev wrote: > - Updated libffi to 3.3. This pull request has now been integrated. Changeset: 6bd0e22d Author: Alexander Matveev URL: https://git.openjdk.java.net/jfx/commit/6bd0e22d Stats: 10217 lines in 37 files changed: 4167

Re: RFR: 8239095: Upgrade libFFI to the latest 3.3 version

2020-06-01 Thread Alexander Matveev
On Mon, 1 Jun 2020 13:21:08 GMT, Kevin Rushforth wrote: >> That's a good question. The commented line was there from the first commit >> (in 9, changeset 9231:241f9696e3ad, >> https://bugs.openjdk.java.net/browse/JDK-8043352) but I don't see a reason >> on why it was disabled. >> libffi is

RFR: 8239095: Upgrade libFFI to the latest 3.3 version

2020-05-29 Thread Alexander Matveev
- Updated libffi to 3.3. - Commit messages: - 8239095: Fixed jcheck - 8239095: Upgrade libFFI to the latest 3.3 version Changes: https://git.openjdk.java.net/jfx/pull/242/files Webrev: https://webrevs.openjdk.java.net/jfx/242/webrev.00 Issue:

RFR: 8242530: [macos] Some audio files miss spectrum data when another audio file plays first

2020-04-15 Thread Alexander Matveev
https://bugs.openjdk.java.net/browse/JDK-8242530 - GstElementClass which is base class for all elements has same instance between all spectrum elements (not sure if it is same for all elements) and thus post_message was sending events to AVFoundation callback from GStreamer platform. This

RFR: 8241629: [macos10.15] Long startup delay playing media over https on Catalina

2020-04-13 Thread Alexander Matveev
https://bugs.openjdk.java.net/browse/JDK-8241629 We used to link with system provided libffi (due to a bug in Makefile) and for some reason GLib signals did not work correctly and thus we did not able to build dynamic pipelines. We did not switch to AVFoundation until timeout is reached while

Re: [Closed] RFR: 8240694: [macos 10.15] JavaFX Media hangs on some video files on Catalina

2020-04-09 Thread Alexander Matveev
On Tue, 7 Apr 2020 23:44:17 GMT, Alexander Matveev wrote: > https://bugs.openjdk.java.net/browse/JDK-8240694 > > - Original fix JDK-8236832 was reverted. > - Timestamp will be queried on event loop thread when spectrum event is > received by event loop. > - FIx only enab

Re: [Rev 01] RFR: 8240694: [macos 10.15] JavaFX Media hangs on some video files on Catalina

2020-04-08 Thread Alexander Matveev
On Wed, 8 Apr 2020 22:52:27 GMT, Kevin Rushforth wrote: >> Alexander Matveev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8240694: Improved comments per reviewers request > > Can you add a root ca

Re: [Rev 01] RFR: 8240694: [macos 10.15] JavaFX Media hangs on some video files on Catalina

2020-04-08 Thread Alexander Matveev
> https://bugs.openjdk.java.net/browse/JDK-8240694 > > - Original fix JDK-8236832 was reverted. > - Timestamp will be queried on event loop thread when spectrum event is > received by event loop. > - FIx only enabled for macOS when using OSXPlatform. Alexander Matveev ha

RFR: 8240694: [macos 10.15] JavaFX Media hangs on some video files on Catalina

2020-04-07 Thread Alexander Matveev
https://bugs.openjdk.java.net/browse/JDK-8240694 - Original fix JDK-8236832 was reverted. - Timestamp will be queried on event loop thread when spectrum event is received by event loop. - FIx only enabled for macOS when using OSXPlatform. - Commit messages: - 8240694: [macos

Re: RFR: 8240832: Remove unused applecoreaudio.md third-party legal file

2020-03-10 Thread Alexander Matveev
On Tue, 10 Mar 2020 18:37:50 GMT, Kevin Rushforth wrote: > As noted in the JBS issue, this is a follow-on bug to > [https://bugs.openjdk.java.net/browse/JDK-8232589](https://bugs.openjdk.java.net/browse/JDK-8232589) > to remove the > applecoreaudio.md third-party legal file now that we no

Re: [Integrated] RFR: 8236832: [macos 10.15] JavaFX Application hangs on video play on Cata…

2020-02-27 Thread Alexander Matveev
Changeset: 4c82af8d Author:Alexander Matveev Date: 2020-02-28 05:07:50 + URL: https://git.openjdk.java.net/jfx/commit/4c82af8d 8236832: [macos 10.15] JavaFX Application hangs on video play on Cata… Reviewed-by: kcr, ghb ! modules/javafx.media/src/main/native/jfxmedia

  1   2   >