Review request for JDK-8173852: FXCanvas needs to invert rotation angle when forwarding a gesture event.

2017-02-03 Thread Alexander Nyssen
Hallo Kevin, hallo Alexander, please review the following fix: https://bugs.openjdk.java.net/browse/JDK-8173852 http://cr.openjdk.java.net/~anyssen/8173852/webrev/ Best Regards, Alexander

Re: Review request for 8166242: Removal of com.sun.javafx.embed.AbstractEvents

2016-09-22 Thread Alexander Nyssen
y to be easier to maintain, we might at least consider it when/if > the recently announced schedule slip for JDK 9 becomes effective. > > -- Kevin > > > Alexander Nyssen wrote: >> Hallo Kevin, Alexander Z, Vadim, >> >> I have created an initial patch for

Re: :graphics:compilePrismCompilers fails with latest 9-dev tip on my mac

2016-09-21 Thread Alexander Nyssen
Hi Dave, I am using 2.11, as recommend. But as already said, the problem was on my side. Best Regards, Alexander > Am 21.09.2016 um 15:39 schrieb David Hill <david.h...@oracle.com>: > > On 9/21/16, 2:58 AM, Alexander Nyssen wrote: >> Hi all, >> >> havin

Re: :graphics:compilePrismCompilers fails with latest 9-dev tip on my mac

2016-09-21 Thread Alexander Nyssen
and it works fine. > Let's see your gradle --debug log then. > > Vadim > > On 21.09.2016 11:23, Alexander Nyssen wrote: >> Hi Vadim, >> >> unfortunately both does not help, the problem persists. >> >> Best Regards, >> Alexander >&g

Re: :graphics:compilePrismCompilers fails with latest 9-dev tip on my mac

2016-09-21 Thread Alexander Nyssen
gt; these parts of build were reworked. > You could start with gradle cleanAll, if it doesn't help, then rm -r build > buildSrc/build should help. > > Thanks, > Vadim > > On 21.09.2016 9:58, Alexander Nyssen wrote: >> Hi all, >> >> having update

:graphics:compilePrismCompilers fails with latest 9-dev tip on my mac

2016-09-21 Thread Alexander Nyssen
Hi all, having updated 9-dev to the latest tip, the gradle build now fails on my Mac with the following errors. Updating JIGSAW home to ea136 did not resolve the problems. Any ideas? Best Regards, Alexander :graphics:compilePrismCompilers

Re: Necessity of com.sun.javafx.embed.AbstractEvents

2016-09-18 Thread Alexander Nyssen
text of an FXCanvas). We called it FXControlAdapter (https://github.com/eclipse/gef/blob/master/org.eclipse.gef.fx.swt/src/org/eclipse/gef/fx/swt/controls/FXControlAdapter.java). It’s still pretty basic, but might be a good starting point. > > Thanks, > > Artem Best Regards, Ale

Necessity of com.sun.javafx.embed.AbstractEvents

2016-09-16 Thread Alexander Nyssen
Hi Alexander Z., Kevin, while working on JDK-8143596 (FXCanvas does not forward touch gestures to embedded scene) I came across some „smell“ that I would like to discuss. That is, the information about events that is exchanged between JFXPanel/FXCanvas and the EmbeddedScene/EmbeddedStage is

Review request [2] for 8143596: FXCanvas does not forward touch gestures to embedded scene

2016-09-15 Thread Alexander Nyssen
Hallo Alexander Z., Kevin, I have adjusted the patch for JDK-8143596 to reflect the initial review finding of Alexander Z. and to fix some whitespace issues: https://bugs.openjdk.java.net/browse/JDK-8143596 http://cr.openjdk.java.net/~anyssen/8143596/webrev.01/

Re: javafx.embed.swt.* regarded as JDK internal API by jdeps of jdk9-ea135

2016-09-14 Thread Alexander Nyssen
single „bridge“ back to the Eclipse Workbench/SWT world. > > — Kevin Best Regards Alexander > > > Alexander Nyssen wrote: >> >> Tom, >> >> just to make that explicit: you expected it to be shipped as an explicit and >> not as an automatic, i

Re: javafx.embed.swt.* regarded as JDK internal API by jdeps of jdk9-ea135

2016-09-14 Thread Alexander Nyssen
ith the jdk/jre - i can not repackage and > ship openjfx code from eclipse.org > > Tom > > Von meinem iPhone gesendet > >> Am 14.09.2016 um 08:51 schrieb Alexander Nyssen <alexan...@nyssen.org>: >> >> Hi Tom, Kevin, >> >> I have to admit tha

Re: javafx.embed.swt.* regarded as JDK internal API by jdeps of jdk9-ea135

2016-09-14 Thread Alexander Nyssen
named one loaded in a > secondary layer (eg by the efxclipse OSGi-Adapter-Hook) - at least this > is the theory. I didn't have time yet to follow this path yet. > > Tom > > On 13.09.16 20:31, Alexander Nyssen wrote: >> Hi Kevin, >> >>

Re: javafx.embed.swt.* regarded as JDK internal API by jdeps of jdk9-ea135

2016-09-13 Thread Alexander Nyssen
Hi Kevin, > Am 13.09.2016 um 16:30 schrieb Kevin Rushforth <kevin.rushfo...@oracle.com>: > > > > Alexander Nyssen wrote: >> Hi Kevin, >> >>> Am 13.09.2016 um 15:42 schrieb Kevin Rushforth <kevin.rushfo...@oracle.com >>> <mailto:kev

Re: javafx.embed.swt.* regarded as JDK internal API by jdeps of jdk9-ea135

2016-09-13 Thread Alexander Nyssen
. Is there a concrete schedule? > > — Kevin Best Regards, Alexander > > > Alexander Nyssen wrote: >> Hi all, >> >> I used a recent jdeps (from jdk9-ea135) to check the Eclipse GEF code base >> and was astonished to see that all dependencies to javafx.emb

javafx.embed.swt.* regarded as JDK internal API by jdeps of jdk9-ea135

2016-09-13 Thread Alexander Nyssen
Hi all, I used a recent jdeps (from jdk9-ea135) to check the Eclipse GEF code base and was astonished to see that all dependencies to javafx.embed.swt.* now seem to be regarded as JDK internal API. I assume this is just a temporal inconsistency. Therefore, let me ask when it is planned to

Re: [PATCH] 8143596: FXCanvas does not forward touch gestures to embedded scene

2016-08-18 Thread Alexander Nyssen
plugin.system.issuetabpanels:comment-tabpanel#comment-13989256 > > > Alexander Nyssen wrote: >> Hi all, Kevin, >> >> attached please find a patch for JDK-8143596 >> <https://bugs.openjdk.java.net/browse/JDK-8143596> (FXCanvas does not >> forward touch gestu

Re: Marking synthesized scroll events as such.

2016-08-16 Thread Alexander Nyssen
mpared to JavaFX native). Regards, Alexander > Am 16.08.2016 um 08:55 schrieb Alexander Nyssen <alexan...@nyssen.org>: > > Hi all, > > as I am currently working on FXCanvas, there is one aspect I would like to > discuss, which is closely related to JDK-8161282 > <

Re: [PATCH] 8161282: FXCanvas does not forward horizontal mouse scroll events to the embedded scene

2016-08-16 Thread Alexander Nyssen
ad this revised version of the patch today. > > -- Kevin > > > Alexander Nyssen wrote: >> >> Hi Kevin, >> >> please consider the following updated patch instead, which contains an >> additional null-check. >> >> Regards >> Alexand

Marking synthesized scroll events as such.

2016-08-16 Thread Alexander Nyssen
Hi all, as I am currently working on FXCanvas, there is one aspect I would like to discuss, which is closely related to JDK-8161282 (FXCanvas does not forward horizontal mouse scroll events to the embedded scene) and JDK-8143596

Re: [PATCH] 8161282: FXCanvas does not forward horizontal mouse scroll events to the embedded scene

2016-08-15 Thread Alexander Nyssen
Hi Kevin, please consider the following updated patch instead, which contains an additional null-check. Regards Alexander > Am 12.08.2016 um 16:04 schrieb Alexander Nyssen <alexan...@nyssen.org>: > > Hi Kevin, > > attached please find an initial patch for > https

[PATCH] 8161282: FXCanvas does not forward horizontal mouse scroll events to the embedded scene

2016-08-12 Thread Alexander Nyssen
Hi Kevin, attached please find an initial patch for https://bugs.openjdk.java.net/browse/JDK-8161282 . The patch is not as minimal as I had hoped, as the EmbeddedSceneInterface had to be changed to differentiate between mouse and scroll events

Re: [PATCH] 8160325: Provide a public API to obtain the FXCanvas for an embedded scene.

2016-08-11 Thread Alexander Nyssen
le.com>: > > > > Alexander Nyssen wrote: >> >> Hi Kevin, >> >> thanks for your feedback. Please fin my comments inline. >> >> >>> Am 09.08.2016 um 03:10 schrieb Kevin Rushforth <kevin.rushfo...@oracle.com> >>> <mailto:kevin.rush

Re: [PATCH] 8160325: Provide a public API to obtain the FXCanvas for an embedded scene.

2016-08-09 Thread Alexander Nyssen
Would you prefer that? > > Additionally, I requested JDK 9 release team approval for this. The approval > process can proceed in parallel with your addressing the issues I raised. > > — Kevin Regards, Alexander > > > Alexander Nyssen wrote: >> Hi Kevin, >&

Re: [PATCH] 8088147: FXCanvas: implement custom cursors (revised)

2016-07-27 Thread Alexander Nyssen
dules.xml that > should be reverted. Please send a new patch with the above two fixed. > > The rest looks fine to me, but I will wait to verify until you provide an > update to fix the unit test. > > As for the JIGSAW mode tests, I agree that can/should be a follow-on effort. &g

Re: [PATCH] 8088147: FXCanvas: implement custom cursors (revised)

2016-07-27 Thread Alexander Nyssen
> > > Kevin Rushforth wrote: >> I'm back, and given that the review will take some time anyway, I will >> sponsor this once the review is complete. I see that Guru uploaded the patch >> for you (thanks, Guru) so I can test it next week. >> >> -- Kevin >>

Re: [PATCH] 8088147: FXCanvas: implement custom cursors (revised)

2016-07-12 Thread Alexander Nyssen
It seems I was unsuccessful again. If somebody would be willing to sponsor this contribution while Kevin is away (or at least update the patch provided for JDK-8088147), I could mail the patch privately. Regards, Alexander > Am 11.07.2016 um 19:59 schrieb Alexander Nyssen <alexan...@nyss

Re: [PATCH] 8088147: FXCanvas: implement custom cursors (revised)

2016-07-11 Thread Alexander Nyssen
It seems my attachment has again been ‚consumed‘ by the list. Trying again with an archive containing the patch file. Regards, Alexander > Am 08.07.2016 um 23:28 schrieb Alexander Nyssen <alexan...@nyssen.org>: > > Hi Kevin, all, > > attached please find a revised patc

Re: [PATCH] 8088147: FXCanvas: implement custom cursors

2016-06-30 Thread Alexander Nyssen
>> Can you please send me the patch offline, as a zip file (so line endings are >> preserved across different systems), and I will unzip it and attach it to >> the bug report. >> >> -- Kevin >> >> >> Alexander Nyssen wrote: >>> Hi, >>> >&

[PATCH] 8088147: FXCanvas: implement custom cursors

2016-06-23 Thread Alexander Nyssen
Hi, I have worked on a first contribution related to JDK-8088147. Attached please find a patch (created in extended Git format) that comprises the related changes. I have augmented the implementation of javafx.embed.swt.SWTCursors to handle the image cursor case. I further adjusted

Re: LocalDateTimeStringConverterTest seem to fail if default locale is different to en_US

2016-06-18 Thread Alexander Nyssen
at test.javafx.scene.web.LoadTest.loadJarFile(LoadTest.java:285) Caused by: netscape.javascript.JSException: ReferenceError: Can't find variable: jsr0 Any idea about these? I am running Mac OS X El Capitan on my machine. Maybe that’s important. Regards, Alexander > > -- Kevin >

Re: LocalDateTimeStringConverterTest seem to fail if default locale is different to en_US

2016-06-17 Thread Alexander Nyssen
rol at test.javafx.scene.control.TreeViewTest.setup(TreeViewTest.java:121) 7133 tests completed, 6326 failed, 239 skipped :controls:test FAILED FAILURE: Build failed with an exception. The build succeeded (using gradle). Any idea what might be wrong? Regards, Alexander > Am 17.06.2016 um 07:56 schrieb Alexander Nyssen &

LocalDateTimeStringConverterTest seem to fail if default locale is different to en_US

2016-06-16 Thread Alexander Nyssen
Hi, in order to be able to contribute to OpenJFX, I am currently trying to set up my development environment. After checking out the latest head from hg clone http://hg.openjdk.java.net/openjfx/9-dev/rt , compilation succeeds, but tests fail with