Re: [10] Review request for 8185634, 8185634: Java Fx-Swing dialogs appearing behind main stage

on mac? --Semyon On 11/07/2017 10:11 AM, Alexander Zvegintsev wrote: Hi Sergey, I am not able to crash it on several platforms, except one case: if we are terminating JavaFX application while EDT processing some long task. But it is unrelated to the fix and reproducible on current builds

Re: [10] Review request for 8185634, 8185634: Java Fx-Swing dialogs appearing behind main stage

log on linux and windows? On 10/10/2017 13:54, Kevin Rushforth wrote: Note that there is now a 04 version. It looks good to me, although someone more familiar with AWT should also check the AWT changes. We will need a test program for this (as a follow-on issue if not now). -- Kevin Alexande

[10] Review request for 8181406: [linux] Stage resizing bug

Hi all, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/10/8181406/00/ for the issue https://bugs.openjdk.java.net/browse/JDK-8181406 -- Thanks, Alexander.

Re: CFV: New OpenJFX Committer: Ambarish Rapte

Vote: yes Thanks, Alexander. On 01/11/2017 01:48, Kevin Rushforth wrote: I hereby nominate Ambarish Rapte [1] to OpenJFX Committer. Ambarish is a member of JavaFX team at Oracle, who has contributed 10 changesets [2][3] to OpenJFX. Votes are due by November 14, 2017. Only current OpenJFX

[10] Review request for 8165562: Upgrade to newer version of SWT for build/test

Hello, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/10/8165562/00/ for the issue https://bugs.openjdk.java.net/browse/JDK-8165562 -- Thanks, Alexander.

[10] Review request 8185827: SEGV in com.sun.glass.ui.mac.MacCommonDialogs.

Hello, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/10/8185827/01/ for the issue https://bugs.openjdk.java.net/browse/JDK-8185827 -- Thanks, Alexander.

Re: [10] Review request for 8185634, 8185634: Java Fx-Swing dialogs appearing behind main stage

rWindowPtr, ptr, CWrapper.NSWindow.NSWindowAbove); <<<<< Boom } On 9/21/17 22:56, Alexander Zvegintsev wrote: Hi Phil, Please review the updated fix with reflection incorporated http://cr.openjdk.java.net/~azvegint/jdk/10/8185634/01/ New issue created JDK-8187803 <https:/

Re: CFV: New OpenJFX Committer: Prasanta Sadhukhan

Vote: YES Thanks, Alexander. On 28/09/2017 06:40, Kevin Rushforth wrote: I hereby nominate Prasanta Sadhukhan [1] to OpenJFX Committer. Prasanta is a member of JavaFX team at Oracle, who has contributed 12 changesets [2] to OpenJFX. Votes are due by October 11, 2017. Only current OpenJFX

Re: [10] Review request for 8185634, 8185634: Java Fx-Swing dialogs appearing behind main stage

= peer.getOverridenWindowHandle(); <<<<< Dispose the peer if (ownerWindowPtr != 0) {     //Place window above JavaFX stage     CWrapper.NSWindow.addChildWindow(     ownerWindowPtr, ptr, CWrapper.NSWindow.NSWindowAbove); <<<<< Boom } On 9/21/17 22:56, Alexander Zvegintsev wrote: Hi Phil,

Re: [10] Review request for 8185634, 8185634: Java Fx-Swing dialogs appearing behind main stage

-up I suggest that you should replace addChildWindow() with orderWindow() or use some another approach to locate the window above the stage. Thanks, Dmitry On 22 Sep 2017, at 06:56, Alexander Zvegintsev <alexander.zvegint...@oracle.com> wrote: Hi Phil, Please review the updat

Re: [10] Review request for 8185634, 8185634: Java Fx-Swing dialogs appearing behind main stage

f-line that as in the dialog case, the FX side of the code can use reflection and simply be a harmless non-functional no-op if the SwingAccessor does not provide the new method. BTW 264 inline HWND GetOverridenHWnd() { return m_overridenHwnd; } should be "dd" not "d". -phil. On 09/21/2017 03:3

[10] Review request for 185634: Java Fx-Swing dialogs appearing behind main stage

Hello, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/10/8185634/00/ for the issue https://bugs.openjdk.java.net/browse/JDK-8185634 -- Thanks, Alexander.

[10] request for review 8181779: Memory leak in FX Glass Embedded Window

Hello, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/10/8181779/00/ for the issue https://bugs.openjdk.java.net/browse/JDK-8181779 -- Thanks, Alexander.

[10] Review request for 8181476 [macos] Stages with StageStyle.UTILITY are always on-top when initialized without an owner

Hello, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/10/8181476/00/ for the issue https://bugs.openjdk.java.net/browse/JDK-8181476 -- Thanks, Alexander.

Re: CFV: New OpenJFX Committer: Ajit Ghaisas

Vote: yes -- Thanks, Alexander. On 26.05.2017 15:20, Kevin Rushforth wrote: I hereby nominate Ajit Ghaisas [1] to OpenJFX Committer. Ajit is a member of JavaFX team at Oracle, who has contributed 10 changesets to OpenJFX. A list of these changesets is available by the following link:

Re: CFV: New OpenJFX Committer: Semyon Sadetsky

Vote: yes -- Thanks, Alexander. On 25.01.2017 22:39, David Hill wrote: I hereby nominate Semyon Sadetsky to OpenJFX Committer. Semyon Sadetsky is part of the JavaFX team focusing on glass. A list of Semyon's commits and reviews is available by the following links

Re: CFV: New OpenJFX Committer: Ramesh Gangadhar

Vote: yes Thanks, Alexander. On 19/01/2017 00:53, Kevin Rushforth wrote: I hereby nominate Ramesh Gangadhar [1] to OpenJFX Committer. Ramesh is a member of JavaFX SQE team at Oracle working on test development for the Java packager, who has contributed 20 changesets to OpenJFX, at least 8

[9] Review request for 8166106: JVM crash on resizing JavaFX application with title and icon

Hello, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/9/8166106/00/ for the issue https://bugs.openjdk.java.net/browse/JDK-8166106 -- Thanks, Alexander.

Re: CFV: New OpenJFX Committer: Victor Drozdov

Vote: yes Thanks, Alexander. On 12/14/16 3:21 AM, Chris Bensen wrote: I hereby nominate Victor Drozdov [1] to OpenJFX Committer. Victor is a member of Java Deployment team at Oracle working on the Java Packager tool, who has contributed 11 changesets [5] to OpenJFX, at least 8 of which are

[9] Review request for 8150175: Need replacement in FXDnD for DropTargetContext::addNotify, removeNotify

Hello, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/9/8150175/00/ for the issue https://bugs.openjdk.java.net/browse/JDK-8150175 -- Thanks, Alexander.

Re: [9] Review request for 8087498 [Mac] : Full screen mode fails for certain StageStyles

please see the updated webrev http://cr.openjdk.java.net/~azvegint/jdk/9/8087498/01/ Thanks, Alexander. On 8/4/16 3:40 AM, Alexander Zvegintsev wrote: Hello, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/9/8087498/00 for the issue https://bugs.openjdk.java.net/browse/JDK

Re: [PATCH] 8161282: FXCanvas does not forward horizontal mouse scroll events to the embedded scene

Hi Alexander, The fix looks good to me, except the wild card import change in FXCanvas.java(there is no need for a new patch, if it is the only issue found) On 8/16/16 10:24 AM, Alexander Nyssen wrote: You might even take the one I attached. I just recognized I still had some unused

Re: [PATCH] 8160325: Provide a public API to obtain the FXCanvas for an embedded scene.

Looks fine to me too. On 8/16/16 1:45 AM, Kevin Rushforth wrote: The 2016-08-12 revision looks fine to me, except for a missing space as noted in JBS (no need for a new patch if that is the only issue found). While we wait for approval from the JDK 9 release team, we need another reviewer

[9] Review request for 8087498 [Mac] : Full screen mode fails for certain StageStyles

Hello, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/9/8087498/00 for the issue https://bugs.openjdk.java.net/browse/JDK-8087498 -- -- Thanks, Alexander.

[9] Review request for 8163137 [Mac] : Maximizing a window with Cmd+Green button with Screen-Size hides it

Hello, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/9/8163137/00 for the issue https://bugs.openjdk.java.net/browse/JDK-8163137 -- -- Thanks, Alexander.

Re: CFV: New OpenJFX Committer: Arunprasad Rajkumar

vote: yes Thanks, Alexander. On 21/04/16 19:48, Kevin Rushforth wrote: I hereby nominate Arunprasad Rajkumar [1] to OpenJFX Committer. Arunprasad is a member of JavaFX team at Oracle working on WebKit, who has contributed 10 changesets [5] to OpenJFX, at least 8 of which are significant.

[9] Review request: 8088916: Replace sun.net.www.ParseUtil#decode with public API

Hi Kevin, please review the fix http://cr.openjdk.java.net/~azvegint/jdk/9/8088916/00/ for the issue https://bugs.openjdk.java.net/browse/JDK-8088916 -- -- Thanks, Alexander.

Re: CFV: New OpenJFX Committer: Murali Billa

Vote: yes -- Thanks, Alexander. On 01.04.2016 0:04, Kevin Rushforth wrote: I hereby nominate Murali Billa [1] to OpenJFX Committer. Murali is a member of JavaFX team at Oracle working on WebKit, who has contributed 10 changesets [5] to OpenJFX, at least 8 of which are significant. Votes

Re: CFV: New OpenJFX Committer: Anton Nashatyrev

Vote: yes -- Thanks, Alexander. On 05/29/2015 04:16 PM, Kevin Rushforth wrote: I hereby nominate Anton Nashatyrev to OpenJFX Committer. Anton is a member of JavaFX team at Oracle working on WebKit and Media. A list of Anton's contributions is available via the following link:

[8u60, 9] Review request for RT-40548: [GTK] Gdk-ERROR **: g_thread_init() must be called before gdk_threads_init()

Hello, please review the fix http://cr.openjdk.java.net/~azvegint/fx/8u60/40548/00/ for the issue https://javafx-jira.kenai.com/browse/RT-40548 -- Thanks, Alexander.

Re: CFV: New OpenJFX Committer: Elina Kleyman

Vote: YES -- Thanks, Alexander. On 04/10/2014 04:31 PM, David Hill wrote: I hereby nominate Elina Kleyman to OpenJFX Committer. Elina is a member of JavaFX Embedded team at Oracle. Elina's changes are in Glass support code, as well as our test and sample applications. hg log -M -u

[8] Review request for RT-34750 [TextField, PasswordField, TextArea, Linux] selected text is removed on focus leaving

Hello Anthony, Please review fix for https://javafx-jira.kenai.com/browse/RT-34750 -- Thanks, Alexander.

[8] Review request for RT-34196 [Controls, Menus] Gtk: JAVAFX default menu items are difficult to click

Hello Anthony, Martin, Please review fix for https://javafx-jira.kenai.com/browse/RT-34196 -- Thanks, Alexander.

[8] Review request for RT-30457 Gtk: setDragView doesn't work on linux

Hello Anthony, Please review fix for https://javafx-jira.kenai.com/browse/RT-30457 http://cr.openjdk.java.net/~azvegint/fx/8/30457/webrev.00/ -- Thanks, Alexander.

[8] Review request for RT-34272 Gtk: Linux Input Method, partial composed text is not canceled when losing focus.

Hello, Please review fix for https://javafx-jira.kenai.com/browse/RT-34272 http://cr.openjdk.java.net/~azvegint/fx/8/34272/webrev.00/ -- Thanks, Alexander.

[8] Review request for RT-32477 Gtk: TextField: Ctrl+A don't work with Russian keyboard layout.

Hello, Please review fix for https://javafx-jira.kenai.com/browse/RT-32477 http://cr.openjdk.java.net/~azvegint/fx/8/32477/webrev.00/ -- Thanks, Alexander.

[8] Review request for RT-32436 Gtk: OpenGL with JavaFX causes Gthread error and halts

Hello, Please review fix for https://javafx-jira.kenai.com/browse/RT-32436 -- Thanks, Alexander.