Re: [Integrated] RFR: 8211308: Support HTTP/2 in WebView

2019-12-03 Thread Arunprasad Rajkumar
Changeset: 98035cb2 Author:Arunprasad Rajkumar Date: 2019-12-03 08:24:01 + URL: https://git.openjdk.java.net/jfx/commit/98035cb2 8211308: Support HTTP/2 in WebView Reviewed-by: ghb, kcr ! modules/javafx.web/src/main/java/com/sun/webkit/network/ByteBufferPool.java + modules

Re: RFR: 8212034: Potential memory leaks in jpegLoader.c in error case

2019-11-28 Thread Arunprasad Rajkumar
On Wed, 27 Nov 2019 11:58:18 GMT, Ambarish Rapte wrote: > Memory allocated in initDecompressor() and decompressIndirect() is not freed > in error case. > In error case, > 1. Allocated memory should be freed. > 2. Appropriate de-initialization jpeg library calls should be added. > > Verified

Re: [Integrated] RFR: 8232158: [macOS] Fallback to command line tools if xcode is missing

2019-10-23 Thread Arunprasad Rajkumar
Changeset: ab6ea3b9 Author:Arunprasad Rajkumar Date: 2019-10-23 08:41:40 + URL: https://git.openjdk.java.net/jfx/commit/ab6ea3b9 8232158: [macOS] Fallback to command line tools if xcode is missing Reviewed-by: kcr, jvos ! buildSrc/mac.gradle

Re: RFR: 8232158: [macOS] Fallback to command line tools if xcode is missing

2019-10-22 Thread Arunprasad Rajkumar
On Wed, 16 Oct 2019 15:54:54 GMT, Arunprasad Rajkumar wrote: > On Wed, 16 Oct 2019 15:29:05 GMT, Kevin Rushforth wrote: > >> On Wed, 16 Oct 2019 15:21:55 GMT, Arunprasad Rajkumar >> wrote: >> >>> On Fri, 11 Oct 2019 05:52:33 GMT, Arunprasad Rajkumar >

Re: RFR: 8211308: Support HTTP/2 in WebView

2019-10-16 Thread Arunprasad Rajkumar
On Fri, 11 Oct 2019 11:21:08 GMT, Robin Westberg wrote: > On Fri, 11 Oct 2019 07:01:48 GMT, Arunprasad Rajkumar > wrote: > >> On Fri, 11 Oct 2019 06:44:09 GMT, Johan Vos wrote: >> >>> On Fri, 11 Oct 2019 06:18:38 GMT, Arunprasad Rajkumar >>> wrote:

Re: [Rev 01] RFR: WIP: 8211308: Support HTTP/2 in WebView

2019-10-16 Thread Arunprasad Rajkumar
The pull request has been updated with additional changes. Added commits: - 1832c2db: Incorporate fixes provided by @kcr Changes: - all: https://git.openjdk.java.net/jfx/pull/14/files - new: https://git.openjdk.java.net/jfx/pull/14/files/1798a661..1832c2db Webrevs: -

Re: RFR: 8232158: [macOS] Fallback to command line tools if xcode is missing

2019-10-16 Thread Arunprasad Rajkumar
On Wed, 16 Oct 2019 15:29:05 GMT, Kevin Rushforth wrote: > On Wed, 16 Oct 2019 15:21:55 GMT, Arunprasad Rajkumar > wrote: > >> On Fri, 11 Oct 2019 05:52:33 GMT, Arunprasad Rajkumar >> wrote: >> >>> 8232158: [macOS] Fallback to co

Re: RFR: 8232158: [macOS] Fallback to command line tools if xcode is missing

2019-10-16 Thread Arunprasad Rajkumar
On Fri, 11 Oct 2019 05:52:33 GMT, Arunprasad Rajkumar wrote: > 8232158: [macOS] Fallback to command line tools if xcode is missing > > > > Commits: > - 063d2f38: JDK-8232158: [macOS] Fallback to command line tools if xcode is > missin

Re: RFR: WIP: 8211308: Support HTTP/2 in WebView

2019-10-11 Thread Arunprasad Rajkumar
On Fri, 11 Oct 2019 06:44:09 GMT, Johan Vos wrote: > On Fri, 11 Oct 2019 06:18:38 GMT, Arunprasad Rajkumar > wrote: > >> On Fri, 11 Oct 2019 06:07:14 GMT, Arunprasad Rajkumar >> wrote: >> >>> The goal of this enhancement is to use new [HttpClient >&

Re: RFR: 8211308: Support HTTP/2 in WebView

2019-10-11 Thread Arunprasad Rajkumar
On Fri, 11 Oct 2019 06:07:14 GMT, Arunprasad Rajkumar wrote: > The goal of this enhancement is to use new [HttpClient > APIs](https://docs.oracle.com/en/java/javase/11/docs/api/java.net.http/java/net/http/HttpClient.html) > available from JDK 11. > > Reference: > [1] https:

Re: [Rev 01] RFR: 8232158: [macOS] Fallback to command line tools if xcode is missing

2019-10-11 Thread Arunprasad Rajkumar
The pull request has been updated with additional changes. Added commits: - 9b1f7286: 8232158: [macOS] Fallback to command line tools if xcode is missing Changes: - all: https://git.openjdk.java.net/jfx/pull/13/files - new:

RFR: 8211308: Support HTTP/2 in WebView

2019-10-11 Thread Arunprasad Rajkumar
The goal of this enhancement is to use new [HttpClient APIs](https://docs.oracle.com/en/java/javase/11/docs/api/java.net.http/java/net/http/HttpClient.html) available from JDK 11. Reference: [1] https://openjdk.java.net/groups/net/httpclient/intro.html [2]

RFR: 8232158: [macOS] Fallback to command line tools if xcode is missing

2019-10-10 Thread Arunprasad Rajkumar
8232158: [macOS] Fallback to command line tools if xcode is missing Commits: - 063d2f38: JDK-8232158: [macOS] Fallback to command line tools if xcode is missing Changes: https://git.openjdk.java.net/jfx/pull/13/files Webrev: https://webrevs.openjdk.java.net/jfx/13/webrev.00

[RFR] [openjfx13] 8227431: [Windows] Fix assertion failure on X86 32-bit when enabling CLOOP based JavaScript interpreter

2019-07-09 Thread Arunprasad Rajkumar
Hi Kevin, Please review the following PR, https://github.com/javafxports/openjdk-jfx/pull/525 Thanks, Arun

[RFR] [openjfx13] 8222912: Websocket client doesn't work in WebView

2019-07-09 Thread Arunprasad Rajkumar
Hi Kevin, Please review the following PR, JBS: https://bugs.openjdk.java.net/browse/JDK-8222912 https://github.com/javafxports/openjdk-jfx/pull/524 Thanks, Arun

[RFR][openjfx13] 8227079: Cherry pick GTK WebKit 2.24.3 changes

2019-07-03 Thread Arunprasad Rajkumar
Hi Kevin, Johan, Please review the following PR which merges changes from GTK WebKit 2.24.3 release. https://github.com/javafxports/openjdk-jfx/pull/515 Thanks, Arun

[RFR] [openjfx13] 8219362: Update to 608.1 version of WebKit

2019-06-27 Thread Arunprasad Rajkumar
Hi Kevin, Johan, Please review the following patch which merges GTK WebKit 2.24(608.1) into jfx-dev: https://cr.openjdk.java.net/~arajkumar/8219362/webrev Above link has a webrev and a compressed changeset file, 1. rt-non-native-webkit — Contains changes other than

Re: CFV: New OpenJFX Committer: Nir Lisker

2019-06-26 Thread Arunprasad Rajkumar
Vote: YES > On 26-Jun-2019, at 3:14 AM, Kevin Rushforth > wrote: > > I hereby nominate Nir Lisker [1] to OpenJFX Committer. > > Nir is an OpenJFX community member, who has contributed 16 changesets [2][3] > to OpenJFX. > > Votes are due by July 13, 2019. > > Only current OpenJFX Committers

[RFR][openjfx13] 8225203: Update SQLite to version 3.28.0

2019-06-20 Thread Arunprasad Rajkumar
Hi Kevin, Johan, Please review the following PR, which upgrades sqlite to 3.28.0. https://github.com/javafxports/openjdk-jfx/pull/505 https://bugs.openjdk.java.net/browse/JDK-8225203 Thanks, Arun

JDK-8222360: Remove spurious empty file from repo

2019-06-19 Thread Arunprasad Rajkumar
Hi Kevin, Please review the following simple PR., it just removes an empty file which got added part of JDK-8211454. https://github.com/javafxports/openjdk-jfx/pull/504 https://bugs.openjdk.java.net/browse/JDK-8222360 Thanks, Arun

[RFR] [openjfx13] JDK-8224016: Intermittent test failure in SVGTest on Linux

2019-05-21 Thread Arunprasad Rajkumar
Hi Kevin, Please review the following PR which fixes a test bug, https://github.com/javafxports/openjdk-jfx/pull/476 https://bugs.openjdk.java.net/browse/JDK-8224016 Thanks, Arun

[RFR][openjfx13] JDK-8222788: javafx.web build fails on XCode 10.2

2019-05-16 Thread Arunprasad Rajkumar
Hi Kevin, Johan, Please review the following PR. It is just a cherry-pick from upstream WebKit repo to resolve build failure when using Xcode 10.2. https://github.com/javafxports/openjdk-jfx/pull/474 https://bugs.openjdk.java.net/browse/JDK-8222788 Thanks, Arun

[RFR][openjfx13] JDK-8221300, JDK-8221302, JDK-8221299: Upgrade to {Xcode 10.1, gcc 8.2, Visual Studio 2017 version 15.9.6}

2019-04-10 Thread Arunprasad Rajkumar
Hi Kevin, Johan, Please review the following Github PR which upgrades toolchains. https://github.com/javafxports/openjdk-jfx/pull/438 The above PR is targeted for the following JBS issue, JDK-8221300: Upgrade to Xcode 10.1 JDK-8221302: Upgrade to gcc 8.2 on Linux JDK-8221299: Upgrade to Visual

[RFR] [openjfx13] JDK-8221941: Wrong package declaration for WCTextRunImpl.java in web module

2019-04-03 Thread Arunprasad Rajkumar
Hi Kevin, Please review the following PR, https://github.com/javafxports/openjdk-jfx/pull/429 Thanks, Arun

[RFR][openjfx13] JDK-8214716: Record the versions of tools used to build FX in the repo

2019-04-02 Thread Arunprasad Rajkumar
Hi, Please review the following PR which add information about JavaFX dependency tools. https://github.com/javafxports/openjdk-jfx/pull/427 Thanks, Arun

[RFR] JDK-8217942: Upgrade to libxslt 1.1.33

2019-03-22 Thread Arunprasad Rajkumar
Hi Kevin, Johan, Please review the following PR which updates libxslt to 1.1.33. https://github.com/javafxports/openjdk-jfx/pull/416 Thanks, Arun

[RFR] JDK-8220147: Cherry pick GTK WebKit 2.22.7 changes

2019-03-05 Thread Arunprasad Rajkumar
Hi, Please review the following PR, https://github.com/javafxports/openjdk-jfx/pull/399 https://bugs.openjdk.java.net/browse/JDK-8220147 Thanks, Arun

[RFR] JDK-8219917: [WebView] Sub-resource integrity check fails

2019-03-01 Thread Arunprasad Rajkumar
Hi, Please review following Github PR, https://github.com/javafxports/openjdk-jfx/pull/392 JBS: https://bugs.openjdk.java.net/browse/JDK-8219917 Thanks, Arun

[RFR] 8211308: Support HTTP/2 in WebView

2019-02-20 Thread Arunprasad Rajkumar
Hi, Please review the following Github PR which uses new HttpClient interface (introduced since JDK11[1]) to support HTTP/2. https://github.com/javafxports/openjdk-jfx/pull/247 https://bugs.openjdk.java.net/browse/JDK-8211308 Note: There is a runtime property “com.sun.webkit.useHTTP2Loader"

[RFR] JDK-8215775: Scrollbars from web pages appear to be absolute, overlapping everything

2019-02-16 Thread Arunprasad Rajkumar
Hi, Please review the following PR, https://github.com/javafxports/openjdk-jfx/pull/349 https://bugs.openjdk.java.net/browse/JDK-8215775 Thanks, Arun

RFR JDK-8218611: [DRT] fast/xslt tests fails with Unsupported encoding windows-1251

2019-02-08 Thread Arunprasad Rajkumar
Hi, Please review the following PR, https://github.com/javafxports/openjdk-jfx/pull/373 JBS: https://bugs.openjdk.java.net/browse/JDK-8218611 Thanks, Arun

RFR 8215702: SVG gradients are not rendered

2019-01-16 Thread Arunprasad Rajkumar
Hi, Please review the following PR related to JDK-8215702, https://github.com/javafxports/openjdk-jfx/pull/347 https://bugs.openjdk.java.net/browse/JDK-8215702 Thanks, Arun

RFR 8216470: Some methods of System.Logger are unimplemented in PlatformLogger

2019-01-10 Thread Arunprasad Rajkumar
Hi Kevin, Ajit, Please review the following PR which fixes JDK-8216470. https://github.com/javafxports/openjdk-jfx/pull/343/ https://bugs.openjdk.java.net/browse/JDK-8216470 Thanks, Arun

RFR 8211454: Update SQLite to version 3.26.0

2019-01-07 Thread Arunprasad Rajkumar
Hi, Please review the following PR which upgrades sqlite to latest stable version 3.26.0. https://github.com/javafxports/openjdk-jfx/pull/341 https://bugs.openjdk.java.net/browse/JDK-8211454 Thanks, Arun

RFR 8214452: Update libxml2 to version 2.9.9

2019-01-07 Thread Arunprasad Rajkumar
Hi, Please review the following PR which upgrades libxml2 to latest stable version 2.9.9. https://github.com/javafxports/openjdk-jfx/pull/340 https://bugs.openjdk.java.net/browse/JDK-8214452 Thanks, Arun

RFR JDK-8215799: [Windows] Complex texts are not rendered properly

2019-01-04 Thread Arunprasad Rajkumar
Hi, Please review the following Github PR, https://github.com/javafxports/openjdk-jfx/pull/337 https://bugs.openjdk.java.net/browse/JDK-8215799 Thanks, Arun

RFR JDK-8211399: libxslt fails to build with glibc 2.26

2018-12-20 Thread Arunprasad Rajkumar
Hi, Please review the following PR targeted for JDK-8211399. https://github.com/javafxports/openjdk-jfx/pull/314 https://bugs.openjdk.java.net/browse/JDK-8211399 Thanks, Arun

RFR: 8214119: Update to 607.1 version of WebKit

2018-12-18 Thread Arunprasad Rajkumar
Hi Kevin, Murali, Johan, Joeri, Please review the following patch which merges GTK WebKit 2.22(607.1) into jfx-dev: http://cr.openjdk.java.net/~arajkumar/8214119/webrev Above link has a webrev and a changeset file, 1. rt-non-native-webkit — Contains changes other than

Re: issue with WebView in 8u202

2018-11-20 Thread Arunprasad Rajkumar
orrect me if im wrong. > > Thanks, > Murali > > -Original Message- > From: Arunprasad Rajkumar > Sent: Tuesday, November 20, 2018 12:39 PM > To: Anton Tarasov > Cc: openjfx-dev@openjdk.java.net > Subject: Re: issue with WebView in 8u202 > > Hi Anton, >

Re: issue with WebView in 8u202

2018-11-19 Thread Arunprasad Rajkumar
Hi Anton, Looks like this is mostly related to Content Security Policy(CSP)[1] which have got strengthened after recent WebKit upgrades. I have reduced the given html further(PSB) & I could reproduce the problem with the following html snippet,

[RFR][openjfx12] JDK-8211307: Add prefix to build tools paths

2018-11-13 Thread Arunprasad Rajkumar
Hi, Please review the following Github PR, https://github.com/javafxports/openjdk-jfx/pull/283 https://bugs.openjdk.java.net/browse/JDK-8211307 Thanks, Arun

[RFR] [openjfx12] 8213135: HTMLEditorTest.checkStyleProperty fails intermittently

2018-10-31 Thread Arunprasad Rajkumar
Hi Kevin/Murali, Please review the patch for the following bug, Root cause: WebView load workers's state change notification received for the default page of HTMLEditor and not for the html doc which loaded using setHtmlText. The erroneous notification caused assertion check on invalid html

[RFR] 8210218: WebKit build fails with newer versions of VS 2017

2018-09-05 Thread Arunprasad Rajkumar
Hi Kevin, Johan, Please review the following PR. https://github.com/javafxports/openjdk-jfx/pull/200 Thanks, Arun

Re: webkit feedback calls on failure

2018-09-05 Thread Arunprasad Rajkumar
Hi Johan, Thanks for reporting this. I agree, there are few areas which needs improvement in WebView component, error handling is one among them. Please file a bug. Regards, Arun > On 04-Sep-2018, at 7:01 PM, Johan Vos wrote: > > The WebEngine already allows to get information about the

Re: [RFR] [openjfx12] 8148129: Implement Accelerated composition for WebView

2018-09-04 Thread Arunprasad Rajkumar
018, at 12:25 PM, Arunprasad Rajkumar > wrote: > > Hi, > > Please review the patch for following enhancement, it is targeted for > openjfx12. > > https://bugs.openjdk.java.net/browse/JDK-8148129 > > Changes are available as gihub PR, refer the following link, &g

[RFR][8u-dev] JDK-8210216: Build of 8u-dev fails on 32-bit Linux after fix for JDK-8207159

2018-08-31 Thread Arunprasad Rajkumar
Hi Kevin, Please review the fix for the bug JDK-8210216. Root cause and solution is updated in JBS. Thanks, Arun

Re: building webkit

2018-08-25 Thread Arunprasad Rajkumar
tency due to varying build times, which may lead to canceled > jobs? > > On Sat, Aug 25, 2018 at 7:12 PM Arunprasad Rajkumar > mailto:arunprasad.rajku...@oracle.com>> > wrote: > As Kevin mentioned, I tried to make WebKit build work on Travis with few > hacks(us

Re: building webkit

2018-08-25 Thread Arunprasad Rajkumar
As Kevin mentioned, I tried to make WebKit build work on Travis with few hacks(using ccache). It seemed to be working, but not consistently all the time. > How does AdoptJDK solve problems of long build times? Can we not adopt > their build chain/infrastructure? Looks like they host their own

[RFR] [openjfx12] 8148129: Implement Accelerated composition for WebView

2018-08-25 Thread Arunprasad Rajkumar
Hi, Please review the patch for following enhancement, it is targeted for openjfx12. https://bugs.openjdk.java.net/browse/JDK-8148129 Changes are available as gihub PR, refer the following link, https://github.com/javafxports/openjdk-jfx/pull/51 Unified diff is available in the following

Re: How to access com.sun.webkit.network.CookieManager at JDK 10?

2018-08-24 Thread Arunprasad Rajkumar
Hello Miro, CookieManager is a module private class, which is not exposed to outside. I could think of two options, 1. com.sun.webkit.network.CookieManager is a type of java.net.CookieHandler, that means after instantiating WebEngine, you can call CookieHandler.getDefault() to get the

[RFR] 8207159:Update ICU to version 62.1

2018-08-20 Thread Arunprasad Rajkumar
Hi, Please review the fix for JDK-8207159. Changeset: 1. Build system related changes(done by us): http://cr.openjdk.java.net/~arajkumar/8207159/webrev 2. Complete changeset({62.1 icu + build system} changes): http://cr.openjdk.java.net/~arajkumar/8207159/webrev/icu.core.changeset.gz #1

[RFR] JDK-8209457] [WebView : Canvas.toDataURL with image/jpeg MIME type fails

2018-08-16 Thread Arunprasad Rajkumar
Hi Kevin, Murali, Please review the fix for following bug, https://bugs.openjdk.java.net/browse/JDK-8209457 Root cause: BufferedImage is created with ARGB color model while converting from PrismImage to JPEG. JPEG doesn't supports alpha channel, which leads to error while encoding to JPEG

[RFR] 8209191: [macOS] Distorted complex text rendering

2018-08-13 Thread Arunprasad Rajkumar
Hi Kevin,Phil, Please review the fix for following bug, https://bugs.openjdk.java.net/browse/JDK-8209191 Root cause: JDK-8198354 takes care of NULL return from CTRunGetGlyphsPtr, the similar treatment has to be given for CTRunGetPositionsPtr[1] as well. (CTRunGetStringIndicesPtr already got

[RFR] 8209049: Cherry pick GTK WebKit 2.20.4 changes

2018-08-13 Thread Arunprasad Rajkumar
Hi Kevin/Murali, Please review the fix the following bug, https://bugs.openjdk.java.net/browse/JDK-8209049 I didn’t generate webrev because patch contains changes from GTK WebKit 2.20.4 branch[1]. [1] https://trac.webkit.org/log/webkit/releases/WebKitGTK/webkit-2.20 Thanks, Arun

[RFR] JDK-8208622: [WebView] IllegalStateException when invoking print API with html form controls

2018-08-02 Thread Arunprasad Rajkumar
Hi, Please review the fix for following bug, https://bugs.openjdk.java.net/browse/JDK-8208622 Root cause: `RenderThemeJava` instance is associated with form controls rendering in `WebPage::prePaint` and disassociated in `WebPage::postPaint`. However, when printing is invoked, `WebPage.print`

[openjfx11][RFR] 8196968: One time crash on exit in JNIEnv_::CallObjectMethod

2018-07-24 Thread Arunprasad Rajkumar
Hi, Please review the following fix, JBS: https://bugs.openjdk.java.net/browse/JDK-8196968 webrev: http://cr.openjdk.java.net/~arajkumar/8196968/webrev Root cause: From the crash log, I could see that WebCore image decoder is trying to call the Java method(through JNI) after detaching from

[openjfx11][RFR] 8208114: Drag and drop of text contents and URL links functionalities are broken in Webview

2018-07-24 Thread Arunprasad Rajkumar
Hi, Please review the following fix, JBS: https://bugs.openjdk.java.net/browse/JDK-8208114 Root cause: It is a regression of JDK-8199474. DataTransfer mode should be set to readonly before calling DataTransfer::types, otherwise it will return empty mime type list while doing DnD. Solution:

[openjfx11] [RFC] 8147476: Rendering issues with MathML token elements

2018-07-17 Thread Arunprasad Rajkumar
Hi, The following bug has been already reviewed and merged to OpenJFX GitHub mirror repo[1][2]. https://bugs.openjdk.java.net/browse/JDK-8147476 Soon it will be pushed to jfx-dev[3] and 8u-dev[4] repos as well. Please let me know if you have

[openjfx11] Review request for 8206995: Remove unused WebKit files

2018-07-17 Thread Arunprasad Rajkumar
Hi, Please review the fix for following bug, Bug: https://bugs.openjdk.java.net/browse/JDK-8206995 Patch: https://bugs.openjdk.java.net/secure/attachment/77667/rt.patch Thanks, Arun

Re: CFV: New OpenJFX Committer: Prem Balakrishnan

2018-07-11 Thread Arunprasad Rajkumar
Vote: Yes > On 11-Jul-2018, at 5:11 AM, Kevin Rushforth > wrote: > > I hereby nominate Prem Balakrishnan [1] to OpenJFX Committer. > > Prem is a member of JavaFX team at Oracle, who has contributed 10 changesets > [2] to OpenJFX. > > Votes are due by July 24, 2018. > > Only current OpenJFX

[openjfx11] Review request for 8206899: DRT crashes randomly when running 'dom/html/level2/html/AppletsCollection.html'

2018-07-09 Thread Arunprasad Rajkumar
Hi, Please review the following fix, https://bugs.openjdk.java.net/browse/JDK-8206899 http://cr.openjdk.java.net/~arajkumar/8206899/webrev Root-cause: Problem is due to the following

[11] Review request: 8199474: Update to 606.1 version of WebKit

2018-06-27 Thread Arunprasad Rajkumar
Hello All, Following patchset contains changes to upgrade to newer WebKit which is based on GTK WebKit 2.20 [1] http://cr.openjdk.java.net/~arajkumar/8199474/webrev Above link has a webrev and a changeset file, 1. rt-non-native-webkit —

[openjfx11] Review request for 8204856: WebEngine document becomes null after PAGE_REPLACED event

2018-06-27 Thread Arunprasad Rajkumar
Hi, Please review the following fix: patch: http://cr.openjdk.java.net/~arajkumar/8204856/webrev/ bug: https://bugs.openjdk.java.net/browse/JDK-8204856 Root cause: When ever location

[openjfx11] Review request for 8203294: [Linux] Link libgcc and libstdc++ statically to support gcc-7.x

2018-05-21 Thread Arunprasad Rajkumar
Hi, Please review the following fix: http://cr.openjdk.java.net/~arajkumar/8203294/webrev Root cause: Currently C and C++ standard libraries are linked dynamically(except javafx.web), it may restrict the usage of javafx on old Linux distros when we upgrade to latest compiler(GCC 7.3?)

[11] Review request for 8197987: Update libxslt to version 1.1.32

2018-04-20 Thread Arunprasad Rajkumar
Hi Kevin, Please review the following fix for JDK-8197987 , JavaFX specific file changes: http://cr.openjdk.java.net/~arajkumar/8197987/webrev/jfx_changes Changeset (includes

[11] Review request for 8200629: Update SQLite to version 3.23.0

2018-04-10 Thread Arunprasad Rajkumar
Hi, Please review the following fix for JDK-8200629 , cmake related changes: http://cr.openjdk.java.net/~arajkumar/8200629/webrev/cmake changeset (includes cmake & sqlite upstream changes):

Re: CFV: New OpenJFX Committer: Rajath Kamath

2018-03-29 Thread Arunprasad Rajkumar
VOTE: Yes > On 29-Mar-2018, at 10:12 PM, Kevin Rushforth > wrote: > > I hereby nominate Rajath Kamath [1] to OpenJFX Committer. > > Rajath is a member of JavaFX team at Oracle, who has contributed 17 > changesets [2][3] to OpenJFX. > > Votes are due by April 12,

[11] Review request: 8146672: [Windows] Support cmake ninja build

2018-02-16 Thread Arunprasad Rajkumar
Hi, Please review the simple fix to enable ninja build generation from cmake on Windows. Linux and macOS builds are already supports ninja build. JBS: https://bugs.openjdk.java.net/browse/JDK-8146672 Webrev: http://cr.openjdk.java.net/~arajkumar/8146672/webrev Thanks, Arun

[10] Review request: 8197463: Update libxml2 to version 2.9.7

2018-02-13 Thread Arunprasad Rajkumar
Hi, Please review the following fix, Bug: https://bugs.openjdk.java.net/browse/JDK-8197463 Compressed changeset: http://cr.openjdk.java.net/~arajkumar/8197463/webrev.00/libxml2-2.9.7v3.diff.gz Cmake only changes for review:

Re: CFV: New OpenJFX Committer: Rajath Kamath

2018-02-12 Thread Arunprasad Rajkumar
Vote: YES > On 13-Feb-2018, at 3:32 AM, Kevin Rushforth > wrote: > > I hereby nominate Rajath Kamath [1] to OpenJFX Committer. > > Rajath is a member of JavaFX team at Oracle, who has contributed 11 > changesets [2][3] to OpenJFX. > > Votes are due by February

[11] Review request: 8196677: Cherry pick GTK WebKit 2.18.6 changes

2018-02-05 Thread Arunprasad Rajkumar
Hi, Please review the following fix, Bug: https://bugs.openjdk.java.net/browse/JDK-8196677 Patch: http://cr.openjdk.java.net/~arajkumar/8196677/webrev Thanks, Arun

Re: CFV: New OpenJFX Committer: Laurent Bourgès

2017-12-11 Thread Arunprasad Rajkumar
Vote: Yes On 12/12/2017 5:50 AM, Kevin Rushforth wrote: I hereby nominate Laurent Bourgès [1] to OpenJFX Committer. Laurent is the author of the Marlin rasterizer, which is used as the default rasterizer for both Java2D and JavaFX. He has contributed 10 changesets [2] to OpenJFX. Votes

[10] Review request: 8148939: Font rendering artifacts on Adobe.com

2017-12-05 Thread Arunprasad Rajkumar
Hi Kevin, Phil, Please review the following fix related to LCD text rendering issue in Windows, Bug: https://bugs.openjdk.java.net/browse/JDK-8148939 Patch: http://cr.openjdk.java.net/~arajkumar/8148939/webrev Root cause: Padding is added for "left, bottom and right" parts to avoid LCD text

[10] Review request: 8089264: DRT test fast/events/before-unload-returnValue.html times out

2017-11-06 Thread Arunprasad Rajkumar
Hi, Please review the following patch, Webrev: http://cr.openjdk.java.net/~arajkumar/8089264/webrev Bug: https://bugs.openjdk.java.net/browse/JDK-8089264 Detailed analysis is updated as JBS comment. Thanks, Arun

Re: CFV: New OpenJFX Committer: Ambarish Rapte

2017-11-01 Thread Arunprasad Rajkumar
Vote: Yes > On 01-Nov-2017, at 1:48 AM, Kevin Rushforth > wrote: > > I hereby nominate Ambarish Rapte [1] to OpenJFX Committer. > > Ambarish is a member of JavaFX team at Oracle, who has contributed 10 > changesets [2][3] to OpenJFX. > > Votes are due by November

[10] Review request: 8185804: rpath is not set properly in OSX build

2017-08-07 Thread Arunprasad Rajkumar
Hi, Please review the simple fix for the following bug, https://bugs.openjdk.java.net/browse/JDK-8185804 Detailed analysis and fix is updated as JBS comment. Thanks, Arun

[10] Review request: 8184448: Crash while loading gif images with more frames

2017-07-28 Thread Arunprasad Rajkumar
Hi, Please review the following changset, Webrev: http://cr.openjdk.java.net/~arajkumar/8184448/webrev.01 Bug: https://bugs.openjdk.java.net/browse/JDK-8184448 Detailed analysis is updated as JBS comment. Thanks, Arun

[10] Review request: 8185132: window.requestAnimationFrame API is not working

2017-07-27 Thread Arunprasad Rajkumar
Hi, Please review the following changset, Webrev: http://cr.openjdk.java.net/~arajkumar/8185132/webrev Bug: https://bugs.openjdk.java.net/browse/JDK-8185132 Detailed analysis is updated as JBS comment. Thanks, Arun

[10] Review request: 8183292: Update to 604.1 version of WebKit

2017-07-21 Thread Arunprasad Rajkumar
Hello All Following patchset contains changes to upgrade to newer WebKit which is based on GTK WebKit 2.16 [1], http://cr.openjdk.java.net/~arajkumar/8183292/webrev.00 Above link has 1 webrev and one patchset file, 1. rt-non-webkit — Contains changes other than

[webkit] [9] 8180825: Javafx WebView fails to render pdf.js

2017-06-13 Thread Arunprasad Rajkumar
Kevin, Guru, Murali, Please review the following fix targeted for JDK-9. JBS: https://bugs.openjdk.java.net/browse/JDK-8180825 Webrev: http://cr.openjdk.java.net/~arajkumar/8180825/webrev Regards, Arun

Re: CFV: New OpenJFX Committer: Ajit Ghaisas

2017-05-27 Thread Arunprasad Rajkumar
Vote: YES > On 26-May-2017, at 5:50 PM, Kevin Rushforth > wrote: > > I hereby nominate Ajit Ghaisas [1] to OpenJFX Committer. > > Ajit is a member of JavaFX team at Oracle, who has contributed 10 changesets > to OpenJFX. A list of these changesets is available by

[webkit] [10] 8178440: Build libxml2 and libxslt from source

2017-05-16 Thread Arunprasad Rajkumar
Hello Kevin, Please review the following changeset. JBS: https://bugs.openjdk.java.net/browse/JDK-8178440 Webrev: http://cr.openjdk.java.net/~arajkumar/8178440/webrev Regards, Arun

[9] Code Review Request For 8179321: WebEngine.getDocument().getDocumentURI() no longer returns null for loading a String of HTML

2017-04-26 Thread Arunprasad Rajkumar
Hi Kevin, Guru, Please review the following fix, JIRA: https://bugs.openjdk.java.net/browse/JDK-8179321 Webrev: http://cr.openjdk.java.net/~arajkumar/8179321/webrev/ Thanks, Arun

[webkit] [10] 8178319: Build sqlite3 from source

2017-04-12 Thread Arunprasad Rajkumar
Hello Kevin, Please review the fix for JDK-8178319 . http://cr.openjdk.java.net/~arajkumar/8178319/webrev Thanks, Arun

Re: CFV: New OpenJFX Committer: Ramesh Gangadhar

2017-01-18 Thread Arunprasad Rajkumar
Vote: YES > On 19-Jan-2017, at 3:23 AM, Kevin Rushforth > wrote: > > I hereby nominate Ramesh Gangadhar [1] to OpenJFX Committer. > > Ramesh is a member of JavaFX SQE team at Oracle working on test development > for the Java packager, who has contributed 20

[webkit] [9] Review request for 8165909: JavaScript to Java String conversion is not correct

2017-01-02 Thread Arunprasad Rajkumar
Hello Kevin, Guru, Murali, Please review the fix for JDK-8165909 . http://cr.openjdk.java.net/~arajkumar/8165909/webrev Analysis is updated in JBS. Thanks, Arun

[webkit] [9] Review request for 8136847: DRT test fast/canvas/canvas-fillRect-shadow.html fails

2016-12-23 Thread Arunprasad Rajkumar
Hello Kevin, Guru, Murali, Please review the fix for JDK-8136847 . http://cr.openjdk.java.net/~arajkumar/8136847/webrev Analysis is updated in JBS. Thanks, Arun

[webkit] [9] Review request for 8132675: VBox.setVgrow and HBox.setHgrow corrupt following controls when window resized

2016-12-20 Thread Arunprasad Rajkumar
Hello Kevin, Guru, Murali, Please review the fix for JDK-8132675 . http://cr.openjdk.java.net/~arajkumar/8132675/webrev Thanks,

[webkit] [9] Review request for 8168887: [WebView] ComboBox and DropDownList - Render fragments of the scrollbar are visible

2016-12-20 Thread Arunprasad Rajkumar
Hello Kevin, Guru, Murali, Please review the fix for JDK-8168887 . http://cr.openjdk.java.net/~arajkumar/8168887/webrev Thanks, Arun

[webkit] [9] Review request for 8170450: Crash while loading wordpress.com in HiDPI / Retina display

2016-11-30 Thread Arunprasad Rajkumar
Hello Kevin, Guru, Murali, Please review the fix for JDK-8170450 . Analysis: While applying a filter, WebCore get's ImageData from ImageDataJava using getPremultipliedImageData method. Our current implementation doesn't considers

Re: [webkit] [9] Review request for 8088205: [Mac] WebView renders icons instead of letters on some sites

2016-11-07 Thread Arunprasad Rajkumar
Hello Kevin, Phil, I have incorporated review comments, Please take a look. http://cr.openjdk.java.net/~arajkumar/8088205/webrev.01/ <http://cr.openjdk.java.net/~arajkumar/8088205/webrev.01/> Thanks, Arun > On 04-Oct-2016, at 12:15 AM, Arunprasad Rajkumar > <arunprasad.rajk

[webkit] [9] Review request for 8088205: [Mac] WebView renders icons instead of letters on some sites

2016-10-03 Thread Arunprasad Rajkumar
Hello Kevin, Phil, Guru Please review the following fix. JIRA: https://bugs.openjdk.java.net/browse/JDK-8088205 Webrev: http://cr.openjdk.java.net/~arajkumar/8088205/webrev.00 Analysis: Some Web Fonts(like Thin.ttf, refer the attachment) doesn’t have valid entry in the TTF Naming Table. Due

[webkit] [9] Review request for 8164495: [WebView] Backout changeset 653ce34aafba

2016-08-19 Thread Arunprasad Rajkumar
Hello Kevin, Guru, Murali, Please review the simple fix to revert the unintentional change. JIRA: https://bugs.openjdk.java.net/browse/JDK-8164495 Webrev: http://cr.openjdk.java.net/~arajkumar/8164495/webrev.00/ Regards, Arun

[webkit] [9] Review request for 8164314: [WebView] Debug build is no longer working in OSX

2016-08-18 Thread Arunprasad Rajkumar
Hello Kevin, Guru, Murali, Please review the simple debug build fix for OSX. JIRA: https://bugs.openjdk.java.net/browse/JDK-8164314 Webrev: http://cr.openjdk.java.net/~arajkumar/8164314/webrev.00

[webkit] [9] Review request for 8162949: [WebView] WebView can't display social network icons on wellsfargo.com

2016-08-04 Thread Arunprasad Rajkumar
Hello Kevin, Guru, Murali, Please review the following fix. JIRA: https://bugs.openjdk.java.net/browse/JDK-8162949 Webrev: http://cr.openjdk.java.net/~arajkumar/8162949/webrev.00 Regards, Arun

[webkit] [9] Review request for 8162715: Add regression test for JDK-8161258

2016-07-30 Thread Arunprasad Rajkumar
Hello Kevin, Guru, Murali, Please review the following fix. JIRA: https://bugs.openjdk.java.net/browse/JDK-8162715 Webrev: http://cr.openjdk.java.net/~arajkumar/8162715/webrev.00 Regards, Arun

Re: CFV: New OpenJFX Committer: Andrey Rusakov

2016-07-24 Thread Arunprasad Rajkumar
Vote: YES On 7/23/2016 8:12 PM, Kevin Rushforth wrote: I hereby nominate Andrey Rusakov [1] to OpenJFX Committer. Andrey is a member of JavaFX SQE team at Oracle working on test development, who has contributed 19 changesets [5] to OpenJFX, at least 8 of which are significant. Votes are

[webkit] [9] Review request for 8160769: [WebView] Unable to tile SVG image using css background property

2016-07-13 Thread Arunprasad Rajkumar
Hello Guru, Alexander Z, Murali, Please review the following fix. JIRA: https://bugs.openjdk.java.net/browse/JDK-8160769 Webrev: http://cr.openjdk.java.net/~arajkumar/8160769/webrev.00 Issue: Unable to tile SVG image using css background property Analysis: For tiled SVG image drawing,

[webkit] [9] Review request for 8161258: [Win] Timer functionality is broken after JDK-8089563

2016-07-13 Thread Arunprasad Rajkumar
Hello Guru, Murali, Please review the following fix. JIRA: https://bugs.openjdk.java.net/browse/JDK-8161258 Webrev: http://cr.openjdk.java.net/~arajkumar/8161258/webrev.00 Issue: Timer functionality is broken after JDK-8161258 in Windows. Analysis: Our monotonically increasing time

[webkit] [9] Review request for 8160260: WebView cannot render CSS background image with SVG data

2016-07-04 Thread Arunprasad Rajkumar
Hello Alexander Z, Chien, Guru Please review the following fix. JIRA: https://bugs.openjdk.java.net/browse/JDK-8160260 Webrev: http://cr.openjdk.java.net/~arajkumar/8160260/webrev.00 Issue: SVG images are not shown when rendering initiated in the context of or CSS background property.

  1   2   >