Re: Default PointLight for Scene

2017-05-23 Thread Chien Yang
No, this light is created internally within JavaFX as a convenient light source if the scene doesn't have one. User can't access to it reference. You can find this information in the Scene class documentation: Class Scene ... A default headlight will be added to a scene that contains one or

[10] Code Review Request For 8178837: Potential performance drawback due to type mismatch

2017-04-19 Thread Chien Yang
Hi Kevin, Please review the proposed fix. JIRA: https://bugs.openjdk.java.net/browse/JDK-8178837 Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8178837/webrev.00/ Thanks, - Chien

[9] Code Review Request For 8178804: Excessive memory consumption in TriangleMesh/MeshView

2017-04-19 Thread Chien Yang
Hi Kevin, Please review the proposed fix. JIRA: https://bugs.openjdk.java.net/browse/JDK-8178804 Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8178804/webrev.00/ Thanks, - Chien

Re: JavaFX graphics performance

2017-04-18 Thread Chien Yang
CPU usage. I hope the bug fix will also be backported to Java 8. Michael Am 12.04.17 um 22:19 schrieb Chien Yang: BTW, it is a bug that we are unaware of if you are seeing a 60X nominal memory consumption in your program. Please file a JIRA with a test program and we will investigate it. Thanks

Re: JavaFX graphics performance

2017-04-12 Thread Chien Yang
BTW, it is a bug that we are unaware of if you are seeing a 60X nominal memory consumption in your program. Please file a JIRA with a test program and we will investigate it. Thanks, - Chien On 4/10/2017 1:08 PM, Kevin Rushforth wrote: We are planning some performance improvements in JDK

[9] Code Review Request 8163385: Fix doclint errors and warnings in javafx.controls module

2017-03-09 Thread Chien Yang
Hi Jonathan and Kevin, Please review the proposed fix. JIRA: https://bugs.openjdk.java.net/browse/JDK-8163385 Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8163385/webrev.00/ Thanks, - Chien

Re: [9] Code Review Request For 8163384: Fix doclint errors and warnings in javafx.graphics module

2017-03-01 Thread Chien Yang
@code } or {@literal. -- Jon On 02/28/2017 03:00 PM, Chien Yang wrote: Hi all, Please review the proposed fix. JIRA: https://bugs.openjdk.java.net/browse/JDK-8163384 Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8163384/webrev.00/ Thanks, - Chien

[9] Code Review Request For 8163384: Fix doclint errors and warnings in javafx.graphics module

2017-02-28 Thread Chien Yang
Hi all, Please review the proposed fix. JIRA: https://bugs.openjdk.java.net/browse/JDK-8163384 Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8163384/webrev.00/ Thanks, - Chien

[9] Code Review Request For 8173796: Overriden method, requestLayout(), by subclass of Parent didn't get call when process layout

2017-02-07 Thread Chien Yang
Hi Kevin and Jonathan, Please review the proposed fix. JIRA: https://bugs.openjdk.java.net/browse/JDK-8173796 Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8173796/webrev.00/ Thanks, - Chien

Code Review Request 8172364: Ensemble8 Canvas Fireworks jitters while animating

2017-02-01 Thread Chien Yang
Hi Kevin, Please review the proposed fix. JIRA: https://bugs.openjdk.java.net/browse/JDK-8172364 Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8172364/webrev.00/ Thanks, - Chien

[9] Code Review Request For 8171852: JavaFX Stage flickers on resize on Windows platforms

2017-01-06 Thread Chien Yang
Hi Kevin, Please review the proposed fix: JIRA: https://bugs.openjdk.java.net/browse/JDK-8171852 Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8171852/webrev.00/ Thanks, - Chien

8170624: [Mac] HostServices.showDocument() throws IllegalAccessException

2016-12-15 Thread Chien Yang
Hi Kevin, Please review the proposed fix. JIRA: https://bugs.openjdk.java.net/browse/JDK-8170624 Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8170624/webrev.00/ Thanks, - Chien

[9] Code Review Request For 8170500: Interminate ProgressIndicator no longer animates if scene is set on stage before content is added

2016-12-14 Thread Chien Yang
Hi Jonathan, Please review the proposed fix and investigation in the JIRA. JIRA: https://bugs.openjdk.java.net/browse/JDK-8170500 Thanks, - Chien

[9] Code Review Request For 8170421: Ensemble8 black flash at startup on b145+

2016-11-28 Thread Chien Yang
Jim or Kevin, Please review this simple fix posted in the JIRA: https://bugs.openjdk.java.net/browse/JDK-8170421 Thanks, - Chien

[9] Code Review Request For 8166932: Fix @Deprecated annotations for deprecated JavaFX methods

2016-11-17 Thread Chien Yang
Hi Jim and Kevin, Please review the proposed fix: JIRA: https://bugs.openjdk.java.net/browse/JDK-8166932 Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8166932/webrev.00/ Thanks, - Chien

Re: [9] Code Review Request For 8088179: [Quantum] White flashing when opening a stage with dark background

2016-11-10 Thread Chien Yang
Yes, we decide to punt on ImagePattern as there isn't a trivial way to find a reasonable background color for it. - Chien On 11/10/16, 10:22 AM, Jim Graham wrote: I guess we'll punt on ImagePattern? Other than that the fix looks fine... ...jim On 11/9/16 5:35 PM, Chien Yang

Re: [9] Code Review Request For 8088179: [Quantum] White flashing when opening a stage with dark background

2016-11-10 Thread Chien Yang
with StageStyle.TRANSPARENT? What happens if i set the Scene.fill to an rgba value? Doesn't this lead to a different color than what you get today where the background stage background is always white? Tom Von meinem iPhone gesendet Am 10.11.2016 um 02:35 schrieb Chien Yang<chie

[9] Code Review Request For 8088179: [Quantum] White flashing when opening a stage with dark background

2016-11-09 Thread Chien Yang
Hi Jim and Kevin, Please review the proposed fix: JIRA: https://bugs.openjdk.java.net/browse/JDK-8088179 Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8088179/webrev.00/ Thanks, - Chien

[9] Code Review Request For 8168616: -Xcheck:jni indicates there are missing exception checks in Font

2016-10-31 Thread Chien Yang
Hi Phil, Please review the proposed fix. JIRA: https://bugs.openjdk.java.net/browse/JDK-8168616 Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8168616/webrev.00/ Thanks, - Chien

[8u] Code Review Request For 8168821: Cleanup whitespace after fix for JDK-8156078

2016-10-26 Thread Chien Yang
Hi Kevin, Please review this one line cleanup fix (diff in the JIRA): JIRA: https://bugs.openjdk.java.net/browse/JDK-8168821 Thanks, - Chien

[9] Code Review Request For 8166470: -Xcheck:jni indicates there are missing exception checks in Glass

2016-10-24 Thread Chien Yang
Hi Kevin, Please the proposed fix: JIRA: https://bugs.openjdk.java.net/browse/JDK-8166470 Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8166470/webrev.00/ Thanks, - Chien

[9] Code Review Request For 8130675:Document that setting scene on stage changes stage size unless explicitly set

2016-08-15 Thread Chien Yang
Hi Kevin, Please review this proposed doc fix: JIRA:https://bugs.openjdk.java.net/browse/JDK-8130675 Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8130675/webrev.00/ Thanks, - Chien

Re: Memory leaks on Linux with hardware renderer

2016-08-11 Thread Chien Yang
Based on my recollection, this oddity (2 contexts) is because we use CALayer on Mac. We have tested in early prototype, when we did the switch from JOGL to native GL, Prism implementation on Linux works fine with a single GL context. - Chien On 8/11/2016 2:08 PM, Jim Graham wrote: It looks

[9] Code Review Request For 8163383: Fix doclint errors and warnings in javafx.base module

2016-08-09 Thread Chien Yang
Hi Kevin, Please review this proposed fix: JIRA: https://bugs.openjdk.java.net/browse/JDK-8163383 Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8163383/webrev.00/ Thanks, - Chien

Re: [8udev (backport)] Code Review Request For 8163302: Stage alwaysOnTop property not reset to false if permission is denied

2016-08-05 Thread Chien Yang
should have the Bug ID of the main bug: 8156078 Thanks. -- Kevin Chien Yang wrote: Hi Kevin, Please review the proposed backport: JIRA: https://bugs.openjdk.java.net/browse/JDK-8163302 Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8163302/webrev.00/ Thanks, - Chien

[8udev (backport)] Code Review Request For 8156078: Stage alwaysOnTop property not reset to false if permission is denied

2016-08-05 Thread Chien Yang
Hi Kevin, Please review the proposed backport: JIRA: https://bugs.openjdk.java.net/browse/JDK-8156078 Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8156078/backport.00/ Thanks, - Chien

[8udev (backport)] Code Review Request For 8163302: Stage alwaysOnTop property not reset to false if permission is denied

2016-08-05 Thread Chien Yang
Hi Kevin, Please review the proposed backport: JIRA: https://bugs.openjdk.java.net/browse/JDK-8163302 Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8163302/webrev.00/ Thanks, - Chien

Code Review Request For 8156078: Stage alwaysOnTop property not reset to false if permission is denied

2016-08-02 Thread Chien Yang
Hi Kevin, Please review the proposed fix: JIRA: https://bugs.openjdk.java.net/browse/JDK-8156078 Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8156078/webrev.00/ Thanks, - Chien

Code Review Request For 8162883: ESC button fails to cancel Dialog

2016-08-01 Thread Chien Yang
Hi Jonathan and Kevin, Please review the proposed fix: JIRA: https://bugs.openjdk.java.net/browse/JDK-8162883 Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8162883/webrev.00/ Thanks, - Chien

[9] Code Review Request For 8154148: JavaFX crashes on startup when run on Mac in VMWare

2016-07-28 Thread Chien Yang
Hi Kevin and Dave, Please review the proposed fix: JIRA: https://bugs.openjdk.java.net/browse/JDK-8154148 Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8154148/webrev.00/ Thanks, - Chien

Re: CFV: New OpenJFX Committer: Ankit Srivastava

2016-07-25 Thread Chien Yang
Vote: YES On 7/19/16 6:37 AM, David Hill wrote: I hereby nominate Ankit Srivastava to OpenJFX Committer. Ankit Srivastava is part of the JavaFX team focusing on Web. A list of Ankit's commits and reviews is available by the following links

[9] Code Review Request For 8148721: Memory leak caused by scroll gesture

2016-07-16 Thread Chien Yang
Hi Jonathan, Please review the proposed fix: JIRA: https://bugs.openjdk.java.net/browse/JDK-8148721 Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8148721/webrev.00/ Thanks, - Chien

Re: ProgressIndicator indeterminate transition bugs

2016-07-13 Thread Chien Yang
indicator issues are all done as talked, GREAT! Are they planned to be included in Java 8? Cheers, Diego -Original Message- From: Chien Yang [mailto:chien.y...@oracle.com] Sent: Dienstag, 8. März 2016 20:41 To: Cirujano Cuesta, Diego<diego.cirujano-cue...@zeiss.com>; jonat

[9] Code Review Request For 8088846: PopupWindow does not disappear when associated Control is not visible.

2016-07-08 Thread Chien Yang
Hi Dave and Jonathan, Please review the proposed fix. JIRA: https://bugs.openjdk.java.net/browse/JDK-8088846 Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8088846/webrev.00/ Thanks, - Chien

[9] Code Review Request For 8090322: Need new tree visible property in Node that consider Scene and Stage visibility

2016-07-05 Thread Chien Yang
Hi Jonathan, Please review the proposed fix: JIRA: https://bugs.openjdk.java.net/browse/JDK-8090322 Thanks, - Chien

[9] Code Review Request For 8158006: Improve javadoc for abstract classes that application should not directly extend

2016-06-23 Thread Chien Yang
Hi Kevin, Please review the proposed fix: JIRA: https://bugs.openjdk.java.net/browse/JDK-8158006 Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8158006/webrev.00/ Thanks, - Chien

[9] Review Request For 8158948: SceneBuilder needs public access to CSS styling support from JavaFX that is no longer available

2016-06-23 Thread Chien Yang
Hi Kevin, Please review this proposed fix as we have discussed earlier. Webrev: https://bugs.openjdk.java.net/browse/JDK-8158948 Thanks, - Chien

[9] Code Review Request For 8159005: SceneBuilder needs public access to FXMLLoader setStaticLoad support from JavaFX that is no longer available

2016-06-23 Thread Chien Yang
Hi Kevin, Please review this proposed fix as we have discussed earlier. Webrev: https://bugs.openjdk.java.net/browse/JDK-8159005 Thanks, - Chien

[9] Code Review Request For 8158004: Node, Shape and Shape3D need meaningful runtime exception message when application directly extends these classes

2016-06-22 Thread Chien Yang
Hi Kevin, Please review the proposed fix: JIRA: https://bugs.openjdk.java.net/browse/JDK-8158004 Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8158004/webrev.00/ Thanks, - Chien

[9] Code Review Request For 8157500: Create unit tests for new public methods in GridPane

2016-06-17 Thread Chien Yang
Hi Kevin, Please review the proposed unit test: JIRA: https://bugs.openjdk.java.net/browse/JDK-8157500 Webev: http://cr.openjdk.java.net/~ckyang/JDK-8157500/webrev.00/ Thanks, - Chien

[9] Code Review Request For 8159383: Mouse hover on Webview scroll bar leads to NPE in ScrollBarThemeImpl.hitTest

2016-06-15 Thread Chien Yang
Hi Kevin, Please review the simple bug fix as we have investigated: https://bugs.openjdk.java.net/browse/JDK-8159383 Thanks, - Chien

[9] Code Review Request For 8159021: Redo layout bounds tests in GroupTest

2016-06-07 Thread Chien Yang
Kevin and Vadim, Please review this simple fix: JIRA: https://bugs.openjdk.java.net/browse/JDK-8159021 Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8159021/webrev.00/ Thanks, - Chien

[9] Code Review For 8144585: Encapsulate JavaFX impl_* implementation methods

2016-06-03 Thread Chien Yang
Hi all, Please review the proposed fix: JIRA: https://bugs.openjdk.java.net/browse/JDK-8144585 Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8144585/webrev.00/ Thanks, - Chien

[9] Code Review Request For 8158659: Encapsulate impl_ methods in Node and its subclasses

2016-06-03 Thread Chien Yang
Hi all, Please review the proposed fix: JIRA: https://bugs.openjdk.java.net/browse/JDK-8158659 Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8158659/webrev.00/ Thanks, - Chien

[9] Code Review Request For 8157900: Encapsulate JavaFX impl_* implementation methods in Node (peer and dirty)

2016-05-26 Thread Chien Yang
Hi Kevin, Jonathon and Vadim, Please review the proposed fix: JIRA: https://bugs.openjdk.java.net/browse/JDK-8157900 Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8157900/webrev.00/ PS: This is a huge webrev and touches many components. I believe most component owners would want to do a

[9] Code Review Request For 8091874: Need API in GridPane to get row count, column count, and cell bounds

2016-05-20 Thread Chien Yang
Hi Kevin, Please review the suggested fix: JIRA: https://bugs.openjdk.java.net/browse/JDK-8091874 Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8091874/webrev.00/ Thanks, - Chien

[9] Code Review Request For 8157350: Encapsulate impl_ methods in Shapes related classes

2016-05-20 Thread Chien Yang
Hi Kevin, Please review the proposed fix as we have discussed. JIRA: https://bugs.openjdk.java.net/browse/JDK-8157350 Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8157350/webrev.00/ Thanks, - Chien

[9] Code Review Request For 8157295: Encapsulate impl_ methods in Scene and KeyValue classes

2016-05-18 Thread Chien Yang
Hi Jonathan and Kevin, Please review the proposed fix: Webrev: https://bugs.openjdk.java.net/browse/JDK-8157295 JIRA: http://cr.openjdk.java.net/~ckyang/JDK-8157295/webrev.00/ Thanks, - Chien

[9] Code Review Request For 8155998: Encapsulate JavaFX impl_* implementation methods in stage package

2016-05-15 Thread Chien Yang
Hi Jonathan and Kevin, Please review the proposed fix: JIRA: https://bugs.openjdk.java.net/browse/JDK-8155998 Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8155998/webrev.00/ Thanks, - Chien

Re: [9] Code Review Request For 8155762: Encapsulate JavaFX impl_* implementation methods in transform package

2016-05-07 Thread Chien Yang
ibly mentioning the intent in the javadoc... ...jim On 5/3/2016 11:24 PM, Chien Yang wrote: Kevin and Jim, Please review the proposed fix: Webrev: https://bugs.openjdk.java.net/browse/JDK-8155762 JIRA: http://cr.openjdk.java.net/~ckyang/JDK-8155762/webrev.00/ Thanks, - Chien

[9] Code Review Request For 8156170: Clean up Stage and StageHelper

2016-05-06 Thread Chien Yang
Hi Kevin and Jonathan, Please review the proposed fix: JIRA: https://bugs.openjdk.java.net/browse/JDK-8156170 Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8156170/webrev.00/ - Chien

[9] Code Review Request For 8155762: Encapsulate JavaFX impl_* implementation methods in transform package

2016-05-04 Thread Chien Yang
Kevin and Jim, Please review the proposed fix: Webrev: https://bugs.openjdk.java.net/browse/JDK-8155762 JIRA: http://cr.openjdk.java.net/~ckyang/JDK-8155762/webrev.00/ Thanks, - Chien

Re: Code Review Request For 8155757: Encapsulate impl_ methods in animation, canvas, image, input, layout, paint, and text packages

2016-05-02 Thread Chien Yang
ava/lang/Object."":()V 9: return public void bar(); Code: 0: aload_0 1: getfield #1 // Field this$0:LInnerPackageTest; 4: invokevirtual #3 // Method InnerPackageTest.foo:()V 7: return } ...ji

Code Review Request For 8155757: Encapsulate impl_ methods in animation, canvas, image, input, layout, paint, and text packages

2016-04-29 Thread Chien Yang
Hi Kevin, Please review the proposed fix: JIRA: https://bugs.openjdk.java.net/browse/JDK-8155757 Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8155757/webrev.00/ Thanks, - Chien

[9] Code Review Request For 8155053: Encapsulate impl_ methods in Effect and on the setting of TraversalEngine

2016-04-26 Thread Chien Yang
Hi Kevin, Please review the purposed fix. JIRA: https://bugs.openjdk.java.net/browse/JDK-8155053 Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8155053/webrev.00/ Thanks, - Chien

Re: Jvm crash: es2 pipeline crashs jvm on macosx vm

2016-04-18 Thread Chien Yang
Hi Ali, Context management is tightly couple between Glass and Prism. The fix will likely touches both places. - Chien On 4/16/16, 11:05 AM, Ali Ebrahimi wrote: Hi, On Sat, Apr 16, 2016 at 10:11 PM, Chien Yang <chien.y...@oracle.com <mailto:chien.y...@oracle.com>> wrote:

Re: Jvm crash: es2 pipeline crashs jvm on macosx vm

2016-04-16 Thread Chien Yang
works for javafx8. On Fri, Apr 15, 2016 at 2:07 AM, Chien Yang <chien.y...@oracle.com <mailto:chien.y...@oracle.com>> wrote: Thanks reporting your finding and suggestion. Do you mind filing a bug report? Please include the steps and your system configuration that we m

[9] Code Review Request: 8144556: Add support to allow user specified rendering order

2016-03-31 Thread Chien Yang
Please review the proposed specification and implementation. JIRA: https://bugs.openjdk.java.net/browse/JDK-8144556 Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8144556/webrev.00/ - Chien

Re: JavaFX Application Heat up MacBook Pro

2016-03-28 Thread Chien Yang
, Chien Yang wrote: You are correct. MBP 13 only has an integrated GPU and those 2 fixes mentioned earlier don't apply to your case. - Chien On 3/25/16, 3:15 PM, Tai Hu wrote: I have a MacBook Pro 13 inch (2014 model). If I remembered correctly, it only has an integrated GPU

Re: JavaFX Application Heat up MacBook Pro

2016-03-28 Thread Chien Yang
You are correct. MBP 13 only has an integrated GPU and those 2 fixes mentioned earlier don't apply to your case. - Chien On 3/25/16, 3:15 PM, Tai Hu wrote: I have a MacBook Pro 13 inch (2014 model). If I remembered correctly, it only has an integrated GPU. There is no discreet GPU Thanks,

Re: ProgressIndicator indeterminate transition bugs

2016-03-08 Thread Chien Yang
You may track the progress of this work with this JIRA for now. We are still investigating the scope and impact of this work. We may decide to create a new JIRA and resolve this as a duplicate if we decide to go with a better naming. https://bugs.openjdk.java.net/browse/JDK-8090322 - Chien

Re: GLS language errors (Was: Internal error: Error loading stock shader FillRoundRect_LinearGradient,_PAD on Vivante ARM)

2016-03-02 Thread Chien Yang
Hi Maurice, Can you please file a JIRA on this issue? Thanks, - Chien On 3/1/16, 11:45 PM, Maurice wrote: Jim, A solution in line of that of Johan Vos [1] works. JavaFX can be run and doesn't crash on startup when compiling the shaders. I think they should be taken into account for at

Re: GLS language errors (Was: Internal error: Error loading stock shader FillRoundRect_LinearGradient,_PAD on Vivante ARM)

2016-02-29 Thread Chien Yang
on the Wiki <https://wiki.openjdk.java.net/display/OpenJFX/Cross+Building+for+ARM+Hard+Float>. Maurice. Op 29-02-16 om 17:49 schreef Chien Yang: I have a quick question. Did you get your embedded JavaFX library from Glueon? http://gluonhq.com/open-source/javafxports/downloads/ - Chien

Re: GLS language errors (Was: Internal error: Error loading stock shader FillRoundRect_LinearGradient,_PAD on Vivante ARM)

2016-02-29 Thread Chien Yang
I have a quick question. Did you get your embedded JavaFX library from Glueon? http://gluonhq.com/open-source/javafxports/downloads/ - Chien On 2/29/16, 7:21 AM, Maurice wrote: Should I file a bug? I can't determine whether this is a client platform issue or a major bug in the EGL that

Code Review Request For 8137252: JavaFX StackPane bounds not updated

2016-02-16 Thread Chien Yang
Hi Kevin and Jonathan, Please review the proposed fix and the detail of the fix is recorded in the JIRA: JIRA: https://bugs.openjdk.java.net/browse/JDK-8137252 Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8137252/webrev.00/ Thanks, - Chien

Re: Canvas Clip performance

2016-02-05 Thread Chien Yang
It will be great if you can include in your bug report the following 2 piece of information: 1) Run your program with -Dprism.verbose=true. This will give us the graphics hardware information of your system. 2) Run your program with -Dprism.order=sw. This will force JavaFX to use its

Re: Canvas Clip performance

2016-02-05 Thread Chien Yang
e than one rectangular shape. Every rectangular shape beyond the first seems to reduce my FPS by 10. I'm using JDK 1.80_60 by the way. On Fri, Feb 5, 2016 at 6:38 PM, Chien Yang <chien.y...@oracle.com <mailto:chien.y...@oracle.com>> wrote: It will be great if you can include in

Code Review Request For JDK-8140306: Add regression test for JDK-8136495

2016-01-29 Thread Chien Yang
Hi Kevin, Please review the proposed robot test: http://cr.openjdk.java.net/~ckyang/JDK-8140306/webrev.00/ I have verified that it works well on Mac, Linux and Windows. Thanks, - Chien

Code Review Request For JDK-8147010: Update JavaFX for move of sun.misc.PerformanceLogger to sun.awt.util

2016-01-27 Thread Chien Yang
Hi Kevin, Please review the proposed fix: JIRA: https://bugs.openjdk.java.net/browse/JDK-8147010 Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8147010/webrev.00/ Thanks, - Chien

Code Review Request For JDK-8090185: Ubuntu: switching to fullscreen from primary stage in browser displays grey screen

2016-01-13 Thread Chien Yang
Hi Kevin, Please review the proposed fix as we have investigated yesterday: The fix is to check and handle correctly when there is change in the underlaying nativeWindow. This is the case happened on Linux when we do fullscreen in Applet mode. Passed dev-build-lite run on Linux and Mac.

Re: Huge JavaFX performance drop in Debian Jessie

2015-12-22 Thread Chien Yang
Hi Chris, JavaFX may run on Intel GMA 3150, but it is not a supported GPU. There is a high likelihood that the drop in performance is caused by the switch from sw pipe (Debian Wheezy) to es2 pipe (Debian Jessie). GMA 3150 is an underpowered GPU for JavaFX's es2 pipe. You can try forcing

Re: CFV: New OpenJFX Committer: Johan Vos

2015-12-21 Thread Chien Yang
Vote: YES On 12/21/2015 11:45 AM, David Hill wrote: I hereby nominate Johan Vos to OpenJFX Committer. Johan Vos (jvos) has been active in the OpenJFX community, and instrumental in the maturity of Monocle, the owner of the Android and IOS ports and is an OpenJFX Author. A list of Johan's

Re: [Review request] 8145143: Promote Image.impl_getUrl() to public API as Image.getUrl()

2015-12-10 Thread Chien Yang
The patch looks good to me as it is. Question: Will the change to Optional makes it at odd with the existing public constructors? Or API cleanliness though I do see the beauty of using Optional here. - Chien On 12/10/15, 2:16 PM, David Grieve wrote: I believe the url might be used in the CSS

Code Review Request For JDK-8091170: Compile-time warnings in prism-es2 code

2015-12-08 Thread Chien Yang
Hi Kevin, Please review the proposed fix which was moved from JDK-8090866 as per our conversation: JIRA: https://bugs.openjdk.java.net/browse/JDK-8091170 Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8091170/webrev.00/ Thanks, - Chien

Code Review Request For JDK-8090866: Mac GL APIs do not need to be looked up

2015-12-07 Thread Chien Yang
Hi Kevin, Please review the proposed fix. JIRA: https://bugs.openjdk.java.net/browse/JDK-8090866 webrev: http://cr.openjdk.java.net/~ckyang/JDK-8090866/webrev.00/ Thanks, - Chien

Code Review Request For JDK-8144542: Remove an experimental stopgap fix (-Dprism.experimental.skipMeshNormalComputation) that is no longer needed

2015-12-02 Thread Chien Yang
Hi Kevin, Please review the proposed fix. JIRA: https://bugs.openjdk.java.net/browse/JDK-8144542 Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8144542/webrev.00/ Thanks, - Chien

Re: [9] Review request for 8140503: JavaFX "Pair" Hash Code Collisions

2015-11-03 Thread Chien Yang
> The key in Pair could actually be null and in this case hashCode will throw NPE. This might be a good enough reason to have this fix. - Chien On 11/3/15, 12:07 PM, Vadim Pakhnushev wrote: Hmm, yeah, the actual difference is in the prime number only (that is changing the algorithm only

Re: Feature request: DirectX Support for Java3D / JavaFX on Windows & "Take care that OpenGL1 and OpenGL2 are supported by Java3D / JavaFX in a way, that OpenGL1-only computers are not excluded from a

2015-10-20 Thread Chien Yang
And by default Java 3D uses D3D on Windows too. - Chien On 10/20/15, 6:12 AM, Tom Schindl wrote: Hi, I've to admit that I could not follow you completely but JavaFX on Windows is based on DirectX (OpenGL is only provided for Linux/OS-X where it is the defacto standard and far from dead). Tom

Re: pisces, produceFillAlphas

2015-10-15 Thread Chien Yang
Hi Johan, This optimization is buggy but to see whether it helps you can try setting -Dprism.scrollcacheopt=true Please see JDK-8093860 for reason why it was disabled: https://bugs.openjdk.java.net/browse/JDK-8093860 - Chien On 10/15/15, 12:30 PM, Johan Vos wrote: Thanks Jim. I tried with

JDK-8137004: Memory leak caused by Parent#removed not being freed

2015-09-27 Thread Chien Yang
Hi Vadim, Can you please review the proposed fix? JIRA: https://bugs.openjdk.java.net/browse/JDK-8137004 Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8137004/webrev.00/ Thanks, - Chien

Code Review Request For JDK-8136495: On es2 pipe, SceneAntialiasing.BALANCED flips scene affecting Mac and Linux platforms

2015-09-14 Thread Chien Yang
Hi Jim and Kevin, Please review the proposed fix: JIRA: https://bugs.openjdk.java.net/browse/JDK-8136495 Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8136495/webrev.00/ Thanks, - Chien

Re: Bug: SceneAntialiasing.BALANCED flips the scene on Mac

2015-09-14 Thread Chien Yang
in the future, you do so here: http://bugs.java.com/ Thanks. -- Kevin José Pereda wrote: Hi Chien I'm not allow to do it, so I was going to ask... Please go ahead. Thank you, Jose On Mon, Sep 14, 2015 at 9:58 PM, Chien Yang <chien.y...@oracle.com <mailto:chien.y...@oracle.com>> wrote:

Re: Bug: SceneAntialiasing.BALANCED flips the scene on Mac

2015-09-14 Thread Chien Yang
Hi Jose, Thanks for the heads-up! I'm able to reproduce the bug on my Macbook Pro (retina display). I will file a JIRA on this if you haven't done it yet. Thanks, - Chien On 9/12/15, 7:34 AM, Kevin Rushforth wrote: > I haven't found any report of this at http://bugs.openjdk.java.net. Then

Code Review Request For JDK-8088670: Remove use of internal classes methods from toys

2015-08-26 Thread Chien Yang
Hi Dave, Jonathan and Kevin, Please review the proposed fix mentioned in the JIRA: JIRA: https://bugs.openjdk.java.net/browse/JDK-8088670 Thanks, - Chien

Code Review Request For JDK-8087624: BoxBounds.is2D() method needs to take into account of its Z dimension in it return value

2015-07-27 Thread Chien Yang
Hi Kevin, Please review the proposed as described in the bug report: JBS: https://bugs.openjdk.java.net/browse/JDK-8087624 Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8087624/webrev.00/ Thanks, - Chien

Re: Status of 3D blending when diffuse component has alpha

2015-07-09 Thread Chien Yang
In 8u60, we made 3D Node to use the same default blendMode property setting of Node; i.e. SRC_OVER: https://docs.oracle.com/javase/8/javafx/api/javafx/scene/Node.html#blendModeProperty This default blend mode should address most of the transparency rendering requested in [1] and [2]. Our

[8u60] Code Review Request For JDK-8130122: Horizontal ListView incorrectly displays long data

2015-06-30 Thread Chien Yang
Hi Kevin, Please review this proposed fix for a late-breaking regression found during this week's sanity testing: JBS: https://bugs.openjdk.java.net/browse/JDK-8130122 Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8130122/webrev.01/ Thanks, - Chien

Code Review Request For RT-38179: [TabPane] TableView in TabPane has memory leak

2015-06-05 Thread Chien Yang
Hi Kevin, Please the proposed fix with unit test included: JIRA: https://javafx-jira.kenai.com/browse/RT-38179 Webrev: http://cr.openjdk.java.net/~ckyang/RT-38179/webrev.00/ Thanks, - Chien

Code Review Request For RT-38370: [3D] PNT mesh only: Internally computed tangent vectors need to recomputed if its assocated texCoords or points have changed

2015-05-12 Thread Chien Yang
Hi Kevin, Please review the proposed fix: JIRA: https://javafx-jira.kenai.com/browse/RT-38370 Webrev: http://cr.openjdk.java.net/~ckyang/RT-38370/webrev.00/ Thanks, - Chien

Code Review Request For RT-39418: [Mac,Retina,3D] Lighting is wrong (too dark, incorrect highlight) with pixel scaling

2015-05-06 Thread Chien Yang
Hi Kevin and Jim, Please review the proposed fix, and detail information is in the JIRA: JIRA: https://javafx-jira.kenai.com/browse/RT-39418 Webrev: http://cr.openjdk.java.net/~ckyang/RT-39418/webrev.00/ - Chien

Code Review For RT-39755: ScrollPane introduces distortions when scrolling up down

2015-05-04 Thread Chien Yang
Hi Kevin, Please review the proposed fix: JIRA: https://javafx-jira.kenai.com/browse/RT-39755 Webrev: http://cr.openjdk.java.net/~ckyang/RT-39755/webrev.00/ - Chien

Code Review Request For RT-39856: Layout Regression - bad row height

2015-04-28 Thread Chien Yang
Hi Kevin, Please review the proposed fix. JIRA: https://javafx-jira.kenai.com/browse/RT-39856 Thanks, - Chien

Code Review Request For RT-40004: [3D] Texture transparency is ignored in 8u40

2015-04-21 Thread Chien Yang
Hi Kevin, Please review the proposed fix. JiRA: https://javafx-jira.kenai.com/browse/RT-40004 Webrev: http://cr.openjdk.java.net/~ckyang/RT-40004/webrev.00/ Thanks, - Chien

Code Review Request For RT-37862: [ScenePulseListener] NPE in synchronizeSceneProperties

2015-03-19 Thread Chien Yang
Hi Kevin, Please review the proposed fix. JIRA: https://javafx-jira.kenai.com/browse/RT-37862 Thanks, - Chien

Code Review Request For RT-40245: Regression: Mac (prism-sw) rendering is corrupted

2015-03-17 Thread Chien Yang
Hi Kevin and Jim, Please review the proposed fix: JIRA: https://javafx-jira.kenai.com/browse/RT-40245 Webrev: http://cr.openjdk.java.net/~ckyang/RT-40245/webrev.00/ Thanks, - Chien

Code Review Request For RT-40099: GridPane percentage layout bug since JavaFx 8u40

2015-03-03 Thread Chien Yang
Hi Kevin, Please review the proposed fix. Detail information is in the JIRA: https://javafx-jira.kenai.com/browse/RT-40099 Thanks, - Chien

Re: Using JavaFX on VMWare / Linux

2015-02-26 Thread Chien Yang
Hi Adam, I would like to inform you that VMware is not a certified hypervisor for Oracle JDK 8 and JRE 8, and hardware rendering is not supported in guest systems on Oracle VM, VirtualBox and Hyper-V Server 2012. Please see this link for details information:

Re: Directional light in JavaFX 3D

2015-02-06 Thread Chien Yang
Hi Herve, A JIRA for directional light has already been filed but there is no immediate plan to add this feature at the moment. Currently JavaFX 3D only supports point light and ambient light. - Chien On 2/6/15 3:10 PM, Herve Girod wrote: Hello, Are there plans to implement an API

Re: Directional light in JavaFX 3D

2015-02-06 Thread Chien Yang
Sorry, I forgot to paste the JIRA link before hitting the send button. https://javafx-jira.kenai.com/browse/RT-33899 - Chien On 2/6/15 3:16 PM, Chien Yang wrote: Hi Herve, A JIRA for directional light has already been filed but there is no immediate plan to add this feature at the moment

Code Review Request For RT-39921: With two or more application modal windows; windows deeper in the stack are receiving requestToFront when not enabled causes an NSBeep.

2015-02-04 Thread Chien Yang
Hi Kevin, Please review this straightforward fix: JIRA: https://javafx-jira.kenai.com/browse/RT-39921 webrev: http://cr.openjdk.java.net/~ckyang/RT-39921/webrev.00/ Thanks, - Chien

  1   2   >