[10] Review request: 8187059 Update VS Projects

2017-08-31 Thread Chris Bensen
Victor, Please review this change to upgrade the native projects to the latest version of VS 2017: JIRA: https://bugs.openjdk.java.net/browse/JDK-8187059 Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8187059/webrev.00/ Chris

[10] Review request: 8186237 Refactor jdk.packager to legacy package

2017-08-16 Thread Chris Bensen
Victor, Please review this refactor to get ready for the new CLI. JIRA: https://bugs.openjdk.java.net/browse/JDK-8186237 Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8186237/webrev.00/ Chris

[10] Review request: 8184769 Static Link to SHGetKnownFolderPath

2017-07-17 Thread Chris Bensen
Victor, Please review this change to remove the LoadLibray. JIRA: https://bugs.openjdk.java.net/browse/JDK-8184769 Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8184769/webrev.00/ Chris

[10] Review request: 8183246 Remove Platform::GetSystemJRE()

2017-07-07 Thread Chris Bensen
Victor, Please review this change to remove the dead code related to acquiring the system JRE for a packaged app. JIRA: https://bugs.openjdk.java.net/browse/JDK-8183246 Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8183246/webrev.00/ Chris

[10] Review request: 8091418 Evaluate TODOs in code, either removing or filing issues as appropriate

2017-06-30 Thread Chris Bensen
Victor, Please review these changes related to the TODOs and FIXMEs in the java packager code. JIRA: https://bugs.openjdk.java.net/browse/JDK-8091418 Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8091418/webrev.00/ Chris

[10] Review request: 8182778 Debug JDK Additions

2017-06-26 Thread Chris Bensen
Kevin, Victor, Please review these additions to the Java Packager debug JDK. This change will bundle the jdk.packager.services module with the resulting application and cleans up the gradle sourceSet. JIRA: https://bugs.openjdk.java.net/browse/JDK-8182778 Webrev:

[10] Review request: JDK-8181738 Remove com.sun.tools.jdeps to jdk.packager

2017-06-15 Thread Chris Bensen
Kevin, Victor, Please review this change following JDK-8179445 to remove the qualified exports of com.sun.tools.jdeps: JIRA: https://bugs.openjdk.java.net/browse/JDK-JDK-8181738 Webrev:

[9] Review request: 8179363 Errors in Redistributable Module List

2017-04-26 Thread Chris Bensen
Kevin, Victor, Please review this change to fix the redistributable file list. JIRA: https://bugs.openjdk.java.net/browse/JDK-8179363 Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8179363/webrev.00/ Chris

Re: javapackager - partially self-contained apps in JDK 9

2017-04-25 Thread Chris Bensen
gt; I really wonder why this case is not handled in some convenient way. > > > > >> On Apr 25, 2017, at 11:32 AM, Chris Bensen <chris.ben...@oracle.com> wrote: >> >> >>> On Apr 11, 2017, at 10:43 AM, Alan Snyder <javali...@cbfiddle.com> wrote: >&g

Re: javapackager - partially self-contained apps in JDK 9

2017-04-25 Thread Chris Bensen
> On Apr 11, 2017, at 10:43 AM, Alan Snyder wrote: > > I have run into a problem in moving my macOS apps from JDK 8 to 9. The issue > relates to using MySQL via JDBC. > The connector class name is fixed. The class is loaded using Class.forName(). > However, there can

[10] Review request: 8176825 Unwanted comment in jdk.packager.services/src/main/java/module-info.java

2017-04-11 Thread Chris Bensen
Victor, Please review this minor change to remove and unwanted comment. JIRA: https://bugs.openjdk.java.net/browse/JDK-8176825 Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8176825/webrev.00/ Chris

[9] Review request: 8178413 Mark All Exported Java Packager APIs as Deprecated

2017-04-11 Thread Chris Bensen
Kevin, Victor, and Mandy, Please review this change to deprecate all the existing non documented Java Packager API for JDK 9 and provide a new API for JDK 10. JIRA: https://bugs.openjdk.java.net/browse/JDK-8178413 Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8178413/webrev.02/ Chris

[9] Review request: 8177451 javapackager -help prints help message of java -help

2017-03-24 Thread Chris Bensen
Kevin, Please review this fix to the javapackager.exe launcher. My last change, I thought I had tested it thoroughly but I made a mistake where I put one of the quotes but I also noticed some other problems. So it’s now launching as a modular application as well. This time I’ve carefully

[9] Review request: 8176582 javapackager.exe doesn't work from c:\program files

2017-03-14 Thread Chris Bensen
Kevin, Victor, Please review this change to add quotes around path strings. JIRA: https://bugs.openjdk.java.net/browse/JDK-8176582 Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8176582/webrev.01/ Chris

[9] Review request: 8150511 LSMinimumSystemVersion set incorrectly

2017-02-23 Thread Chris Bensen
Victor, Please review this change to the minimum supported system version. JIRA: https://bugs.openjdk.java.net/browse/JDK-8150511 Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8150511/webrev.00/ Chris

[8] Review request: 8174842 Uninitialized variable in PosixPlatform.cpp

2017-02-17 Thread Chris Bensen
Kevin, Please review backport request: JIRA: https://bugs.openjdk.java.net/browse/JDK-8174842 Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8174842/webrev.03/ Chris

Re: [8] Review request: 8173139 Packager update App Store runtime rules for libjfxwebkit.dylib

2017-02-15 Thread Chris Bensen
K-8174806/webrev.00/> Chris > On Feb 15, 2017, at 9:46 AM, Chris Bensen <chris.ben...@oracle.com> wrote: > > Kevin, > > Please review this change to no longer strip libjfxwebkit.dylib after 8u152 > from a packaged app. > > JIRA: https://bugs.open

[8] Review request: 8173139 Packager update App Store runtime rules for libjfxwebkit.dylib

2017-02-15 Thread Chris Bensen
Kevin, Please review this change to no longer strip libjfxwebkit.dylib after 8u152 from a packaged app. JIRA: https://bugs.openjdk.java.net/browse/8173139 Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8173139/webrev.00/ Chris

[9] Review request: JDK-8174842 Uninitialized variable in PosixPlatform.cpp

2017-02-13 Thread Chris Bensen
Victor, Please review the fix for initializing the uninitialized variable. JIRA: https://bugs.openjdk.java.net/browse/JDK-8174842 Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8174842/webrev.00/

[9] Review request:

2017-02-08 Thread Chris Bensen
Kevin, Victor: Updating the redistributable module list, changing the name to legacy/jre.list and adding support for comments in the jre.list file. JIRA: https://bugs.openjdk.java.net/browse/JDK-8174131 Webrev:

Re: [9] Review request: JDK-8147781: Javapackager installer needs to cleanup temporary folders

2017-02-06 Thread Chris Bensen
That’s a good point Stefan. I hadn’t noticed the -verbose. Chris > On Feb 6, 2017, at 4:31 PM, Stefan Fuchs wrote: > > Hi, > > are you sure that there is a bug? > > The verbose paramter is explicitly documented to leave temporary files > around, as a starting point for

[9] Review request: 8173774 Update script and icon

2017-02-01 Thread Chris Bensen
Victor, Please review these minor changes to the AppStore version number and icons for submitting to the Mac AppStore. JIRA: https://bugs.openjdk.java.net/browse/JDK-8173774 Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8173774/webrev.02/

[9] Review request: 8173661 Fix ALL-MODULE-PATH

2017-02-01 Thread Chris Bensen
Victor, Please review this change to the addModules. ALL-MODULE-PATH now works with this change but it is subtle and we need to make sure it doesn’t break anything. JIRA: https://bugs.openjdk.java.net/browse/JDK-8173661 Webrev:

[9] Review request: 8173407 New Ensemble AppStore icon

2017-01-26 Thread Chris Bensen
Victor, Please review this very minor change. Rename of the Ensemble illustrator file, along with an updated version that the AppStore should be happy with, and the new PNG. JIRA: https://bugs.openjdk.java.net/browse/JDK-8173407 Webrev:

[9] Review request: 8173225 codesign fails on symlinks

2017-01-23 Thread Chris Bensen
Victor, Please review these changes to submit apps to the Mac App store. JIRA: https://bugs.openjdk.java.net/browse/JDK-8173225 Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8173225/webrev.01/

[9] Review request:

2017-01-20 Thread Chris Bensen
Victor, Please review this change to provide a warning with suggested work arounds when packaging on Windows 10 with Windows Defender enabled. JIRA: https://bugs.openjdk.java.net/browse/JDK-8172444 Webrev:

[9] Review request: 8171811 References to ant-javafx.jar

2017-01-19 Thread Chris Bensen
Victor, Please review these string changes to remove ant-javafx.jar from the error messages where they shouldn’t be. JIRA: https://bugs.openjdk.java.net/browse/JDK-8171811 Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8171811/webrev.00/

Re: CFV: New OpenJFX Committer: Ramesh Gangadhar

2017-01-18 Thread Chris Bensen
Correct: Vote: YES > On Jan 18, 2017, at 2:10 PM, Chris Bensen <chris.ben...@oracle.com> wrote: > > Not: YES > > >> On Jan 18, 2017, at 1:53 PM, Kevin Rushforth <kevin.rushfo...@oracle.com> >> wrote: >> >> I hereby nominate Rames

Re: CFV: New OpenJFX Committer: Ramesh Gangadhar

2017-01-18 Thread Chris Bensen
Not: YES > On Jan 18, 2017, at 1:53 PM, Kevin Rushforth > wrote: > > I hereby nominate Ramesh Gangadhar [1] to OpenJFX Committer. > > Ramesh is a member of JavaFX SQE team at Oracle working on test development > for the Java packager, who has contributed 20

[9] Review request: 8172985 Executable files in repo after JDK-8172925

2017-01-18 Thread Chris Bensen
Kevin, Please review my fixing my mistake. JIRA: https://bugs.openjdk.java.net/browse/JDK-8172985 Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8172985/webrev.00/ Chris

[9] Review request: 8172925 Mac App Store

2017-01-17 Thread Chris Bensen
Victor, Please review the first pass at the Mac App Store changes. JIRA: https://bugs.openjdk.java.net/browse/JDK-8172925 Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8172925/webrev.00/

[9] Review request: 8171979 Missing/Renamed Modules in Redistributable list

2017-01-11 Thread Chris Bensen
Victor, Please review this change to the redistributable module list. JIRA: https://bugs.openjdk.java.net/browse/JDK-8171979 Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8171979/webrev.00/ Thanks, Chris

Result: New OpenJFX Committer: Victor Drozdov

2017-01-04 Thread Chris Bensen
Voting for Victor Drozdov [1] to OpenJFX Committer [2] is now closed. Yes: 7 Veto: 0 Abstain: 0 According to the Bylaws definition of Lazy Consensus, this is sufficient to approve the nomination. Chris [1] http://openjdk.java.net/census#vdrozdov [2]

[9] Review request: JDK-8168306 Iconswap program used by the packager is flagged as malware by Windows Defender

2016-12-21 Thread Chris Bensen
Kevin, Victor, Please review this change to do away with the tools iconswap.exe and versioninfoswap.exe by folding them into javapackager.exe to avoid the problems of these being copied as a resource out of the Java Packager into executing from the temporary directory. JIRA:

[9] Review request: JDK-8171352 javapackager throws "Exception: jdk.tools.jlink.plugin.PluginException: java.lang.IllegalArgumentException: No modules to add" when bundled with NormalJar

2016-12-16 Thread Chris Bensen
Kevin, Please review this minor change to build.gradle as a follow on to JDK-8170198. The location of the redistributable.list was incorrect and my testing didn’t catch it. JIRA: https://bugs.openjdk.java.net/browse/JDK-8171352 Webrev:

[9] Review request: JDK-8170198 Static Redistributable Module List

2016-12-14 Thread Chris Bensen
Kevin, Please review this change to no longer generate the Java Packager’s redistributable module list instead use a static list since the programmatically generated list uses the boot JDK’s list of modules and that can vary between builds. JIRA:

Re: CFV: New OpenJFX Committer: Victor Drozdov

2016-12-14 Thread Chris Bensen
Vote: yes > On Dec 13, 2016, at 4:21 PM, Chris Bensen <chris.ben...@oracle.com> wrote: > > I hereby nominate Victor Drozdov [1] to OpenJFX Committer. > > Victor is a member of Java Deployment team at Oracle working on the Java > Packager tool, who has contributed 11 c

Re: [9] Review request: JDK-8169443 Deprecate Java Packager Blob Signing

2016-12-13 Thread Chris Bensen
The “new” was introduced for some reason in JDK 1.8 documentation but this has been there since JDK 1.0 documentation which I can’t find but it’s also there since JDK 2.0 [1]. The deployment guide will be updated. Chris [1]

CFV: New OpenJFX Committer: Victor Drozdov

2016-12-13 Thread Chris Bensen
I hereby nominate Victor Drozdov [1] to OpenJFX Committer. Victor is a member of Java Deployment team at Oracle working on the Java Packager tool, who has contributed 11 changesets [5] to OpenJFX, at least 8 of which are significant. Votes are due by January 4, 2017. Only current OpenJFX

Re: [9] Review request: JDK-8169443 Deprecate Java Packager Blob Signing

2016-12-13 Thread Chris Bensen
Hi Stefan, Yes, it is being deprecated. It will continue to function as it has. Two main reasons for the deprecation are: 1. Self signed jars are blocked and sign as blob is a self signed jars. 2. There will be a replacement for modules that will be better. Chris > On Dec 12, 2016, at 11:56

[9] Review request: JDK-8169443 Deprecate Java Packager Blob Signing

2016-12-12 Thread Chris Bensen
David, Please review these changes to deprecate the blob signing from the Java Packager. JIRA: https://bugs.openjdk.java.net/browse/JDK-8169443 Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8169443/webrev.00/

[9] Review request: JDK-8170883 Add Class Path to Examples

2016-12-08 Thread Chris Bensen
Kevin, Victor, Please review changes to the Java Packager examples and a new example mixing modular jars and non modular jars. JIRA: https://bugs.openjdk.java.net/browse/JDK-8170883 Webrev:

[9] Review request: JDK-8168407 javapackager throws "java.lang.ClassNotFoundException: testapp.util.Util" when bundle is built through ANT for unnamed module depending on named module scenario

2016-12-08 Thread Chris Bensen
Kevin, Please review this change to allow a non modular jar main app to use and bundle modular jars into the runtime image. JIRA: https://bugs.openjdk.java.net/browse/JDK-8168407 Webrev:

[9] Review request: JDK-8170609: Show Error When Mac AppStore Certificate Expired

2016-12-01 Thread Chris Bensen
Victor, Please review the changes to show an error when the MacApp Store certificate has expired. JIRA: https://bugs.openjdk.java.net/browse/JDK-8170609 Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8170609/webrev.00/ Chris

[9] Review request: JDK-8170295 fx:jvmarg is not set

2016-11-28 Thread Chris Bensen
Victor, Please review this change to fix setting of jvmarg options: JIRA: https://bugs.openjdk.java.net/browse/JDK-8170295 Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8170295/webrev.00/ Chris

[9] Review request: JDK-8170122 Packager Tests

2016-11-28 Thread Chris Bensen
Victor, Please review these Java Packager examples: JIRA: https://bugs.openjdk.java.net/browse/JDK-8170122 Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8170122/webrev.01/ Chris

[9] Review request: 8170122: Packager Tests

2016-11-22 Thread Chris Bensen
Kevin, Adding Java Packager examples/tests. JIRA: https://bugs.openjdk.java.net/browse/JDK-8170122 Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8170122/webrev.00/ Chris

[9] Review request: JDK-8167508 ant-javafx.jar and jdk.packager runtime version check

2016-11-16 Thread Chris Bensen
Kevin, Please review this change to have ant-javafx.jar check the version of Java that is running it and match the version it was intended to run with by comparing against a version string that is stored in the jar file. JIRA: https://bugs.openjdk.java.net/browse/JDK-8167508 Webrev:

Re: [9] Review request: DK-8169417: JavaFX to include jake-compatible versions of module-info.java with import bundles

2016-11-08 Thread Chris Bensen
+1 I did a quick test on Mac and it worked for me. Chris > On Nov 8, 2016, at 4:11 PM, Kevin Rushforth > wrote: > > Hi, > > Please review the following fix to include jake-compatible versions of > module-info.java with our input bundles: > >

Re: javapacker's iconswap flagged as malware

2016-10-18 Thread Chris Bensen
Hi Scott, I’m not actively running Windows 10 and last time I did run the Java Packager under Windows 10 it worked just fine so this is new behavior within I’d say the last 6 months. Feel free to file a bug, but I’m not sure there’s anything that can be done from the JDK side. Thanks, Chris

[9] Review request: JDK-8167973 Absolute path for module-path is not working when trying to execute javapackager from other drive in CLI

2016-10-18 Thread Chris Bensen
Kevin, Please review this change to fix the path separate for Windows. JIRA: https://bugs.openjdk.java.net/browse/JDK-8167973 Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8167973/webrev.00/ Chris

[9] Review request: JDK-8167496 Packager Cleanup

2016-10-11 Thread Chris Bensen
Kevin, Just some cleanup. JIRA: https://bugs.openjdk.java.net/browse/JDK-8167496 Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8167496/webrev.00/ Chris

[9] Review request: JDK-8166661 Remove "-outfile" as compulsary when bundling modules in javapackager

2016-10-07 Thread Chris Bensen
Kevin, Please review the following change to remove the required argument -outfile. JIRA: https://bugs.openjdk.java.net/browse/JDK-811 Webrev: http://cr.openjdk.java.net/~cbensen/JDK-811/webrev.00/ Chris

Re: [9] Review Request: 8165414 javapackager throws NullPointerException in Windows Operating System for CLI

2016-10-06 Thread Chris Bensen
Kevin, did you see this one too? Chris > On Oct 5, 2016, at 8:11 AM, Chris Bensen <chris.ben...@oracle.com> wrote: > > Kevin, > > This resolves the NullPointerExceptions when packaging on Windows. > > JIRA: https://bugs.openjdk.java.net/browse/JDK-8165414 >

[9] Review Request: 8166881 .cfg Configuration file contains hard coded values of path

2016-10-05 Thread Chris Bensen
Kevin, Fix so the config file entry of the jar file is not a hard coded path. JIRA: https://bugs.openjdk.java.net/browse/JDK-8166881 Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8166881/webrev.00/

[9] Review Request: 8165414 javapackager throws NullPointerException in Windows Operating System for CLI

2016-10-05 Thread Chris Bensen
Kevin, This resolves the NullPointerExceptions when packaging on Windows. JIRA: https://bugs.openjdk.java.net/browse/JDK-8165414 Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8165414/webrev.00/

[9] Review Request:

2016-09-16 Thread Chris Bensen
Kevin, Add modules and limit modules are broken in some situations. JIRA: https://bugs.openjdk.java.net/browse/JDK-8166172 Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8166172/webrev.00/

[9] Review Request: 8165059 Many jdk.packager properties files are missing from javafxsdk.tbom

2016-09-13 Thread Chris Bensen
Kevin, Files for translation. JIRA: https://bugs.openjdk.java.net/browse/JDK-8165059 Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8165059/webrev.00/ Chris

[9] Review Request: 8165882 Java Packager Cleanup

2016-09-13 Thread Chris Bensen
Kevin, Just some minor cleanup. JIRA: https://bugs.openjdk.java.net/browse/JDK-8165882 Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8165882/webrev.00/ Chris

[9] Review Request: 8165548 javapackager -help shows --modulepath not --module-path

2016-09-06 Thread Chris Bensen
Kevin, Please review this simple string change. JIRA: https://bugs.openjdk.java.net/browse/JDK-8165548 Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8165548/webrev.00/ Chris

[9] Review Request:

2016-09-01 Thread Chris Bensen
Kevin, Please review this change to fix the .properties files. JIRA: https://bugs.openjdk.java.net/browse/JDK-8165057 Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8165057/webrev.00/ Chris

[9] Review Request: 8163076 javapackager bundling fails due to issue in JAVA-API

2016-08-31 Thread Chris Bensen
Kevin, Please review this change to fix invoking the Java Packager through the Java Packager API. JIRA: https://bugs.openjdk.java.net/browse/JDK-8163076 Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8163076/webrev.00/ Chris

[9] Review Request: 8164248 [packager] New Modular Arguments to be made public for Packager API

2016-08-25 Thread Chris Bensen
Kevin, Please review the change to make all the modular arguments part of the Java Packager public API. JIRA: https://bugs.openjdk.java.net/browse/JDK-8164248 Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8164248/webrev.00/ Thanks, Chris

[9] Review Request: 8155956 Java Packager runtime argument

2016-08-24 Thread Chris Bensen
Kevin, Please review change for Java Packager runtime argument and a few other minor changes. Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8155956/webrev.00/ JIRA: https://bugs.openjdk.java.net/browse/JDK-8155956 Chris

Re: CFV: New OpenJFX Committer: Andrey Rusakov

2016-07-25 Thread Chris Bensen
Vote: yes Chris > On Jul 23, 2016, at 7:42 AM, Kevin Rushforth > wrote: > > I hereby nominate Andrey Rusakov [1] to OpenJFX Committer. > > Andrey is a member of JavaFX SQE team at Oracle working on test development, > who has contributed 19 changesets [5] to

[9] Review Request: 8149975: [packager] Programmatically Determine JDK or JRE Modules

2016-07-05 Thread Chris Bensen
Hi David, Please review this change for the Java Packager to programmatically get a list of the modules that are to be redistributable. This was waiting on https://bugs.openjdk.java.net/browse/JDK-8155955 and

Review Request: 8146582 Ant Support for modular arguments

2016-06-22 Thread Chris Bensen
Hi Kevin, This change adds Ant support for the modular arguments and changes the CLI arguments to match the new proposed GNU-style arguments. JIRA: https://bugs.openjdk.java.net/browse/JDK-8146582 Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8146582/webrev.00/ Thanks, Chris

Review Request: 8154895 Revisit javapackager module path related options

2016-06-07 Thread Chris Bensen
Hi Kevin, This change aligns the CLI of the Java Packager with the rest of the Java toolchain (-modulepath, -addmods, -limitmods and -m). Developers can continue to use the old style -srcfiles, -appClass and -BmainJar= CLI arguments to bundle non-modular applications. JIRA:

Request Review: [9]: [packager] Refactor Java Packager

2016-04-27 Thread Chris Bensen
Kevin, Please review this refactoring change. This is the FX side of JDK-8150990 where the parts of the jdk.packager module that depend on jlink are refactored and moved to the jdk.jlink module. review: http://cr.openjdk.java.net/~cbensen/JDK-8154898/webrev.02/

Re: [9]: : [packager] Module Path Packager Arguments

2016-04-12 Thread Chris Bensen
New webrev: http://cr.openjdk.java.net/~cbensen/JDK-8150991/webrev.03/ <http://cr.openjdk.java.net/~cbensen/JDK-8150991/webrev.03/> Chris > On Apr 11, 2016, at 4:17 PM, Chris Bensen <chris.ben...@oracle.com> wrote: > > Kevin, > > Please review. This adds ne

[9]: : [packager] Module Path Packager Arguments

2016-04-11 Thread Chris Bensen
Kevin, Please review. This adds new argument to Java Packager, the Minesweeper FX Appstore App and cleans a lot of things up. My Packager sandbox will be in sync with 9dev except for refactoring changes. https://bugs.openjdk.java.net/browse/JDK-8150991

[Jake Review]: [packager] Module Path Packager Arguments

2016-04-06 Thread Chris Bensen
Kevin, Please review. This adds new argument to Java Packager and cleans a lot of things up. My Packager sandbox will be in sync except for refactoring changes. https://bugs.openjdk.java.net/browse/JDK-8150991

Jake Review: [packager] Fix packager for jlink API changes

2016-04-05 Thread Chris Bensen
Kevin, Fixes for the Java Packager. https://bugs.openjdk.java.net/browse/JDK-8153529 http://cr.openjdk.java.net/~cbensen/JDK-8153529/webrev.00/ Chris

Re: Request Review: 8150991 [packager] Module Path Packager Arguments

2016-03-04 Thread Chris Bensen
Wrong comment. What I meant to say is “small packager change to add new arguments for the module path”. Chris > On Mar 3, 2016, at 10:22 AM, Chris Bensen <chris.ben...@oracle.com> wrote: > > Hi Kevin, > > Small packager change to pass module path to to the call to JD

Request Review: 8150991 [packager] Module Path Packager Arguments

2016-03-03 Thread Chris Bensen
Hi Kevin, Small packager change to pass module path to to the call to JDEPS. JIRA: https://bugs.openjdk.java.net/browse/JDK-8150991 Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8150991/webrev.00/

Request Review: 8148654 [packager] Add support for module path when calling jdeps

2016-03-01 Thread Chris Bensen
Hi Kevin, Small packager change to pass module path to to the call to JDEPS. JIRA: https://bugs.openjdk.java.net/browse/JDK-8148654 Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8148654/webrev.00/ Thanks, Chris

Review Request: 8148978 [packager] bootmodules.jimage was renamed to modules

2016-02-23 Thread Chris Bensen
Hi David, Please review this change to take into account the recent change to JLINK to rename bootmodules.jimage to modules. There’s a bit more in this change as well to just get the packager CLI working in general. JIRA: https://bugs.openjdk.java.net/browse/JDK-8148978

Review Request: 8150294 [packager] Netbeans Packager Project

2016-02-19 Thread Chris Bensen
Hi Kevin, Please review this change to add a Netbeans project for the Java Packager jdk.packager module: JIRA: https://bugs.openjdk.java.net/browse/JDK-8150294 Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8150294/webrev.00

Review Request: 8149966 [packager] JLINK API changes

2016-02-18 Thread Chris Bensen
Hi Kevin, Please review this fix for the changes to the JLINK API that the packager uses: JIRA: https://bugs.openjdk.java.net/browse/JDK-8149966 Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8149966/webrev.00/ Thanks, Chris

Re: javapackager

2016-02-04 Thread Chris Bensen
> On Feb 3, 2016, at 1:08 PM, Scott Palmer <swpal...@gmail.com> wrote: > > >> On Feb 3, 2016, at 11:40 AM, Chris Bensen <chris.ben...@oracle.com> wrote: >> >> On Feb 2, 2016, at 7:27 PM, Scott Palmer <swpal...@gmail.com> wrote: >>&

Re: javapackager

2016-02-04 Thread Chris Bensen
ed (uses shared libs), for GNU/Linux 2.6.15, > BuildID[sha1]=0x7e6522a86eca91b45cfb4dfa5defbddac0b1294a, not stripped > > > So the 64-bit launcher is bundled. > > > > > > Can you file a minimum test case along with the Linux system used so we can > > prior

Re: javapackager

2016-02-03 Thread Chris Bensen
er executable? I think it’d be: $ file myserver-1.0-1.x86_64/app/myserver Can you file a minimum test case along with the Linux system used so we can prioritize with other bugs and find a solution? Chris > Scott > > >> On Feb 2, 2016, at 7:03 PM, Chris Bensen <chris.ben...@o

Re: javapackager

2016-02-02 Thread Chris Bensen
This list or the Deployment blog (https://blogs.oracle.com/talkingjavadeployment/) are the best places to get help with the javapackager. Is your app built with the 64-bit or 32-bit packager? I noticed “x86_64” appended to the name. If it’s 32-bit you could try running: sudo apt-get install

Re: [9] 8147492: [packager] javapackager.exe support for unicode

2016-01-22 Thread Chris Bensen
Kevin, Just realized I forgot to add your email address to this. Thanks, Chris > On Jan 21, 2016, at 8:47 AM, Chris Bensen <chris.ben...@oracle.com> wrote: > > Kevin, > > Please review the following fix > > https://bugs.openjdk.java.net/browse/JDK-8147492 &

[9] 8147492: [packager] javapackager.exe support for unicode

2016-01-21 Thread Chris Bensen
Kevin, Please review the following fix https://bugs.openjdk.java.net/browse/JDK-8147492 http://cr.openjdk.java.net/~cbensen/JDK-8147492/webrev.00/ Thanks, Chris

[9] Review request for 8146169: Javapackager displays version as 8.0 instead of 9.0 for JDK9

2016-01-15 Thread Chris Bensen
Kevin, Please review the following fix https://bugs.openjdk.java.net/browse/JDK-8146169 http://cr.openjdk.java.net/~cbensen/JDK-8146169/webrev.00/ Thanks, Chris

Re: [8u-dev] Review request: 8143314: Runtime not respected with INI-configuration while creating native bundle

2015-11-19 Thread Chris Bensen
+1, but then again, I’m not Danno > On Nov 19, 2015, at 6:14 AM, Dmitry Cherepanov > wrote: > > Chris, Danno, > > Please review the following fix: > > https://bugs.openjdk.java.net/browse/JDK-8143314 > http://cr.openjdk.java.net/~dcherepanov/8143314/webrev.0/ >

Re: Java 8 updates are causing "Apps that use non-public APIs will be rejected"

2015-11-17 Thread Chris Bensen
There have been cases where Apple received the updated delivery and didn’t test the updated bits or sent the old rejection letter for some reason. I’m not exactly sure what it took and I’m not 100% sure this is the case but it required Apple to examine the new upload. I have an app that I’m

Re: Java 8 updates are causing "Apps that use non-public APIs will be rejected"

2015-11-17 Thread Chris Bensen
The change is only for the Mac App Store. You can easily look at the changeset associated with JDK-8138650 to verify this: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/761213753af4 This is the relevant code change: +++

Re: Followup on our Splash Screen discussion at JavaOne (using AWT-SplashScreen)

2015-11-11 Thread Chris Bensen
Hi Tom, Yes, I remember our conversation. Danno’s right, there’s an open bug. I thought it was resolved at some point. Each Operating System acts differently making it a tough problem. I’ll add it to my (very long) todo list and get to it as soon as I can. Thanks, Chris > On Nov 11, 2015,

Re: [sandbox-9-jake] Review Request 8080531 - fix ant-javafx ant tasks

2015-10-19 Thread Chris Bensen
+1 Chris > On Oct 19, 2015, at 1:02 PM, Danno Ferrin wrote: > > Kevin, Chris, Dmitry > Because of the way resources are being handled in current revs of Jake we > need to pull the main ant task classes back into ant-javafx and not deploy > them into the main

Re: [9-sandbox-jake] Request for Approval - 8080531 - Modular Java Application Packaging

2015-10-13 Thread Chris Bensen
+1 > On Oct 12, 2015, at 11:50 AM, Danno Ferrin wrote: > > Kevin, Chris, > > This is a Work in Progress to be put in the jake sandbox for JEP-275 work. > Mostly so we can get it out in the open before JavaOne at the end of the > month. > > This patch breaks the

Re: Mac App Store Refusal because of QTKit API's

2015-09-30 Thread Chris Bensen
from its *own* internal copy of webkit which in turn has a >>>>>> copy of ICU. >>>>>> >>>>>> What is very odd is that Apple is essentially then objecting to >>>>>> referencing >>>>>> functions that are internal to

Re: Mac App Store Refusal because of QTKit API's

2015-09-30 Thread Chris Bensen
Hi Scott, Those APIs are for the text system ICU. I believe the App Store team may be in error. Perhaps they accidentally copied the wrong forbidden APIs when writing the message. Thanks, Chris > On Sep 29, 2015, at 3:15 AM, Scott Selvia wrote: > > I’m using JDK 8 update

Re: Review Request: RT-39975 - AppCDS support for packager

2015-03-31 Thread Chris Bensen
Correct! On Mar 31, 2015, at 4:41 AM, Mike Hearn m...@plan99.net wrote: The bug is restricted - intentional? I'm guessing this is class data sharing and would make startup of packaged apps faster? On Tue, Mar 31, 2015 at 12:52 AM, Chris Bensen chris.ben...@oracle.com wrote: +1

Re: Review Request: RT-39975 - AppCDS support for packager

2015-03-31 Thread Chris Bensen
Java apps are running on the same JRE simultaneously. I guess that won't apply to packaged apps so the only benefit can be startup time. On Tue, Mar 31, 2015 at 3:59 PM, Chris Bensen chris.ben...@oracle.com wrote: Correct! On Mar 31, 2015, at 4:41 AM, Mike Hearn m...@plan99.net wrote

Re: Review Request: RT-39975 - AppCDS support for packager

2015-03-30 Thread Chris Bensen
+1 On Mar 30, 2015, at 3:11 PM, Danno Ferrin danno.fer...@oracle.com wrote: Kevin, Chris, please review jira: https://javafx-jira.kenai.com/browse/RT-39975 webrev: http://cr.openjdk.java.net/~shemnon/RT-39975/webrev.00/

Re: [8u40] review request: RT-39182: Enable building 32-bit Linux on 64-bit systems

2014-11-24 Thread Chris Bensen
+1 On Nov 22, 2014, at 5:29 PM, Kevin Rushforth kevin.rushfo...@oracle.com wrote: Dave, Kirill, Anton, Chris, Please review the following build changes to enable building 32-bit graphics, media, webkit, and packager binaries on a 64-bit Linux system.

Review for RT-39137

2014-11-12 Thread Chris Bensen
Danno, Please review this patch. More info in the JIRA Webrev: http://cr.openjdk.java.net/~cbensen/RT-39137/webrev.00/ JIRA: https://javafx-jira.kenai.com/browse/RT-39137

Re: Review for RT-38968

2014-10-13 Thread Chris Bensen
From what I’ve seen, jvmuserarg.0 never exists. It is 1 based. If you are however changing it to 0 based then this line is fine: -TString prefix = TString(_T(jvmuserarg.)) + PlatformString(index).toString(); +TString prefix = TString(_T(jvmuserarg.)) + PlatformString(index +

  1   2   >