Re: RFR: 8204568: Relative CSS-Attributes don't work all time [v5]

2021-03-08 Thread David Grieve
On Mon, 8 Mar 2021 07:49:23 GMT, Ambarish Rapte wrote: >> Issue is that the size of properties that are relatively(`em`) sized is not >> computed correctly when the reference `-fx-font-size` is also specified >> relatively and is nested. >> >> Fix is a slight variation of an earlier

Re: RFR: 8204568: Relative CSS-Attributes don't work all time

2021-02-08 Thread David Grieve
On Mon, 8 Feb 2021 11:37:35 GMT, Ambarish Rapte wrote: > Issue is that the size of properties that are relatively(`em`) sized is not > computed correctly when the reference `-fx-font-size` is also specified > relatively and is nested. > > Fix is a slight variation of an earlier suggestion in

RE: [EXTERNAL] Re: JDK-8177635: Optimise CSS lookup resolution

2021-01-29 Thread David Grieve
> > > On 1/29/2021 7:02 AM, David Grieve wrote: > > Anyone mind if I take a crack at 8177635: Optimise CSS lookup resolution? > >

JDK-8177635: Optimise CSS lookup resolution

2021-01-29 Thread David Grieve
Anyone mind if I take a crack at 8177635: Optimise CSS lookup resolution?

RE: CFV: New OpenJFX Committer: Jose Pereda

2020-06-02 Thread David Grieve
Vote: YES

RE: CFV: New OpenJFX Committer: Jeanette Winzenburg

2020-06-02 Thread David Grieve
Vote: YES

Re: Community request to test 3D performance

2020-04-27 Thread David Grieve
Results with NVIDIA Quadro P400: Without the fix, 1000 quads, average FPS ~7.4 With the fix, 1000 quads, average FPS ~6.1 (this is with Kevin’s pointlighttest.zip) From: Nir Lisker Sent: Thursday, April 23, 2020 5:41 PM To: David Grieve ; openjfx-dev@openjdk.java.net Mailing Subject

Re: [Rev 03] RFR: 8217472: Add attenuation for PointLight

2020-04-27 Thread David Grieve
On Sat, 25 Apr 2020 17:07:21 GMT, Kevin Rushforth wrote: >> @kevinrushforth >> Member >> kevinrushforth commented Apr 18, 2020 >> >> I think most of those are good suggestions going forward. As for the >> performance drop, the only place we've seen it so >> far is on graphics accelerators that

Re: Community request to test 3D performance

2020-04-24 Thread David Grieve
est is relatively simple, so it should be worth it. Thanks. > > On Fri, Apr 24, 2020 at 12:04 AM David Grieve > > wrote: > >> I have an NVIDIA Quadro P400. Will that help? >> >> -Original Message- >> From: openjfx-dev On Behalf Of >> Nir

Re: White box / window flicker upon launch

2020-04-23 Thread David Grieve
It doesn't reproduce for me on windows with JavaFX 11.0.2. Whether this is a bug and/or a regression I cannot say. -Original Message- From: Dirk Lemmermann Sent: Thursday, April 23, 2020 10:20 AM To: David Grieve Cc: OpenJFX Subject: [EXTERNAL] Re: White box / window flicker upon

RE: White box / window flicker upon launch

2020-04-23 Thread David Grieve
Another possible workaround is to call Node#applyCss() before stage.show(). There is an example in the Javadoc for the applyCss() method. -Original Message- From: openjfx-dev On Behalf Of Dirk Lemmermann Sent: Wednesday, April 22, 2020 1:46 PM To: OpenJFX Subject: [EXTERNAL] White box

RE: JavaFX controls have large size on Raspberry Pi

2020-04-20 Thread David Grieve
The sizes of controls are controlled by CSS styles. Things like borders, backgrounds, padding, insets, all of that defaults to the styles in a stylesheet. Most sizes are 'em' units, meaning they are relative to the size of the font. JavaFX CSS will use the Font.getDefault() font size if there

RE: Is it possible to customise the theme of the Scene Builder itself?

2020-04-20 Thread David Grieve
This is probably not the right forum for this question. Try a forum like stackoverflow. Or reach out to great people at Gluon. The short answer, however, is that you can play with the CSS styles that make up the theme. You'd either need to update the stylesheets in the jar or build scene

RE: Windows Installation Instructions, All DLL Files Missing

2020-04-20 Thread David Grieve
Set -Djava.library.path= C:\Program Files\Java\javafx-sdk-14\bin For the jlink question, look at jmod. You'll use jmod to bundle up the dll's and whatever else you need, then jlink to create the custom runtime. -Original Message- From: openjfx-dev On Behalf Of Christopher Miles Sent:

RE: [EXTERNAL] Re: RE: JDK-8177945 : Single cell selection flickers when adding data to TableView

2020-03-26 Thread David Grieve
to circle back on this, but I was looking at and around javafx.scene.control.Cell#updateItem and javafx.scene.control.Cell#updateSelected From: Eric Bresie Sent: Thursday, March 26, 2020 9:01 AM To: David Grieve Cc: Danny Gonzalez ; openjfx-dev@openjdk.java.net Subject: [EXTERNAL] Re: RE: JDK-8177945

Re: JDK-8177945 : Single cell selection flickers when adding data to TableView

2020-03-12 Thread David Grieve
This fix causes several unit tests to fail. From: David Grieve Sent: Tuesday, March 10, 2020 12:48 PM To: David Grieve ; Danny Gonzalez Cc: openjfx-dev@openjdk.java.net Subject: RE: JDK-8177945 : Single cell selection flickers when adding data to TableView

RE: JDK-8177945 : Single cell selection flickers when adding data to TableView

2020-03-10 Thread David Grieve
dex(-1); +//} addAllToPile(); releaseAllPrivateCells(); } else if (needsReconfigureCells) { > -Original Message- > From: openjfx-dev On Behalf Of > David Grieve > Sent: Friday, March 6, 2020 9:29 AM > To: Danny Gonzalez > Cc: openjfx-dev@openjdk.jav

RE: JDK-8177945 : Single cell selection flickers when adding data to TableView

2020-03-06 Thread David Grieve
state that changes? Or is this just the CSS implementation recalculating styles and un-necessarily clearing old values? Some debugging is in order. From: Danny Gonzalez Sent: Wednesday, March 4, 2020 4:34 AM To: David Grieve Cc: openjfx-dev@openjdk.java.net Subject: [EXTERNAL] Re: JDK-8177945

RE: JDK-8177945 : Single cell selection flickers when adding data to TableView

2020-03-03 Thread David Grieve
ave narrowed down when the issue > was first introduced. > > Here is the changeset: > > commit 05afad6b528e871d607b76aea2642cf788b417fe > Author: David Grieve > mailto:dgri...@openjdk.org>> > Date: Tue Apr 15 11:51:38 2014 -0400 > > RT-36672: move code to process

RE: [EXTERNAL] Explanation of different scaling factors anywhere?

2020-01-27 Thread David Grieve
Wouldn't this just be a scale transform? > -Original Message- > From: openjfx-dev On Behalf Of > Mike Hearn > Sent: Monday, January 27, 2020 11:00 AM > To: openjfx-dev@openjdk.java.net > Subject: [EXTERNAL] Explanation of different scaling factors anywhere? > > Hello, > > A feature I

Re: [Rev 01] RFR: 8237469: CssStyleHelper reuse check fixed

2020-01-22 Thread David Grieve
On Wed, 22 Jan 2020 17:03:49 GMT, Dean Wookey wrote: >> Everything passes with the fix and 5 of the new tests fail without the fix. >> >> removingThenAddingNodeToDifferentBranchGetsNewFontStyleTest >> movingBranchToDifferentBranchGetsNewCssVariableTest >>

Re: RFR: 8237469: CssStyleHelper reuse check fixed

2020-01-22 Thread David Grieve
On Fri, 17 Jan 2020 14:09:54 GMT, Dean Wookey wrote: > Everything passes with the fix and 5 of the new tests fail without the fix. > > removingThenAddingNodeToDifferentBranchGetsNewFontStyleTest > movingBranchToDifferentBranchGetsNewCssVariableTest >

RE: [EXTERNAL] CssStyleHelper canReuseStyleHelper

2020-01-16 Thread David Grieve
for the new parent (line 110 or so in CssStyleHelper.java) are different. > -Original Message- > From: openjfx-dev On Behalf Of > Dean Wookey > Sent: Thursday, January 16, 2020 11:34 AM > To: openjfx-dev@openjdk.java.net Mailing d...@openjdk.java.net>; David Grieve > Cc:

RE: [EXTERNAL] Memory leak in JavaFX 8 when changing skins

2020-01-09 Thread David Grieve
Possible workarounds would be to use Control.setSkin instead of -fx-skin, or to bind the skin property after it has been set to something other than the default. CSS should not mess with a bound property. > -Original Message- > From: openjfx-dev On Behalf Of > Adam Granger > Sent:

Re: [Rev 01] RFR: 8236259: MemoryLeak in ProgressIndicator

2019-12-19 Thread David Grieve
On Thu, 19 Dec 2019 16:16:28 GMT, Kevin Rushforth wrote: >> probably not invented so often - just c'd from searches of occurances of >> System.gc ;-) > > Yes, exactly. > > @FlorianKirmaier Proposing to add test class to the test infrastructure would > be a reasonable alternative to pulling

Re: [Rev 01] RFR: 8236259: MemoryLeak in ProgressIndicator

2019-12-19 Thread David Grieve
Github failed me. My 'remove' comment was applied to the System.out.println, not the assert. > -Original Message- > From: openjfx-dev On Behalf Of > David Grieve > Sent: Thursday, December 19, 2019 2:29 PM > To: openjfx-dev@openjdk.java.net > Subject: [EXTERNAL

Re: [Rev 01] RFR: 8236259: MemoryLeak in ProgressIndicator

2019-12-19 Thread David Grieve
On Thu, 19 Dec 2019 19:28:34 GMT, Florian Kirmaier wrote: >> Hi everyone, >> >> ticket: https://bugs.openjdk.java.net/browse/JDK-8236259 >> >> The fix itself is quite straight forward. >> It basically just removed the listener which causes the leak. >> >> The unit-test for the fix is a bit

Re: apps/toys HelloTextFlow renders incorrectly on macOS 10.15

2019-12-19 Thread David Grieve
Because the toy itself handles the highlighting, I believe this is a problem in the toy, not in the library.

Re: RFR: 8193445: JavaFX CSS is applied redundantly leading to significant performance degradation

2019-11-26 Thread David Grieve
On Tue, 26 Nov 2019 09:22:01 GMT, Ajit Ghaisas wrote: > On Tue, 19 Nov 2019 14:29:16 GMT, David Grieve > wrote: > >> On Tue, 19 Nov 2019 10:48:52 GMT, Ajit Ghaisas wrote: >> >>> On Fri, 15 Nov 2019 09:14:04 GMT, Ajit Ghaisas wrote: >>> >&

Re: [Approved] RFR: 8193445: JavaFX CSS is applied redundantly leading to significant performance degradation

2019-11-26 Thread David Grieve
On Tue, 12 Nov 2019 16:45:04 GMT, Ajit Ghaisas wrote: > **Issue :** > https://bugs.openjdk.java.net/browse/JDK-8193445 > > **Background :** > The CSS performance improvement done in > [JDK-8151756](https://bugs.openjdk.java.net/browse/JDK-8151756) had to be > backed out due to functional

Re: RFR: 8193445: JavaFX CSS is applied redundantly leading to significant performance degradation

2019-11-19 Thread David Grieve
On Tue, 19 Nov 2019 10:48:52 GMT, Ajit Ghaisas wrote: > On Fri, 15 Nov 2019 09:14:04 GMT, Ajit Ghaisas wrote: > >> On Thu, 14 Nov 2019 18:33:05 GMT, Kevin Rushforth wrote: >> >>> On Tue, 12 Nov 2019 16:45:04 GMT, Ajit Ghaisas wrote: >>> **Issue :**

Re: RFR: 8193445: JavaFX CSS is applied redundantly leading to significant performance degradation

2019-11-14 Thread David Grieve
On Thu, 14 Nov 2019 15:02:40 GMT, Dean Wookey wrote: > On Thu, 14 Nov 2019 14:27:24 GMT, Kevin Rushforth wrote: > >> On Thu, 14 Nov 2019 12:34:56 GMT, Kevin Rushforth wrote: >> >>> On Thu, 14 Nov 2019 11:33:24 GMT, Dean Wookey wrote: >>> >>>>

Re: RFR: 8193445: JavaFX CSS is applied redundantly leading to significant performance degradation

2019-11-13 Thread David Grieve
On Tue, 12 Nov 2019 16:55:45 GMT, Ajit Ghaisas wrote: > On Tue, 12 Nov 2019 16:52:54 GMT, Ajit Ghaisas wrote: > >> On Tue, 12 Nov 2019 16:45:04 GMT, Ajit Ghaisas wrote: >> >>> **Issue :** >>> https://bugs.openjdk.java.net/browse/JDK-8193445 >>> >>> **Background :** >>> The CSS performance

RE: RFR: 8130738: TextFlow's tab width is static

2019-11-06 Thread David Grieve
What happens if you do text.tabSizeProperty().setValue(null) ? > -Original Message- > From: openjfx-dev On Behalf Of > Scott Palmer > Sent: Wednesday, November 6, 2019 11:12 AM > To: openjfx-dev@openjdk.java.net > Subject: RFR: 8130738: TextFlow's tab width is static > > Added tabSize

RE: Custom Fonts in User Agent Stylesheets

2019-10-04 Thread David Grieve
This seems like a bug. Certainly overriding Region#getUserAgentStylesheet() is the preferred way of customizing styles for a control. Maybe the styles from the Region UA stylesheet aren’t being considered when doing a font lookup. That would for sure be a bug. But there are a lot of moving

Re: Custom InputControl w/o char->string conversion

2019-03-26 Thread David Grieve
Have you looked at javax.security.auth.Destroyable? On 3/26/19 9:07 AM, Finn Herpich wrote: Hi Nicolas, thanks for the long write up. I'm indeed working with a lot of C# in the last year, but that is a pure accident, to reproduce the SecureString-class was not my intention. I'm totally aware

Re: EM Font Size Performance

2019-01-17 Thread David Grieve
g font size: 10852ms Without setting font size: 20357ms Dean On Thu, Apr 19, 2018 at 9:51 PM David Grieve <mailto:david.gri...@oracle.com>> wrote: I was thinking about https://bugs.openjdk.java.net/browse/JDK-8177635 and https://bugs.openjdk.java.net/browse/JDK-8090462

Re: JDK-8193445 Performance Test

2018-11-07 Thread David Grieve
One of the dangers of mucking around with the CSS code is whether or not the changes break things like popups, dialogs, menus. And whether or not the change breaks inline styles versus attributes set in code, versus stylesheets added to the scene/subscene/control, versus default stylesheets.

Re: Maybe a TitledPane bug

2018-11-01 Thread David Grieve
On 11/1/18 2:19 PM, Sverre Moe wrote: scene.getStylesheets().add(getClass().getResource("light.css").toExternalForm()); Here is the CSS content for light.css .titled-pane > .title {     -fx-color: rgb(220, 220, 220); Well, there you go. Your 'light.css' style trumps the setBackground. The

Re: Maybe a TitledPane bug

2018-11-01 Thread David Grieve
It's hard to tell without some short, self-contained, correct example. This sample I crafted here doesn't reproduce the issue. @Override public void start(Stage primaryStage) { final TitledPane titledPane =new TitledPane("Button Pane",new Button("Button")); final HBox root =new

Re: JavaFX in-memory dynamic CSS file editing and applying

2018-10-15 Thread David Grieve
Just setStyle -fx-theme-header (etc.) on the root node. On 10/15/18 1:05 AM, Ty Young wrote: Does JavaFX have an API for dynamically editing and applying CSS files in-memory? If not, would there be any possibility in one ever being made? My reasoning for such an API is, instead of switching

Re: JavaFX 11 on Android

2018-10-04 Thread David Grieve
You just need Android Studio 3 for try-with-resources. See https://developer.android.com/studio/write/java8-support I've never had a problem using java.util.logging with Android. Logging ends up in logcat. On 10/4/18 2:45 PM, Nir Lisker wrote: But indeed, there are other things (e.g.

Re: Formatting and Validating

2018-08-24 Thread David Grieve
You can set a javafx.scene.control.TextFormatter on any TextInputControl On 8/24/18 4:58 PM, Miroslav Nachev wrote: Hi, Is there any intention of adding formatting and validating of data in JavaFX? Are there any active projects or libraries for that? For example integer, decimal, currency,

Re: EM Font Size Performance

2018-04-19 Thread David Grieve
-8088615. There's also https://bugs.openjdk.java.net/browse/JDK-8193445. - Nir On Thu, Apr 19, 2018 at 1:42 PM, David Grieve <david.gri...@oracle.com <mailto:david.gri...@oracle.com>> wrote: Resolving the relative size involves a lot of lookup. You have to go up the scen

Re: EM Font Size Performance

2018-04-19 Thread David Grieve
Resolving the relative size involves a lot of lookup. You have to go up the scene-graph from the child to find a font style. If you get to the root and haven't found a font style, then use the default font. Performance in this area could be vastly improved by passing the size from either a

Re: CSSParser Color.parse() for unexpected CSS properties

2018-04-04 Thread David Grieve
itical to UI perf a less than optimal solution? Could it be changed to handle this more gracefully than catch / ignore exceptions? Is it worth raising a ticket for such a topic, would it ever be considered for improvement. I think it is worth raising a ticket. Thanks again, Matt On 4 Apr

Re: CSSParser Color.parse() for unexpected CSS properties

2018-04-04 Thread David Grieve
The parser doesn't have any concept of what the property is or value it might have. This allows the addition of new properties (such as an user might add for their own CSS styles) without having to modify the parser to handle them. On 4/4/18 10:03 AM, Matthew Elliot wrote: Hi all, (first

Re: CSS reference URL?

2017-12-08 Thread David Grieve
https://docs.oracle.com/javase/9/docs/api/javafx/scene/doc-files/cssref.html On 12/8/17 8:46 AM, Johan Vos wrote: Hi, Our Pro JavaFX 9 book is about to be published, and it will contain links to online resources. One very useful resource is the CSS reference. For JavaFX 8, this was at

Re: [10] Review request : JDK-8090462 : CSS performance: Link style helpers together to avoid going through parent chain looking for parent style helpers

2017-08-10 Thread David Grieve
Ajit, I have provided some comments in the bug. On 8/10/17 8:45 AM, Ajit Ghaisas wrote: Hi Jonathan, Request you to review following change : Issue : https://bugs.openjdk.java.net/browse/JDK-8090462 Fix : http://cr.openjdk.java.net/~aghaisas/fx/e8090462/webrev.2/ Regards,

Re: CSS style class rendering bug

2017-08-01 Thread David Grieve
Smells like a bug to me. On 8/1/17 10:08 AM, a...@adamish.com wrote: (https://stackoverflow.com/questions/45440102/javafx-css-class-not-removed-when-node-disconnected) I appeared to have discovered a case in JavaFX (8u144, running on Windows 7) where a TextField is rendered using the wrong

Re: CSS id selector with embedded dot

2017-05-10 Thread David Grieve
Fair enough. The CSS Reference Guide says " While the JavaFX CSS parser will parse valid CSS syntax, it is not a fully compliant CSS parser." Escaped characters is a case in point. On 5/10/17 11:10 AM, Doswald Michael wrote: On 5/10/17 2:02 PM, David Grieve wrote: Having an id

Re: CSS id selector with embedded dot

2017-05-10 Thread David Grieve
Having an id with a dot is not valid CSS syntax. From the spec: " An ID selector contains a "number sign" (U+0023, #) immediately followed by the ID value, which must be an CSS identifiers." An identifier is defined here: https://www.w3.org/TR/CSS21/syndata.html#value-def-identifier. The

Re: review: Generate bss for all css files, remove TODO

2017-03-30 Thread David Grieve
The question I have about this change is, do you necessarily want all of the css/bss files that may be in that directory in the dist? If someone adds a css file in the future, should it be a conscience decision to put it into the dist? On 3/30/17 1:50 PM, David Hill wrote: Jonathan,

Re: Structuring CSS Stylesheets

2016-08-15 Thread David Grieve
On 8/15/16 10:52 AM, Daniel Glöckner wrote: We found the culprits by patching the JRE, adding some statistics to SimpleSelector and CompoundSelector. I was wondering whether there are easier ways but anyway, it works ;) This sounds like some code that would be good to share with the

Re: Structuring CSS Stylesheets

2016-08-15 Thread David Grieve
On 8/15/16 9:46 AM, Daniel Glöckner wrote: Hi, We recently came across a number of performance issues which were caused by our poor CSS. Our stylesheet contained too many selectors, specifically too many generic selectors targeting "common" JavaFX controls (.text, .label etc.). Make the

Re: How do I read the output of the Pulse Logger?

2016-03-15 Thread David Grieve
Sometimes the layout might introduce nodes into the scenegraph. If these new nodes also need laid out, CSS is applied to those nodes since style can affect layout. I would expect CSS overhead to be very small unless there are many new nodes being added to the scene

Re: reapplyCss() Is called too many times when adding a node hierarchy to the Scene

2016-03-11 Thread David Grieve
There is (was?) some code in Node or Parent that was supposed to prevent this. Namely, I thought I had it so CSS was applied from the parent before applying to the children. It may also depend on how you add the nodes to the scene. On 3/11/16 5:18 PM, Scott Palmer wrote: I think I've

Re: including fonts

2016-01-04 Thread David Grieve
The reason CSS ignores everything but src is that there is no public API in Font for providing the additional information. CSS uses Font.loadFont to load a font from a @font-face src url. See com/sun/javafx/css/StyleManager.java On 1/4/16 2:43 PM, Phil Race wrote: Hi, I can't speak

Re: Constant resetting to initial-state when adding/remove styleclasses

2015-12-22 Thread David Grieve
Adding/removing style-classes is simply bad practice. And not just in JavaFX. It is better to use pseudo-class state. When the style-class changes, the set of styles that match a node can, and is very likely to, change. The css implementation 're-applies' css to the node and its children by

Re: [Review request] 8145143: Promote Image.impl_getUrl() to public API as Image.getUrl()

2015-12-10 Thread David Grieve
I believe the url might be used in the CSS engine for caching images loaded from .css files. If the css image cache is made public (I don't know if that is planned, but it should be considered), then this API will matter. On 12/10/15 4:39 PM, Kevin Rushforth wrote: That's an interesting

Re: Why are style classes stored in a List instead of a Set?

2015-05-21 Thread David Grieve
The bottom line answer is poor design of the API. There has been discussion about how to handle this, such as having a List implementation that rejects duplicates (but that would break the List contract), or adding new API. You might be interested to know that, on the CSS implementation side,

Re: @import in CSS

2015-04-09 Thread David Grieve
in the style sheet itself. On 4/9/15 1:42 AM, Tom Eugelink wrote: Does the order in which things appear in a CSS have influence on the behavior? Tom On 8-4-2015 23:22, David Grieve wrote: The spec says that if there is an @import it has to appear first before any rule, except @charset

Re: @import in CSS

2015-04-09 Thread David Grieve
(.SimpleMetroArcGauge) block. I don't understand why this matters, if it is declaration based. https://github.com/JFXtras/jfxtras-labs/blob/8.0/src/main/resources/jfxtras/labs/internal/scene/control/gauge/linear/SimpleMetroArcGauge.css On 9-4-2015 13:34, David Grieve wrote: Yes. The details

Re: @import in CSS

2015-04-08 Thread David Grieve
The spec says that if there is an @import it has to appear first before any rule, except @charset, if present. On 4/8/15 5:12 PM, Tom Eugelink wrote: I'm currently porting and reworking some gauges from Enzo to JFXtras. One of things that gets reworked involves that all gauges will have

Re: Debugging CSS

2015-04-06 Thread David Grieve
You should file an issue in jira for this. On 4/6/15 3:31 AM, Tom Eugelink wrote: On 6-4-2015 00:58, David Grieve wrote: On 4/5/15 3:56 AM, Tom Eugelink wrote: I have another interesting behavior involving CSS. The gauge has a text representation of the value of the needle, which can

Re: Debugging CSS

2015-04-05 Thread David Grieve
uses for its CSS analyzer. Tom On 3-4-2015 22:19, David Grieve wrote: When you add or remove style-classes, CSS for the node (and all its children) is totally re-calculated. This means that cached data for that node is tossed out and the node is styled from scratch, as if it were just added

Re: Debugging CSS

2015-04-03 Thread David Grieve
When you add or remove style-classes, CSS for the node (and all its children) is totally re-calculated. This means that cached data for that node is tossed out and the node is styled from scratch, as if it were just added to the scene-graph. You are much better off using pseudo-class state

Re: Event when CSS is applied

2015-02-17 Thread David Grieve
On 2/17/15 8:02 AM, Tom Eugelink wrote: I have a skin (of a control) that centers a Text node. This Text node can be styled via CSS, so this styling is a factor when centering. because larger font means wider text. The centering works perfectly, the only problem is figuring out when to

Re: Event when CSS is applied

2015-02-17 Thread David Grieve
not often enough. Would adding such an event be a big change? On 17-2-2015 14:50, David Grieve wrote: On 2/17/15 8:02 AM, Tom Eugelink wrote: I have a skin (of a control) that centers a Text node. This Text node can be styled via CSS, so this styling is a factor when centering. because

Re: CSS under 1.8.0_40 not identical to 31 or older

2015-02-05 Thread David Grieve
Create an issue in JIRA and include a simple example that reproduces the issue. On 2/4/15 4:13 PM, Tom Eugelink wrote: I've just now ran JFXtras Samples under the latest 1.8.0_40 and it does not render identical as when run under 1.8.0_31, some CSS rules are not applied. Samples is easily

Re: CSS under 1.8.0_40 not identical to 31 or older

2015-02-05 Thread David Grieve
a file to that issue... Tom On 5-2-2015 16:47, David Grieve wrote: Create an issue in JIRA and include a simple example that reproduces the issue. On 2/4/15 4:13 PM, Tom Eugelink wrote: I've just now ran JFXtras Samples under the latest 1.8.0_40 and it does not render identical as when run

Re: switching skins at runtime

2014-12-23 Thread David Grieve
Yes, it is allowed. But know that there is some code in setSkin that prevents setting a skin that is either instance equal or the same class. On 12/23/14, 6:27 AM, Tom Eugelink wrote: Is it allowed / supported to execute setSkin with a new skin on a control that is part of a scene? Tom

Re: CSS warning

2014-10-21 Thread David Grieve
JavaFX CSS has a 'lookup' feature that allows you to declare the value of a property as another property. For example, the -fx-base property defines the base color of the modena theme (the same goes for caspian). When a css value is calculated, these looked-up properties have to be resolved to

Re: Classpath-relative URLs in CSS

2014-10-15 Thread David Grieve
, then there shouldn't be a problem. Rgds Werner On 01.06.2012 04:03, David Grieve wrote: In the current implementation, absolute paths without a scheme are not resolved relative to the class path. I have created RT-21967 to track the issue.

Re: WARNING: CSS Error parsing

2014-10-15 Thread David Grieve
There is no short-hand for border in JavaFX. You need to use both -fx-border-color and -fx-border-style See http://docs.oracle.com/javase/8/javafx/api/javafx/scene/doc-files/cssref.html On 10/15/14, 3:53 PM, Peter Penzov wrote: Hi, I tested Java 8u40. I get error when I run this part of

Re: CSS: style leaks from unrelated stylesheet

2014-10-09 Thread David Grieve
In 8u20 and before, adding a stylesheet via Control.getUserAgentStylesheet will simply add the user-agent stylesheet to the entire scene, not just the control. This has been fixed in 8u40 where the getUserAgentStylesheet method is now public API on Region and the styles added will affect only

hg: openjfx/8u-dev/rt: RT-38395: Add ability to resolve the URL given with an @import statement relative to the FX runtime

2014-09-19 Thread david . grieve
Changeset: 835a333ec7ee Author:David Grievedavid.gri...@oracle.com Date: 2014-09-19 08:44 -0400 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/835a333ec7ee RT-38395: Add ability to resolve the URL given with an @import statement relative to the FX runtime Reviewed-by: kcr

hg: openjfx/8u-dev/rt: 2 new changesets

2014-09-19 Thread david . grieve
Changeset: cdc219ec5ce8 Author:David Grievedavid.gri...@oracle.com Date: 2014-09-19 13:54 -0400 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/cdc219ec5ce8 [TEST-ONLY] RT-38687: [CSS] Using setUserAgentStylesheet() with @import syntax issue !

hg: openjfx/8u-dev/rt: RT-38640: [CSS, Control] Improve handling of Control.getUserAgentStylesheet()

2014-09-18 Thread david . grieve
Changeset: ea09e7b425d3 Author:David Grievedavid.gri...@oracle.com Date: 2014-09-18 14:55 -0400 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/ea09e7b425d3 RT-38640: [CSS, Control] Improve handling of Control.getUserAgentStylesheet() Reviewed by: kevin, jonathan !

[8u40] Post-commit review: RT-38640: Improve handling of Control.getUserAgentStylesheet()

2014-09-18 Thread David Grieve
A change was made to the Control API which removed the protected method getUserAgentStylesheet(). This method was moved to Region and was made public: javafx.scene.control.Control -protected String getUserAgentStylesheet() javafx.scene.layout.Region +public String

hg: openjfx/8u-dev/rt: 3 new changesets

2014-09-16 Thread david . grieve
Changeset: 887985e5611d Author:David Grievedavid.gri...@oracle.com Date: 2014-09-16 12:05 -0400 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/887985e5611d RT-38616: ConcurrentModificationException when SubScene.setUserAgentStylesheet() is called !

[8u40] API proposal: [CSS, Control] Improve handling of Control.getUserAgentStylesheet()

2014-09-11 Thread David Grieve
Relative to https://javafx-jira.kenai.com/browse/RT-38640, I propose to add the following method to Region: /** * An implementation may specify its own user-agent styles for this Region, and its children, * by overriding this method. These styles are used in addition to whatever

[8u40] Review Request: (RT-38395) [CSS] Add ability to resolve the URL given with an @import statement relative to the FX runtime

2014-09-09 Thread David Grieve
Kevin, Steve, Please review https://javafx-jira.kenai.com/browse/RT-38395 http://cr.openjdk.java.net/~dgrieve/RT-38395/webrev.00/ Thanks.

hg: openjfx/8u-dev/rt: RT-38389: SubScene.setUserAgentStylesheet() not resilient to stress

2014-09-04 Thread david . grieve
Changeset: dbc39f3566d5 Author:David Grievedavid.gri...@oracle.com Date: 2014-09-04 16:43 -0400 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/dbc39f3566d5 RT-38389: SubScene.setUserAgentStylesheet() not resilient to stress !

Re: TableView bug?

2014-08-29 Thread David Grieve
Possibly https://javafx-jira.kenai.com/browse/RT-38013? On 8/29/14, 8:29 AM, Robert Fisher wrote: Hi guys, I am having some difficulties fine-tuning the style of my TableView and I'm wondering if I've found a bug. It may well be related to an existing JIRA issue, so I thought I'd check

hg: openjfx/8u-dev/rt: RT-38483: [CSS] add indefinite as a value for duration type

2014-08-29 Thread david . grieve
Changeset: 4c3674e9ab57 Author:David Grievedavid.gri...@oracle.com Date: 2014-08-29 09:37 -0400 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/4c3674e9ab57 RT-38483: [CSS] add indefinite as a value for duration type !

Re: Any plans to support CSS transitions?

2014-08-29 Thread David Grieve
Although the CSS features for 9 haven't been settled yet, this is high on my wish list. On 8/29/14, 12:06 PM, Mike Hearn wrote: I enjoy iterating on my UI using JFX CSS and a simple hot reload feature I added to my app, but I still have to drop back into writing code for doing animations. In

hg: openjfx/8u-dev/rt: RT-38455: [CSS] lexer should not consume @font-face and @import as one token

2014-08-28 Thread david . grieve
Changeset: b72f6918383b Author:David Grievedavid.gri...@oracle.com Date: 2014-08-28 19:54 -0400 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/b72f6918383b RT-38455: [CSS] lexer should not consume @font-face and @import as one token !

hg: openjfx/8u-dev/rt: [DOCS-ONLY] RT-38453: [CSS] errors in cssref html causing issues in various browsers

2014-08-27 Thread david . grieve
Changeset: 9ae7393e72e9 Author:David Grievedavid.gri...@oracle.com Date: 2014-08-27 13:51 -0400 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/9ae7393e72e9 [DOCS-ONLY] RT-38453: [CSS] errors in cssref html causing issues in various browsers !

hg: openjfx/8u-dev/rt: RT-38391: [CSS] Add support for specifying durations

2014-08-26 Thread david . grieve
Changeset: 6efbcb758363 Author:David Grievedavid.gri...@oracle.com Date: 2014-08-26 15:54 -0400 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/6efbcb758363 RT-38391: [CSS] Add support for specifying durations ! apps/toys/Hello/src/main/java/hello/HelloCSS.java !

[8u40] Post-commit review: (RT-38391) [CSS] Add support for specifying durations

2014-08-26 Thread David Grieve
Added handling of 's' and 'ms' time units to the CSS parser. Added public static StyleConverter?,Duration getDurationConverter() to javafx.css.StyleConverter Added corresponding createStyleableDurationProperty methods to javafx.css.StyleablePropertyFactory.

Re: CSS: Use none or null?

2014-08-26 Thread David Grieve
Either one. On 8/26/14, 4:21 PM, Tomas Mikula wrote: Just a quick question: Which one is correct, -fx-fill: none; or -fx-fill: null; ? Thanks, Tomas

[8u40] API Review Request: (RT-38192) CSS support for Region as graphicProperty on Labeled

2014-08-22 Thread David Grieve
In as much as CSS is considered public API, please review https://javafx-jira.kenai.com/browse/RT-38192, which allows FXML to be specified as the -fx-graphic property of Labeled. Example of a Button with a graphicProperty that is specified in CSS as a Region shaped like an X: @Override

hg: openjfx/8u-dev/rt: RT-38352: [CSS] Warning messages in media Ensemble tests

2014-08-19 Thread david . grieve
Changeset: 96b2950a91e3 Author:David Grievedavid.gri...@oracle.com Date: 2014-08-19 12:52 -0400 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/96b2950a91e3 RT-38352: [CSS] Warning messages in media Ensemble tests !

hg: openjfx/8u-dev/rt: RT-38345: [CSS] Warning messages from CSS on touch devices

2014-08-18 Thread david . grieve
Changeset: d7373a5e9cd9 Author:David Grievedavid.gri...@oracle.com Date: 2014-08-18 12:30 -0400 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/d7373a5e9cd9 RT-38345: [CSS] Warning messages from CSS on touch devices Reviewed by: kevin, lisa !

hg: openjfx/8u-dev/rt: 2 new changesets

2014-08-15 Thread david . grieve
Changeset: a8e87f631464 Author:David Grievedavid.gri...@oracle.com Date: 2014-08-15 11:53 -0400 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/a8e87f631464 RT-38201: [CSS] Enum values should not be treated as value references to be looked up !

hg: openjfx/8u-dev/rt: Backed out changeset a63ebe7c34f2 for RT-38300 since the test still fails

2014-08-15 Thread david . grieve
Changeset: bc95b0652aca Author:David Grievedavid.gri...@oracle.com Date: 2014-08-15 17:42 -0400 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/bc95b0652aca Backed out changeset a63ebe7c34f2 for RT-38300 since the test still fails !

hg: openjfx/8u-dev/rt: RT-38138: -fx-spacing used wrong in .menubar in modena.css

2014-08-12 Thread david . grieve
Changeset: e5dccbae218a Author:David Grievedavid.gri...@oracle.com Date: 2014-08-12 08:03 -0400 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/e5dccbae218a RT-38138: -fx-spacing used wrong in .menubar in modena.css Reviewed by: kcr !

Re: [8u40] API review: (RT-38192) CSS support for Region as graphicProperty on Labeled

2014-08-08 Thread David Grieve
on the syntax would it be better instead of defining svg-path to work with protocols like browsers are doing it today (see data-urls). We'd have then: * file: * http: * ... * data:scenegraph/svg-path; * data:scenegraph/fxml; Tom On 07.08.14 00:59, David Grieve wrote: In as much as CSS styles can

[8u40] Review Request: (RT-38138) -fx-spacing used wrong in .menubar in modena.css

2014-08-06 Thread David Grieve
, 05 Aug 2014 16:12:06 -0400 From: David Grieve david.gri...@oracle.com To: Jonathan Giles jonathan.gi...@oracle.com CC: openjfx-dev@openjdk.java.net List openjfx-dev@openjdk.java.net Jonathan, Please review https://javafx-jira.kenai.com/browse/RT-38138. There are two patches attached

  1   2   3   >